As @AntonKhorev suggested, we're now displaying these icons only when users
open the full diary entry, as outlined in #5121. Since this is currently used
in one place, turbo pagination issues can be handled in a future PR if a use
case arises for combining it with turbo pagination. Thank you.
-
@kcne pushed 1 commit.
4efc63d6090eef1bb334fa7b58c123cf4d80577b Add social sharing functionality
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4985/files/ff4b223f68baf21e70e79acc5f82eca34b872ab2..4efc63d6090eef1bb334fa7b58c123cf4d80577b
You are receiving this
I almost finished the code. I think it will be ready tomorrow. The idea is to
truncate entries server-side and, for example, if we show only 1000 characters,
estimate that image will take space of 500, therefore, it will truncate text
and also won't allow to add many photos that will overload di
Timestamp + version is not stable. cgimap does mass inserts/updates, where
elements have the exact same timestamp down to the µs.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5209#issuecomment-2353545924
You are receiving this
When I thought how to do truncated diary entries I first considered doing it
server-side. I already go through markdown parse trees in the richtext library
to get images and descriptions for Open Graph tags. I can probably extend that
to generate truncated entries.
Then I thought that ultimatel
This is now ready for review again, as #5218 has been merged and deployed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5212#issuecomment-2353415803
You are receiving this because you are subscribed to this thread.
Message ID:
Well what I mostly want in the short term is for the tests to be reliable, but
the reason they're not reliable is that the web site is not reliable - next and
previous may not step through the objects reliably.
As we're paginating this data with a full count of pages we're already reading
it al
@AntonKhorev pushed 1 commit.
8acfc36fcb94abec9bcbce4152b830f63943a0be Remove classic pagination
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5205/files/2637e79ddbdd4f4e9e04e7b6175c3ff16f2e9ca6..8acfc36fcb94abec9bcbce4152b830f63943a0be
You are receiving this
This was suggested in
https://github.com/openstreetmap/openstreetmap-website/pull/4571#issuecomment-1994856482
but I haven't done it because we don't have appropriate indexes. This requires
reading all changeset node/ways/relations and sorting them. We also have counts
of changeset elements but
Maybe the discussion is too technical that "redact" wasn't mentioned. I didn't
search for "changeset comments" thinking it's too broad. In fact, there was a
failed attempt.
https://github.com/openstreetmap/openstreetmap-website/pull/1167
I don't know if DWG has already passed that case to OWG.
@AntonKhorev Okay, thanks. I'll update it to ``. It will be more
comfortable to reuse and will produce cleaner code.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5201#issuecomment-2352793179
You are receiving this because you a
Merged #5218 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5218#event-14272241868
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5218#issuecomment-2352794799
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev
Best is to send an email to operations with all relevant details.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5219#issuecomment-2352714939
You are receiving this because you are subscribed to this thread.
Message ID:
__
Closed #5219 as not planned.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5219#event-14271220988
You are receiving this because you are subscribed to this thread.
Message ID:
___
r
- changeset comment tags: duplicate of #470
- changeset discussion comments: already implemented
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5219#issuecomment-2352641044
You are receiving this because you are subscribed to th
> Adding icon to the sprite was solely for the accordance with the current
> state and practices of the project.
Currently we use both `` and css sprite maps. One problem with sprite maps
is that it's more difficult to control the colors of the icons.
app/assets/images/sprite.svg is mainly used
Ok I don't really know the details of different privilege levels, and how
changeset comments can be moderated. Half creating this to discussed what
should be done about this situation.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/
Moderators can hide changeset comments, sysadmin/operations can completely
remove the data, if needed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5219#issuecomment-2352284851
You are receiving this because you are subscribe
Honestly surprised this isn't already a feature. Seems to me the changeset
comment is, after the data itself, THE place where sensitive information might
be shared.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5219#issuecomm
### Problem
A user recently uploaded edits suggesting the objects are related to their
female family members in the title. DWG replied that they are unable to act on
it.
### Description
Upload comments, and changeset discussions, should be made redactable. This
closes a privacy and safety l
21 matches
Mail list logo
