Re: [R-pkg-devel] windows and configure scripts

2021-08-08 Thread Timothy Keitt
Thanks. Just me trying to be minimalist and see if I could achieve the aim without extra files, etc. All I need to do is see if the CXX17 config option is empty and modify PKG_CPPFLAGS and CXX_STD appropriately. That means calling R and and implementing an if-else in the Makevars file outside of an

Re: [R-pkg-devel] windows and configure scripts

2021-08-07 Thread Kevin Ushey
On Fri, Aug 6, 2021 at 3:47 PM Tim Keitt wrote: > > As configure is not run on windows, but according to the writing extensions > docs you can run commands in Makevars, is that not preferable for simple > cases? IMHO it's ultimately up to you. Do what makes your life easier as a package maintaine

Re: [R-pkg-devel] windows and configure scripts

2021-08-07 Thread Timothy Keitt
Good suggestion. I'll try that. THK On Fri, Aug 6, 2021 at 6:44 PM Gábor Csárdi wrote: > On Sat, Aug 7, 2021 at 1:32 AM Timothy Keitt wrote: > > > > Snarky answers aside, it's still a valid question whether it's not just > > cleaner in simple cases to run commands from the Makevars file as > d

Re: [R-pkg-devel] windows and configure scripts

2021-08-06 Thread Gábor Csárdi
On Sat, Aug 7, 2021 at 1:32 AM Timothy Keitt wrote: > > Snarky answers aside, it's still a valid question whether it's not just > cleaner in simple cases to run commands from the Makevars file as described > in the extensions doc. Of course there's no particularly useful examples > there and searc

Re: [R-pkg-devel] windows and configure scripts

2021-08-06 Thread Timothy Keitt
Snarky answers aside, it's still a valid question whether it's not just cleaner in simple cases to run commands from the Makevars file as described in the extensions doc. Of course there's no particularly useful examples there and searching 'Makevars' on github (yes tried that) is not very illumina

Re: [R-pkg-devel] windows and configure scripts

2021-08-06 Thread Dirk Eddelbuettel
If look closely enough at _Writing R Extensions_ you notice that it mentions 'configure.win' over half a dozen times. A powerful trick is to then use the fact that there are other packages on CRAN, in fact almost 18k of them. And e.g. this search https://github.com/search?q=org%3Acran+config