Re: [R-pkg-devel] shadowing a method from the stats package

2019-01-16 Thread Heather Turner
Hi Oscar, I don't think this is such a good idea, for a few reasons. First, `setMethod` defines an S4 method, so both an S3 method (from stats) and an S4 method (from your package) will be defined. This seems to work, but could give unexpected results and is confusing for anyone trying to under

Re: [R-pkg-devel] shadowing a method from the stats package

2019-01-12 Thread qxacur
Hi Joris,     thank you for your reply.     I re-read the CRAN policy after I saw your reply and you are right, I do not need permission for this.     About the search PATH. unifed will always be attached after stats, so I think the unifed function would always be found before the one in stats (

Re: [R-pkg-devel] shadowing a method from the stats package

2019-01-12 Thread Joris Meys
Hi, technically you don't need permission for this. You only need permission if you tamper with the namespace of the stats package, which you don't. You just hide a function from another package, which is rather common actually (eg dplyr::lag() and stats::lag() ). Then again, I'm not sure this wi