Re: [R-pkg-devel] need some help to understand package build workflow

2015-08-03 Thread Hadley Wickham
On Fri, Jul 31, 2015 at 5:14 PM, Kevin Ushey wrote: > I'm not sure if that's correct -- from what I see, in the generated Rd > documentation: > > - The 'usage' is drawn from the S4 generic, > - The 'arguments' are drawn from the function. > > I think R CMD check is correctly warning about that. A

Re: [R-pkg-devel] need some help to understand package build workflow

2015-07-31 Thread Duncan Murdoch
On 31/07/2015 6:14 PM, Kevin Ushey wrote: > I'm not sure if that's correct -- from what I see, in the generated Rd > documentation: > > - The 'usage' is drawn from the S4 generic, > - The 'arguments' are drawn from the function. > > I think R CMD check is correctly warning about that. I agree th

Re: [R-pkg-devel] need some help to understand package build workflow

2015-07-31 Thread Kevin Ushey
I'm not sure if that's correct -- from what I see, in the generated Rd documentation: - The 'usage' is drawn from the S4 generic, - The 'arguments' are drawn from the function. I think R CMD check is correctly warning about that. On Fri, Jul 31, 2015 at 2:56 PM, Hadley Wickham wrote: >>> It see

Re: [R-pkg-devel] need some help to understand package build workflow

2015-07-31 Thread Hadley Wickham
>> It seems arguable that this is actually a roxygen bug - the function >> that's actually exported from the package does not have a type >> argument. > > The package fails R CMD check because of a bad .Rd file. If a user had > written that file, it would be user error, but roxygen2 wrote it, so I

Re: [R-pkg-devel] need some help to understand package build workflow

2015-07-31 Thread Duncan Murdoch
On 31/07/2015 7:11 AM, Hadley Wickham wrote: > It seems arguable that this is actually a roxygen bug - the function > that's actually exported from the package does not have a type > argument. The package fails R CMD check because of a bad .Rd file. If a user had written that file, it would be us

Re: [R-pkg-devel] need some help to understand package build workflow

2015-07-31 Thread Hadley Wickham
It seems arguable that this is actually a roxygen bug - the function that's actually exported from the package does not have a type argument. Hadley On Fri, Jul 31, 2015 at 12:53 AM, Kevin Ushey wrote: > I've posted an MRE at https://github.com/klutometis/roxygen/issues/362. > > The issue occurs

Re: [R-pkg-devel] need some help to understand package build workflow

2015-07-30 Thread Kevin Ushey
I've posted an MRE at https://github.com/klutometis/roxygen/issues/362. The issue occurs when a function and an S4 generic have the same name; I imagine this is fairly uncommon? Wouldn't the function be masked by the S4 generic and effectively be invisible after the package was loaded? On Thu, Ju

Re: [R-pkg-devel] need some help to understand package build workflow

2015-07-30 Thread Hadley Wickham
On Thursday, July 30, 2015, Duncan Murdoch wrote: > On 30/07/2015 9:14 PM, Duncan Murdoch wrote: > > On 30/07/2015 8:49 PM, Glenn Schultz wrote: > >> Hi All, > >> > >> I have a package stable and working. Now, I am trying to consolidate > some functions that share similar inputs. Example below.

Re: [R-pkg-devel] need some help to understand package build workflow

2015-07-30 Thread Duncan Murdoch
On 30/07/2015 9:14 PM, Duncan Murdoch wrote: > On 30/07/2015 8:49 PM, Glenn Schultz wrote: >> Hi All, >> >> I have a package stable and working. Now, I am trying to consolidate some >> functions that share similar inputs. Example below. So, I branched on >> github and work with the branch but

Re: [R-pkg-devel] need some help to understand package build workflow

2015-07-30 Thread Duncan Murdoch
On 30/07/2015 8:49 PM, Glenn Schultz wrote: > Hi All, > > I have a package stable and working. Now, I am trying to consolidate some > functions that share similar inputs. Example below. So, I branched on > github and work with the branch but now when I run the R check in studio I > get the f