Re: [R-pkg-devel] Rcpp: how best to include source from another Github repository

2025-02-03 Thread John Clarke
Thanks Dirk and others -- I see the tradeoffs now. In my case, I think a simple copy of source (just a few files), plus maybe some sort of commit/tag reference to indicate where/when the source is coming from. -John On Thu, Jan 23, 2025 at 3:47 PM Dirk Eddelbuettel wrote: > > On 21 January 2025

Re: [R-pkg-devel] Rcpp: how best to include source from another Github repository

2025-01-23 Thread Dirk Eddelbuettel
On 21 January 2025 at 12:04, Jonathan Berrisch wrote: | first of all: I'm not an expert on this and don't really know if there | is a recommended way. | | However, you may look at my 'rcpptimer' package and how it includes | 'cpptimer' as a submodule. | | You can find the repository here: htt

Re: [R-pkg-devel] Rcpp: how best to include source from another Github repository

2025-01-23 Thread John Clarke
Thanks Jonathan, this is helpful. I'm just a bit concerned based on other comments that submodules might not be compatible with CRAN and/or other CI runners. Plus, I only want a few cpp files copied over. On Thu, Jan 23, 2025 at 3:19 PM Jonathan Berrisch wrote: > Hi John, > > first of all: I'm n

Re: [R-pkg-devel] Rcpp: how best to include source from another Github repository

2025-01-23 Thread Jonathan Berrisch
Hi John, first of all: I'm not an expert on this and don't really know if there is a recommended way. However, you may look at my 'rcpptimer' package and how it includes 'cpptimer' as a submodule. You can find the repository here: https://github.com/BerriJ/rcpptimer And here you can see 'c

Re: [R-pkg-devel] Rcpp: how best to include source from another Github repository

2025-01-23 Thread John Clarke
Thank you Dirk and Thibault for your additional tips and ideas. I took a look at the vignette for *rcppcorels* and noted that this is exactly the model/pattern I used to create my package. And it appears that the /src files are simply copied from the external *corels* C++ library into the rcppcore

Re: [R-pkg-devel] Rcpp: how best to include source from another Github repository

2025-01-22 Thread Thibault Vatter
There is balance between DRY, safety, and customization needs. The symlinkish approach would be "dangerous" imo, because you can't guarantee the wrapper.cpp will stay compatible with changes in the underlying C++ library. The submodule approach works well. Alternatives that I know of are: - a

Re: [R-pkg-devel] Rcpp: how best to include source from another Github repository

2025-01-22 Thread John Clarke
Thanks Ivan, this is helpful. I'll do some more research. It would be nice to have an Rcpp standard/recommended way to do this. I don't want to have a non-standard ./src or ./data folder structure for my Rcpp package, but these are the two relevant folders in my original repository. Maybe with some

Re: [R-pkg-devel] Rcpp: how best to include source from another Github repository

2025-01-21 Thread Ivan Krylov via R-package-devel
В Tue, 21 Jan 2025 11:57:46 +0100 John Clarke пишет: > Ideally, it would be nice to be able to pull the files from the > source repo using a tag/hash so that the only code change in the Rcpp > repo would be that reference rather than all the changes to the > shared source. I've been using Git su