Re: [R-pkg-devel] Warnings from upstream C library in CRAN submission

2024-02-04 Thread Satyaprakash Nayak
Thank you Jeff and Simon for your feedback. I have filed your feedback as an issue to the SUNDIALS developers at - https://github.com/LLNL/sundials/issues/409 Thank you. On Sat, Feb 3, 2024 at 10:38 AM Satyaprakash Nayak wrote: > Hi > > I had a package 'sundialr' which was archived from CRAN.

Re: [R-pkg-devel] Warnings from upstream C library in CRAN submission

2024-02-03 Thread Simon Urbanek
Satyaprakash, those are clear bugs in the SUNDIALS library - they assume that "unsigned long" type is 64-bit wide (that assumption is also mentioned in the comments), but there is no such guarantee and on Windows it is only 32-bit wide, so the code has to be changed to replace "unsigned long" w

Re: [R-pkg-devel] Warnings from upstream C library in CRAN submission

2024-02-03 Thread Jeff Newmiller via R-package-devel
Type conversions are always a bit risky... this one appears to be likely to corrupt data. If they actually intended to truncate values like this then they should have cast explicitly. Looks like you need to report this to the SUNDIALS maintainers. On February 3, 2024 7:38:35 AM PST, Satyaprakas

[R-pkg-devel] Warnings from upstream C library in CRAN submission

2024-02-03 Thread Satyaprakash Nayak
Hi I had a package 'sundialr' which was archived from CRAN. It is an interface to some of the solvers in SUNDIALS ODE Solving library. I have fixed the issue which was related to emails being forwarded from the maintainer's email address. The repository code can be found at - https://github.com/s