Re: [R-pkg-devel] Deprecating apparent S3 method, changing name

2024-10-01 Thread Murray Efford via R-package-devel
: Wednesday, 2 October 2024 00:45 To: Jan van der Laan Cc: Murray Efford ; Murray Efford via R-package-devel Subject: Re: [R-pkg-devel] Deprecating apparent S3 method, changing name � Tue, 1 Oct 2024 09:00:24 +0200 Jan van der Laan �: > S3method(esa, plot, esaplotmethod) > > To

Re: [R-pkg-devel] Deprecating apparent S3 method, changing name

2024-10-01 Thread Ivan Krylov via R-package-devel
В Tue, 1 Oct 2024 09:00:24 +0200 Jan van der Laan пишет: > S3method(esa, plot, esaplotmethod) > > To register `esaplotmethod` as the method that is called when using > `esa` with an object of type `plot`. This would prevent this issue. > However, this probably (can't test as the note doesn't h

Re: [R-pkg-devel] Deprecating apparent S3 method, changing name

2024-10-01 Thread Jan van der Laan
On 9/26/24 23:48, Murray Efford via R-package-devel wrote: I am tossing up between (i) appealing to CRAN to allow the submission through with NOTEs until it feels safe to remove the functions with misleading names altogether, and (ii) removing them now and warning users about the new names

Re: [R-pkg-devel] Deprecating apparent S3 method, changing name

2024-09-29 Thread Murray Efford via R-package-devel
day, 30 September 2024 00:46 To: r-package-devel@r-project.org Subject: Re: [R-pkg-devel] Deprecating apparent S3 method, changing name Hmm, the following doesn't seem to trigger warnings or notes in `R CMD check --as-cran` (R 4.4.1; linux) esa <- function(x) { UseMethod("

Re: [R-pkg-devel] Deprecating apparent S3 method, changing name

2024-09-29 Thread Jan van der Laan
Hmm, the following doesn't seem to trigger warnings or notes in `R CMD check --as-cran` (R 4.4.1; linux) esa <- function(x) { UseMethod("esa") } esa.plot <- function(y) { .Deprecated("esaPlot") esaPlot(y) } esaPlot <- function(y) { message("esaPl

Re: [R-pkg-devel] Deprecating apparent S3 method, changing name

2024-09-26 Thread Murray Efford via R-package-devel
September 2024 08:48 To: Murray Efford via R-package-devel Cc: Murray Efford Subject: Re: [R-pkg-devel] Deprecating apparent S3 method, changing name � Wed, 25 Sep 2024 05:13:31 + Murray Efford via R-package-devel �: > When I deprecate the old functions (by exporting a shell funct

Re: [R-pkg-devel] Deprecating apparent S3 method, changing name

2024-09-26 Thread Ivan Krylov via R-package-devel
В Wed, 25 Sep 2024 05:13:31 + Murray Efford via R-package-devel пишет: > When I deprecate the old functions (by exporting a shell function > that calls .Deprecated and the new function), I get a package check > note for e.g. esa.plot "* checking S3 generic/method consistency ... > NOTE Appare

[R-pkg-devel] Deprecating apparent S3 method, changing name

2024-09-24 Thread Murray Efford via R-package-devel
A package of mine on CRAN has some old function names (not S3 methods) that include "." (e.g., "esa.plot"). In a new version I want to simultaneously 1. rename these functions to e.g. "esaPlot" 2. export a new S3 generic with the base name (e.g. "esa") and methods for different model types (e.g.