Re: [R-pkg-devel] LaTeX errors under MacOS on CRAN

2024-08-03 Thread Simon Urbanek
Ben, if I recall there were a couple regressions in knitr that broke things, but since this is only a WARNING it means the check has not been automatically repeated after knitr update (ERRORs are re-tried nightly). I can kick off things manually which is likely to remove the WARNING. Cheers, S

Re: [R-pkg-devel] A function in one of my package is now a method in base R

2024-08-03 Thread Georgi Boshnakov
Since the main problem is that in base-R's function your 'object' is called 'x', you could consider issuing an intermediate version of the package, where you strongly advise users not to name the first argument and to always name the remaining arguments. Also, make sure that your examples foll

Re: [R-pkg-devel] A function in one of my package is now a method in base R

2024-08-03 Thread Duncan Murdoch
The problem with that is a call like sort_by( object = foo, by = bar ) wouldn't be dispatched to the est_table method when foo is an est_table object, it would give a "argument 'x' is missing" kind of error. It would be fine for sort_by( foo, bar ) but would also mess up on sort_by( f

[R-pkg-devel] rhub (old and new) balks at building ncdf4 package

2024-08-03 Thread Daniel Kelley
I have a package, named 'oce' (developed at www.github.com/dankelley/oce and available through CRAN for over a decade) that uses 'ncdf4' to read some file types. When I do test builds on the win and mac builders, all is fine. When I do it with rhub, though, I get an error that ncdf4 cannot be

Re: [R-pkg-devel] A function in one of my package is now a method in base R

2024-08-03 Thread Shu Fai Cheung
Thanks a lot for both suggestions! I haven't thought about these approaches, They may solve my problem without breaking existing code. I may just keep the original arguments for backward compatibility. Coincidentally, "object" and "by" have the same meanings as "x" and "y" in base::sort_by() and so

Re: [R-pkg-devel] A function in one of my package is now a method in base R

2024-08-03 Thread Deepayan Sarkar
I haven't thought about this carefully, but shouldn't this mostly work? sort_by.est_table <- function(x, y = c("op", "lhs", "rhs"), object = x, by = y, op_priority = c("=~", "~", "~~", ":=", "~1", "|", "~*~"), number_rows = TRUE, ...) { } -Deepayan On Sat, 3 Aug 2024 at 00:1

Re: [R-pkg-devel] rhub (version 2) baulking at building a vignette.

2024-08-03 Thread Rolf Turner
Thanks to Ivan Krylov and Dirk Eddelbuettel who came to my rescue. At first I thought that Dirk's suggestion ("the zero-dependency approach" due to Mark van der Loo) was exactly what I needed. But this turned out not to work; rhub_check() still failed with a complaint about needing pdflatex. I