Re: [R-pkg-devel] Checking package in Windows fails

2021-11-16 Thread Ivan Krylov
On Wed, 17 Nov 2021 00:20:44 +0100 Ben Engbers wrote: > I don't edit the NAMESPACE file by hand. It is created by roxygen2. Right. In that case, use an @importFrom tag: https://roxygen2.r-lib.org/articles/namespace.html#imports -- Best regards, Ivan ___

Re: [R-pkg-devel] Checking package in Windows fails

2021-11-16 Thread Ben Engbers
Thanks for your reply. I have moved new/edited 'input_to_raw' code and the validation code to another file with all kind of utility-functions and that seems to have solved that problem. (But I don't understand why that helped ;-() Hopefully then next version of my client will be using C++ to

Re: [R-pkg-devel] Checking package in Windows fails

2021-11-16 Thread Ivan Krylov
On Mon, 15 Nov 2021 17:15:14 +0100 Ben Engbers wrote: > I don't know why I have to explicitly include 'library("rex")' in > the code since I have added rex to the Imports in the DESCRIPTION Have you added the corresponding importFrom(...) [1] commands to your NAMESPACE file? > pi <- pingr::is_o

Re: [R-pkg-devel] Using \donttest with R >= 4.0.0

2021-11-16 Thread Ben Bolker
(This crossed with Martin Ondrus's reply). In the past few years CRAN screeners have gotten more strict about \dontrun{}; a first-round screening often comes back requesting that \dontrun{}, and commented-out examples, not be used. https://stat.ethz.ch/pipermail/r-package-devel/2018q3/003

Re: [R-pkg-devel] Using \donttest with R >= 4.0.0

2021-11-16 Thread Martin Ondrus
Hi Guido, Yes \dontrun works fine for me as well when I'm running the package check on my own, as well as the win-builder link you've sent. The problem I always run into is that when it first gets inspected by CRAN it is always flagged and I am asked to change \dontrun to \donttest, or remove \don

Re: [R-pkg-devel] Using \donttest with R >= 4.0.0

2021-11-16 Thread Guido Schwarzer
Am 16.11.21 um 20:16 schrieb Martin Ondrus: Hi Duncan, That's a fair point, and I think making the examples run quicker probably makes the most sense. I have bad experiences with using dontrun - my package always gets flagged. Although not ideal, it's probably better to include some very fast r

Re: [R-pkg-devel] Using \donttest with R >= 4.0.0

2021-11-16 Thread Martin Ondrus
Hi Duncan, That's a fair point, and I think making the examples run quicker probably makes the most sense. I have bad experiences with using dontrun - my package always gets flagged. Although not ideal, it's probably better to include some very fast running examples rather than none at all. Apprec

Re: [R-pkg-devel] Using \donttest with R >= 4.0.0

2021-11-16 Thread Duncan Murdoch
On 15/11/2021 2:30 p.m., Martin Ondrus wrote: Hello, I am a package maintainer for the package "fabisearch" which is now archived on CRAN. The package includes many examples which take a long time to run. In past versions of R, I used to simply wrap these in \donttest and the examples ran as exp

[R-pkg-devel] Using \donttest with R >= 4.0.0

2021-11-16 Thread Martin Ondrus
Hello, I am a package maintainer for the package "fabisearch" which is now archived on CRAN. The package includes many examples which take a long time to run. In past versions of R, I used to simply wrap these in \donttest and the examples ran as expected. With R >= 4.0.0 however, examples wrapped

[R-pkg-devel] Checking package in Windows fails

2021-11-16 Thread Ben Engbers
Hi, I have written a function which - checks if the input is a raw-vector - if the input is a file-descriptor, it converts the file-content to a raw-vector - if the input is a URL, it converts the content to a raw vector - if the input is a character-string, it is converted to a raw vector. Th