Re: [R-pkg-devel] can't reproduce 'Additional issues' on CRAN with valgrind

I think the following change to str.c, in str_strcpy_internal(), fixes the valgrind issues. It was easier to track down after the calloc() was changed to malloc(), since before it only happened after a realloc(). $ diff -u rbibutils/src/str.c rbibutils-fixed/src/str.c --- rbibutils/src/str.c 2021

Re: [R-pkg-devel] windows and configure scripts

On Sat, Aug 7, 2021 at 1:32 AM Timothy Keitt wrote: > > Snarky answers aside, it's still a valid question whether it's not just > cleaner in simple cases to run commands from the Makevars file as described > in the extensions doc. Of course there's no particularly useful examples > there and searc

Re: [R-pkg-devel] windows and configure scripts

Snarky answers aside, it's still a valid question whether it's not just cleaner in simple cases to run commands from the Makevars file as described in the extensions doc. Of course there's no particularly useful examples there and searching 'Makevars' on github (yes tried that) is not very illumina

Re: [R-pkg-devel] windows and configure scripts

If look closely enough at _Writing R Extensions_ you notice that it mentions 'configure.win' over half a dozen times. A powerful trick is to then use the fact that there are other packages on CRAN, in fact almost 18k of them. And e.g. this search https://github.com/search?q=org%3Acran+config

[R-pkg-devel] windows and configure scripts

As configure is not run on windows, but according to the writing extensions docs you can run commands in Makevars, is that not preferable for simple cases? What shell is active in Makevars? Is it "/bin/sh" or is make the interpreter here? Can we use $(shell ...cmd...) in Makevars on windows? I'm

Re: [R-pkg-devel] Ongoing CXX17 woes

Fixed. Thanks. THK On Fri, Aug 6, 2021 at 4:33 PM Tim Keitt wrote: > > > On Fri, Aug 6, 2021 at 4:22 PM Tim Keitt wrote: > >> >> >> On Fri, Aug 6, 2021 at 4:05 PM Ivan Krylov wrote: >> >>> On Fri, 6 Aug 2021 15:51:37 -0500 >>> Tim Keitt wrote: >>> >>> > CXX17=`${R_HOME}/bin/R CMD config --al

Re: [R-pkg-devel] Ongoing CXX17 woes

On Fri, Aug 6, 2021 at 4:22 PM Tim Keitt wrote: > > > On Fri, Aug 6, 2021 at 4:05 PM Ivan Krylov wrote: > >> On Fri, 6 Aug 2021 15:51:37 -0500 >> Tim Keitt wrote: >> >> > CXX17=`${R_HOME}/bin/R CMD config --all | awk '{print $1}' | grep \ >> > "^CXX17$"` >> >> This seems to output "CXX17" on a

Re: [R-pkg-devel] Ongoing CXX17 woes

On Fri, Aug 6, 2021 at 4:05 PM Ivan Krylov wrote: > On Fri, 6 Aug 2021 15:51:37 -0500 > Tim Keitt wrote: > > > CXX17=`${R_HOME}/bin/R CMD config --all | awk '{print $1}' | grep \ > > "^CXX17$"` > > This seems to output "CXX17" on a machine with no C++17 support. On the > other hand, running `${R

Re: [R-pkg-devel] Ongoing CXX17 woes

On Fri, 6 Aug 2021 15:51:37 -0500 Tim Keitt wrote: > CXX17=`${R_HOME}/bin/R CMD config --all | awk '{print $1}' | grep \ > "^CXX17$"` This seems to output "CXX17" on a machine with no C++17 support. On the other hand, running `${R_HOME}/bin/R CMD config CXX17` here gives me an empty string. --

[R-pkg-devel] Ongoing CXX17 woes

Hi Folks, I have a package that compiles fine under C++11 but it throws an "Error: C++17 standard requested but CXX17 is not defined" error when checking under Solaris. My configure looks like: #!/bin/sh # Borrowed from https://github.com/eddelbuettel/rcppsimdjson/blob/master/configure : ${R_H

[R-pkg-devel] WinBuilder error: dependency version not available

I am in the final stages of preparing an R package to submit to CRAN. The package passes devtools::check() locally, GitHub Actions on multiple systems (including windows), devtools::check_rhub() remotely, and rhub::check_on_windows(check_args =