Re: [R-pkg-devel] CRAN review

2019-03-29 Thread Ralf Stubner
On 29.03.19 17:05, William Dunlap wrote: > It looks like it is not boost but RcppEigen that has the call to > std::rand() that volesti/src/rotating.cpp contains. > > RcppEigen/include/Eigen/src/Core/MathFunctions.h: > static inline Scalar run(const Scalar& x, const Scalar& y) > { > return

Re: [R-pkg-devel] CRAN review

2019-03-29 Thread William Dunlap
One can use 'g++ -E' to find the which include file is the culprit. E.g., % g++ -c -E -I`R RHOME`/include -I`R RHOME`/site-library/Rcpp/include -I`R RHOME`/site-library/RcppEigen/include -Iexternal/LPsolve_src/run_headers -Iexternal/minimum_ellipsoid -Iinclude -Iinclude/volume -Iinclude/generator

Re: [R-pkg-devel] CRAN review

2019-03-29 Thread William Dunlap
The check only looks at compiled code. BH contains only headers, no compiled code. Bill Dunlap TIBCO Software wdunlap tibco.com On Fri, Mar 29, 2019 at 9:27 AM Maxime Turgeon < maxime.turg...@mail.mcgill.ca> wrote: > Hi Bill, > > Maybe I'm missing something, but if RcppEigen were the cause of

Re: [R-pkg-devel] CRAN review

2019-03-29 Thread William Dunlap
Oops, RcppEigen does contain compiled code, but its header files include much more code that doesn't get checked because it is not used in RcppEigen.so. Bill Dunlap TIBCO Software wdunlap tibco.com On Fri, Mar 29, 2019 at 9:35 AM William Dunlap wrote: > The check only looks at compiled code.

Re: [R-pkg-devel] CRAN review

2019-03-29 Thread Ralf Stubner
On 29.03.19 17:27, Maxime Turgeon wrote: > Maybe I'm missing something, but if RcppEigen were the cause of the NOTE, > wouldn't RcppEigen also get the same NOTE? However, it does not: > https://cran.r-project.org/web/checks/check_results_RcppEigen.html > > And for what it's worth, neither does B

Re: [R-pkg-devel] CRAN review

2019-03-29 Thread Maxime Turgeon
Hi Bill, Maybe I'm missing something, but if RcppEigen were the cause of the NOTE, wouldn't RcppEigen also get the same NOTE? However, it does not: https://cran.r-project.org/web/checks/check_results_RcppEigen.html And for what it's worth, neither does BH: https://cran.r-project.org/web/checks

Re: [R-pkg-devel] CRAN review

2019-03-29 Thread William Dunlap
It looks like it is not boost but RcppEigen that has the call to std::rand() that volesti/src/rotating.cpp contains. RcppEigen/include/Eigen/src/Core/MathFunctions.h: static inline Scalar run(const Scalar& x, const Scalar& y) { return x + (y-x) * Scalar(std::rand()) / Scalar(RAND_MAX); }

Re: [R-pkg-devel] CRAN review

2019-03-29 Thread William Dunlap
> Library lpSolveAPI uses rand() and srand() in lp_utils.c. We replace > both functions with GetRNGstate(); PutRNGstate(); unif_rand(); from > R’s internal random number generation routines as it is proposed in > `Writing R Extensions`. Moreover if you run in folder `/src`: > $ grep -r 'rand()' > Y

Re: [R-pkg-devel] CRAN review

2019-03-29 Thread Vissarion Fisikopoulos
Dear all, @Henrik: thanks a lot for your reply. I did one more submission (the third) and I am posting below my answer to the automatic cran email with 2 NOTES. Looking forward to your feedback. Best regards, Vissarion. On Fri, 29 Mar 2019 at 11:04, Vissarion Fisikopoulos wrote: > > Dear all,