[Rd] Potential bugs in table dnn

2021-10-24 Thread SOEIRO Thomas
; > > > > -Message d'origine----- > > > De : Martin Maechler [mailto:maechler using stat.math.ethz.ch] > > > Envoyé : jeudi 14 octobre 2021 11:44 > > > À : SOEIRO Thomas > > > Cc : R Development List > > > Objet : Re: [Rd] Potential bugs

[Rd] Potential bugs in table dnn

2021-10-15 Thread SOEIRO Thomas
; > > -Message d'origine- > > De : Martin Maechler [mailto:maechler using stat.math.ethz.ch] > > Envoyé : jeudi 14 octobre 2021 11:44 > > À : SOEIRO Thomas > > Cc : R Development List > > Objet : Re: [Rd] Potential bugs in table dnn > > > &

Re: [Rd] Potential bugs in table dnn

2021-10-14 Thread SOEIRO Thomas
4 > À : SOEIRO Thomas > Cc : R Development List > Objet : Re: [Rd] Potential bugs in table dnn > > EMAIL EXTERNE - TRAITER AVEC PRÉCAUTION LIENS ET FICHIERS > > Dear Thomas, > > actually, I have in the mean time already applied the changes I think are > needed, both in th

Re: [Rd] Potential bugs in table dnn

2021-10-14 Thread Martin Maechler
Dear Thomas, actually, I have in the mean time already applied the changes I think are needed, both in the code and in the documentation. So, in this case, it may be a waste of time to still open a bugzilla issue, I think. Here are my current changes (not yet committed; of course I would also ad

Re: [Rd] Potential bugs in table dnn

2021-10-14 Thread Martin Maechler
> SOEIRO Thomas > on Wed, 13 Oct 2021 11:12:09 + writes: > Inline comments below in the previous message I'm not 100% > sure if the current behavior is intended or not. If not, > here is a patch (which I can submit on R Bugzilla if > appropriate): Excuse us for no

Re: [Rd] Potential bugs in table dnn

2021-10-13 Thread SOEIRO Thomas
Inline comments below in the previous message I'm not 100% sure if the current behavior is intended or not. If not, here is a patch (which I can submit on R Bugzilla if appropriate): diff -u orig/table.R mod/table.R --- orig/table.R2021-10-13 10:04:28.560912800 +0200 +++ mod/table.R 202

[Rd] Potential bugs in table dnn

2021-10-10 Thread SOEIRO Thomas
Dear list, table does not set dnn for dataframes of length 1: table(warpbreaks[2:3]) # has dnn # tension # wool L M H #A 9 9 9 #B 9 9 9 table(warpbreaks[2]) # has no dnn # # A B # 27 27 This is because of if (length(dnn) != length(args)) (line 53 in https://github.com/wch/r-so