Re: [Rd] [PATCH] Ensure correct order of evaluation in macro

2017-05-24 Thread Sahil Kang
Hi Martin, Would you feel comfortable merging my small patch in? I'd like to send additional patches that will improve these types of function macros so I'm hoping to start with this small change. Thanks, Sahil __ R-devel@r-project.org mailing list

Re: [Rd] [PATCH] Ensure correct order of evaluation in macro

2017-05-23 Thread Duncan Murdoch
On 23/05/2017 11:47 AM, Sahil Kang wrote: Hi Duncan, Would you merge this patch? I'm planning on sending larger patches in the next few days that fix other macros I've seen, but I figured​ it'd be best to start with a smaller patch. No, I generally try to leave the macro stuff to others. Dun

Re: [Rd] [PATCH] Ensure correct order of evaluation in macro

2017-05-23 Thread Sahil Kang
Hi Duncan, Would you merge this patch? I'm planning on sending larger patches in the next few days that fix other macros I've seen, but I figured​ it'd be best to start with a smaller patch. Thanks, Sahil __ R-devel@r-project.org mailing list https://

[Rd] [PATCH] Ensure correct order of evaluation in macro

2017-05-22 Thread Sahil Kang
Hello, I'd like to contribute this small patch (attached) that I think will help prevent some future bugs from occurring in paste.c. By wrapping the macro's arguments in parentheses, we can ensure that the correct order of evaluation will take place during preprocessing. To illustrate, we can