Re: [Rd] Proposal to limit Internet access during package load

2022-09-26 Thread Gabriel Becker
Ah, thats embarrassing. Thats a bug in how/where I handle lack of connectivity, rather than me not doing it. I've just push a fix to the github repo that now cleanly passes check with no internet connectivity (much more stringent). Using a canned file is a bit odd, because in the case where there

Re: [Rd] Question about grid.group compositing operators in cairo

2022-09-26 Thread Paul Murrell
Could you also please send me the SVG code that your device is generating for your example. Thanks! Paul On 27/09/22 08:50, Paul Murrell wrote: Hi Thanks for the report.  It certainly sounds like I have done something stupid :)  For my debugging and testing could you please share the R

Re: [Rd] Proposal to limit Internet access during package load

2022-09-26 Thread Dirk Eddelbuettel
Regarding 'system' libraries: Packages like stringi and nloptr download the source of, respectively, libicu or libnlopt and build a library _if_ the library is not found locally. If we outlaw this, more users may hit a brick wall because they cannot install system libraries (for lack of permissi

Re: [Rd] Proposal to limit Internet access during package load

2022-09-26 Thread Bob Rudis
I would personally like something like an Android/iOS permissions required/requested manifest document describing what the pkg needs with R doing what it can to enforce said permissions. R would be breaking some ground in this space, but it does that regularly in many respects. Yes, I know I just 1

Re: [Rd] Proposal to limit Internet access during package load

2022-09-26 Thread Simon Urbanek
BTW: It is a good question whether packages that require internet access in order to function at all should be flagged as such so they can be removed from server installations. Let's say if a package provides an API for retrieving stock quotes online and it's all it does then perhaps it does mak

Re: [Rd] Proposal to limit Internet access during package load

2022-09-26 Thread Simon Urbanek
> On 27/09/2022, at 11:02 AM, Gabriel Becker wrote: > > For the record, the only things switchr (my package) is doing internet wise > should be hitting the bioconductor config file > (http://bioconductor.org/config.yaml) so that it knows the things it need to > know about Bioc repos/version

Re: [Rd] Proposal to limit Internet access during package load

2022-09-26 Thread Gabriel Becker
For the record, the only things switchr (my package) is doing internet wise should be hitting the bioconductor config file ( http://bioconductor.org/config.yaml) so that it knows the things it need to know about Bioc repos/versions/etc (at load time, actually, not install time, but since install do

Re: [Rd] Proposal to limit Internet access during package load

2022-09-26 Thread Simon Urbanek
> On 27/09/2022, at 10:21 AM, Iñaki Ucar wrote: > > On Mon, 26 Sept 2022 at 23:07, Simon Urbanek > wrote: >> >> Iñaki, >> >> I'm not sure I understand - system dependencies are an entirely different >> topic and I would argue a far more important one (very happy to start a >> discussion a

Re: [Rd] Proposal to limit Internet access during package load

2022-09-26 Thread Iñaki Ucar
On Mon, 26 Sept 2022 at 23:07, Simon Urbanek wrote: > > Iñaki, > > I'm not sure I understand - system dependencies are an entirely different > topic and I would argue a far more important one (very happy to start a > discussion about that), but that has nothing to do with declaring downloads. >

Re: [Rd] Proposal to limit Internet access during package load

2022-09-26 Thread Simon Urbanek
Iñaki, I'm not sure I understand - system dependencies are an entirely different topic and I would argue a far more important one (very happy to start a discussion about that), but that has nothing to do with declaring downloads. I assumed your question was about large files in packages which p

Re: [Rd] Proposal to limit Internet access during package load

2022-09-26 Thread Simon Urbanek
Gabe, that's a great example how **not** to do it and why it is such a bad idea. icu4c is a system library, so it is generally available and it already includes the data in the system library, so embedding data from an outdated version is generally bad. I'm not sure why it should be needed in t

Re: [Rd] Proposal to limit Internet access during package load

2022-09-26 Thread Iñaki Ucar
On Mon, 26 Sept 2022 at 21:50, Simon Urbanek wrote: > > [snip] > Sure, I fully agree that it would be a good first step, but I'm still waiting > for examples ;). Oh, you want me to actually name specific packages? I thought that this was a well-established fact from your initial statement "I ful

Re: [Rd] Proposal to limit Internet access during package load

2022-09-26 Thread Gabriel Becker
Hi Simon, The example of this I'm aware of that is most popular and widely used "in the wild" is the stringi package (which is a dep of the widely used stringr pkg) whose configure file downloads the ICU Data Library (icudt). See https://github.com/gagolews/stringi/blob/master/configure#L5412 No

Re: [Rd] Question about grid.group compositing operators in cairo

2022-09-26 Thread Paul Murrell
Hi Thanks for the report. It certainly sounds like I have done something stupid :) For my debugging and testing could you please share the R code from your tests ? Thanks! Paul On 26/09/22 10:27, Panagiotis Skintzos wrote: Hello, I'm trying to update ggiraph package in graphic engine v1

Re: [Rd] Proposal to limit Internet access during package load

2022-09-26 Thread Simon Urbanek
> On Sep 27, 2022, at 8:25 AM, Iñaki Ucar wrote: > > On Sat, 24 Sept 2022 at 01:55, Simon Urbanek > wrote: >> >> Iñaki, >> >> I fully agree, this a very common issue since vast majority of server >> deployments I have encountered don't allow internet access. In practice this >> means that

Re: [Rd] Proposal to limit Internet access during package load

2022-09-26 Thread Iñaki Ucar
On Sat, 24 Sept 2022 at 01:55, Simon Urbanek wrote: > > Iñaki, > > I fully agree, this a very common issue since vast majority of server > deployments I have encountered don't allow internet access. In practice this > means that such packages are effectively banned. > > I would argue that not ev

[Rd] Question about grid.group compositing operators in cairo

2022-09-26 Thread Panagiotis Skintzos
Hello, I'm trying to update ggiraph package in graphic engine v15 (currently we support up to v14). I've implemented the group operators and when I compare the outputs of ggiraph::dsvg with the outputs of svg/png, I noticed some weird results. Specifically, some operators in cairo (in, out,

Re: [Rd] Better 'undefined columns' error for data.frame

2022-09-26 Thread GILLIBERT, Andre
Duncan Murdoch wrote: > > > On 25/09/2022 2:48 p.m., Dirk Eddelbuettel wrote: > > > > Andre, > > > > On 25 September 2022 at 18:09, GILLIBERT, Andre wrote: > > | Please, find the patch attached, based on the latest R SVN trunk code. > > > > Well the mailing list software tends to drop attachmen