Re: [Rd] R CMD build should fail early for old package versions?

2019-09-30 Thread Duncan Murdoch
On 30/09/2019 5:25 p.m., Toby Hocking wrote: Hi all, Today I had an R CMD build that failed while building a vignette because the vignette needs tidyr (>= 1.0, declared in DESCRIPTION Suggests) but my system had a previous version installed. It did not take me too long to figure out the issue (

[Rd] R CMD build should fail early for old package versions?

2019-09-30 Thread Toby Hocking
Hi all, Today I had an R CMD build that failed while building a vignette because the vignette needs tidyr (>= 1.0, declared in DESCRIPTION Suggests) but my system had a previous version installed. It did not take me too long to figure out the issue (solved by upgrading tidyr) but it would have be

Re: [Rd] speed up R_IsNA, R_IsNaN for vector input

2019-09-30 Thread Jan Gorecki
Dear Tomas, I was thinking it is because of taking ieee_double y; out from the loop, and re-using across iterations. Now I checked that was not the reason of speed up. So as you wrote, it was only due to inlining. I am surprised the difference is so significant. Thank you, Jan On Mon, Sep 3

Re: [Rd] speed up R_IsNA, R_IsNaN for vector input

2019-09-30 Thread Tomas Kalibera
On 9/29/19 1:09 PM, Jan Gorecki wrote: Dear R developers, I spotted that R_isNA and R_IsNaN could be improved when applied on a vector where we could take out small part of their logic, run it once, and then reuse inside the loop. Dear Jan, Looking at your examples, I just see you have hand-i

Re: [Rd] typeof(getOption("warn")) is "integer" instead of "double" in R unstable (2019-09-27 r77229)? Reproducible?

2019-09-30 Thread Tomas Kalibera
On 9/29/19 6:12 PM, nos...@altfeld-im.de wrote: Thanks a lot for pointing out the reason (and yes, I am testing quite to stringent in this case - it's my old testing disease ;-) Please note that it is not a good practice to test for these things in unit tests. Every system has some specified

Re: [Rd] depending on orphaned packages?

2019-09-30 Thread Matt Denwood
Hi Bob I had also started working on SuppDists a couple of months ago as I needed to expose some of the distributions at C-level for use in another package. Perhaps I/we could create a GitHub repo and collaborate on this? I’m happy for you to take the lead, but a job shared is a job halved an