Re: [Rd] [PATCH] Ensure correct order of evaluation in macro

2017-05-24 Thread Sahil Kang
Hi Martin, Would you feel comfortable merging my small patch in? I'd like to send additional patches that will improve these types of function macros so I'm hoping to start with this small change. Thanks, Sahil __ R-devel@r-project.org mailing list

Re: [Rd] Getting an R bugzilla account

2017-05-24 Thread Nathan Sosnovske via R-devel
Thank you for creating this! I'll go ahead and start working on bugs as I have time. I have a patch for the bug I linked below so you should see that soon. :) Nathan -Original Message- From: Martyn Plummer [mailto:plumm...@iarc.fr] Sent: Tuesday, May 23, 2017 11:16 PM To: r-devel@r-proj

Re: [Rd] reg-tests-1d.R fails in r72721

2017-05-24 Thread Duncan Murdoch
On 24/05/2017 9:59 AM, Hiroyuki Kawakatsu wrote: On 2017-05-24, Duncan Murdoch wrote: [...] Okay, how about if we weaken the test? [...] try stopifnot(path.expand(paste0("~/", filename)) == paste0(path.expand("~/"), filename)) Nope: ## path.expand shouldn't translat

Re: [Rd] reg-tests-1d.R fails in r72721

2017-05-24 Thread Hiroyuki Kawakatsu
On 2017-05-24, Duncan Murdoch wrote: [...] > Okay, how about if we weaken the test? [...] > try > > stopifnot(path.expand(paste0("~/", filename)) == > paste0(path.expand("~/"), filename)) > Nope: > ## path.expand shouldn't translate to local encoding PR#17120 > filenam

Re: [Rd] reg-tests-1d.R fails in r72721

2017-05-24 Thread Duncan Murdoch
On 24/05/2017 7:59 AM, Hiroyuki Kawakatsu wrote: On 2017-05-24, Duncan Murdoch wrote: I think the test is wrong because in the first case you are working in a locale where that character is representable. In my locale it is not, so x1 is converted to UTF-8, and everything compares equal. An e

Re: [Rd] precision of do_arith() in arithmetic.c

2017-05-24 Thread Berend Hasselman
> On 24 May 2017, at 04:24, M Kim wrote: > > To the R development team: > > First of all, thank you so much for maintaining wonderful R software. > > Perhaps, Dr. Ahn has just reported an error on the wilcox.test() function, > and suggesting that an error may arise from abs() and rank(). > >

Re: [Rd] reg-tests-1d.R fails in r72721

2017-05-24 Thread Hiroyuki Kawakatsu
On 2017-05-24, Duncan Murdoch wrote: > > I think the test is wrong because in the first case you are working in a > locale where that character is representable. In my locale it is not, so x1 > is converted to UTF-8, and everything compares equal. > > An explicit conversion of x1 to UTF-8 should

Re: [Rd] reg-tests-1d.R fails in r72721

2017-05-24 Thread Duncan Murdoch
On 24/05/2017 5:47 AM, Hiroyuki Kawakatsu wrote: Hi, I am failing make check in r72721 at the end of reg-tests-1d.R. The relevant block of code is ## path.expand shouldn't translate to local encoding PR#17120 filename <- "\U9b3c.R" print(Encoding(filename)) x1 <- path.expand(paste0("~/", filena

[Rd] precision of do_arith() in arithmetic.c

2017-05-24 Thread M Kim
To the R development team: First of all, thank you so much for maintaining wonderful R software. Perhaps, Dr. Ahn has just reported an error on the wilcox.test() function, and suggesting that an error may arise from abs() and rank(). I just had a quick check that the problem may come from the p

[Rd] reg-tests-1d.R fails in r72721

2017-05-24 Thread Hiroyuki Kawakatsu
Hi, I am failing make check in r72721 at the end of reg-tests-1d.R. The relevant block of code is ## path.expand shouldn't translate to local encoding PR#17120 filename <- "\U9b3c.R" print(Encoding(filename)) x1 <- path.expand(paste0("~/", filename)) print(Encoding(x1)) x2 <- paste0(path.expand("