Applied.
Applied. Also the ; fix in badrcptto.
https://github.com/smtpd/qpsmtpd/pull/25
clamdscan: refactored, tests
moved 'use ClamAV::Client' into register and eval it (graceful failure)
refactored
added tests
when virus detected, decrement karma and set naughty
`
https://github.com/smtpd/qpsmtpd/pull/26
dspam: work around DESTROY bug
worked around qpsmtpd bug that DESTROYs the parent when a forked child exits
expanded learning support. Now learns from spamassassin, naughty, and karma
(both good and bad).
better logging for 'reject agree'
improved POD
On Sat, 2 Jun 2012, Matt Simerson wrote:
> Is it a good idea to validate that the MAIL FROM address is the same as
> the From: header in the message?
>
> What exceptions need to be made, if any?
>
> What problems might I encounter if I were to do this?
For starters, you would penalise this me
On Sun, 3 Jun 2012, Matt Simerson wrote:
> ---
> plugins/connection_time | 18 ++
> 1 file changed, 14 insertions(+), 4 deletions(-)
>
> diff --git a/plugins/connection_time b/plugins/connection_time
> index bfac4d2..9cff7f9 100644
> --- a/plugins/connection_time
> +++ b/plu
On Jun 4, 2012, at 9:32 AM, Charlie Brady wrote:
> On Sun, 3 Jun 2012, Matt Simerson wrote:
>
>> ---
>> plugins/connection_time | 18 ++
>> 1 file changed, 14 insertions(+), 4 deletions(-)
>>
>> diff --git a/plugins/connection_time b/plugins/connection_time
>> index bfac4d2..9c
On Jun 4, 2012, at 9:32, Charlie Brady wrote:
>> -use Time::HiRes qw(gettimeofday tv_interval);
>> use Qpsmtpd::Constants;
>>
>> +use Time::HiRes qw(gettimeofday tv_interval);
>> +
>
> Is the change in ordering here accidental, gratuitous, or is there some
> hidden functional significance?
I
On 02.06.2012 23:23, Matt Simerson wrote:
On Jun 2, 2012, at 11:15 AM, Jared Johnson wrote:
Yup. Part of the motivation for this plugin was to short circuit all the
intermediate plugins and handlers so I can feed the message to sa-learn
and dspam. Until dspam is trained, that's a very important
On Jun 4, 2012, at 10:16 AM, Ask Bjørn Hansen wrote:
> On Jun 4, 2012, at 9:32, Charlie Brady wrote:
>
>>> -use Time::HiRes qw(gettimeofday tv_interval);
>>> use Qpsmtpd::Constants;
>>>
>>> +use Time::HiRes qw(gettimeofday tv_interval);
>>
>> Is the change in ordering here accidental, gratuito
On Jun 4, 2012, at 6:40 AM, Stevan Bajić wrote:
> On 02.06.2012 23:23, Matt Simerson wrote:
>> On Jun 2, 2012, at 11:15 AM, Jared Johnson wrote:
>>
Yup. Part of the motivation for this plugin was to short circuit all the
intermediate plugins and handlers so I can feed the message to sa
Bayes is a little bit of a black box to me, so I can't really quantify
just how useful this is, but I'd say it's greater than zero. Dspam even
treats headers in a special way to ensure that their usefulness is
maximized.
>>> Usefulness != gain. There may be some gain, but I'm
The bad news: I did introduce a bug.
The good news: My tests caught it. Travis complained.
Pull Request: https://github.com/smtpd/qpsmtpd/pull/27
Details:
This code does not increment $count correctly:
+my $count = $self->connection->notes('unrec_cmd_count') || 0 + 1;
+
On Jun 4, 2012, at 9:26 AM, Charlie Brady wrote:
> On Sat, 2 Jun 2012, Matt Simerson wrote:
>
>> Is it a good idea to validate that the MAIL FROM address is the same as
>> the From: header in the message?
>>
>> What exceptions need to be made, if any?
>>
>> What problems might I encounter if
On 04.06.2012 21:09, Matt Simerson wrote:
On Jun 4, 2012, at 6:40 AM, Stevan Bajić wrote:
On 02.06.2012 23:23, Matt Simerson wrote:
On Jun 2, 2012, at 11:15 AM, Jared Johnson wrote:
Yup. Part of the motivation for this plugin was to short circuit all the
intermediate plugins and handlers so
On Mon, 4 Jun 2012, Matt Simerson wrote:
>
> On Jun 4, 2012, at 9:26 AM, Charlie Brady wrote:
>
> > On Sat, 2 Jun 2012, Matt Simerson wrote:
> >
> >> Is it a good idea to validate that the MAIL FROM address is the same as
> >> the From: header in the message?
...
> > Also wouldn't work well f
On Mon, 4 Jun 2012, Matt Simerson wrote:
> +my $count = $self->connection->notes('unrec_cmd_count') || 0;
> + $self->connection->notes('unrec_cmd_count',
> ++$count );
>
> Which does increment correctly.
>
> This also works (note the parens), which is how it was d
On Jun 4, 2012, at 7:35 PM, Charlie Brady wrote:
>
> On Mon, 4 Jun 2012, Matt Simerson wrote:
>
>> +my $count = $self->connection->notes('unrec_cmd_count') || 0;
>> + $self->connection->notes('unrec_cmd_count',
>> ++$count );
>>
>> Which does increment correctly.
> In addition to whatever value it might have for Bayesian filters, it may
> be useful to always add an X-From: header, so that diagnosing email
> problems like my client with the forged From: header would be easier. I
> had to grep through his server logs to see how the spammer bypassed the
> SPF
19 matches
Mail list logo
