Re: New plugin: reaper

2012-06-03 Thread Matt Simerson
On Jun 2, 2012, at 11:22 AM, Jared Johnson wrote: >>> Why hasn't your rejected idea been worked into qpsmtpd yet? >> >> Because I came to view qpsmtpd in a different way than many >> do (many view it as a service with useful plugins which they >> can deploy, use, and enjoy). Instead I view it

[PATCH] basicheaders: adding missing semicolon, fixed POD error

2012-06-03 Thread Matt Simerson
--- plugins/check_basicheaders |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/check_basicheaders b/plugins/check_basicheaders index 684b9a4..c72f229 100644 --- a/plugins/check_basicheaders +++ b/plugins/check_basicheaders @@ -35,7 +35,7 @@ I would be surprised i

[PATCH] connection consistency

2012-06-03 Thread Matt Simerson
- $self->qp->connection->notes + $self->connection->notes and all tests pass. --- docs/advanced.pod |4 ++-- plugins/async/check_earlytalker|3 +-- plugins/async/dnsbl|8 plugins/async/require_resolvable_fromhost

[PATCH] make SPF level 2 a little more lenient

2012-06-03 Thread Matt Simerson
--- plugins/sender_permitted_from |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/sender_permitted_from b/plugins/sender_permitted_from index 2353493..17805f1 100644 --- a/plugins/sender_permitted_from +++ b/plugins/sender_permitted_from @@ -167,7 +167,7 @@ sub hook_

Re: New plugin: reaper

2012-06-03 Thread Matt Simerson
https://github.com/smtpd/qpsmtpd/pull/24 Instead of zombies, undead, and a reaper, the plugin has been renamed 'naughty'. NAME naughty - dispose of naughty connections BACKGROUND Rather than immediately terminating naughty connections, plugins often mark the connection

[PATCH] plugins.pod: much simpler way to get debug logging

2012-06-03 Thread Matt Simerson
for individual plugins --- docs/plugins.pod | 47 +++ 1 file changed, 3 insertions(+), 44 deletions(-) diff --git a/docs/plugins.pod b/docs/plugins.pod index 46b174b..43a4c4e 100644 --- a/docs/plugins.pod +++ b/docs/plugins.pod @@ -217,7 +217,7 @@ hoo

[PATCH] badrcptto: remove spurious semicolon

2012-06-03 Thread Matt Simerson
--- plugins/check_badrcptto |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/check_badrcptto b/plugins/check_badrcptto index fdea8e8..7b5f7d9 100644 --- a/plugins/check_badrcptto +++ b/plugins/check_badrcptto @@ -63,7 +63,7 @@ sub hook_rcpt { $line =~ s/^\s+/

[PATCH] connection_time: make compatible with tcpserver deployment

2012-06-03 Thread Matt Simerson
--- plugins/connection_time | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/plugins/connection_time b/plugins/connection_time index bfac4d2..9cff7f9 100644 --- a/plugins/connection_time +++ b/plugins/connection_time @@ -26,9 +26,10 @@ Adjust the quantity o

[PATCH] loop: use default if invalid config set

2012-06-03 Thread Matt Simerson
--- plugins/check_loop |1 + 1 file changed, 1 insertion(+) diff --git a/plugins/check_loop b/plugins/check_loop index 5ffa608..634c126 100644 --- a/plugins/check_loop +++ b/plugins/check_loop @@ -35,6 +35,7 @@ sub init { if ( $self->{_max_hops} !~ /^\d+$/ ) { $self->log(LOGWARN, "I

[PATCH] unrecognized_commands: better log messages

2012-06-03 Thread Matt Simerson
removed hook_connect, unnecessary. --- plugins/count_unrecognized_commands | 29 + 1 file changed, 9 insertions(+), 20 deletions(-) diff --git a/plugins/count_unrecognized_commands b/plugins/count_unrecognized_commands index 445dca7..1c3cbf2 100644 --- a/plugins/cou

Re: [PATCH] unrecognized_commands: better log messages

2012-06-03 Thread Ask Bjørn Hansen
On Jun 3, 2012, at 19:00, Matt Simerson wrote: > removed hook_connect, unnecessary. I think it's there so if you log or otherwise use the note, it'll be reasonably initialized. > - if ($badcmdcount >= $self->{_unrec_cmd_max}) { > -my $msg = "Closing connection, $badcmdcount unrecognized c

Re: [PATCH] unrecognized_commands: better log messages

2012-06-03 Thread Matt Simerson
On Jun 3, 2012, at 11:41 PM, Ask Bjørn Hansen wrote: > > On Jun 3, 2012, at 19:00, Matt Simerson wrote: > >> removed hook_connect, unnecessary. > > I think it's there so if you log or otherwise use the note, it'll be > reasonably initialized. It's not used anywhere else in qpsmtpd or plugins