Re: tls plugin and SSL version

2010-07-25 Thread Matt Simerson
Here's a chunk of code from one of my projects: A config file setting allows an admin to choose from; all, high, medium, or pci. my $s = $ciphers eq 'all'? 'ALL' : $ciphers eq 'high' ? 'HIGH:!SSLv2' : $ciphers eq 'medium' ? 'HIGH:MEDIUM:!SSLv2' : $ciphers eq 'pci'

Re: [BUG] Default search path used in require_resolvable_fromhost

2010-07-25 Thread Robert Spier
I've committed this as ab7c2601f0740fac1c3c117e7e5c0a5690348194. I'm not 100% sure it's a good idea, but I think it's mostly a good thing. Charlie - It would be great if you could send patches instead of "suggestions". -R Charlie Brady wrote: > > > http://bugs.contribs.org/show_bug.cgi?id=5

Re: rpm packaging bug - smtpd user created with shell not /bin/false

2010-07-25 Thread Robert Spier
Fix committed as 9348539ed7aa03b438905f953771db14fcb4c1ea Once again, a patch would have been great. I haven't tested this, so any RPM users, please do. -R Charlie Brady wrote: > > > http://bugs.contribs.org/show_bug.cgi?id=6025 > > if ! id smtpd >/dev/null 2>&1 > then > # need to creat

Re: tls plugin and SSL version

2010-07-25 Thread Robert Spier
Matt, Could you integrate this kind of config into the tls plugin? That's definitely nicer than hardcoding a cipher. Thanks! -R Matt Simerson wrote: > > > Here's a chunk of code from one of my projects: > > A config file setting allows an admin to choose from; all, high, medium, or

Re: Rewritten URIBL plugin

2010-07-25 Thread Robert Spier
> - Introduces support for URIBL services that may not have worked right, at > least out of the box, before. Defines the subtle differences between > various known URIBL services in order to maximize compatibility. Is it worth pulling some of this config out of the code and putting it into some

[PATCH 1/2] corrected email address

2010-07-25 Thread Matt Simerson
--- plugins/greylisting |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/plugins/greylisting b/plugins/greylisting index ebdec8f..7860b13 100644 --- a/plugins/greylisting +++ b/plugins/greylisting @@ -133,7 +133,7 @@ use something like File::NFSLock instead. Written by

[PATCH 2/2] increased default TLS security setting

2010-07-25 Thread Matt Simerson
switched default TLS security in config/tls_ciphers from HIGH to HIGH:!SSLv2. Added note for how to set the minimum level of security necessary for PCI compliance. --- config.sample/tls_ciphers |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/config.sample/tls_ciph

Re: [PATCH 1/2] corrected email address

2010-07-25 Thread Robert Spier
Applied: d0c9b7cbe5ec615e2e23b91072781019ad59ee19 Matt Simerson wrote: > > --- > plugins/greylisting |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/plugins/greylisting b/plugins/greylisting > index ebdec8f..7860b13 100644 > --- a/plugins/greylisting > +++ b/plu

Re: [PATCH 2/2] increased default TLS security setting

2010-07-25 Thread Robert Spier
Applied: 3a7f46aa3e75988686ef9fcae5158fc29f6a86f6 Matt Simerson wrote: > > switched default TLS security in config/tls_ciphers from HIGH to HIGH:!SSLv2. > Added note for how to set the minimum level of security necessary for PCI > compliance. > --- > config.sample/tls_ciphers |8 +++-

[PATCH] add test name to test output

2010-07-25 Thread Matt Simerson
--- t/plugin_tests/check_badrcptto |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/t/plugin_tests/check_badrcptto b/t/plugin_tests/check_badrcptto index 9f7b9c9..b9a986d 100644 --- a/t/plugin_tests/check_badrcptto +++ b/t/plugin_tests/check_badrcptto @@ -5,5 +5,5 @@ sub r

[PATCH] give badrcptto a reasonable name

2010-07-25 Thread Matt Simerson
renamed check_badrcptto test from foo to test_check_badrcptto_ok --- t/plugin_tests/check_badrcptto |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/t/plugin_tests/check_badrcptto b/t/plugin_tests/check_badrcptto index d10f992..9f7b9c9 100644 --- a/t/plugin_tests/check_b

Re: [PATCH] add test name to test output

2010-07-25 Thread Robert Spier
Thanks, Applied: 0c4a76ffe75190a82010dca5dd7e2bd4bdbe14cb Matt Simerson wrote: > > --- > t/plugin_tests/check_badrcptto |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/t/plugin_tests/check_badrcptto b/t/plugin_tests/check_badrcptto > index 9f7b9c9..b9a986d 100644

Re: [PATCH] give badrcptto a reasonable name

2010-07-25 Thread Robert Spier
Thanks, Applied! d11b87e0509e1482e6c76f203d0d9cacd581db5e Matt Simerson wrote: > > renamed check_badrcptto test from foo to test_check_badrcptto_ok > --- > t/plugin_tests/check_badrcptto |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/t/plugin_tests/check_badr