Re: PATCH [1/5] Disconnect badhelo

2009-06-19 Thread Charlie Brady
On Thu, 18 Jun 2009, Ask Bj?rn Hansen wrote: On Jun 17, 2009, at 8:13, Filippo Carletti wrote: +++ qpsmtpd-0.40/plugins/check_spamhelo 2007-06-14 13:21:45.0 -0600 @@ -23,7 +23,7 @@ for my $bad ($self->qp->config('badhelo')) { if ($host eq lc $bad) { $self->log(LOGDEBUG, "

Re: PATCH [2/5] rhsbl_disconnect

2009-06-19 Thread Charlie Brady
This one's mine. On Wed, 17 Jun 2009, Filippo Carletti wrote: See http://bugs.contribs.org/show_bug.cgi?id=3390 for discussion. diff -Nur -x '*.orig' -x '*.rej' qpsmtpd-0.40/plugins/rhsbl mezzanine_patched_qpsmtpd-0.40/plugins/rhsbl --- qpsmtpd-0.40/plugins/rhsbl 2007-06-14 13:57:24.

Re: PATCH [3/5] spamassassin noise

2009-06-19 Thread Charlie Brady
On Wed, 17 Jun 2009, Filippo Carletti wrote: http://bugs.contribs.org/show_bug.cgi?id=3340 Also me. Here's the background. Line 195 highlighted: my ($flag, $hits, $required); while () { $self->log(LOGDEBUG, "check_spam: spamd: $_"); #warn "GOT FROM SPAMD1: $_"; last unless m

Re: PATCH [4/5] clamdscan parameter change

2009-06-19 Thread Charlie Brady
On Wed, 17 Jun 2009, Filippo Carletti wrote: This is needed to use clamav-0.95 which changed an option. http://bugs.contribs.org/show_bug.cgi?id=5108 Jonathan Martens --- qpsmtpd-0.40/plugins/virus/clamav.fixClamscanParameterChange 2009-03-28 08:47:34.0 +0100 +++ qpsmtpd-

Re: PATCH [5/5] clamav denied on fail

2009-06-19 Thread Charlie Brady
On Wed, 17 Jun 2009, Filippo Carletti wrote: http://bugs.contribs.org/show_bug.cgi?id=3098 Shad L. Lords --- qpsmtpd-0.40/plugins/virus/clamav 2007-06-14 11:57:23.0 -0600 +++ mezzanine_patched_qpsmtpd-0.40/plugins/virus/clamav 2007-06-14 17:46:23.0 -0600 @@ -139,6 +139,9

Re: PATCH [1/5] Disconnect badhelo

2009-06-19 Thread Chris Lewis
Charlie Brady wrote: It's not as though there are any SMTP clients out there which will try again with a different helo host. Unless there is a spambot tuned for this qpsmtpd plugin. There are plenty of bots that do that. I don't understand your statement here. In what way would any client b

Re: PATCH [1/5] Disconnect badhelo

2009-06-19 Thread Jared Johnson
I like this approach, but it's had its complications for us because we don't want to make the compromise of doing the rest of the checks at a given stage needlessly; e.g. if our RBL plugin hits, we don't want to bother doing RDNS and SPF lookups only to say 'sorry, you were on an RBL' afterward

Re: PATCH [1/5] Disconnect badhelo

2009-06-19 Thread Chris Lewis
Jared Johnson wrote: I like this approach, but it's had its complications for us because we don't want to make the compromise of doing the rest of the checks at a given stage needlessly; e.g. if our RBL plugin hits, we don't want to bother doing RDNS and SPF lookups only to say 'sorry, you were