address notes patches

2009-02-20 Thread Jared Johnson
I've finally got around to attempting to learn to navigate Git. Attempting to follow the suggested workflow in development.pod, I've created a QP fork on Github: http://github.com/jaredj/qpsmtpd/tree ... and created three topic branches, each with a single commit, representing my new effort

reset_transaction between AUTH and MAIL_FROM

2009-02-20 Thread Jared Johnson
I've begun working on a custom auth plugin and tried setting some transaction notes after successful authentication based on the credentials that were used. Of course this didn't work, as the transaction is reset as soon as MAIL FROM is issued. I can probably get around this with connection n

Re: Error: 503 but you already said AUTH

2009-02-20 Thread Jared Johnson
The attached diff should fix it for you. I'll commit later if nobody complains. It appears this still hasn't been applied. I just applied it myself and it works for me; is there anything stopping this from being committed? Also note that you might want to wipe out the tab that's in the midst

Re: reset_transaction between AUTH and MAIL_FROM

2009-02-20 Thread Jared Johnson
Responding to myself here, after testing and realizing the auth results are sticky for the whole connection, rather than reset at MAIL FROM or RSET -- it is probably a very silly idea to set any transaction notes as opposed to connection notes in an auth plugin, making my question somewhat irre

Re: Error: 503 but you already said AUTH

2009-02-20 Thread Hanno Hecker
On Fri, 20 Feb 2009 10:21:22 -0600 Jared Johnson wrote: > > The attached diff should fix it for you. I'll commit later if nobody > > complains. > > It appears this still hasn't been applied. I just applied it myself and > it works for me; is there anything stopping this from being committed? N

Re: Error: 503 but you already said AUTH

2009-02-20 Thread Jared Johnson
Does git support 'hooks' like SVN does? Here at work we have some very spiffy SVN hooks that don't let us commit code if it fails perltidy, contains tabs, trailing whitespace, long lines, etc. It can be overridden by the comitter, but often it catches things we didn't actually mean to commit.

Re: Error: 503 but you already said AUTH

2009-02-20 Thread Guy Hulbert
On Fri, 2009-20-02 at 14:20 -0600, Jared Johnson wrote: > Does git support 'hooks' like SVN does? Yes and they are trivial to implement ... I found SVN to be a PITA -- partly why I switched. Different hooks are documented in different git man pages, iirc, so you need to read more than one page.

Re: persistence?

2009-02-20 Thread David Nicol
Okay then. Anyone for collaborating on setting one up, with a unified accessor syntax similar to what we have for "notes" ? http://advenge.com/2009/products/downloads/qpsmtpd/plugins/verp is a working plugin that uses DirDB persistence library to rewrite the envelope return addresses of all traf

Re: persistence?

2009-02-20 Thread Pedro Melo
Hi, On Feb 20, 2009, at 9:24 PM, David Nicol wrote: Okay then. Anyone for collaborating on setting one up, with a unified accessor syntax similar to what we have for "notes" ? http://advenge.com/2009/products/downloads/qpsmtpd/plugins/verp is a working plugin that uses DirDB persistence libr

Re: persistence?

2009-02-20 Thread Jared Johnson
David Nicol wrote: Okay then. Anyone for collaborating on setting one up, with a unified accessor syntax similar to what we have for "notes" ? http://advenge.com/2009/products/downloads/qpsmtpd/plugins/verp is a working plugin that uses DirDB persistence library to rewrite the envelope return

Re: persistence?

2009-02-20 Thread Hanno Hecker
On Fri, 20 Feb 2009 15:24:42 -0600 David Nicol wrote: > Okay then. Anyone for collaborating on setting one up, with a unified > accessor syntax similar to what we have for "notes" ? Some (longer) time ago I tried something like Apache::DBI for Qpsmtpd. I never really tried how it works in a real