indentation, line length, trailing whitespace

2009-01-14 Thread Jared Johnson
Hi, Is there any interest in patches to conform current QP code to line length and whitespace standards? 1. I notice that most of the codebase uses 4-space indents, but I have seen some areas with 2-space indents and tab characters. 2. It's been pointed out that it is preferred that lines

Re: indentation, line length, trailing whitespace

2009-01-14 Thread Matt Sergeant
On Wed, 14 Jan 2009 09:10:14 -0600, Jared Johnson wrote: > Hi, > > Is there any interest in patches to conform current QP code to line > length and whitespace standards? > > 1. I notice that most of the codebase uses 4-space indents, but I > have seen some areas with 2-space indents and tab ch

Today's stupid question...

2009-01-14 Thread Chris Lewis
In my user verification plugin, I'm using the standard Qpsmtpd function: return Qpsmtpd::DSN->no_such_user("No such email address $address"); to generate no-such-user errors. I use other DSN functions for other errors as well. The above generates this, for example: 550 No such email address sd

Re: Today's stupid question...

2009-01-14 Thread Hanno Hecker
On Thu, 15 Jan 2009 00:20:22 -0500 "Chris Lewis" wrote: > Which puts the extended error code (5.1.1) at the end with the # sign. Eg: > > RFC821-error, text, (#extended error code) > > My quick glance at the RFCs and examples coming up from google all show > such an error being expressed this wa

Re: indentation, line length, trailing whitespace

2009-01-14 Thread Robert Spier
Matt Sergeant wrote: > > On Wed, 14 Jan 2009 09:10:14 -0600, Jared Johnson wrote: > > Hi, > > > > Is there any interest in patches to conform current QP code to line > > length and whitespace standards? > > > > 1. I notice that most of the codebase uses 4-space indents, but I > > have seen