Re: Christmas release?

2008-12-23 Thread Kaare Rasmussen
> > On Dec 19, 2008, at 18:56, Matt Sergeant wrote: > >> Shall we do a release for xmas? It's been forever... On the topic of releasing, why isn't qpsmtpd released to CPAN? -- Med venlig hilsen Kaare Rasmussen, Jasonic Jasonic Telefon: +45 3816 2582 Nordre Fasanvej 12 2000 Fre

Re: PATCH: allow regular expressions for address matching to be easily overridden

2008-12-23 Thread Robin Bowes
Jared Johnson wrote: $Qpsmtpd::Address::domain_expr = '(?:[a-zA-Z0-9](?:[-a-zA-Z0-9]*[a-zA-Z0-9])?)(?:.(?:[a-zA-Z0-9](?:[-a-zA-Z0-9]*[a-zA-Z0-9])?))*'; Any reason this, and most/all the other regex definitions are not qr{...} ? R.

strange mix up of 2 check

2008-12-23 Thread Antoine
Hi, I was informed of a strange bounce today, and since I couldn't figure it out I check the qpstmpd log (0.32-6 in debian etch) and there's 2 lines which bug me, the bounce was received by the sender of the 2nd line : (unfortunately I'm using logterse pugin) Tue Dec 23 18:30:54 2008 box[24604]:

Re: Christmas release?

2008-12-23 Thread Matt Sergeant
On Mon, 22 Dec 2008 11:58:23 +0100, Kaare Rasmussen wrote: >>> On Dec 19, 2008, at 18:56, Matt Sergeant wrote: Shall we do a release for xmas? It's been forever... > > On the topic of releasing, why isn't qpsmtpd released to CPAN? Because we never really got it easily installable via the wh

Re: PATCH: allow regular expressions for address matching to be easily overridden

2008-12-23 Thread Jared Johnson
Robin Bowes wrote: Any reason this, and most/all the other regex definitions are not qr{...} ? Good idea! Attached a new patch. Tested with normal address syntax and u...@[ip] syntax, with $Qpsmtpd::Address::address_literal_expr set and unset... it might need some closer review for any othe

Re: PATCH: allow regular expressions for address matching to be easily overridden

2008-12-23 Thread Robert Spier
There's no point to use qr here, as these are mostly strings which are substituted into other regular expressions. Also, please try and avoid lines over 80 characters. -R Jared Johnson wrote: > > Robin Bowes wrote: > > Any reason this, and most/all the other regex definitions are not qr{...}

Re: PATCH: Generalize spool dir permissions

2008-12-23 Thread Robert Spier
Jared Johnson wrote: > > Index: plugins/virus/clamdscan > === > --- plugins/virus/clamdscan (revision 961) > +++ plugins/virus/clamdscan (working copy) > @@ -24,8 +24,8 @@ > =item * Enable the "AllowSupplementaryGroups" option

Trimming blanks in config files

2008-12-23 Thread Henry Baragar
Hello, This really bit me in config/relayclients: # Format is IP, or IP part with trailing dot # e.g. "127.0.0.1", or "192.168." 127.0.0.1 10. Notice the space in the "10. " line? Did you know it was significant? Neither did I. I have attached a diff file that contains the code (and tests) to