Re: Connection notes and TLS

2008-05-26 Thread John Peacock
Chris Lewis wrote: SMTP state and qpsmtpd/filtering state are not the same thing. The RFCs talk about destroying SMTP state. It already does that without having to destroy any notes() AFAICT. But it shouldn't blithely throwing away qpsmtpd/filtering state - it's none of the RFC's business.

Re: Connection notes and TLS

2008-05-26 Thread Matt Sergeant
On 26-May-08, at 5:24 PM, John Peacock wrote: Those are *connection* attributes, not *transaction* attributes. If a plugin is storing them in the transaction object, that is a mistake. We can and probably should maintain the connection notes from before the TLS reset, but I maintain that

Re: Connection notes and TLS

2008-05-26 Thread John Peacock
Matt Sergeant wrote: OK, I'm fine with that. Hopefully to put this thread to rest, I committed my one line change to preserve the connection notes. If anyone's favorite core plugin stashes connection-related stuff (like dnsbl) in the transaction notes, let's start individual threads (with p