Re: more reset_connection() and uninitialized values

2007-10-08 Thread Ask Bjørn Hansen
On Oct 8, 2007, at 11:13, Hanno Hecker wrote: If it's ok, I'll submit to trunk, so we can release 0.42 +1.Leaving in the reset_connection method and have it used from prefork seems sorta useful (even if it's empty), but you can do it either way. Take out the entry from the Changes f

Re: more reset_connection() and uninitialized values

2007-10-08 Thread Matt Sergeant
Hanno Hecker wrote: I can't test with -async, because Matt's last change involved some changes that's not available on CPAN (Event::Lib 1.03 does not have the "dns" export), reverting to the old ParaDNS works. Yeah, that was a bad commit. I'll try and revert it.

Re: more reset_connection() and uninitialized values

2007-10-08 Thread Hanno Hecker
On Mon, 1 Oct 2007 20:56:12 +0200 Hanno Hecker <[EMAIL PROTECTED]> wrote: > On Sun, 30 Sep 2007 23:28:42 -0700 > Ask Bjørn Hansen <[EMAIL PROTECTED]> wrote: > > Is this a regression from 0.40? If it is then we need to fix it > > before releasing 0.42 - if it happened in 0.40 too then we can fi

Re: more reset_connection() and uninitialized values

2007-10-01 Thread Hanno Hecker
On Sun, 30 Sep 2007 23:28:42 -0700 Ask Bjørn Hansen <[EMAIL PROTECTED]> wrote: > > Mhh, seems like it does it always like this, no matter which order... > > Is this a regression from 0.40? If it is then we need to fix it > before releasing 0.42 - if it happened in 0.40 too then we can fix it

Re: more reset_connection() and uninitialized values

2007-09-30 Thread Ask Bjørn Hansen
On Sep 30, 2007, at 10:51 AM, Hanno Hecker wrote: [prefork reset problem] ...and on the second connection: $ telnet hex 2525 Trying 10.7.7.2... Connected to hex.city.ankh-morp.org. Escape character is '^]'. 220 hex ESMTP qpsmtpd 0.42rc1 ready; send us your mail, but not your spam. ehlo hex 5

Re: more reset_connection() and uninitialized values

2007-09-30 Thread Hanno Hecker
On Sun, 30 Sep 2007 11:49:16 -0400 John Peacock <[EMAIL PROTECTED]> wrote: > Hanno Hecker wrote: > ># reset transaction if we queued the mail > > + $self->reset_connection; > >$self->reset_transaction; > Except if it is written properly, reset_connection should in fact drop the > transa

Re: more reset_connection() and uninitialized values

2007-09-30 Thread John Peacock
Hanno Hecker wrote: > Index: lib/Qpsmtpd/SMTP.pm > === > --- lib/Qpsmtpd/SMTP.pm (revision 804) > +++ lib/Qpsmtpd/SMTP.pm (working copy) > @@ -802,6 +802,7 @@ >my ($self, $rc, $msg, $args) = @_; > ># reset trans

more reset_connection() and uninitialized values

2007-09-30 Thread Hanno Hecker
Hi, there are some more uninitialized values when running with the ->id stuff. This one happens also in -forkserver, and can only be fixed by resetting the _connection_ after queueing the mail. See attached diff. Is this what we want? Hanno Index: qpsmtpd-prefork =