Re: Regarding config plugins...

2009-09-09 Thread Jason Mills
Well I guess git send-email omitted my commit log in the sent patches. So I'll just cover it real quick here: Patch 1 of 2 adds a new hook currently named 'config-get-cachekey'. This hook allows plugin authors to mutate or build logic around the key used when referencing Qpsmtpd.pm's $_config_cach

[Re: Regarding config plugins... 2/2] Example plugin for new 'config-get-configkey' hook with plugin_tests.

2009-09-09 Thread dex . pdx
From: Jason Mills Signed-off-by: Jason Mills --- config.sample/plugins |3 +++ plugins/reverse_config_cachekey| 10 ++ t/plugin_tests/reverse_config_cachekey | 18 ++ 3 files changed, 31 insertions(+), 0 deletions(-) create mode 100644

[Re: Regarding config plugins... 1/2] Added support for 'config-get-cachekey' hook.

2009-09-09 Thread dex . pdx
From: Jason Mills Signed-off-by: Jason Mills --- lib/Qpsmtpd.pm| 35 +-- lib/Qpsmtpd/Plugin.pm |1 + 2 files changed, 26 insertions(+), 10 deletions(-) diff --git a/lib/Qpsmtpd.pm b/lib/Qpsmtpd.pm index a47d330..7f4298f 100644 --- a/lib/Qpsmtpd.pm

Re: Regarding config plugins...

2009-09-09 Thread Jared Johnson
Patches submitted where? -Jared On 09/09/2009 04:43 PM, Jason Mills wrote: Okay patches submitted. For for the time delay but I had a bit of hard drive scare last night after I finished the code but before I could spin the patch. Any input, suggestions and or scorn is welcome :) - J On Tue,

Re: Regarding config plugins...

2009-09-09 Thread Jason Mills
Okay patches submitted. For for the time delay but I had a bit of hard drive scare last night after I finished the code but before I could spin the patch. Any input, suggestions and or scorn is welcome :) - J On Tue, 2009-09-08 at 21:22 -0700, Jason Mills wrote: > Working on it right now :) > >

Re: Regarding config plugins...

2009-09-08 Thread Jason Mills
Working on it right now :) On Tue, 2009-09-08 at 21:17 -0700, Ask Bjørn Hansen wrote: > On Sep 8, 2009, at 21:05, Jason Mills wrote: > > > So to the point of the question: Would anyone mind if I patched the > > configuration stuff within Qpsmtpd to allow configuration minded > > plugins > > to

Re: Regarding config plugins...

2009-09-08 Thread Ask Bjørn Hansen
On Sep 8, 2009, at 21:05, Jason Mills wrote: So to the point of the question: Would anyone mind if I patched the configuration stuff within Qpsmtpd to allow configuration minded plugins to alter/hook/stack into how Qpsmtpd discovers and utilizes cached configuration values? Show us a patch