Re: DNSBL and answer id check missing

2008-09-30 Thread Peter J. Holzer
On 2008-09-30 01:30:44 -0700, Ask Bjørn Hansen wrote: > How about making qpsmtpd require Net::DNS 0.60 then? I've built in a work-around for the problem in older releases of Net::DNS. But I'm not sure if that still works - from a casual glance at the source I'd say no, and I'm not sure how it coul

Re: DNSBL and answer id check missing

2008-09-30 Thread Ask Bjørn Hansen
How about making qpsmtpd require Net::DNS 0.60 then? - ask

Re: DNSBL and answer id check missing

2008-09-29 Thread Chris Lewis
Charlie Brady wrote: > > On Sun, 28 Sep 2008, Ask Bj�rn Hansen wrote: > >> On Sep 28, 2008, at 12:01 AM, Diego d'Ambra wrote: >> >>> my $res = new Net::DNS::Resolver; >>> $res->tcp_timeout(30); >>> $res->udp_timeout(30); >>> $res->srcport(1024+int(rand(64511))); >> >> Shouldn't this fix be in

Re: DNSBL and answer id check missing

2008-09-29 Thread Charlie Brady
On Mon, 29 Sep 2008, Charlie Brady wrote: On Sun, 28 Sep 2008, Ask Bj?rn Hansen wrote: On Sep 28, 2008, at 12:01 AM, Diego d'Ambra wrote: > my $res = new Net::DNS::Resolver; > $res->tcp_timeout(30); > $res->udp_timeout(30); > $res->srcport(1024+int(rand(64511))); Shouldn't this f

Re: DNSBL and answer id check missing

2008-09-29 Thread Charlie Brady
On Sun, 28 Sep 2008, Ask Bj?rn Hansen wrote: On Sep 28, 2008, at 12:01 AM, Diego d'Ambra wrote: my $res = new Net::DNS::Resolver; $res->tcp_timeout(30); $res->udp_timeout(30); $res->srcport(1024+int(rand(64511))); Shouldn't this fix be in Net::DNS::Resolver? http://search.cpan.org/src

Re: DNSBL and answer id check missing

2008-09-28 Thread Ask Bjørn Hansen
On Sep 28, 2008, at 12:01 AM, Diego d'Ambra wrote: my $res = new Net::DNS::Resolver; $res->tcp_timeout(30); $res->udp_timeout(30); $res->srcport(1024+int(rand(64511))); Shouldn't this fix be in Net::DNS::Resolver? - ask -- http://develooper.com/ - http://askask.com/

PATCH: Re: DNSBL and answer id check missing

2008-09-28 Thread Diego d'Ambra
Diego d'Ambra wrote: To me it seems that plugin DNSBL is using Net::DNS bgsend/bgread, but is not checking the id of the reply received. [...] Attached suggested patch. Large part of it inspired by how Spamassassin does it. Changelog: * Added source port randomisation to DNS queries * Ad

Re: DNSBL and answer id check missing

2008-09-28 Thread Diego d'Ambra
Diego d'Ambra wrote: [...] I made a little change to DNSBL to ensure it randomize scr port and I see a major difference. Maybe latest version of Net::DNS does this (after Dan's widely report exploit). My box is an older Sarge solution, so others may not see same issue. But even with ran

Re: DNSBL and answer id check missing

2008-09-28 Thread Diego d'Ambra
Matt Sergeant wrote: On Sat, 27 Sep 2008 13:56:58 +0200, Diego d'Ambra wrote: To me it seems that plugin DNSBL is using Net::DNS bgsend/bgread, but is not checking the id of the reply received. If true this means that an attacker can white- or blacklist any email Thinking more about this - si

Re: DNSBL and answer id check missing

2008-09-27 Thread Matt Sergeant
On Sat, 27 Sep 2008 20:09:37 -0400, Chris Lewis wrote: > I've extended the async dnsbl plugin to do scoring. It occured to me a > few days ago that DNSBLs with negative scores (DNSWLs) should be treated > as a hit if they get a timeout or other failure. This has prompted me > to comment about che

Re: DNSBL and answer id check missing

2008-09-27 Thread Chris Lewis
Matt Sergeant wrote: > On Sat, 27 Sep 2008 13:56:58 +0200, Diego d'Ambra wrote: >> To me it seems that plugin DNSBL is using Net::DNS bgsend/bgread, but >> is not checking the id of the reply received. >> >> If true this means that an attacker can white- or blacklist any email > > Thinking more

Re: DNSBL and answer id check missing

2008-09-27 Thread Matt Sergeant
On Sat, 27 Sep 2008 13:56:58 +0200, Diego d'Ambra wrote: > To me it seems that plugin DNSBL is using Net::DNS bgsend/bgread, but > is not checking the id of the reply received. > > If true this means that an attacker can white- or blacklist any email Thinking more about this - since we don't do

Re: DNSBL and answer id check missing

2008-09-27 Thread Diego d'Ambra
Hanno Hecker wrote: Hi Diego, On Sat, 27 Sep 2008 10:11:15 -0400 Matt Sergeant <[EMAIL PROTECTED]> wrote: On Sat, 27 Sep 2008 13:56:58 +0200, Diego d'Ambra wrote: To me it seems that plugin DNSBL is using Net::DNS bgsend/bgread, but is not checking the id of the reply received. [...] I'm wor

Re: DNSBL and answer id check missing

2008-09-27 Thread Hanno Hecker
Hi Diego, On Sat, 27 Sep 2008 10:11:15 -0400 Matt Sergeant <[EMAIL PROTECTED]> wrote: > On Sat, 27 Sep 2008 13:56:58 +0200, Diego d'Ambra wrote: > > To me it seems that plugin DNSBL is using Net::DNS bgsend/bgread, but > > is not checking the id of the reply received. [...] > > I'm working on a

Re: DNSBL and answer id check missing

2008-09-27 Thread Matt Sergeant
On Sat, 27 Sep 2008 13:56:58 +0200, Diego d'Ambra wrote: > To me it seems that plugin DNSBL is using Net::DNS bgsend/bgread, but > is not checking the id of the reply received. > > If true this means that an attacker can white- or blacklist any email > by sending fake dns replies (only randomisa