Re: [PATCH 3/7] basicheaders, add reject option, loglevel

2012-05-21 Thread Matt Simerson
On May 21, 2012, at 3:26 PM, Jared Johnson wrote: >> There's several plugins that have something like what you've suggested: >> >> plugin action [ add-header | deny | denysoft ] >> >> And here's a sampling of the arguments that various plugins use with >> action: >> >> add-header, lo

Re: [PATCH 3/7] basicheaders, add reject option, loglevel

2012-05-21 Thread Jared Johnson
> There's several plugins that have something like what you've suggested: > > plugin action [ add-header | deny | denysoft ] > > And here's a sampling of the arguments that various plugins use with > action: > > add-header, log, continue, reject, deny, denysoft, accept, delete, add > >

Re: [PATCH 3/7] basicheaders, add reject option, loglevel

2012-05-18 Thread Matt Simerson
On May 18, 2012, at 11:23 AM, Jared Johnson wrote: > a little OT: 'reject N' seems a little clunky; why not something more > like 'action [reject | add-header | ...]'? > > -Jared Having a single action argument is less versatile and less obvious than having explicit reject and add-header opti

Re: [PATCH 3/7] basicheaders, add reject option, loglevel

2012-05-18 Thread Jared Johnson
a little OT: 'reject N' seems a little clunky; why not something more like 'action [reject | add-header | ...]'? -Jared

Re: [PATCH 3/7] basicheaders, add reject option, loglevel

2012-05-18 Thread Charlie Brady
On Fri, 18 May 2012, Matt Simerson wrote: > On May 18, 2012, at 9:33 AM, Charlie Brady wrote: > > > I think the documentation of the reject option could be clearer. What > > value of the parameter should be used when first using this plugin? I > > think "reject 0". > > Boolean means 0 or 1, b

Re: [PATCH 3/7] basicheaders, add reject option, loglevel

2012-05-18 Thread Matt Simerson
On May 18, 2012, at 9:33 AM, Charlie Brady wrote: > I think the documentation of the reject option could be clearer. What > value of the parameter should be used when first using this plugin? I > think "reject 0". Boolean means 0 or 1, but your point is well made. The documentation should be

Re: [PATCH 3/7] basicheaders, add reject option, loglevel

2012-05-18 Thread Charlie Brady
I think the documentation of the reject option could be clearer. What value of the parameter should be used when first using this plugin? I think "reject 0". On Fri, 18 May 2012, Matt Simerson wrote: > added reject option > document the existence of the loglevel option > --- > plugins/check_b

[PATCH 3/7] basicheaders, add reject option, loglevel

2012-05-18 Thread Matt Simerson
added reject option document the existence of the loglevel option --- plugins/check_basicheaders | 13 + 1 file changed, 13 insertions(+) diff --git a/plugins/check_basicheaders b/plugins/check_basicheaders index 114867a..ef0e42d 100644 --- a/plugins/check_basicheaders +++ b/plugins