Re: [PATCH] don't print GeoIP country if not defined

2012-04-28 Thread Matt Simerson
On Apr 28, 2012, at 10:48 AM, Robert Spier wrote: > On Mon, Apr 23, 2012 at 8:39 AM, Matt Simerson wrote: > >> >> On Apr 22, 2012, at 11:45 PM, Robert Spier wrote: >> >>> This change contains a bunch of unnecessary whitespace changes. This >> can make it hard to trace back to original chang

Re: [PATCH] don't print GeoIP country if not defined

2012-04-28 Thread Robert Spier
On Mon, Apr 23, 2012 at 8:39 AM, Matt Simerson wrote: > > On Apr 22, 2012, at 11:45 PM, Robert Spier wrote: > > > This change contains a bunch of unnecessary whitespace changes. This > can make it hard to trace back to original changes. I'm not saying there's > not a need for a whitespace clea

Re: [PATCH] don't print GeoIP country if not defined

2012-04-23 Thread Matt Simerson
On Apr 22, 2012, at 11:45 PM, Robert Spier wrote: > This change contains a bunch of unnecessary whitespace changes. This can > make it hard to trace back to original changes. I'm not saying there's not a > need for a whitespace cleanup, but I wonder if it would be better to do it > all at o

Re: [PATCH] don't print GeoIP country if not defined

2012-04-22 Thread Robert Spier
This change contains a bunch of unnecessary whitespace changes. This can make it hard to trace back to original changes. I'm not saying there's not a need for a whitespace cleanup, but I wonder if it would be better to do it all at once? On Sun, Apr 22, 2012 at 2:25 PM, Matt Simerson wrote: >

[PATCH] don't print GeoIP country if not defined

2012-04-22 Thread Matt Simerson
don't print GeoIP country if not defined (suppress warning) If we don't get a result from the lookup, all we know is that we didn't get a result. Maybe an error, maybe the IP not in the database. --- plugins/ident/geoip | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff