Re: [PATCH] add TCPLOCAL* variables to $qp->connection

2010-05-11 Thread Robert Spier
Matt Simerson wrote: > > > On May 11, 2010, at 9:19 PM, Robert Spier wrote: > > > FWIW, I'm still a little concerned about potentially breaking the p0f > > plugin for people using the other qpsmtpd engines, but I'm happier to > > have someone properly maintaining it, and we'll deal with fallou

Re: [PATCH] add TCPLOCAL* variables to $qp->connection

2010-05-11 Thread Matt Simerson
On May 11, 2010, at 9:19 PM, Robert Spier wrote: > FWIW, I'm still a little concerned about potentially breaking the p0f > plugin for people using the other qpsmtpd engines, but I'm happier to > have someone properly maintaining it, and we'll deal with fallout > later, if any. (Because it'll be

Re: [PATCH] add TCPLOCAL* variables to $qp->connection

2010-05-11 Thread Robert Spier
FWIW, I'm still a little concerned about potentially breaking the p0f plugin for people using the other qpsmtpd engines, but I'm happier to have someone properly maintaining it, and we'll deal with fallout later, if any. (Because it'll be pretty obvious when it breaks.) -R Robert Spier wrote: >

Re: [PATCH] add TCPLOCAL* variables to $qp->connection

2010-05-11 Thread Robert Spier
Applied as 671a6953b0c9503717bda10dd07f434cbd302c9c Matt Simerson wrote: > > (patch remade against latest rspier/qpsmtpd) > > added remote_port, local_ip, local_port, and local_host to $qp->connection, > as the p0f plugin relies on it. > added notes to TcpServer.pm and the p0f plugin noting th

[PATCH] add TCPLOCAL* variables to $qp->connection

2010-05-10 Thread Matt Simerson
(patch remade against latest rspier/qpsmtpd) added remote_port, local_ip, local_port, and local_host to $qp->connection, as the p0f plugin relies on it. added notes to TcpServer.pm and the p0f plugin noting the dependence, and the lack of support for models other than tcpserver. --- lib/Qpsmtpd

Re: [PATCH] add TCPLOCAL* variables to $qp->connection

2010-05-10 Thread Matt Simerson
On May 10, 2010, at 9:17 PM, Robert Spier wrote: > What about the non-TcpServer based engines? i.e. Apache, async, etc. As I'm unfamiliar with them, the best I could do is add some comments in there stating that someone who knows how those other engines work should add the code, and if they d

Re: [PATCH] add TCPLOCAL* variables to $qp->connection

2010-05-10 Thread Robert Spier
What about the non-TcpServer based engines? i.e. Apache, async, etc. (Ok, async probably isn't an issue since p0f wouldn't work well with it anyway.) I can probably be convinced to apply this anyway, but I'm trying to keep compatibility where we can. -R Matt Simerson wrote: > > added remote

[PATCH] add TCPLOCAL* variables to $qp->connection

2010-05-10 Thread Matt Simerson
added remote_port, local_ip, local_port, and local_host to $qp->connection, as the p0f plugin relies on it. --- lib/Qpsmtpd/TcpServer.pm | 13 - 1 files changed, 12 insertions(+), 1 deletions(-) diff --git a/lib/Qpsmtpd/TcpServer.pm b/lib/Qpsmtpd/TcpServer.pm index e2f380f..964b9db