Re: [PATCH] Log even when we aren't in a transaction

2009-08-26 Thread Ask Bjørn Hansen
On Aug 25, 2009, at 7:46, Matt Sergeant wrote: I never understood why it did that. Any reason it can't return either undef or (preferably) a new Transaction object? I don't really understand it either, and I fear that which I don't understand, so I worry about taking it out and breaking som

Re: [PATCH] Log even when we aren't in a transaction

2009-08-24 Thread Matt Sergeant
On Mon, 24 Aug 2009 09:55:52 -0500, Jared Johnson wrote: > On 08/23/2009 04:03 PM, Matt Sergeant wrote: >> On Thu, 20 Aug 2009 10:18:39 -0500, Jared Johnson wrote: >>> It looks like logging/file doesn't like the empty hashref returned by >>> Qpsmtpd::transaction(). >> >> I never understood why it

Re: [PATCH] Log even when we aren't in a transaction

2009-08-24 Thread Jared Johnson
On 08/23/2009 04:03 PM, Matt Sergeant wrote: On Thu, 20 Aug 2009 10:18:39 -0500, Jared Johnson wrote: It looks like logging/file doesn't like the empty hashref returned by Qpsmtpd::transaction(). I never understood why it did that. Any reason it can't return either undef or (preferably) a new

Re: [PATCH] Log even when we aren't in a transaction

2009-08-23 Thread Matt Sergeant
On Thu, 20 Aug 2009 10:18:39 -0500, Jared Johnson wrote: > It looks like logging/file doesn't like the empty hashref returned by > Qpsmtpd::transaction(). I never understood why it did that. Any reason it can't return either undef or (preferably) a new Transaction object?

Re: [PATCH] Log even when we aren't in a transaction

2009-08-20 Thread Jared Johnson
On 08/14/2009 04:31 PM, Ask Bjørn Hansen wrote: On Aug 14, 2009, at 14:14, Jared Johnson wrote: This should allow the logging/file plugin to log even if it isn't called from within a transaction Thanks, applied and pushed. The conditional around where you made the first change are a bit of

Re: [PATCH] Log even when we aren't in a transaction

2009-08-20 Thread Jared Johnson
This should allow the logging/file plugin to log even if it isn't called from within a transaction Thanks, applied and pushed. The conditional around where you made the first change are a bit of a mess (indicating that there's a better way to do whatever it does), but I didn't look closer ...

Re: [PATCH] Log even when we aren't in a transaction

2009-08-14 Thread Ask Bjørn Hansen
On Aug 14, 2009, at 14:14, Jared Johnson wrote: This should allow the logging/file plugin to log even if it isn't called from within a transaction Thanks, applied and pushed. The conditional around where you made the first change are a bit of a mess (indicating that there's a better way

[PATCH] Log even when we aren't in a transaction

2009-08-14 Thread Jared Johnson
From: Jared Johnson This should allow the logging/file plugin to log even if it isn't called from within a transaction --- plugins/logging/file |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/plugins/logging/file b/plugins/logging/file index 31292ad..5717fe5 100644 --