Re: Prevent plugins from running forever (Re: A basket of changes)

That was 4 years ago, and the posted patch never got committed. It makes me think the problem was a local and ultimately fixed via other means. Are you aware of anyone having this problem today? Matt On May 18, 2012, at 9:45 AM, Charlie Brady wrote: > > Maybe I've missed it in the flurry of

[PATCH] basicheaders: Charlie's corrections

spell deferr correctly add name of deprecated config name to error message --- plugins/check_basicheaders |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/check_basicheaders b/plugins/check_basicheaders index 6ca2056..70f765f 100644 --- a/plugins/check_basicheader

Re: [PATCH] basicheaders: improved POD and expanded tests

On Fri, 18 May 2012, Charlie Brady wrote: > and ... > > > +# provide backwards comptibility with the old 'days' argument > > +if ( $self->{_args}{days} ) { > > +$self->log(LOGWARN, "deprecated arguments. Update your config."); > >$self->log(LOGWARN, "deprecated argument

Re: [PATCH] basicheaders: improved POD and expanded tests

On Fri, 18 May 2012, Matt Simerson wrote: > factored date validity tests into their own sub > added tests improved POD Excellent. But: s/deffered/deferred/ and ... > +# provide backwards comptibility with the old 'days' argument > +if ( $self->{_args}{days} ) { > +$self->log(LO

[PATCH] basicheaders: improved POD and expanded tests

factored date validity tests into their own sub added tests --- plugins/check_basicheaders| 90 ++--- t/plugin_tests/check_basicheaders | 64 ++ 2 files changed, 118 insertions(+), 36 deletions(-) diff --git a/plugins/check_basic

Re: [PATCH 3/7] basicheaders, add reject option, loglevel

On May 18, 2012, at 11:23 AM, Jared Johnson wrote: > a little OT: 'reject N' seems a little clunky; why not something more > like 'action [reject | add-header | ...]'? > > -Jared Having a single action argument is less versatile and less obvious than having explicit reject and add-header opti

Re: [PATCH 3/7] basicheaders, add reject option, loglevel

a little OT: 'reject N' seems a little clunky; why not something more like 'action [reject | add-header | ...]'? -Jared

Re: [PATCH 3/7] basicheaders, add reject option, loglevel

On Fri, 18 May 2012, Matt Simerson wrote: > On May 18, 2012, at 9:33 AM, Charlie Brady wrote: > > > I think the documentation of the reject option could be clearer. What > > value of the parameter should be used when first using this plugin? I > > think "reject 0". > > Boolean means 0 or 1, b

Re: [PATCH 3/7] basicheaders, add reject option, loglevel

On May 18, 2012, at 9:33 AM, Charlie Brady wrote: > I think the documentation of the reject option could be clearer. What > value of the parameter should be used when first using this plugin? I > think "reject 0". Boolean means 0 or 1, but your point is well made. The documentation should be

Prevent plugins from running forever (Re: A basket of changes)

Maybe I've missed it in the flurry of patches, but I still see no sign of timeouts being enforced across plugins. http://grokbase.com/p/perl/qpsmtpd/097nr0gyr2/never-times-out http://www.nntp.perl.org/group/perl.qpsmtpd/2008/02/msg7779.html Hanno once developed some code to address the issue,

Re: [PATCH 3/7] basicheaders, add reject option, loglevel

I think the documentation of the reject option could be clearer. What value of the parameter should be used when first using this plugin? I think "reject 0". On Fri, 18 May 2012, Matt Simerson wrote: > added reject option > document the existence of the loglevel option > --- > plugins/check_b

[PATCH 1/7] delete 3 relay plugins

--- plugins/check_norelay | 58 -- plugins/check_relay | 83 - plugins/relay_only| 36 - 3 files changed, 177 deletions(-) delete mode 100644 plugins/check_norelay delete mode 100644 p

[PATCH 2/7] new relay plugin, with tests!

replaces functionality of previous 3 relay plugins --- config.sample/norelayclients |5 + config.sample/plugins|8 +- plugins/relay| 237 ++ t/plugin_tests/relay | 81 +++ 4 files changed, 327 insertions

[PATCH 5/7] anglebrackets: emit log entry when change made

--- plugins/dont_require_anglebrackets |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/plugins/dont_require_anglebrackets b/plugins/dont_require_anglebrackets index 7bb1eea..30a 100644 --- a/plugins/dont_require_anglebrackets +++ b/plugins/dont_require_anglebracke

[PATCH 3/7] basicheaders, add reject option, loglevel

added reject option document the existence of the loglevel option --- plugins/check_basicheaders | 13 + 1 file changed, 13 insertions(+) diff --git a/plugins/check_basicheaders b/plugins/check_basicheaders index 114867a..ef0e42d 100644 --- a/plugins/check_basicheaders +++ b/plugins

[PATCH 7/7] dnsbl test: set relayclient

another test might set it, which changes the test outcome --- t/plugin_tests/dnsbl |1 + 1 file changed, 1 insertion(+) diff --git a/t/plugin_tests/dnsbl b/t/plugin_tests/dnsbl index 0440a80..0995be7 100644 --- a/t/plugin_tests/dnsbl +++ b/t/plugin_tests/dnsbl @@ -51,6 +51,7 @@ sub test_hook_

[PATCH 4/7] dnsbl: fixed path to docs/logging.pod

--- plugins/dnsbl |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/dnsbl b/plugins/dnsbl index 7c2ff71..9832a9c 100644 --- a/plugins/dnsbl +++ b/plugins/dnsbl @@ -250,7 +250,7 @@ the same answer for a short period of time (the minimum DNS cache period). =head2 log

[PATCH 6/7] relay: added POD for loglevel option

--- plugins/relay |4 1 file changed, 4 insertions(+) diff --git a/plugins/relay b/plugins/relay index d8a643b..47d4986 100644 --- a/plugins/relay +++ b/plugins/relay @@ -81,6 +81,10 @@ I as shown: relay only 1 +=head2 loglevel + +Adjust the quantity of logging for this plugin. Se