Re: [PATCH] Log even when we aren't in a transaction

2009-08-14 Thread Ask Bjørn Hansen
On Aug 14, 2009, at 14:14, Jared Johnson wrote: This should allow the logging/file plugin to log even if it isn't called from within a transaction Thanks, applied and pushed. The conditional around where you made the first change are a bit of a mess (indicating that there's a better way

[PATCH] Log even when we aren't in a transaction

2009-08-14 Thread Jared Johnson
From: Jared Johnson This should allow the logging/file plugin to log even if it isn't called from within a transaction --- plugins/logging/file |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/plugins/logging/file b/plugins/logging/file index 31292ad..5717fe5 100644 --

patch for minor logging plugin crash

2009-08-14 Thread Jared Johnson
We noticed that logging/file sometimes emitted this error: XX: Can't call method "notes" on unblessed reference at /usr/share/qpsmtpd/plugins/logging/file line 272. It appears this is because QP internal sometimes legitimately calls ->log before a transaction object exists. The patch I'm sending