[Qemu-devel] [PATCH] MAINTAINERS: update my email address

2017-04-21 Thread Xie Changlong
From: Zhang Chen I'm leaving my job at Fujitsu, this email address will stop working this week. Update it to one that I will have access to later. Signed-off-by: Xie Changlong --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS

[Qemu-devel] [PATCH] memory: make ram device read/write endian sensitive

2017-02-20 Thread Yongji Xie
ommit 6758008e2c4e79fb6bd04fe8e7a41665fa583965. Signed-off-by: Yongji Xie --- memory.c | 14 +++--- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/memory.c b/memory.c index 6c58373..1ccb99f 100644 --- a/memory.c +++ b/memory.c @@ -1139,13 +1139,13 @@ static uin

[Qemu-devel] [PATCH V1] replication: clarify permissions

2017-03-14 Thread Changlong Xie
x27;colo-disk', 'writable': true } } {"error": {"class": "GenericError", "desc": "Conflicts with use by hidden-qcow2-driver as 'backing', which does not allow 'write' on sec-qcow2-driver-for-nbd"}} CC: Zhang Hail

[Qemu-devel] [PATCH v2] vfio: Add support for mmapping sub-page MMIO BARs

2016-08-11 Thread Yongji Xie
age BAR is changed and not page aligned any more in guest. And we also set the priority of these BARs' memory regions to zero in case of overlap with BARs which share the same page with sub-page BARs in guest. Signed-off-by: Yongji Xie --- hw/vfio/common.c |3 +-- hw/vfio/

Re: [Qemu-devel] [PATCH v24 11/12] support replication driver in blockdev-add

2016-08-14 Thread Changlong Xie
On 08/09/2016 05:08 PM, Kevin Wolf wrote: Am 27.07.2016 um 09:01 hat Changlong Xie geschrieben: From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: Changlong Xie Signed-off-by: Wang WeiWei Signed-off-by: zhanghailiang Signed-off-by: Gonglei Reviewed-by: Eric Blake

Re: [Qemu-devel] [PATCH v24 11/12] support replication driver in blockdev-add

2016-08-15 Thread Changlong Xie
On 08/15/2016 04:37 PM, Kevin Wolf wrote: Am 15.08.2016 um 03:49 hat Changlong Xie geschrieben: On 08/09/2016 05:08 PM, Kevin Wolf wrote: Am 27.07.2016 um 09:01 hat Changlong Xie geschrieben: From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: Changlong Xie Signed-off-by: Wang

Re: [Qemu-devel] [PATCH COLO-Frame v18 00/34] COarse-grain LOck-stepping(COLO) Virtual Machines for Non-stop Service (FT)

2016-08-15 Thread Changlong Xie
d it again :) Thanks -Xie

Re: [Qemu-devel] [PATCH COLO-Frame v18 00/34] COarse-grain LOck-stepping(COLO) Virtual Machines for Non-stop Service (FT)

2016-08-16 Thread Changlong Xie
. BTW, you should send email to QEMU community directly, but not personal email next time. Thanks -Xie Regards, Zhi Yong Wu On Wed, Aug 3, 2016 at 8:25 PM, zhanghailiang wrote: This is the 18th version of COLO FT feature. It is based on '[PATCH v24 00/12] Block replicatio

Re: [Qemu-devel] About the trace framework

2017-07-11 Thread Xie Changlong
在 7/11/2017 9:33 AM, Wang Dong 写道: On 07/10/2017 01:24 PM, Xie Changlong wrote: 在 7/9/2017 5:57 PM, Wang Dong 写道: Hi, I am new to QEMU. But I got some problem so that I want to figure it out. So I try to debug qemu to see what happened. And I found trace framework. I think this will

Re: [Qemu-devel] About the trace framework

2017-07-09 Thread Xie Changlong
advance. * Did you set *trace-event*? I've encountered this issue in the past :) (qemu) help trace-event trace-event name on|off -- changes status of a specific trace event (qemu) info trace-events -- Thanks -Xie

Re: [Qemu-devel] [PATCH 5/6] block: Fix write/resize permissions for inactive images

2017-08-18 Thread Xie Changlong
become readonly. I've tried on my side, but it seems not easy to fix it. I wonder if there is any way to bypass this? Any suggestion would be appreciated. It's very easy to reproduce this scenario: (gdb) r Starting program: /root/.xie/qemu-colo/x86_64-softmmu/qemu-system-x86_64

Re: [Qemu-devel] block replication

2017-08-10 Thread Xie Changlong
ning_sectors, qiov); backup_cow_request_end(&req); goto out; } ret = bdrv_co_readv(bs->file, sector_num, remaining_sectors, qiov); out: return replication_return_value(s, ret); } -- Thanks -Xie

Re: [Qemu-devel] [PATCH] file-posix: Clear out first sector in hdev_create

2017-08-11 Thread Xie Changlong
在 8/10/2017 4:01 PM, Fam Zheng 写道: People get surprised when, after "qemu-imc create -f raw /dev/sdX", they s/qemu-imc/qemu-img/ still see qcow2 with "qemu-img info", if previously the bdev had a qcow2 -- Thanks -Xie

[Qemu-devel] [PATCH] libvhost-user: Fix resource leak

2018-01-18 Thread Yongji Xie
Free the mmaped memory when we need to mmap new memory space on vu_set_mem_table_exec() and vu_set_log_base_exec() to avoid memory leak. Also close the corresponding fd after mmap() on vu_set_log_base_exec() to avoid fd leak. Signed-off-by: Yongji Xie --- contrib/libvhost-user/libvhost-user.c

[Qemu-devel] [PATCH] libvhost-user: Support across-memory-boundary access

2018-01-18 Thread Yongji Xie
er in vu_gpa_to_va() so we can handle this case, returning the actual mapped length. Signed-off-by: Yongji Xie --- contrib/libvhost-user/libvhost-user.c | 133 + contrib/libvhost-user/libvhost-user.h |3 +- 2 files changed, 122 insertions(+), 14 deletions(-) diff --

Re: [Qemu-devel] [PATCH for-4.0 2/6] vhost-user: Add shared memory to record inflight I/O

2018-12-05 Thread Yongji Xie
On Thu, 6 Dec 2018 at 15:19, Marc-André Lureau wrote: > > Hi > On Thu, Dec 6, 2018 at 10:40 AM wrote: > > > > From: Xie Yongji > > > > This introduces a new message VHOST_USER_SET_VRING_INFLIGHT > > to support offering shared memory to backend to record

Re: [Qemu-devel] [PATCH for-4.0 0/6] vhost-user-blk: Add support for backend reconnecting

2018-12-05 Thread Yongji Xie
On Thu, 6 Dec 2018 at 15:23, Marc-André Lureau wrote: > > Hi > > On Thu, Dec 6, 2018 at 10:36 AM wrote: > > > > From: Xie Yongji > > > > This patchset is aimed at supporting qemu to reconnect > > vhost-user-blk backend after vhost-user-blk backend crash

Re: [Qemu-devel] [PATCH for-4.0 1/6] char-socket: Enable "wait" option for client mode

2018-12-05 Thread Yongji Xie
On Thu, 6 Dec 2018 at 15:23, Marc-André Lureau wrote: > > Hi > > On Thu, Dec 6, 2018 at 10:38 AM wrote: > > > > From: Xie Yongji > > > > Now we attempt to connect asynchronously for "reconnect socket" > > during open(). But vhost-user device

Re: [Qemu-devel] [PATCH for-4.0 0/6] vhost-user-blk: Add support for backend reconnecting

2018-12-06 Thread Yongji Xie
On Thu, 6 Dec 2018 at 17:21, Yury Kotov wrote: > > Hi, it's very interesting patchset. > > I also research reconnecting issue for vhost-user-blk and SPDK. > Did you support a case when vhost backend is not started but QEMU does? > Now we do not support this case. Because qemu have to get config f

Re: [Qemu-devel] [PATCH for-4.0 0/6] vhost-user-blk: Add support for backend reconnecting

2018-12-06 Thread Yongji Xie
On Thu, 6 Dec 2018 at 17:52, Yury Kotov wrote: > > Yes, I also think that realize shout be sync. > > But may be it's better to add an 'disconnected' option to init the chardev > in disconnected state, then do the first connection with > qemu_chr_fe_wait_connected from vhost_user_blk_realize. So wh

Re: [Qemu-devel] [PATCH for-4.0 5/6] vhost-user-blk: Add support for reconnecting backend

2018-12-06 Thread Yongji Xie
On Thu, 6 Dec 2018 at 20:21, Yury Kotov wrote: > > 06.12.2018, 09:38, "elohi...@gmail.com" : > > From: Xie Yongji > > > > Since the new message VHOST_USER_SET_VRING_INFLIGHT, > > the backend is able to restart safely. This patch > > allow qemu to rec

Re: [Qemu-devel] [PATCH for-4.0 0/6] vhost-user-blk: Add support for backend reconnecting

2018-12-07 Thread Yongji Xie
On Thu, 6 Dec 2018 at 21:57, Jason Wang wrote: > > > On 2018/12/6 下午2:35, elohi...@gmail.com wrote: > > From: Xie Yongji > > > > This patchset is aimed at supporting qemu to reconnect > > vhost-user-blk backend after vhost-user-blk backend crash or > >

Re: [Qemu-devel] [PATCH for-4.0 0/6] vhost-user-blk: Add support for backend reconnecting

2018-12-11 Thread Yongji Xie
On Mon, 10 Dec 2018 at 17:32, Jason Wang wrote: > > > On 2018/12/6 下午9:59, Michael S. Tsirkin wrote: > > On Thu, Dec 06, 2018 at 09:57:22PM +0800, Jason Wang wrote: > >> On 2018/12/6 下午2:35,elohi...@gmail.com wrote: > >>> From: Xie Yongji > >>> &g

Re: [Qemu-devel] [PATCH for-4.0 0/6] vhost-user-blk: Add support for backend reconnecting

2018-12-11 Thread Yongji Xie
On Wed, 12 Dec 2018 at 11:00, Jason Wang wrote: > > > On 2018/12/12 上午10:48, Yongji Xie wrote: > > On Mon, 10 Dec 2018 at 17:32, Jason Wang wrote: > >> > >> On 2018/12/6 下午9:59, Michael S. Tsirkin wrote: > >>> On Thu, Dec 06, 2018 at 09:57:22PM +0800,

Re: [Qemu-devel] [PATCH for-4.0 0/6] vhost-user-blk: Add support for backend reconnecting

2018-12-11 Thread Yongji Xie
On Wed, 12 Dec 2018 at 12:07, Jason Wang wrote: > > > On 2018/12/12 上午11:21, Yongji Xie wrote: > > On Wed, 12 Dec 2018 at 11:00, Jason Wang wrote: > >> > >> On 2018/12/12 上午10:48, Yongji Xie wrote: > >>> On Mon, 10 Dec 2018 at 17:32, Jason Wang

Re: [Qemu-devel] [PATCH for-4.0 0/6] vhost-user-blk: Add support for backend reconnecting

2018-12-12 Thread Yongji Xie
On Wed, 12 Dec 2018 at 15:47, Jason Wang wrote: > > > On 2018/12/12 下午2:41, Yongji Xie wrote: > > On Wed, 12 Dec 2018 at 12:07, Jason Wang wrote: > >> > >> On 2018/12/12 上午11:21, Yongji Xie wrote: > >>> On Wed, 12 Dec 2018 at 11:00, Jason Wang wr

Re: [Qemu-devel] [PATCH for-4.0 0/6] vhost-user-blk: Add support for backend reconnecting

2018-12-12 Thread Yongji Xie
On Thu, 13 Dec 2018 at 10:58, Jason Wang wrote: > > > On 2018/12/12 下午5:18, Yongji Xie wrote: > >>>> Ok, then we can simply forbid increasing the avail_idx in this case? > >>>> > >>>> Basically, it's a question of whether or not it&#

Re: [Qemu-devel] [PATCH v2] vhost-user-blk: start vhost when guest kicks

2018-09-18 Thread Yongji Xie
Kindly ping... On Thu, 7 Jun 2018 at 20:50, Stefan Hajnoczi wrote: > > On Wed, Jun 06, 2018 at 09:24:48PM +0800, Yongji Xie wrote: > > Some old guests (before commit 7a11370e5: "virtio_blk: enable VQs early") > > kick virtqueue before setting VIRTIO_CONFIG_S_DRIV

Re: [Qemu-devel] [PATCH for-4.0 0/6] vhost-user-blk: Add support for backend reconnecting

2018-12-13 Thread Yongji Xie
On Thu, 13 Dec 2018 at 22:45, Michael S. Tsirkin wrote: > > On Thu, Dec 06, 2018 at 02:35:46PM +0800, elohi...@gmail.com wrote: > > From: Xie Yongji > > > > This patchset is aimed at supporting qemu to reconnect > > vhost-user-blk backend after vhost-user-bl

Re: [Qemu-devel] [PATCH for-4.0 0/6] vhost-user-blk: Add support for backend reconnecting

2018-12-13 Thread Yongji Xie
On Fri, 14 Dec 2018 at 10:20, Michael S. Tsirkin wrote: > > On Fri, Dec 14, 2018 at 09:56:41AM +0800, Yongji Xie wrote: > > On Thu, 13 Dec 2018 at 22:45, Michael S. Tsirkin wrote: > > > > > > On Thu, Dec 06, 2018 at 02:35:46PM +0800, elohi...@gmail.com w

Re: [Qemu-devel] [PATCH for-4.0 0/6] vhost-user-blk: Add support for backend reconnecting

2018-12-15 Thread Yongji Xie
On Sat, 15 Dec 2018 at 05:23, Michael S. Tsirkin wrote: > > On Fri, Dec 14, 2018 at 10:33:54AM +0800, Yongji Xie wrote: > > On Fri, 14 Dec 2018 at 10:20, Michael S. Tsirkin wrote: > > > > > > On Fri, Dec 14, 2018 at 09:56:41AM +0800, Yongji Xie wrote: > &

Re: [Qemu-devel] [PATCH v2 for-4.0 6/7] vhost-user-blk: Add support to reconnect backend

2018-12-18 Thread Yongji Xie
On Tue, 18 Dec 2018 at 20:30, Yury Kotov wrote: > > + wrfsh@ > > Hi, > > 18.12.2018, 13:01, "elohi...@gmail.com" : > > From: Xie Yongji > > > > Since we now support the message VHOST_USER_GET_SHM_SIZE > > and VHOST_USER_SET_SHM_FD. The backend

Re: [Qemu-devel] [PATCH v2 for-4.0 1/7] chardev: Add disconnected option for chardev socket

2018-12-18 Thread Yongji Xie
On Tue, 18 Dec 2018 at 20:24, Marc-André Lureau wrote: > > Hi > > On Tue, Dec 18, 2018 at 2:01 PM wrote: > > > > From: Xie Yongji > > > > New option "disconnected" is added to init the chardev socket > > in disconnected state. Then we can

Re: [Qemu-devel] [PATCH v2 for-4.0 2/7] vhost-user: Support providing shared memory to backend

2018-12-18 Thread Yongji Xie
On Tue, 18 Dec 2018 at 22:25, Michael S. Tsirkin wrote: > > On Tue, Dec 18, 2018 at 05:59:57PM +0800, elohi...@gmail.com wrote: > > From: Xie Yongji > > > > This patch introduces two new messages VHOST_USER_GET_SHM_SIZE > > and VHOST_USER_SET_SHM_FD to support

Re: [Qemu-devel] [PATCH v2 for-4.0 6/7] vhost-user-blk: Add support to reconnect backend

2018-12-18 Thread Yongji Xie
On Tue, 18 Dec 2018 at 22:35, Yury Kotov wrote: > > 18.12.2018, 17:16, "Yongji Xie" : > > On Tue, 18 Dec 2018 at 20:30, Yury Kotov wrote: > >> + wrfsh@ > >> > >> Hi, > >> > >> 18.12.2018, 13:01, "elohi...@gmail.com"

Re: [Qemu-devel] [PATCH v2 for-4.0 2/7] vhost-user: Support providing shared memory to backend

2018-12-18 Thread Yongji Xie
On Tue, 18 Dec 2018 at 22:57, Michael S. Tsirkin wrote: > > On Tue, Dec 18, 2018 at 10:47:32PM +0800, Yongji Xie wrote: > > On Tue, 18 Dec 2018 at 22:25, Michael S. Tsirkin wrote: > > > > > > On Tue, Dec 18, 2018 at 05:59:57PM +0800, elohi...@gmail.com w

Re: [Qemu-devel] [PATCH v2 for-4.0 6/7] vhost-user-blk: Add support to reconnect backend

2018-12-19 Thread Yongji Xie
On Tue, 18 Dec 2018 at 23:33, Yury Kotov wrote: > > > > 18.12.2018, 17:59, "Yongji Xie" : > > On Tue, 18 Dec 2018 at 22:35, Yury Kotov wrote: > >> 18.12.2018, 17:16, "Yongji Xie" : > >> > On Tue, 18 Dec 2018 at 20:30, Yury

Re: [Qemu-devel] [PATCH v2 for-4.0 1/7] chardev: Add disconnected option for chardev socket

2018-12-19 Thread Yongji Xie
eau wrote: > > > > Hi > > > > > > > > On Tue, Dec 18, 2018 at 2:01 PM wrote: > > > > > > > > > > From: Xie Yongji > > > > > > > > > > New option "disconnected" is added to init the chardev socket > >

Re: [Qemu-devel] [PATCH v2 for-4.0 1/7] chardev: Add disconnected option for chardev socket

2018-12-19 Thread Yongji Xie
gt; > > > On Tue, Dec 18, 2018 at 04:24:26PM +0400, Marc-André Lureau wrote: > > > > > Hi > > > > > > > > > > On Tue, Dec 18, 2018 at 2:01 PM wrote: > > > > > > > > > > > > From: Xie Yongji > > > >

Re: [Qemu-devel] [PATCH v4 for-4.0 1/7] char-socket: Enable "nowait" option on client sockets

2019-01-10 Thread Yongji Xie
On Fri, 11 Jan 2019 at 00:41, Daniel P. Berrangé wrote: > > On Thu, Jan 10, 2019 at 10:29:20PM +0800, Yongji Xie wrote: > > On Thu, 10 Jan 2019 at 22:11, Daniel P. Berrangé > > wrote: > > > > > > On Thu, Jan 10, 2019 at 10:08:54PM +0800, Yongji Xie wrote:

Re: [Qemu-devel] [PATCH v4 for-4.0 1/7] char-socket: Enable "nowait" option on client sockets

2019-01-11 Thread Yongji Xie
On Fri, 11 Jan 2019 at 16:32, Daniel P. Berrangé wrote: > > On Fri, Jan 11, 2019 at 03:50:40PM +0800, Yongji Xie wrote: > > On Fri, 11 Jan 2019 at 00:41, Daniel P. Berrangé > > wrote: > > > > > > On Thu, Jan 10, 2019 at 10:29:20PM +0800, Yongji Xie wrote:

Re: [Qemu-devel] [PATCH v4 for-4.0 0/7] vhost-user-blk: Add support for backend reconnecting

2019-01-11 Thread Yongji Xie
On Fri, 11 Jan 2019 at 23:53, Stefan Hajnoczi wrote: > > On Thu, Jan 10, 2019 at 06:59:27PM +0800, Yongji Xie wrote: > > On Thu, 10 Jan 2019 at 18:25, Stefan Hajnoczi wrote: > > > > > > On Wed, Jan 09, 2019 at 07:27:21PM +0800, elohi...@gmail.com w

Re: [Qemu-devel] [PATCH v4 for-4.0 0/7] vhost-user-blk: Add support for backend reconnecting

2019-01-14 Thread Yongji Xie
On Mon, 14 Jan 2019 at 18:22, Stefan Hajnoczi wrote: > > On Sat, Jan 12, 2019 at 12:50:12PM +0800, Yongji Xie wrote: > > On Fri, 11 Jan 2019 at 23:53, Stefan Hajnoczi wrote: > > > > > > On Thu, Jan 10, 2019 at 06:59:27PM +0800, Yongji Xie wrote: > > >

Re: [Qemu-devel] [PATCH v4 for-4.0 2/7] vhost-user: Support transferring inflight buffer between qemu and backend

2019-01-14 Thread Yongji Xie
On Tue, 15 Jan 2019 at 06:25, Michael S. Tsirkin wrote: > > On Wed, Jan 09, 2019 at 07:27:23PM +0800, elohi...@gmail.com wrote: > > @@ -382,6 +397,30 @@ If VHOST_USER_PROTOCOL_F_SLAVE_SEND_FD protocol > > feature is negotiated, > > slave can send file descriptors (at most 8 descriptors in each m

Re: [Qemu-devel] [PATCH v4 for-4.0 2/7] vhost-user: Support transferring inflight buffer between qemu and backend

2019-01-15 Thread Yongji Xie
On Tue, 15 Jan 2019 at 20:54, Michael S. Tsirkin wrote: > > On Tue, Jan 15, 2019 at 02:46:42PM +0800, Yongji Xie wrote: > > On Tue, 15 Jan 2019 at 06:25, Michael S. Tsirkin wrote: > > > > > > On Wed, Jan 09, 2019 at 07:27:23PM +0800, elohi...@gmail.com wrote: &

Re: [Qemu-devel] [PATCH v4 for-4.0 4/7] libvhost-user: Support tracking inflight I/O in shared memory

2019-01-15 Thread Yongji Xie
On Tue, 15 Jan 2019 at 15:52, Jason Wang wrote: > > > On 2019/1/11 下午2:10, Yongji Xie wrote: > > On Fri, 11 Jan 2019 at 11:56, Jason Wang wrote: > >> > >> On 2019/1/9 下午7:27, elohi...@gmail.com wrote: > >>> From: Xie Yongji > >>> > &g

Re: [Qemu-devel] [PATCH v4 for-4.0 1/7] char-socket: Enable "nowait" option on client sockets

2019-01-15 Thread Yongji Xie
On Tue, 15 Jan 2019 at 23:39, Daniel P. Berrangé wrote: > > On Fri, Jan 11, 2019 at 04:36:11PM +0800, Yongji Xie wrote: > > On Fri, 11 Jan 2019 at 16:32, Daniel P. Berrangé > > wrote: > > > > > > On Fri, Jan 11, 2019 at 03:50:40PM +0800, Yongji Xie wrote:

Re: [Qemu-devel] [PATCH v4 for-4.0 2/7] vhost-user: Support transferring inflight buffer between qemu and backend

2019-01-17 Thread Yongji Xie
On Tue, 15 Jan 2019 at 22:18, Yongji Xie wrote: > > On Tue, 15 Jan 2019 at 20:54, Michael S. Tsirkin wrote: > > > > On Tue, Jan 15, 2019 at 02:46:42PM +0800, Yongji Xie wrote: > > > On Tue, 15 Jan 2019 at 06:25, Michael S. Tsirkin wrote: > > > > > >

Re: [Qemu-devel] [PATCH v4 for-4.0 4/7] libvhost-user: Support tracking inflight I/O in shared memory

2019-01-17 Thread Yongji Xie
On Thu, 17 Jan 2019 at 17:57, Jason Wang wrote: > > > On 2019/1/15 下午10:51, Yongji Xie wrote: > >> Well, this may work but here're my points: > >> > >> 1) The code want to recover from backed crash by introducing extra space > >> to store infligh

Re: [Qemu-devel] [PATCH v4 for-4.0 4/7] libvhost-user: Support tracking inflight I/O in shared memory

2019-01-17 Thread Yongji Xie
On Fri, 18 Jan 2019 at 12:00, Jason Wang wrote: > > > On 2019/1/18 上午11:32, Yongji Xie wrote: > > On Thu, 17 Jan 2019 at 17:57, Jason Wang wrote: > >> > >> On 2019/1/15 下午10:51, Yongji Xie wrote: > >>>> Well, this may work but here're my p

Re: [Qemu-devel] [PATCH v4 for-4.0 4/7] libvhost-user: Support tracking inflight I/O in shared memory

2019-01-19 Thread Yongji Xie
On Fri, 18 Jan 2019 at 17:27, Jason Wang wrote: > > > On 2019/1/18 下午3:01, Yongji Xie wrote: > > On Fri, 18 Jan 2019 at 12:00, Jason Wang wrote: > >> > >> On 2019/1/18 上午11:32, Yongji Xie wrote: > >>> On Thu, 17 Jan 2019 at 17:57, Jason Wang wrote:

Re: [Qemu-devel] [PATCH v3 for-4.0 2/7] vhost-user: Support providing shared memory to backend

2019-01-03 Thread Yongji Xie
On Fri, 4 Jan 2019 at 01:02, Michael S. Tsirkin wrote: > > On Thu, Jan 03, 2019 at 06:18:14PM +0800, elohi...@gmail.com wrote: > > From: Xie Yongji > > > > This patch introduces two new messages VHOST_USER_GET_SHM_SIZE > > and VHOST_USER_SET_SHM_FD to support

Re: [Qemu-devel] [PATCH v3 for-4.0 2/7] vhost-user: Support providing shared memory to backend

2019-01-03 Thread Yongji Xie
On Fri, 4 Jan 2019 at 10:41, Michael S. Tsirkin wrote: > > On Fri, Jan 04, 2019 at 10:31:34AM +0800, Yongji Xie wrote: > > On Fri, 4 Jan 2019 at 01:02, Michael S. Tsirkin wrote: > > > > > > On Thu, Jan 03, 2019 at 06:18:14PM +0800, elohi...@gmail.com w

Re: [Qemu-devel] [PATCH v3 for-4.0 2/7] vhost-user: Support providing shared memory to backend

2019-01-03 Thread Yongji Xie
On Fri, 4 Jan 2019 at 01:13, Michael S. Tsirkin wrote: > > On Thu, Jan 03, 2019 at 06:18:14PM +0800, elohi...@gmail.com wrote: > > From: Xie Yongji > > > > This patch introduces two new messages VHOST_USER_GET_SHM_SIZE > > and VHOST_USER_SET_SHM_FD to support

Re: [Qemu-devel] [PATCH v4 for-4.0 0/7] vhost-user-blk: Add support for backend reconnecting

2019-01-10 Thread Yongji Xie
On Thu, 10 Jan 2019 at 18:25, Stefan Hajnoczi wrote: > > On Wed, Jan 09, 2019 at 07:27:21PM +0800, elohi...@gmail.com wrote: > > From: Xie Yongji > > > > This patchset is aimed at supporting qemu to reconnect > > vhost-user-blk backend after vhost-user-bl

Re: [Qemu-devel] [PATCH v4 for-4.0 0/7] vhost-user-blk: Add support for backend reconnecting

2019-01-10 Thread Yongji Xie
On Thu, 10 Jan 2019 at 18:39, Marc-André Lureau wrote: > > Hi > > On Wed, Jan 9, 2019 at 3:28 PM wrote: > > > > From: Xie Yongji > > > > This patchset is aimed at supporting qemu to reconnect > > vhost-user-blk backend after vhost-user-blk backend cras

Re: [Qemu-devel] [PATCH v4 for-4.0 1/7] char-socket: Enable "nowait" option on client sockets

2019-01-10 Thread Yongji Xie
On Thu, 10 Jan 2019 at 20:50, Daniel P. Berrangé wrote: > > On Wed, Jan 09, 2019 at 07:27:22PM +0800, elohi...@gmail.com wrote: > > From: Xie Yongji > > > > Enable "nowait" option to make QEMU not do a connect > > on client sockets during initializa

Re: [Qemu-devel] [PATCH v4 for-4.0 1/7] char-socket: Enable "nowait" option on client sockets

2019-01-10 Thread Yongji Xie
On Thu, 10 Jan 2019 at 21:24, Daniel P. Berrangé wrote: > > On Thu, Jan 10, 2019 at 09:19:41PM +0800, Yongji Xie wrote: > > On Thu, 10 Jan 2019 at 20:50, Daniel P. Berrangé > > wrote: > > > > > > On Wed, Jan 09, 2019 at 07:27:22PM +0800, elohi...@gmail

Re: [Qemu-devel] [PATCH v4 for-4.0 1/7] char-socket: Enable "nowait" option on client sockets

2019-01-10 Thread Yongji Xie
On Thu, 10 Jan 2019 at 22:11, Daniel P. Berrangé wrote: > > On Thu, Jan 10, 2019 at 10:08:54PM +0800, Yongji Xie wrote: > > On Thu, 10 Jan 2019 at 21:24, Daniel P. Berrangé > > wrote: > > > > > > On Thu, Jan 10, 2019 at 09:19:41PM +0800, Yongji Xie wrote:

Re: [Qemu-devel] [PATCH v4 for-4.0 4/7] libvhost-user: Support tracking inflight I/O in shared memory

2019-01-10 Thread Yongji Xie
On Fri, 11 Jan 2019 at 11:56, Jason Wang wrote: > > > On 2019/1/9 下午7:27, elohi...@gmail.com wrote: > > From: Xie Yongji > > > > This patch adds support for VHOST_USER_GET_INFLIGHT_FD and > > VHOST_USER_SET_INFLIGHT_FD message to set/get shared memory > > t

[Qemu-devel] [PATCH] kvmclock: run KVM_KVMCLOCK_CTRL ioctl in vcpu thread

2018-07-11 Thread Yongji Xie
According to KVM API Documentation, we should only run vcpu ioctls from the same thread that was used to create the vcpu. This patch makes KVM_KVMCLOCK_CTRL ioctl consistent with the Documentation. No functional change. Signed-off-by: Yongji Xie Signed-off-by: Chai Wen --- hw/i386/kvm/clock.c

[Qemu-devel] [PATCH] kvmclock: run KVM_KVMCLOCK_CTRL ioctl in vcpu thread

2018-07-11 Thread Yongji Xie
According to KVM API Documentation, we should only run vcpu ioctls from the same thread that was used to create the vcpu. This patch makes KVM_KVMCLOCK_CTRL ioctl consistent with the Documentation. No functional change. Signed-off-by: Yongji Xie Signed-off-by: Chai Wen --- hw/i386/kvm/clock.c

[Qemu-devel] [PATCH] vhost-user-blk: start vhost when guest kicks

2018-06-05 Thread Yongji Xie
). Signed-off-by: Yongji Xie Signed-off-by: Chai Wen Signed-off-by: Ni Xun --- hw/block/vhost-user-blk.c | 20 1 file changed, 20 insertions(+) diff --git a/hw/block/vhost-user-blk.c b/hw/block/vhost-user-blk.c index d755223..8fd0e6f 100644 --- a/hw/block/vhost-user-blk.

Re: [Qemu-devel] [PATCH] vhost-user-blk: start vhost when guest kicks

2018-06-05 Thread Yongji Xie
On 5 June 2018 at 22:23, Michael S. Tsirkin wrote: > On Tue, Jun 05, 2018 at 09:56:10PM +0800, Yongji Xie wrote: >> Some old guests (before commit 7a11370e5: "virtio_blk: enable VQs early") >> kick virtqueue before setting VIRTIO_CONFIG_S_DRIVER_OK. This would cause >

[Qemu-devel] [PATCH v2] vhost-user-blk: start vhost when guest kicks

2018-06-06 Thread Yongji Xie
ned-off-by: Yongji Xie Signed-off-by: Chai Wen Signed-off-by: Ni Xun --- hw/block/vhost-user-blk.c | 25 + 1 file changed, 25 insertions(+) diff --git a/hw/block/vhost-user-blk.c b/hw/block/vhost-user-blk.c index d755223..1451940 100644 --- a/hw/block/vhost-user-blk.c +++

Re: [Qemu-devel] [PATCH] kvmclock: run KVM_KVMCLOCK_CTRL ioctl in vcpu thread

2018-08-01 Thread Yongji Xie
Ping... On 11 July 2018 at 21:22, Yongji Xie wrote: > According to KVM API Documentation, we should only > run vcpu ioctls from the same thread that was used > to create the vcpu. This patch makes KVM_KVMCLOCK_CTRL > ioctl consistent with the Documentation. > > No functional

Re: [Qemu-devel] [PATCH RFC v2 1/6] docs/block-replication: Add description for shared-disk case

2016-12-20 Thread Changlong Xie
;: 'inet', +'data': { +'host': '0', +'port': 'yyy' + } +} + } + } +2. { 'execute': 'nbd-server-add', + 'arguments': { +'device': 'hidden_disk0', +'writable': true +} + } + +After Failover: +Primary: + { 'execute': 'x-blockdev-del', +'arguments': { +'node-name': 'rep' +} + } + +Secondary: + {'execute': 'nbd-server-stop' } + TODO: 1. Continuous block replication -2. Shared disk Looks good to me Reviewed-by: Changlong Xie

Re: [Qemu-devel] [PATCH RFC v2 2/6] replication: add shared-disk and shared-disk-id options

2016-12-20 Thread Changlong Xie
On 12/05/2016 04:35 PM, zhanghailiang wrote: diff --git a/qapi/block-core.json b/qapi/block-core.json index c29bef7..52d7e0d 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -2232,12 +2232,19 @@ # node who owns the replication node chain. Must not be given in #

Re: [Qemu-devel] [PATCH RFC v2 3/6] replication: Split out backup_do_checkpoint() from secondary_do_checkpoint()

2016-12-20 Thread Changlong Xie
condary_disk->bs->job, &local_err); +if (local_err) { +error_propagate(errp, local_err); +break; +} secondary_do_checkpoint(s, errp); +break; +default: +abort(); } aio_context_release(aio_context); } Looks good to me Reviewed-by: Changlong Xie

Re: [Qemu-devel] [PATCH RFC v2 4/6] replication: fix code logic with the new shared_disk option

2016-12-20 Thread Changlong Xie
On 12/05/2016 04:35 PM, zhanghailiang wrote: Some code logic only be needed in non-shared disk, here we adjust these codes to prepare for shared disk scenario. Signed-off-by: zhanghailiang --- block/replication.c | 47 --- 1 file changed, 28 insert

Re: [Qemu-devel] [PATCH] replication: Fix replication open fail

2017-10-26 Thread Xie Changlong
ned-off-by: Wang Yong Thanks, this patch fixs the problem in http://lists.nongnu.org/archive/html/qemu-devel/2017-08/msg03358.html. Reviewed-by: Xie Changlong > --- > block/replication.c | 11 +++ > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/block

Re: [Qemu-devel] [PATCH v6 0/1] Introduce "xen-load-devices-state"

2016-06-30 Thread Changlong Xie
Would any migration maintainer pick this patch or give some comments? Thanks -Xie On 06/03/2016 05:58 PM, Changlong Xie wrote: Changelog v6: 1. Fix channel open flag v5: 1. Introduce qio channel since 8925839f v4: 1. Rebased to the lastest code v3: 1. Addressed on David's commets

[Qemu-devel] [PATCH] dirty-bitmap: remove unnecessary return

2016-06-30 Thread Changlong Xie
Otherwise, we could never trigger assert(!bitmap->successor) Signed-off-by: Changlong Xie --- block/dirty-bitmap.c | 1 - 1 file changed, 1 deletion(-) diff --git a/block/dirty-bitmap.c b/block/dirty-bitmap.c index 4902ca5..e9df5ac 100644 --- a/block/dirty-bitmap.c +++ b/block/dirty-bitma

Re: [Qemu-devel] [PATCH] dirty-bitmap: remove unnecessary return

2016-06-30 Thread Changlong Xie
On 06/30/2016 04:25 PM, Fam Zheng wrote: On Thu, 06/30 16:01, Changlong Xie wrote: Otherwise, we could never trigger assert(!bitmap->successor) Signed-off-by: Changlong Xie --- block/dirty-bitmap.c | 1 - 1 file changed, 1 deletion(-) diff --git a/block/dirty-bitmap.c b/block/di

Re: [Qemu-devel] [PATCH] dirty-bitmap: remove unnecessary return

2016-06-30 Thread Changlong Xie
On 07/01/2016 02:18 AM, John Snow wrote: On 06/30/2016 10:00 AM, Jeff Cody wrote: On Thu, Jun 30, 2016 at 04:45:52PM +0800, Changlong Xie wrote: On 06/30/2016 04:25 PM, Fam Zheng wrote: On Thu, 06/30 16:01, Changlong Xie wrote: Otherwise, we could never trigger assert(!bitmap->succes

Re: [Qemu-devel] [PATCH v20 Resend 09/10] tests: add unit test case for replication

2016-07-03 Thread Changlong Xie
On 06/14/2016 03:53 PM, Changlong Xie wrote: Signed-off-by: Wen Congyang Signed-off-by: Changlong Xie --- tests/.gitignore | 1 + tests/Makefile | 4 + tests/test-replication.c | 555 +++ 3 files changed, 560 insertions

Re: [Qemu-devel] [PATCH] json-streamer: Don't leak tokens on incomplete parse

2016-07-04 Thread Changlong Xie
On 05/19/2016 05:46 AM, Eric Blake wrote: Valgrind complained about a number of leaks in tests/check-qobject-json: ==12657==definitely lost: 17,247 bytes in 1,234 blocks All of which had the same root cause: on an incomplete parse, we were abandoning the token queue without cleaning up the

Re: [Qemu-devel] [PATCH] json-streamer: fix double-free on exiting during a parse

2016-07-05 Thread Changlong Xie
eue earlier, so that it is already in place when the old one is passed to parser->emit. Reported-by: Changlong Xie Signed-off-by: Paolo Bonzini Two meta questions: Is there a reproducer and/or test case coverage? tests/qemu-iotests/071 Does qemu-stable need this? http://lists.nong

[Qemu-devel] [PATCH v21 01/10] unblock backup operations in backing file

2016-07-05 Thread Changlong Xie
From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: Changlong Xie --- block.c | 17 + 1 file changed, 17 insertions(+) diff --git a/block.c b/block.c index f4648e9..f7e7e43 100644 --- a/block.c +++ b/block.c @@ -1309,6 +1309,23 @@ void bdrv_set_backing_hd

[Qemu-devel] [PATCH v21 00/10] Block replication for continuous checkpoints

2016-07-05 Thread Changlong Xie
lock job API 3. Active disk, hidden disk and nbd target uses the same AioContext 4. Add a testcase to test new hbitmap API V2: 1. Redesign the secondary qemu(use image-fleecing) 2. Use Error objects to return error message 3. Address the comments from Max Reitz and Eric Blake Changlong Xie (3): Ba

[Qemu-devel] [PATCH v21 08/10] Implement new driver for block replication

2016-07-05 Thread Changlong Xie
From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie --- block/Makefile.objs | 1 + block/replication.c | 657 2 files changed, 658 insertions(+) create mode

[Qemu-devel] [PATCH v21 02/10] Backup: clear all bitmap when doing block checkpoint

2016-07-05 Thread Changlong Xie
From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie --- block/backup.c | 18 ++ include/block/block_backup.h | 3 +++ 2 files changed, 21 insertions(+) create mode 100644 include

[Qemu-devel] [PATCH v21 04/10] Link backup into block core

2016-07-05 Thread Changlong Xie
From: Wen Congyang Some programs that add a dependency on it will use the block layer directly. Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie Reviewed-by: Stefan Hajnoczi Reviewed-by: Jeff Cody --- block/Makefile.objs | 2

[Qemu-devel] [PATCH v21 09/10] tests: add unit test case for replication

2016-07-05 Thread Changlong Xie
Signed-off-by: Wen Congyang Signed-off-by: Changlong Xie --- tests/.gitignore | 1 + tests/Makefile.include | 4 + tests/test-replication.c | 557 +++ 3 files changed, 562 insertions(+) create mode 100644 tests/test-replication.c diff

[Qemu-devel] [PATCH v21 10/10] support replication driver in blockdev-add

2016-07-05 Thread Changlong Xie
From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie Reviewed-by: Eric Blake --- qapi/block-core.json | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/qapi/block-core.json b

[Qemu-devel] [PATCH v21 03/10] Backup: export interfaces for extra serialization

2016-07-05 Thread Changlong Xie
} ret = bdrv_co_readv(); out: return ret; } Signed-off-by: Changlong Xie Signed-off-by: Wen Congyang --- block/backup.c | 41 ++--- include/block/block_backup.h | 14 ++ 2 files changed, 48 insertions(+), 7 deletions(-)

Re: [Qemu-devel] [PATCH] qom/object: fix comment typo

2016-07-05 Thread Changlong Xie
Would any maintainer pick this one? On 06/14/2016 03:27 PM, Changlong Xie wrote: Signed-off-by: Changlong Xie --- include/qom/object.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/qom/object.h b/include/qom/object.h index 99de539..925c279 100644 --- a/include

[Qemu-devel] [PATCH v21 06/10] auto complete active commit

2016-07-05 Thread Changlong Xie
From: Wen Congyang Auto complete mirror job in background to prevent from blocking synchronously Signed-off-by: Wen Congyang Signed-off-by: Changlong Xie --- block/mirror.c| 13 + blockdev.c| 2 +- include/block/block_int.h | 3 ++- qemu-img.c

[Qemu-devel] [PATCH v21 05/10] docs: block replication's description

2016-07-05 Thread Changlong Xie
From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie --- docs/block-replication.txt | 239 + 1 file changed, 239 insertions(+) create mode 100644 docs/block

[Qemu-devel] [PATCH v21 07/10] Introduce new APIs to do replication operation

2016-07-05 Thread Changlong Xie
please refer to replication.h Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie --- Makefile.objs| 1 + qapi/block-core.json | 13 replication.c| 107 +++ replication.h| 174

[PATCH 2/2] iscsi: return -EIO when sense fields are meaningless

2020-07-01 Thread Xie Yongji
When an I/O request failed, now we only return correct value on scsi check condition. We should also have a default errno such as -EIO in other case. Signed-off-by: Xie Yongji --- block/iscsi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/block/iscsi.c b/block/iscsi.c index 2964c9f8d2

[PATCH 1/2] iscsi: handle check condition status in retry loop

2020-07-01 Thread Xie Yongji
The handling of check condition was incorrect because we would only do it after retries exceed maximum. Fixes: 8c460269aa ("iscsi: base all handling of check condition on scsi_sense_to_errno") Signed-off-by: Xie Yongji --- block/iscsi.c | 20 ++-- 1 file changed, 10

[PATCH 0/3] Introduce vhost-vdpa block device

2021-04-08 Thread Xie Yongji
/20210331080519.172-1-xieyon...@bytedance.com/ Xie Yongji (3): Remove redundant declaration of address_space_memory vhost-blk: add vhost-blk-common abstraction vhost-vdpa-blk: Introduce vhost-vdpa-blk host device hw/block/Kconfig | 5 + hw/block/meson.build | 3

[PATCH 1/3] vhost-vdpa: Remove redundant declaration of address_space_memory

2021-04-08 Thread Xie Yongji
The symbol address_space_memory are already declared in include/exec/address-spaces.h. So let's add this header file and remove the redundant declaration in include/hw/virtio/vhost-vdpa.h. Signed-off-by: Xie Yongji --- hw/virtio/vhost-vdpa.c | 1 + include/hw/virtio/vhost-vdpa.

[PATCH 2/3] vhost-blk: Add vhost-blk-common abstraction

2021-04-08 Thread Xie Yongji
This commit abstracts part of vhost-user-blk into a common parent class which is useful for the introducation of vhost-vdpa-blk. Signed-off-by: Xie Yongji --- hw/block/meson.build | 2 +- hw/block/vhost-blk-common.c | 291 + hw/block/vhost-user

[PATCH 3/3] vhost-vdpa-blk: Introduce vhost-vdpa-blk host device

2021-04-08 Thread Xie Yongji
This commit introduces a new vhost-vdpa block device, which will set up a vDPA device specified by a "vdpa-dev" parameter, something like: qemu-system-x86_64 \ -device vhost-vdpa-blk-pci,vdpa-dev=/dev/vhost-vdpa-0 Signed-off-by: Xie Yongji --- hw/block/Kconfig |

Re: Re: [PATCH 2/3] vhost-blk: Add vhost-blk-common abstraction

2021-04-08 Thread Yongji Xie
AINERS entry vhost-blk-common.h/c either under > vhost-user-blk or create a new vhost-blk entry. I'm not sure what the > best practices are for this. > Not sure. Maybe adding vhost-blk-common.h/c under vhost-user-blk entry is OK. > On Thu, Apr 08, 2021 at 06:12:51PM +0800, Xie Yon

Re: Re: [PATCH 3/3] vhost-vdpa-blk: Introduce vhost-vdpa-blk host device

2021-04-09 Thread Yongji Xie
On Fri, Apr 9, 2021 at 2:02 PM Jason Wang wrote: > > > 在 2021/4/8 下午6:12, Xie Yongji 写道: > > This commit introduces a new vhost-vdpa block device, which > > will set up a vDPA device specified by a "vdpa-dev" parameter, > > something like: > > > >

Re: Re: [PATCH 3/3] vhost-vdpa-blk: Introduce vhost-vdpa-blk host device

2021-04-12 Thread Yongji Xie
On Mon, Apr 12, 2021 at 3:14 PM Jason Wang wrote: > > > 在 2021/4/9 下午4:17, Yongji Xie 写道: > > On Fri, Apr 9, 2021 at 2:02 PM Jason Wang wrote: > >> > >> 在 2021/4/8 下午6:12, Xie Yongji 写道: > >>> This commit introduces a new vhost-vdpa block device, wh

[PATCH v2] vhost-vdpa: Remove redundant declaration of address_space_memory

2021-05-17 Thread Xie Yongji
The symbol address_space_memory are already declared in include/exec/address-spaces.h. So let's add this header file and remove the redundant declaration in include/hw/virtio/vhost-vdpa.h. Signed-off-by: Xie Yongji Reviewed-by: Philippe Mathieu-Daudé --- hw/virtio/vhost-vdpa.c

<    1   2   3   4   5   6   7   >