On 03/10/2016 10:49 AM, Changlong Xie wrote:
From: Wen Congyang
The new QMP command name is x-blockdev-change. It's just for adding/removing
quorum's child now, and doesn't support all kinds of children, all kinds of
operations, nor all block drivers. So it is experimental now.
On 03/11/2016 06:34 PM, Changlong Xie wrote:
From: Wen Congyang
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
---
docs/block-replication.txt | 238 +
1 file changed, 238 insertions
On 05/24/2016 09:47 PM, Kevin Wolf wrote:
+blk = blk_new();
blk_new(errp);
On 05/24/2016 09:47 PM, Kevin Wolf wrote:
+s->base = blk_new();
blk_new(errp);
+blk_insert_bs(s->base, base);
+
+s->top = blk_new();
blk_new(errp);
On 05/24/2016 09:47 PM, Kevin Wolf wrote:
+s->target = blk_new();
blk_new(errp);
On 05/24/2016 09:47 PM, Kevin Wolf wrote:
+job->target = blk_new();
blk_new(errp);
On 05/25/2016 12:01 PM, Eric Blake wrote:
On 05/24/2016 09:51 PM, Changlong Xie wrote:
On 05/24/2016 09:47 PM, Kevin Wolf wrote:
+s->target = blk_new();
blk_new(errp);
Depends on Kevin's block/next branch, which currently includes:
commit 5d7dd50566a4f9786b95f49448f48fead0bb34d
On 05/24/2016 09:47 PM, Kevin Wolf wrote:
There is a single remaining user in qemu-img, which can be trivially
converted to using BlockJob.blk instead.
Signed-off-by: Kevin Wolf
Reviewed-by: Max Reitz
---
blockjob.c | 1 -
include/block/blockjob.h | 1 -
qemu-img.c
On 04/11/2016 11:56 AM, Changlong Xie wrote:
Changelog
v4:
1. Rebased to the lastest code
v3:
1. Addressed on David's commets, fix a bug
v2:
1. Rebased to the lastest code
2. Addressed on Eric's comments, fixed coding style
Wen Congyang (1):
Introduce "xen-load-devices-stat
On 05/20/2016 03:36 PM, Changlong Xie wrote:
+static void io_write(BlockDriverState *bs, long pattern, int64_t pattern_count,
+ int64_t offset, int64_t count, bool expect_failed)
+{
+void *pattern_buf;
Should initialize as NULL to avoid below warnning:
tests/test
Ping here : )
Hi fam, do you have time to help reviewing this patchset? Consider of we
are in the same time zone what will speed up code reviewing process,
any feedback will be appreciated.
Thanks
-Xie
On 05/20/2016 03:36 PM, Changlong Xie wrote:
Block replication is a very
l-max' is unset then the bucket size is 100.
Sorry to brother, why the bucket size is 100 rather than 100 x 60?
Thanks
-Xie
The bucket is initially empty, therefore water can be added until it's
full at a rate of 2000 IOPS (the burst rate). Once the bucket is full
Signed-off-by: Changlong Xie
---
include/block/blockjob.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/block/blockjob.h b/include/block/blockjob.h
index 86d2807..00ac418 100644
--- a/include/block/blockjob.h
+++ b/include/block/blockjob.h
@@ -397,7 +397,7 @@ int
On 05/30/2016 06:00 PM, Alberto Garcia wrote:
On Mon 30 May 2016 08:49:18 AM CEST, Changlong Xie wrote:
- Water leaks from the bucket at a rate of 100 IOPS.
- Water can be added to the bucket at a rate of 2000 IOPS.
- The size of the bucket is 2000 x 60 = 12
- - If '
On 05/31/2016 02:14 AM, Stefan Hajnoczi wrote:
On Fri, May 20, 2016 at 03:36:18PM +0800, Changlong Xie wrote:
+/* start backup job now */
+error_setg(&s->blocker,
+ "block device is in use by internal backup job");
+
+top_bs = bdrv_lo
On 05/31/2016 01:34 AM, Stefan Hajnoczi wrote:
On Fri, May 20, 2016 at 03:36:19PM +0800, Changlong Xie wrote:
+/* primary */
+#define P_LOCAL_DISK "/tmp/p_local_disk.XX"
+#define P_COMMAND "driver=replication,mode=primary,node-name=xxx,"\
+
On 05/31/2016 02:20 AM, Stefan Hajnoczi wrote:
On Fri, May 20, 2016 at 03:36:10PM +0800, Changlong Xie wrote:
Block replication is a very important feature which is used for
continuous checkpoints(for example: COLO).
You can get the detailed information about block replication from here:
http
1. suspend both primary vm and secondary vm
2. sync the state
3. resume both primary vm and secondary vm
In such case, we need to update all devices' state in any time.
Signed-off-by: Wen Congyang
Signed-off-by: Changlong Xie
---
migration/savevm.c | 37
Changelog
v5:
1. Introduce qio channel since 8925839f
v4:
1. Rebased to the lastest code
v3:
1. Addressed on David's commets, fix a bug
v2:
1. Rebased to the lastest code
2. Addressed on Eric's comments, fixed coding style
Wen Congyang (1):
Introduce "xen-load-devices-state"
migration/savevm.
On 06/02/2016 06:16 PM, Dr. David Alan Gilbert wrote:
* Stefano Stabellini (sstabell...@kernel.org) wrote:
On Thu, 2 Jun 2016, Stefano Stabellini wrote:
On Wed, 1 Jun 2016, Dr. David Alan Gilbert wrote:
* Amit Shah (amit.s...@redhat.com) wrote:
Dave, can you take a look?
Yes, I think I'm ha
On 06/02/2016 11:14 PM, Anthony PERARD wrote:
On Thu, Jun 02, 2016 at 06:36:46PM +0800, Changlong Xie wrote:
+void qmp_xen_load_devices_state(const char *filename, Error **errp)
+{
+QEMUFile *f;
+QIOChannelFile *ioc;
+int ret;
+
+/* Guest must be paused before loading the device
On 06/02/2016 11:14 PM, Anthony PERARD wrote:
On Thu, Jun 02, 2016 at 06:36:46PM +0800, Changlong Xie wrote:
+void qmp_xen_load_devices_state(const char *filename, Error **errp)
+{
+QEMUFile *f;
+QIOChannelFile *ioc;
+int ret;
+
+/* Guest must be paused before loading the device
On 06/03/2016 09:45 AM, Eric Blake wrote:
On 06/02/2016 07:26 PM, Changlong Xie wrote:
+
+ioc = qio_channel_file_new_path(filename, O_WRONLY | O_CREAT,
0660, errp);
This does not look right, it looks like it's going to open the file
to write to it. You probably want O_RDONLY, a
On 06/03/2016 10:13 AM, Changlong Xie wrote:
On 06/03/2016 09:45 AM, Eric Blake wrote:
On 06/02/2016 07:26 PM, Changlong Xie wrote:
+
+ioc = qio_channel_file_new_path(filename, O_WRONLY | O_CREAT,
0660, errp);
This does not look right, it looks like it's going to open the file
to
1. suspend both primary vm and secondary vm
2. sync the state
3. resume both primary vm and secondary vm
In such case, we need to update all devices' state in any time.
Signed-off-by: Wen Congyang
Signed-off-by: Changlong Xie
---
migration/savevm.c | 37
Changelog
v6:
1. Fix channel open flag
v5:
1. Introduce qio channel since 8925839f
v4:
1. Rebased to the lastest code
v3:
1. Addressed on David's commets, fix a bug
v2:
1. Rebased to the lastest code
2. Addressed on Eric's comments, fixed coding style
Wen Congyang (1):
Introduce "xen-load-device
On 05/20/2016 03:36 PM, Changlong Xie wrote:
+
+/*
+ * Must protect backup target if backup job was stopped/cancelled
+ * unexpectedly
+ */
+bdrv_ref(s->hidden_disk->bs);
+
+backup_start(s->secondary_disk->bs, s->hid
On 05/20/2016 03:36 PM, Changlong Xie wrote:
+if (!failover) {
+/*
+ * This BDS will be closed, and the job should be completed
+ * before the BDS is closed, because we will access hidden
+ * disk, secondary disk in backup_job_completed
From: Wen Congyang
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
---
docs/block-replication.txt | 239 +
1 file changed, 239 insertions(+)
create mode 100644 docs/block
From: Wen Congyang
Signed-off-by: Wen Congyang
Signed-off-by: Changlong Xie
---
block.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/block.c b/block.c
index 736432f..dcf63f4 100644
--- a/block.c
+++ b/block.c
@@ -1310,6 +1310,23 @@ void bdrv_set_backing_hd
From: Wen Congyang
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
---
block/backup.c | 18 ++
include/block/block_backup.h | 3 +++
2 files changed, 21 insertions(+)
create mode 100644 include
ror_setg() instead of error_set()
2. Add a new block job API
3. Active disk, hidden disk and nbd target uses the same AioContext
4. Add a testcase to test new hbitmap API
V2:
1. Redesign the secondary qemu(use image-fleecing)
2. Use Error objects to return error message
3. Address the comments
From: Wen Congyang
Some programs that add a dependency on it will use
the block layer directly.
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Jeff Cody
---
block/Makefile.objs | 2
}
ret = bdrv_co_readv();
out:
return ret;
}
Signed-off-by: Changlong Xie
Signed-off-by: Wen Congyang
---
block/backup.c | 41 ++---
include/block/block_backup.h | 14 ++
2 files changed, 48 insertions(+), 7 deletions(-)
Signed-off-by: Wen Congyang
Signed-off-by: Changlong Xie
---
tests/.gitignore | 1 +
tests/Makefile | 4 +
tests/test-replication.c | 555 +++
3 files changed, 560 insertions(+)
create mode 100644 tests/test-replication.c
diff
From: Wen Congyang
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
---
block/Makefile.objs | 1 +
block/replication.c | 657
2 files changed, 658 insertions(+)
create mode
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
---
Makefile.objs| 1 +
qapi/block-core.json | 13
replication.c| 105 ++
replication.h| 176
From: Wen Congyang
Auto complete mirror job in background to prevent from
blocking synchronously
Signed-off-by: Wen Congyang
Signed-off-by: Changlong Xie
---
block/mirror.c| 13 +
blockdev.c| 2 +-
include/block/block_int.h | 3 ++-
qemu-img.c
From: Wen Congyang
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
Reviewed-by: Eric Blake
---
qapi/block-core.json | 20 ++--
1 file changed, 18 insertions(+), 2 deletions(-)
diff --git a/qapi/block-core.json b
On 06/10/2016 09:22 PM, Michael Tokarev wrote:
08.06.2016 04:11, Changlong Xie wrote:
Block replication is a very important feature which is used for
continuous checkpoints(for example: COLO).
...
I'm not sure I understand why this has been sent to qemu-trivial? :)
$HOME/.gitconfig mi
On 06/08/2016 09:41 PM, Eric Blake wrote:
On 06/07/2016 07:11 PM, Changlong Xie wrote:
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
No mention of the API names in the commit message? Grepping 'git log'
is easier i
On 06/08/2016 09:36 PM, Eric Blake wrote:
On 06/07/2016 07:11 PM, Changlong Xie wrote:
Block replication is a very important feature which is used for
continuous checkpoints(for example: COLO).
Side note: Including qemu-trivial in CC: on a patch series at v20 feels
wrong. Obviously it is
Signed-off-by: Changlong Xie
---
include/qom/object.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/qom/object.h b/include/qom/object.h
index 99de539..925c279 100644
--- a/include/qom/object.h
+++ b/include/qom/object.h
@@ -901,7 +901,7 @@ GSList
From: Wen Congyang
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
---
block/backup.c | 18 ++
include/block/block_backup.h | 3 +++
2 files changed, 21 insertions(+)
create mode 100644 include
}
ret = bdrv_co_readv();
out:
return ret;
}
Signed-off-by: Changlong Xie
Signed-off-by: Wen Congyang
---
block/backup.c | 41 ++---
include/block/block_backup.h | 14 ++
2 files changed, 48 insertions(+), 7 deletions(-)
From: Wen Congyang
Signed-off-by: Wen Congyang
Signed-off-by: Changlong Xie
---
block.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/block.c b/block.c
index 736432f..dcf63f4 100644
--- a/block.c
+++ b/block.c
@@ -1310,6 +1310,23 @@ void bdrv_set_backing_hd
d a testcase to test new hbitmap API
V2:
1. Redesign the secondary qemu(use image-fleecing)
2. Use Error objects to return error message
3. Address the comments from Max Reitz and Eric Blake
Changlong Xie (3):
Backup: export interfaces for extra serialization
Introduce new APIs to do replicati
From: Wen Congyang
Auto complete mirror job in background to prevent from
blocking synchronously
Signed-off-by: Wen Congyang
Signed-off-by: Changlong Xie
---
block/mirror.c| 13 +
blockdev.c| 2 +-
include/block/block_int.h | 3 ++-
qemu-img.c
From: Wen Congyang
Some programs that add a dependency on it will use
the block layer directly.
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Jeff Cody
---
block/Makefile.objs | 2
From: Wen Congyang
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
Reviewed-by: Eric Blake
---
qapi/block-core.json | 20 ++--
1 file changed, 18 insertions(+), 2 deletions(-)
diff --git a/qapi/block-core.json b
From: Wen Congyang
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
---
docs/block-replication.txt | 239 +
1 file changed, 239 insertions(+)
create mode 100644 docs/block
From: Wen Congyang
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
---
block/Makefile.objs | 1 +
block/replication.c | 657
2 files changed, 658 insertions(+)
create mode
please
refer to replication.h
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
---
Makefile.objs| 1 +
qapi/block-core.json | 13
replication.c| 107 +++
replication.h| 174
Signed-off-by: Wen Congyang
Signed-off-by: Changlong Xie
---
tests/.gitignore | 1 +
tests/Makefile | 4 +
tests/test-replication.c | 555 +++
3 files changed, 560 insertions(+)
create mode 100644 tests/test-replication.c
diff
For v19, Stefan said he had reviewed most part of this patchsets.
So, this series need more comments from block and block job maintainers.
@Jeff and/or Kevin, ping...
On 06/14/2016 03:53 PM, Changlong Xie wrote:
Block replication is a very important feature which is used for
continuous
For this patch, i think you forget to add qemu-version.h and/or
qemu-version.h.tmp in .gitignore
changlox ~/w/qemu/qemu% gs
On branch master
Your branch is up-to-date with 'origin/master'.
Untracked files:
(use "git add ..." to include in what will be committed)
qemu-version.h
s/target bs/to_replace/, also we check to_replace bs is not
blocked in qmp_drive_mirror() not here
Signed-off-by: Changlong Xie
---
block/mirror.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/mirror.c b/block/mirror.c
index fa2bdab..335ddd2 100644
--- a/block
Changlong Xie (2):
blockjob: assert(cb) in the entry functions of blockjob
mirror: fix misleading comments
block/commit.c | 1 +
block/mirror.c | 4 +++-
block/stream.c | 1 +
3 files changed, 5 insertions(+), 1 deletion(-)
--
1.9.3
Signed-off-by: Changlong Xie
---
block/commit.c | 1 +
block/mirror.c | 2 ++
block/stream.c | 1 +
3 files changed, 4 insertions(+)
diff --git a/block/commit.c b/block/commit.c
index 444333b..13b55c1 100644
--- a/block/commit.c
+++ b/block/commit.c
@@ -223,6 +223,7 @@ void commit_start
On 06/22/2016 05:50 PM, Paolo Bonzini wrote:
On 22/06/2016 11:16, Changlong Xie wrote:
Signed-off-by: Changlong Xie
---
block/commit.c | 1 +
block/mirror.c | 2 ++
block/stream.c | 1 +
3 files changed, 4 insertions(+)
Why is this useful?
commit/mirror/stream/backup use
On 06/23/2016 01:31 AM, Eric Blake wrote:
On 06/22/2016 04:19 AM, Paolo Bonzini wrote:
On 22/06/2016 12:12, Changlong Xie wrote:
commit/mirror/stream/backup use block_job_create(..., cb,..) to create
relevant blockjob. When they finished, these jobs will invoke
block_job_completed, then
On 06/23/2016 02:21 PM, Kevin Wolf wrote:
Am 23.06.2016 um 03:04 hat Changlong Xie geschrieben:
On 06/23/2016 01:31 AM, Eric Blake wrote:
On 06/22/2016 04:19 AM, Paolo Bonzini wrote:
On 22/06/2016 12:12, Changlong Xie wrote:
commit/mirror/stream/backup use block_job_create(..., cb,..) to
s/target bs/to_replace/, also we check to_replace bs is not
blocked in qmp_drive_mirror() not here
Signed-off-by: Changlong Xie
---
block/mirror.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/mirror.c b/block/mirror.c
index a04ed9c..4420a15 100644
--- a/block
V2
p1: put assert(cb) in block_job_create
Changlong Xie (2):
blockjob: assert(cb) when create job
mirror: fix misleading comments
block/backup.c | 1 -
block/mirror.c | 2 +-
blockjob.c | 1 +
3 files changed, 2 insertions(+), 2 deletions(-)
--
1.9.3
Callback for block job should always exist
Suggested-by: Paolo Bonzini
Suggested-by: Kevin Wolf
Signed-off-by: Changlong Xie
---
block/backup.c | 1 -
blockjob.c | 1 +
2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/backup.c b/block/backup.c
index 581269b..f87f8d5
On 05/06/2016 11:51 PM, Stefan Hajnoczi wrote:
On Fri, Apr 15, 2016 at 04:10:30PM +0800, Changlong Xie wrote:
Block replication is a very important feature which is used for
continuous checkpoints(for example: COLO).
You can get the detailed information about block replication from here:
http
On 05/06/2016 11:46 PM, Stefan Hajnoczi wrote:
On Fri, Apr 15, 2016 at 04:10:37PM +0800, Changlong Xie wrote:
+static void replication_close(BlockDriverState *bs)
+{
+BDRVReplicationState *s = bs->opaque;
+
+if (s->mode == REPLICATION_MODE_SECONDARY) {
+g_free(s-&
36a2899f229a7e26ac Mon Sep 17 00:00:00 2001
From: Changlong Xie
Date: Wed, 18 May 2016 16:19:51 +0800
Subject: [PATCH] [RFC] backup: export interfaces for extra serialization
Normal backup(sync='none') workflow:
step 1. NBD peformance I/O write from client to server
qcow2_
From: Wen Congyang
Some programs that add a dependency on it will use
the block layer directly.
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Jeff Cody
---
block/Makefile.objs | 2
sign the secondary qemu(use image-fleecing)
2. Use Error objects to return error message
3. Address the comments from Max Reitz and Eric Blake
Changlong Xie (3):
Backup: export interfaces for extra serialization
Introduce new APIs to do replication operation
tests: add unit test case for replic
From: Wen Congyang
Auto complete mirror job in background to prevent from
blocking synchronously
Signed-off-by: Wen Congyang
Signed-off-by: Changlong Xie
---
block/mirror.c| 13 +
blockdev.c| 2 +-
include/block/block_int.h | 3 ++-
qemu-img.c
From: Wen Congyang
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
---
block/backup.c | 18 ++
include/block/block_backup.h | 3 +++
2 files changed, 21 insertions(+)
create mode 100644 include
Signed-off-by: Wen Congyang
Signed-off-by: Changlong Xie
---
tests/.gitignore | 1 +
tests/Makefile | 4 +
tests/test-replication.c | 523 +++
3 files changed, 528 insertions(+)
create mode 100644 tests/test-replication.c
diff
From: Wen Congyang
Signed-off-by: Wen Congyang
Signed-off-by: Changlong Xie
---
block.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/block.c b/block.c
index 1205ef8..8c4c2c2 100644
--- a/block.c
+++ b/block.c
@@ -1271,6 +1271,23 @@ void bdrv_set_backing_hd
From: Wen Congyang
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
---
docs/block-replication.txt | 239 +
1 file changed, 239 insertions(+)
create mode 100644 docs/block
From: Wen Congyang
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
Reviewed-by: Eric Blake
---
qapi/block-core.json | 20 ++--
1 file changed, 18 insertions(+), 2 deletions(-)
diff --git a/qapi/block-core.json b
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
---
Makefile.objs| 1 +
qapi/block-core.json | 13
replication.c| 105 ++
replication.h| 176
}
ret = bdrv_co_readv();
out:
return ret;
}
Signed-off-by: Changlong Xie
Signed-off-by: Wen Congyang
---
block/backup.c | 41 ++---
include/block/block_backup.h | 14 ++
2 files changed, 48 insertions(+), 7 deletions(-)
From: Wen Congyang
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
---
block/Makefile.objs | 1 +
block/replication.c | 666
2 files changed, 667 insertions(+)
create mode
BARs'
memory regions to zero in case of overlap with BARs which share
the same page with sub-page BARs in guest.
[1] http://www.spinics.net/lists/kvm/msg132382.html
Signed-off-by: Yongji Xie
---
hw/vfio/common.c |3 +--
hw/vfio/pci.c|
libvduse.c:vduse_iova_add_region() I see it
> > handles the offset by adding it up to the size, instead of using it
> > directly as a parameter in the mmap:
> >
> > void *mmap_addr = mmap(0, size + offset, prot, MAP_SHARED, fd, 0);
>
>
> CC Xie Yongji who wrote this cod
On Wed, 13 Mar 2019 at 00:49, Michael S. Tsirkin wrote:
>
> On Thu, Feb 28, 2019 at 04:53:54PM +0800, elohi...@gmail.com wrote:
> > From: Xie Yongji
> >
> > Since we now support the message VHOST_USER_GET_INFLIGHT_FD
> > and VHOST_USER_SET_INFLIGHT_FD. The backend
On Wed, 13 Mar 2019 at 09:16, Michael S. Tsirkin wrote:
>
> On Thu, Feb 28, 2019 at 04:53:54PM +0800, elohi...@gmail.com wrote:
> > From: Xie Yongji
> >
> > Since we now support the message VHOST_USER_GET_INFLIGHT_FD
> > and VHOST_USER_SET_INFLIGHT_FD. The backend
On Wed, 13 Mar 2019 at 09:08, Michael S. Tsirkin wrote:
>
> On Thu, Feb 28, 2019 at 04:53:48PM +0800, elohi...@gmail.com wrote:
> > From: Xie Yongji
> >
> > This patchset is aimed at supporting qemu to reconnect
> > vhost-user-blk backend after vhost-user-bl
On Thu, 14 Mar 2019 at 19:18, Michael S. Tsirkin wrote:
>
> On Wed, Mar 13, 2019 at 10:47:08AM +0800, Yongji Xie wrote:
> > On Wed, 13 Mar 2019 at 09:16, Michael S. Tsirkin wrote:
> > >
> > > On Thu, Feb 28, 2019 at 04:53:54PM +0800, elohi...@gmail.com w
t; > On Tue, Mar 12, 2019 at 12:49:35PM -0400, Michael S. Tsirkin wrote:
> >> > > On Thu, Feb 28, 2019 at 04:53:54PM +0800, elohi...@gmail.com wrote:
> >> > > > From: Xie Yongji
> >> > > >
> >> > > > Since we now sup
gt; > > > On Thu, Feb 28, 2019 at 04:53:54PM +0800, elohi...@gmail.com wrote:
> > > > > From: Xie Yongji
> > > > >
> > > > > Since we now support the message VHOST_USER_GET_INFLIGHT_FD
> > > > > and VHOST_USER_SET_INFLIGHT_FD
On Fri, 15 Mar 2019 at 11:09, Michael S. Tsirkin wrote:
>
> On Fri, Mar 15, 2019 at 10:46:34AM +0800, Yongji Xie wrote:
> > On Thu, 14 Mar 2019 at 19:18, Michael S. Tsirkin wrote:
> > >
> > > On Wed, Mar 13, 2019 at 10:47:08AM +0800, Yongji Xie wrote:
> &
> On Thu, Mar 14, 2019 at 07:34:03AM -0400, Michael S. Tsirkin wrote:
> >> >> On Thu, Mar 14, 2019 at 11:24:22AM +, Daniel P. Berrangé wrote:
> >> >> > On Tue, Mar 12, 2019 at 12:49:35PM -0400, Michael S. Tsirkin wrote:
> >> &
On Fri, 18 Oct 2019 at 01:17, Felipe Franciosi wrote:
>
> Originally, vhost-user-scsi did not implement a handle_output callback
> as that didn't seem necessary. Turns out it is.
>
> Depending on which other devices are presented to a VM, SeaBIOS may
> decide to map vhost-user-scsi devices on the
On Fri, 18 Oct 2019 at 19:14, Felipe Franciosi wrote:
>
>
>
> > On Oct 18, 2019, at 3:59 AM, Yongji Xie wrote:
> >
> > On Fri, 18 Oct 2019 at 01:17, Felipe Franciosi wrote:
> >>
> >> Originally, vhost-user-scsi did not implement a handle_output callb
On Mon, 21 Oct 2019 at 16:00, Felipe Franciosi wrote:
>
>
>
> > On Oct 21, 2019, at 5:01 AM, Yongji Xie wrote:
> >
> > On Fri, 18 Oct 2019 at 19:14, Felipe Franciosi wrote:
> >>
> >>
> >>
> >>> On Oct 18, 2019, at 3:59 AM, Y
On Mon, 21 Oct 2019 at 16:20, Liu, Changpeng wrote:
>
> There is some logic in vhost_user_blk_handle_output() for now, it's not empty
> as vhost-user-scsi.
> There should be other issue if it can't start from SeaBIOS.
>
No, it's the same issue. We can see the notify is triggered from the
VIRTIO_
On Mon, 21 Oct 2019 at 19:40, Stefan Hajnoczi wrote:
>
> Host notifiers are used in several cases:
> 1. Traditional ioeventfd where virtqueue notifications are handled in
>the main loop thread.
> 2. IOThreads (aio_handle_output) where virtqueue notifications are
>handled in an IOThread Aio
On Mon, Jun 27, 2022 at 12:45 PM Markus Armbruster wrote:
>
> Kevin Wolf writes:
>
> > From: Xie Yongji
> >
> > VDUSE [1] is a linux framework that makes it possible to implement
> > software-emulated vDPA devices in userspace. This adds a library
> > as
In vduse_name_is_valid(), we actually check whether
the name is invalid or not. So let's change the
function name to vduse_name_is_invalid() to match
the behavior.
Signed-off-by: Xie Yongji
---
subprojects/libvduse/libvduse.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
This series fixes some issues reported by coverity.
Patch 1 fixes an incorrect function name.
Patch 2 fixes Coverity CID 1490224.
Patch 3 fixes Coverity CID 1490226, 1490223.
Patch 4 fixes Coverity CID 1490222, 1490227.
Xie Yongji (4):
libvduse: Fix the incorrect function name
libvduse
y() with strncpy() to fix the coverity
complaint.
Fixes: Coverity CID 1490224
Signed-off-by: Xie Yongji
---
subprojects/libvduse/libvduse.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/subprojects/libvduse/libvduse.c b/subprojects/libvduse/libvduse.c
index 6374933881..1e3622
Coverity pointed out (CID 1490222, 1490227) that we called
ioctl somewhere without checking the return value. This
patch fixes these issues.
Fixes: Coverity CID 1490222, 1490227
Signed-off-by: Xie Yongji
---
subprojects/libvduse/libvduse.c | 10 --
1 file changed, 8 insertions(+), 2
The value passed to strerror() should be positive.
So let's fix it.
Fixes: Coverity CID 1490226, 1490223
Signed-off-by: Xie Yongji
---
subprojects/libvduse/libvduse.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/subprojects/libvduse/libvduse.c b/subprojects/lib
201 - 300 of 639 matches
Mail list logo
