sysbus_mmio_get_region(s, 0));
sysbus_connect_irq(s, 0, mpic[3]);
}
Thanks
Simen
于 2013/09/10 16:23, Max Filippov 写道:
On Tue, Sep 10, 2013 at 11:25 AM, Xie Xianshan wrote:
hi everyone,
I`m getting the nobody cared disabling IRQ error, when i raised external
interrupts I
properties and linux driver
for this device.
By the way, how did you finally fix your problem?
Thanks,
Simen
于 2013/09/11 17:29, Max Filippov 写道:
On Wed, Sep 11, 2013 at 12:12 PM, Xie Xianshan wrote:
I want to add a new device "fpga" for e500, and trigger an interrupt IRQ3
Dear Max,
> Does it mean an IRQ to be edge-triggered?
No, it is a level-sensitive and active-high interrupt.
This is why i tried to use qemu_irq_raise() to trigger IRQ.
Thanks,
Simen
Hi Max,
Thanks for your patience and help.
I`ve tried to do what you said, but the problem doe
On 03/06/2016 01:27 AM, Max Reitz wrote:
Sorry that I wasn't so pedantic last time; or maybe I should rather be
sorry that I'm so pedantic this time.
Hi Max
Welcome all your comments : )
On 16.02.2016 10:37, Changlong Xie wrote:
From: Wen Congyang
In some cases, we want
On 03/06/2016 02:13 AM, Max Reitz wrote:
On 16.02.2016 10:37, Changlong Xie wrote:
From: Wen Congyang
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
---
block.c | 8 ++--
block/quorum.c| 122
On 03/06/2016 02:33 AM, Max Reitz wrote:
On 16.02.2016 10:37, Changlong Xie wrote:
From: Wen Congyang
The new QMP command name is x-blockdev-change. It's just for adding/removing
quorum's child now, and doesn't support all kinds of children, all kinds of
operations, nor all bl
t;name + 9, &endptr, 10);
assert(index >= 0 && !*endptr);
Still incorrect; you aren't handling errno properly for detecting all
errors. Even better is to use qemu_strtoul(), which already handles
proper error detection.
Will fix this in next version, thanks for pointing it out.
Thanks
-Xie
= qemu_strtoul(child->name + 9, &endptr, 10, &value);
if (!rc) {
assert(value <= INT_MAX);
index = value;
} else {
error_setg_errno(errp, -rc, "Failed to parse value '%s'",
child->name + 9);
return;
}
Thanks
-Xie
Max
On 03/05/2016 12:13 AM, Stefan Hajnoczi wrote:
On Fri, Feb 05, 2016 at 12:18:06PM +0800, Changlong Xie wrote:
diff --git a/replication.h b/replication.h
new file mode 100644
index 000..faea649
--- /dev/null
+++ b/replication.h
@@ -0,0 +1,53 @@
+/*
+ * Replication filter
+ *
+ * Copyright (c
On 03/05/2016 01:39 AM, Stefan Hajnoczi wrote:
On Fri, Feb 05, 2016 at 12:18:07PM +0800, Changlong Xie wrote:
+static void replication_start(ReplicationState *rs, ReplicationMode mode,
+ Error **errp)
+{
+BlockDriverState *bs = rs->opa
On 03/05/2016 01:53 AM, Stefan Hajnoczi wrote:
On Fri, Feb 05, 2016 at 12:18:07PM +0800, Changlong Xie wrote:
+static void secondary_do_checkpoint(BDRVReplicationState *s, Error **errp)
+{
+Error *local_err = NULL;
+int ret;
+
+if (!s->secondary_disk->bs->job) {
+e
On 03/05/2016 01:39 AM, Stefan Hajnoczi wrote:
On Fri, Feb 05, 2016 at 12:18:07PM +0800, Changlong Xie wrote:
+static void replication_start(ReplicationState *rs, ReplicationMode mode,
+ Error **errp)
+{
+BlockDriverState *bs = rs->opa
From: Wen Congyang
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
---
block.c | 8 ++--
block/quorum.c| 123 +-
include/block/block.h | 4 ++
3 files
ChangLog:
v10~v11:
1. Rebase to the newest codes
2. Address comment from Max
Don't use contractions in error messages,
p1: Remove R-Bs, and use "BdrvChild *child" in bdrv_del_child
p2: Fix error logic in get_new_child_index/remove_child_index, and prefect
child->name parsing
p3: Make bdrv_find_chil
From: Wen Congyang
In some cases, we want to take a quorum child offline, and take
another child online.
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
---
block.c | 49
: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
---
blockdev.c | 55
qapi/block-core.json | 32 ++
qmp-commands.hx | 54 +++
3 fil
On 03/05/2016 01:53 AM, Stefan Hajnoczi wrote:
On Fri, Feb 05, 2016 at 12:18:07PM +0800, Changlong Xie wrote:
+static void secondary_do_checkpoint(BDRVReplicationState *s, Error **errp)
+{
+Error *local_err = NULL;
+int ret;
+
+if (!s->secondary_disk->bs->job) {
+e
On 03/10/2016 02:11 AM, Max Reitz wrote:
On 09.03.2016 04:51, Changlong Xie wrote:
From: Wen Congyang
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
---
block.c | 8 ++--
block/quorum.c| 123
ChangLog:
v11~v12:
1. Address comments from Max
p1. Add R-B
p2. Add R-B, remove unnecessary "endptr" "value"
p3. Add R-B
v10~v11:
1. Rebase to the newest codes
2. Address comment from Max
Don't use contractions in error messages,
p1: Remove R-Bs, and use "BdrvChild *child" in bdrv_del_child
p2: Fi
From: Wen Congyang
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
Reviewed-by: Max Reitz
---
block.c | 8 ++--
block/quorum.c| 121 +-
include/block/block.h
From: Wen Congyang
In some cases, we want to take a quorum child offline, and take
another child online.
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
Reviewed-by: Max Reitz
---
block.c | 49
: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
Reviewed-by: Max Reitz
---
blockdev.c | 55
qapi/block-core.json | 32 ++
qmp-commands.hx | 54 +++
1. suspend both primay vm and secondary vm
2. sync the state
3. resume both primary vm and secondary vm
In such case, we need to update all devices's state in any time.
Signed-off-by: Wen Congyang
Signed-off-by: Changlong Xie
---
migration/savevm.c | 36 +++
On 03/10/2016 10:57 PM, Alberto Garcia wrote:
On Thu 10 Mar 2016 03:49:39 AM CET, Changlong Xie wrote:
From: Wen Congyang
In some cases, we want to take a quorum child offline, and take
another child online.
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
On 03/11/2016 04:31 AM, Eric Blake wrote:
On 03/10/2016 03:23 AM, Changlong Xie wrote:
From: Wen Congyang
Introduce a "xen-load-devices-state" QAPI command that can be used to load
the state of all devices, but not the RAM or the block devices of the
VM.
We only have hmp comma
From: Wen Congyang
Signed-off-by: Wen Congyang
Signed-off-by: Changlong Xie
---
block.c | 18 ++
1 file changed, 18 insertions(+)
diff --git a/block.c b/block.c
index 0e165f9..c78cf47 100644
--- a/block.c
+++ b/block.c
@@ -1273,6 +1273,24 @@ void bdrv_set_backing_hd
From: Wen Congyang
Auto complete mirror job in background to prevent from
blocking synchronously
Signed-off-by: Wen Congyang
Signed-off-by: Changlong Xie
---
block/mirror.c| 13 +
blockdev.c| 2 +-
include/block/block_int.h | 3 ++-
qemu-img.c
AioContext
4. Add a testcase to test new hbitmap API
V2:
1. Redesign the secondary qemu(use image-fleecing)
2. Use Error objects to return error message
3. Address the comments from Max Reitz and Eric Blake
Changlong Xie (1):
Introduce new APIs to do replication operation
Wen Congyang (7):
unblock b
From: Wen Congyang
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
---
block/backup.c| 15 +++
include/block/block_int.h | 2 ++
2 files changed, 17 insertions(+)
diff --git a/block/backup.c b/block
From: Wen Congyang
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
Reviewed-by: Eric Blake
---
qapi/block-core.json | 20 ++--
1 file changed, 18 insertions(+), 2 deletions(-)
diff --git a/qapi/block-core.json b
From: Wen Congyang
Some programs that add a dependency on it will use
the block layer directly.
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Jeff Cody
---
block/Makefile.objs | 2
From: Wen Congyang
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
---
docs/block-replication.txt | 238 +
1 file changed, 238 insertions(+)
create mode 100644 docs/block
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
---
Makefile.objs| 1 +
qapi/block-core.json | 13
replication.c| 94 +++
replication.h| 175
From: Wen Congyang
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
---
block/Makefile.objs | 1 +
block/replication.c | 619
2 files changed, 620 insertions(+)
create mode
On 03/11/2016 08:21 PM, Alberto Garcia wrote:
On Thu 10 Mar 2016 03:49:40 AM CET, Changlong Xie wrote:
@@ -81,6 +82,8 @@ typedef struct BDRVQuorumState {
bool rewrite_corrupted;/* true if the driver must rewrite-on-read
corrupted
* block if Quorum is reached
k it's a good idea to leave it initialized in
case we change that in the future.
Yes.
And now that we're at it, shouldn't we call quorum_report_bad() in FIFO
mode as well? Or is there any reason not to do it?
IMO, no reason not to do it.
Thanks
-Xie
Berto
On 03/11/2016 08:21 PM, Alberto Garcia wrote:
On Thu 10 Mar 2016 03:49:40 AM CET, Changlong Xie wrote:
@@ -81,6 +82,8 @@ typedef struct BDRVQuorumState {
bool rewrite_corrupted;/* true if the driver must rewrite-on-read
corrupted
* block if Quorum is reached
Changelog
v2:
1. Rebased to the lastest code
2. Addressed on Eric's comments, fixed coding style
Wen Congyang (1):
Introduce "xen-load-devices-state"
migration/savevm.c | 36
qapi-schema.json | 14 ++
qmp-commands.hx| 27 ++
1. suspend both primary vm and secondary vm
2. sync the state
3. resume both primary vm and secondary vm
In such case, we need to update all devices' state in any time.
Signed-off-by: Wen Congyang
Signed-off-by: Changlong Xie
---
migration/savevm.c | 36 +++
This patch is needed by COLO Xen, More detail please ref:
http://osdir.com/ml/general/2016-03/msg04860.html
Thank
-Xie
On 03/14/2016 04:03 PM, Changlong Xie wrote:
Changelog
v2:
1. Rebased to the lastest code
2. Addressed on Eric's comments, fixed coding style
Wen Congya
Commit 3514552e added a new test, but did not mark it for
exclusion in .gitignore.
Signed-off-by: Changlong Xie
---
tests/.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/.gitignore b/tests/.gitignore
index b7bf13e..898a35f 100644
--- a/tests/.gitignore
+++ b/tests
On 04/05/2016 02:35 PM, Changlong Xie wrote:
Commit 3514552e added a new test, but did not mark it for
exclusion in .gitignore.
Signed-off-by: Changlong Xie
---
tests/.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/.gitignore b/tests/.gitignore
index b7bf13e..898a35f
Commit 3514552e added a new test, but did not mark it for
exclusion in .gitignore.
Signed-off-by: Changlong Xie
Reviewed-by: Eric Blake
---
tests/.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/.gitignore b/tests/.gitignore
index 6479b79..a303aaa 100644
--- a/tests
voke
qio_channel_wait() and the guest will *HUNG* until i kill
nbd server service.
It's easy to reproduce. My question: If the scenario i describe above is
what we expected?
Thanks
-Xie
many bytes have been filled in s->reply. Then a reply can be filled
by multiple separate invocations of nbd_reply_ready and the
qio_channel_wait() call can be removed completely. Something to
consider for 2.7...
Reported-by: Changlong Xie
Cc: Daniel P. Berrange
Signed-off-by: Paolo Bonzini
Changelog
v4:
1. Rebased to the lastest code
v3:
1. Addressed on David's commets, fix a bug
v2:
1. Rebased to the lastest code
2. Addressed on Eric's comments, fixed coding style
Wen Congyang (1):
Introduce "xen-load-devices-state"
migration/savevm.c | 36
1. suspend both primary vm and secondary vm
2. sync the state
3. resume both primary vm and secondary vm
In such case, we need to update all devices' state in any time.
Signed-off-by: Wen Congyang
Signed-off-by: Changlong Xie
---
migration/savevm.c | 36 +++
as Wen said:
http://lists.nongnu.org/archive/html/qemu-devel/2016-04/msg00898.html
Everytime we try to remove a children.i (i < n-1, so it's not the last
element of the array[n]), we have to rename children.{i+1, n-1} to
children.{i, n-2}.
Thanks
-Xie
I also have another (not
From: Wen Congyang
Signed-off-by: Wen Congyang
Signed-off-by: Changlong Xie
---
block.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/block.c b/block.c
index 4bdc6b3..1e5a4fd 100644
--- a/block.c
+++ b/block.c
@@ -1255,6 +1255,23 @@ void bdrv_set_backing_hd
From: Wen Congyang
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
Reviewed-by: Eric Blake
---
qapi/block-core.json | 20 ++--
1 file changed, 18 insertions(+), 2 deletions(-)
diff --git a/qapi/block-core.json b
From: Wen Congyang
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
---
docs/block-replication.txt | 239 +
1 file changed, 239 insertions(+)
create mode 100644 docs/block
From: Wen Congyang
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
---
block/Makefile.objs | 1 +
block/replication.c | 622 +++
tests/.gitignore | 1 +
tests
From: Wen Congyang
Some programs that add a dependency on it will use
the block layer directly.
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Jeff Cody
---
block/Makefile.objs | 2
qemu(use image-fleecing)
2. Use Error objects to return error message
3. Address the comments from Max Reitz and Eric Blake
Changlong Xie (1):
Introduce new APIs to do replication operation
Wen Congyang (7):
unblock backup operations in backing file
Backup: clear all bitmap when doing blo
From: Wen Congyang
Auto complete mirror job in background to prevent from
blocking synchronously
Signed-off-by: Wen Congyang
Signed-off-by: Changlong Xie
---
block/mirror.c| 13 +
blockdev.c| 2 +-
include/block/block_int.h | 3 ++-
qemu-img.c
From: Wen Congyang
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
---
block/backup.c| 17 +
include/block/block_int.h | 2 ++
2 files changed, 19 insertions(+)
diff --git a/block/backup.c b/block
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
---
Makefile.objs| 1 +
qapi/block-core.json | 13
replication.c| 96
replication.h| 175
ChangLog:
v13:
1. Rebase to the newest codes
2. Address commets from Betro and Max
p1. Add R-B, fix incorrect syntax
p2. Add missing "qemu/cutils.h" since 2.6, and rewrite quorum_add/del_child
p3. Remove unnecessary "id", add "since 2.7"
v11~v12:
1. Address comments from Max
p1. Add R-B
p2. Add R-B
From: Wen Congyang
In some cases, we want to take a quorum child offline, and take
another child online.
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
Reviewed-by: Max Reitz
Reviewed-by: Alberto Garcia
---
block.c
: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
Reviewed-by: Max Reitz
Reviewed-by: Alberto Garcia
---
blockdev.c | 55
qapi/block-core.json | 32 ++
qmp-comman
From: Wen Congyang
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
---
block.c | 8 +++---
block/quorum.c| 78 +--
include/block/block.h | 4 +++
3 files
On 04/13/2016 08:47 PM, Stefan Hajnoczi wrote:
On Mon, Apr 11, 2016 at 04:22:57PM +0800, Changlong Xie wrote:
+/*
+ * The caller of the function MUST make sure vm stopped
+ */
+void replication_start_all(ReplicationMode mode, Error **errp)
+{
+ReplicationState *rs, *next
the code with this path?
Thanks
-Xie
On 04/13/2016 09:02 PM, Stefan Hajnoczi wrote:
On Mon, Apr 11, 2016 at 04:22:58PM +0800, Changlong Xie wrote:
+static coroutine_fn int replication_co_writev(BlockDriverState *bs,
+ int64_t sector_num
Qemu does not support "info blockstats" now.
Signed-off-by: Changlong Xie
---
block/block-backend.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/block-backend.c b/block/block-backend.c
index d74f670..05d5d09 100644
--- a/block/block-backend.c
+++ b/b
Changlong Xie (2):
block: fix description of @stats
block: remove redundant stats of block_acct_start()
block/accounting.c | 4 ++--
block/block-backend.c | 2 +-
dma-helpers.c | 2 +-
hw/block/nvme.c| 3 +--
hw/block/virtio-blk.c | 6
Signed-off-by: Changlong Xie
---
block/accounting.c | 4 ++--
dma-helpers.c | 2 +-
hw/block/nvme.c| 3 +--
hw/block/virtio-blk.c | 6 ++
hw/block/xen_disk.c| 6 ++
hw/ide/atapi.c | 12
hw/ide/core.c
From: Wen Congyang
Some programs that add a dependency on it will use
the block layer directly.
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Jeff Cody
---
block/Makefile.objs | 2
From: Wen Congyang
Auto complete mirror job in background to prevent from
blocking synchronously
Signed-off-by: Wen Congyang
Signed-off-by: Changlong Xie
---
block/mirror.c| 13 +
blockdev.c| 2 +-
include/block/block_int.h | 3 ++-
qemu-img.c
From: Wen Congyang
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
---
block/backup.c| 17 +
include/block/block_int.h | 2 ++
2 files changed, 19 insertions(+)
diff --git a/block/backup.c b/block
From: Wen Congyang
Signed-off-by: Wen Congyang
Signed-off-by: Changlong Xie
---
block.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/block.c b/block.c
index 4bdc6b3..1e5a4fd 100644
--- a/block.c
+++ b/block.c
@@ -1255,6 +1255,23 @@ void bdrv_set_backing_hd
ive disk, hidden disk and nbd target uses the same AioContext
4. Add a testcase to test new hbitmap API
V2:
1. Redesign the secondary qemu(use image-fleecing)
2. Use Error objects to return error message
3. Address the comments from Max Reitz and Eric Blake
Changlong Xie (1):
Introduce new APIs to do re
From: Wen Congyang
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
---
docs/block-replication.txt | 239 +
1 file changed, 239 insertions(+)
create mode 100644 docs/block
From: Wen Congyang
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
---
block/Makefile.objs | 1 +
block/replication.c | 625 +++
tests/.gitignore | 1 +
tests
From: Wen Congyang
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
Reviewed-by: Eric Blake
---
qapi/block-core.json | 20 ++--
1 file changed, 18 insertions(+), 2 deletions(-)
diff --git a/qapi/block-core.json b
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
---
Makefile.objs| 1 +
qapi/block-core.json | 13
replication.c| 105 ++
replication.h| 176
On 04/17/2016 05:59 AM, Max Reitz wrote:
On 15.04.2016 07:46, Changlong Xie wrote:
Qemu does not support "info blockstats" now.
It doesn't? Mine is more than happy to accept that command:
$ x86_64-softmmu/qemu-system-x86_64 -nodefaults \
-drive if=none,id=drv0
On 04/17/2016 06:11 AM, Max Reitz wrote:
I'd like to say that my inertia is keeping me from applying this patch,
but I'd feel like a hypocrite for saying that, considering it would have
taken much less time than writing this response...
Pls feel free to ignore this patch, i just went through ke
On 04/19/2016 09:42 AM, Fam Zheng wrote:
Currently we only recurse to bs->file, which will miss the children in quorum
and VMDK.
Recurse into the whole subtree to avoid that.
Signed-off-by: Fam Zheng
---
block.c | 20 ++--
1 file changed, 14 insertions(+), 6 deletions(-)
di
ping...
On 04/11/2016 11:56 AM, Changlong Xie wrote:
Changelog
v4:
1. Rebased to the lastest code
v3:
1. Addressed on David's commets, fix a bug
v2:
1. Rebased to the lastest code
2. Addressed on Eric's comments, fixed coding style
Wen Congyang (1):
Introduce "xen-loa
ping...
On 04/13/2016 04:33 PM, Changlong Xie wrote:
From: Wen Congyang
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
---
block.c | 8 +++---
block/quorum.c| 78
The main migration code for COLO looks OK now,and they depend on my
block part. So i'd like to ping here.
Thanks
-Xie
On 04/15/2016 04:10 PM, Changlong Xie wrote:
Block replication is a very important feature which is used for
continuous checkpoints(for example: COLO).
You ca
id *colo_process_incoming_thread(void *opaque)
}
out:
+ vmstate_loading = false;
An redundant blank.
It seems there are many coding style issues in whole colo.c that you
did't notice.
Thanks
-Xie
/* Throw the unreported error message after exited from loop */
if (local_err) {
error_report_err(local_err);
On 04/15/2016 04:10 PM, Changlong Xie wrote:
From: Wen Congyang
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
---
block/Makefile.objs | 1 +
block/replication.c | 625
On 05/06/2016 11:20 PM, Max Reitz wrote:
On 13.04.2016 10:33, Changlong Xie wrote:
From: Wen Congyang
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
---
block.c | 8 +++---
block/quorum.c| 78
On 05/09/2016 11:52 PM, Alberto Garcia wrote:
On Wed 13 Apr 2016 10:33:08 AM CEST, Changlong Xie wrote:
Sorry for the late reply!
Never mind : )
The patch looks good, I have some additional comments on top of what Max
Wrote, nothing serious though :)
@@ -67,6 +68,9 @@ typedef struct
From: Wen Congyang
In some cases, we want to take a quorum child offline, and take
another child online.
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
Reviewed-by: Max Reitz
Reviewed-by: Alberto Garcia
---
block.c
ChangLog:
v14:
1. Address commets from Betro and Max
p2: introduce bdrv_drained_begin/end, rename last_index, remove redundant
assert codes
v13:
1. Rebase to the newest codes
2. Address commets from Betro and Max
p1. Add R-B, fix incorrect syntax
p2. Add missing "qemu/cutils.h" since 2.6, and rewri
: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
Reviewed-by: Max Reitz
Reviewed-by: Alberto Garcia
---
blockdev.c | 55
qapi/block-core.json | 32 ++
qmp-comman
From: Wen Congyang
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
---
block.c | 8 +++---
block/quorum.c| 78 +--
include/block/block.h | 4 +++
3 files
Signed-off-by: Changlong Xie
---
util/rfifolock.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/util/rfifolock.c b/util/rfifolock.c
index c22f5fe..f406cc1 100644
--- a/util/rfifolock.c
+++ b/util/rfifolock.c
@@ -50,6 +50,7 @@ void rfifolock_lock(RFifoLock *r)
if (r->nesting
On 05/06/2016 11:46 PM, Stefan Hajnoczi wrote:
On Fri, Apr 15, 2016 at 04:10:37PM +0800, Changlong Xie wrote:
+static void replication_close(BlockDriverState *bs)
+{
+BDRVReplicationState *s = bs->opaque;
+
+if (s->mode == REPLICATION_MODE_SECONDARY) {
+g_free(s-&
On 05/10/2016 05:38 PM, Denis V. Lunev wrote:
On 05/10/2016 12:16 PM, Changlong Xie wrote:
Signed-off-by: Changlong Xie
---
util/rfifolock.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/util/rfifolock.c b/util/rfifolock.c
index c22f5fe..f406cc1 100644
--- a/util/rfifolock.c
+++ b
Signed-off-by: Changlong Xie
---
util/rfifolock.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/util/rfifolock.c b/util/rfifolock.c
index c22f5fe..084c2f0 100644
--- a/util/rfifolock.c
+++ b/util/rfifolock.c
@@ -58,9 +58,9 @@ void rfifolock_lock(RFifoLock *r
On 03/17/2016 02:48 AM, Jeff Cody wrote:
On Fri, Mar 11, 2016 at 06:34:09PM +0800, Changlong Xie wrote:
From: Wen Congyang
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Changlong Xie
---
block/backup.c| 15
ping..
On 03/14/2016 04:03 PM, Changlong Xie wrote:
From: Wen Congyang
Introduce a "xen-load-devices-state" QAPI command that can be used to
load the state of all devices, but not the RAM or the block devices of
the VM.
We only have hmp commands savevm/loadvm, and qmp command
On 03/22/2016 08:22 PM, Dr. David Alan Gilbert wrote:
* Changlong Xie (xiecl.f...@cn.fujitsu.com) wrote:
From: Wen Congyang
Introduce a "xen-load-devices-state" QAPI command that can be used to
load the state of all devices, but not the RAM or the block devices of
the VM.
We onl
On 03/23/2016 05:41 PM, Dr. David Alan Gilbert wrote:
* Wen Congyang (we...@cn.fujitsu.com) wrote:
On 03/23/2016 04:56 PM, Dr. David Alan Gilbert wrote:
* Changlong Xie (xiecl.f...@cn.fujitsu.com) wrote:
On 03/22/2016 08:22 PM, Dr. David Alan Gilbert wrote:
* Changlong Xie (xiecl.f
Changelog
v3:
1. Addressed on David's commets, fix a bug
v2:
1. Rebased to the lastest code
2. Addressed on Eric's comments, fixed coding style
Wen Congyang (1):
Introduce "xen-load-devices-state"
migration/savevm.c | 36
qapi-schema.json | 14 +++
1. suspend both primary vm and secondary vm
2. sync the state
3. resume both primary vm and secondary vm
In such case, we need to update all devices' state in any time.
Signed-off-by: Wen Congyang
Signed-off-by: Changlong Xie
---
migration/savevm.c | 36 +++
101 - 200 of 639 matches
Mail list logo