Re: [Qemu-devel] Disabling IRQ error

2013-09-11 Thread Xie Xianshan
sysbus_mmio_get_region(s, 0)); sysbus_connect_irq(s, 0, mpic[3]); } Thanks Simen 于 2013/09/10 16:23, Max Filippov 写道: On Tue, Sep 10, 2013 at 11:25 AM, Xie Xianshan wrote: hi everyone, I`m getting the nobody cared disabling IRQ error, when i raised external interrupts I

Re: [Qemu-devel] Disabling IRQ error

2013-09-12 Thread Xie Xianshan
properties and linux driver for this device. By the way, how did you finally fix your problem? Thanks, Simen 于 2013/09/11 17:29, Max Filippov 写道: On Wed, Sep 11, 2013 at 12:12 PM, Xie Xianshan wrote: I want to add a new device "fpga" for e500, and trigger an interrupt IRQ3

Re: [Qemu-devel] Disabling IRQ error

2013-09-12 Thread Xie Xianshan
Dear Max, > Does it mean an IRQ to be edge-triggered? No, it is a level-sensitive and active-high interrupt. This is why i tried to use qemu_irq_raise() to trigger IRQ. Thanks, Simen Hi Max, Thanks for your patience and help. I`ve tried to do what you said, but the problem doe

Re: [Qemu-devel] [PATCH v10 1/3] Add new block driver interface to add/delete a BDS's child

2016-03-06 Thread Changlong Xie
On 03/06/2016 01:27 AM, Max Reitz wrote: Sorry that I wasn't so pedantic last time; or maybe I should rather be sorry that I'm so pedantic this time. Hi Max Welcome all your comments : ) On 16.02.2016 10:37, Changlong Xie wrote: From: Wen Congyang In some cases, we want

Re: [Qemu-devel] [PATCH v10 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-03-07 Thread Changlong Xie
On 03/06/2016 02:13 AM, Max Reitz wrote: On 16.02.2016 10:37, Changlong Xie wrote: From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie --- block.c | 8 ++-- block/quorum.c| 122

Re: [Qemu-devel] [PATCH v10 3/3] qmp: add monitor command to add/remove a child

2016-03-07 Thread Changlong Xie
On 03/06/2016 02:33 AM, Max Reitz wrote: On 16.02.2016 10:37, Changlong Xie wrote: From: Wen Congyang The new QMP command name is x-blockdev-change. It's just for adding/removing quorum's child now, and doesn't support all kinds of children, all kinds of operations, nor all bl

Re: [Qemu-devel] [PATCH v10 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-03-07 Thread Changlong Xie
t;name + 9, &endptr, 10); assert(index >= 0 && !*endptr); Still incorrect; you aren't handling errno properly for detecting all errors. Even better is to use qemu_strtoul(), which already handles proper error detection. Will fix this in next version, thanks for pointing it out. Thanks -Xie

Re: [Qemu-devel] [PATCH v10 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-03-07 Thread Changlong Xie
= qemu_strtoul(child->name + 9, &endptr, 10, &value); if (!rc) { assert(value <= INT_MAX); index = value; } else { error_setg_errno(errp, -rc, "Failed to parse value '%s'", child->name + 9); return; } Thanks -Xie Max

Re: [Qemu-devel] [Qemu-block] [PATCH v15 7/9] Introduce new APIs to do replication operation

2016-03-07 Thread Changlong Xie
On 03/05/2016 12:13 AM, Stefan Hajnoczi wrote: On Fri, Feb 05, 2016 at 12:18:06PM +0800, Changlong Xie wrote: diff --git a/replication.h b/replication.h new file mode 100644 index 000..faea649 --- /dev/null +++ b/replication.h @@ -0,0 +1,53 @@ +/* + * Replication filter + * + * Copyright (c

Re: [Qemu-devel] [PATCH v15 8/9] Implement new driver for block replication

2016-03-07 Thread Changlong Xie
On 03/05/2016 01:39 AM, Stefan Hajnoczi wrote: On Fri, Feb 05, 2016 at 12:18:07PM +0800, Changlong Xie wrote: +static void replication_start(ReplicationState *rs, ReplicationMode mode, + Error **errp) +{ +BlockDriverState *bs = rs->opa

Re: [Qemu-devel] [PATCH v15 8/9] Implement new driver for block replication

2016-03-07 Thread Changlong Xie
On 03/05/2016 01:53 AM, Stefan Hajnoczi wrote: On Fri, Feb 05, 2016 at 12:18:07PM +0800, Changlong Xie wrote: +static void secondary_do_checkpoint(BDRVReplicationState *s, Error **errp) +{ +Error *local_err = NULL; +int ret; + +if (!s->secondary_disk->bs->job) { +e

Re: [Qemu-devel] [PATCH v15 8/9] Implement new driver for block replication

2016-03-08 Thread Changlong Xie
On 03/05/2016 01:39 AM, Stefan Hajnoczi wrote: On Fri, Feb 05, 2016 at 12:18:07PM +0800, Changlong Xie wrote: +static void replication_start(ReplicationState *rs, ReplicationMode mode, + Error **errp) +{ +BlockDriverState *bs = rs->opa

[Qemu-devel] [PATCH v11 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-03-08 Thread Changlong Xie
From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie --- block.c | 8 ++-- block/quorum.c| 123 +- include/block/block.h | 4 ++ 3 files

[Qemu-devel] [PATCH v11 0/3] qapi: child add/delete support

2016-03-08 Thread Changlong Xie
ChangLog: v10~v11: 1. Rebase to the newest codes 2. Address comment from Max Don't use contractions in error messages, p1: Remove R-Bs, and use "BdrvChild *child" in bdrv_del_child p2: Fix error logic in get_new_child_index/remove_child_index, and prefect child->name parsing p3: Make bdrv_find_chil

[Qemu-devel] [PATCH v11 1/3] Add new block driver interface to add/delete a BDS's child

2016-03-08 Thread Changlong Xie
From: Wen Congyang In some cases, we want to take a quorum child offline, and take another child online. Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie --- block.c | 49

[Qemu-devel] [PATCH v11 3/3] qmp: add monitor command to add/remove a child

2016-03-08 Thread Changlong Xie
: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie --- blockdev.c | 55 qapi/block-core.json | 32 ++ qmp-commands.hx | 54 +++ 3 fil

Re: [Qemu-devel] [PATCH v15 8/9] Implement new driver for block replication

2016-03-09 Thread Changlong Xie
On 03/05/2016 01:53 AM, Stefan Hajnoczi wrote: On Fri, Feb 05, 2016 at 12:18:07PM +0800, Changlong Xie wrote: +static void secondary_do_checkpoint(BDRVReplicationState *s, Error **errp) +{ +Error *local_err = NULL; +int ret; + +if (!s->secondary_disk->bs->job) { +e

Re: [Qemu-devel] [PATCH v11 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-03-09 Thread Changlong Xie
On 03/10/2016 02:11 AM, Max Reitz wrote: On 09.03.2016 04:51, Changlong Xie wrote: From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie --- block.c | 8 ++-- block/quorum.c| 123

[Qemu-devel] [PATCH v12 0/3] qapi: child add/delete support

2016-03-09 Thread Changlong Xie
ChangLog: v11~v12: 1. Address comments from Max p1. Add R-B p2. Add R-B, remove unnecessary "endptr" "value" p3. Add R-B v10~v11: 1. Rebase to the newest codes 2. Address comment from Max Don't use contractions in error messages, p1: Remove R-Bs, and use "BdrvChild *child" in bdrv_del_child p2: Fi

[Qemu-devel] [PATCH v12 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-03-09 Thread Changlong Xie
From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie Reviewed-by: Max Reitz --- block.c | 8 ++-- block/quorum.c| 121 +- include/block/block.h

[Qemu-devel] [PATCH v12 1/3] Add new block driver interface to add/delete a BDS's child

2016-03-09 Thread Changlong Xie
From: Wen Congyang In some cases, we want to take a quorum child offline, and take another child online. Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie Reviewed-by: Max Reitz --- block.c | 49

[Qemu-devel] [PATCH v12 3/3] qmp: add monitor command to add/remove a child

2016-03-09 Thread Changlong Xie
: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie Reviewed-by: Max Reitz --- blockdev.c | 55 qapi/block-core.json | 32 ++ qmp-commands.hx | 54 +++

[Qemu-devel] [PATCH] Introduce "xen-load-devices-state"

2016-03-10 Thread Changlong Xie
1. suspend both primay vm and secondary vm 2. sync the state 3. resume both primary vm and secondary vm In such case, we need to update all devices's state in any time. Signed-off-by: Wen Congyang Signed-off-by: Changlong Xie --- migration/savevm.c | 36 +++

Re: [Qemu-devel] [PATCH v12 1/3] Add new block driver interface to add/delete a BDS's child

2016-03-10 Thread Changlong Xie
On 03/10/2016 10:57 PM, Alberto Garcia wrote: On Thu 10 Mar 2016 03:49:39 AM CET, Changlong Xie wrote: From: Wen Congyang In some cases, we want to take a quorum child offline, and take another child online. Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei

Re: [Qemu-devel] [PATCH] Introduce "xen-load-devices-state"

2016-03-10 Thread Changlong Xie
On 03/11/2016 04:31 AM, Eric Blake wrote: On 03/10/2016 03:23 AM, Changlong Xie wrote: From: Wen Congyang Introduce a "xen-load-devices-state" QAPI command that can be used to load the state of all devices, but not the RAM or the block devices of the VM. We only have hmp comma

[Qemu-devel] [PATCH v16 1/8] unblock backup operations in backing file

2016-03-11 Thread Changlong Xie
From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: Changlong Xie --- block.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/block.c b/block.c index 0e165f9..c78cf47 100644 --- a/block.c +++ b/block.c @@ -1273,6 +1273,24 @@ void bdrv_set_backing_hd

[Qemu-devel] [PATCH v16 5/8] auto complete active commit

2016-03-11 Thread Changlong Xie
From: Wen Congyang Auto complete mirror job in background to prevent from blocking synchronously Signed-off-by: Wen Congyang Signed-off-by: Changlong Xie --- block/mirror.c| 13 + blockdev.c| 2 +- include/block/block_int.h | 3 ++- qemu-img.c

[Qemu-devel] [PATCH v16 0/8] Block replication for continuous checkpoints

2016-03-11 Thread Changlong Xie
AioContext 4. Add a testcase to test new hbitmap API V2: 1. Redesign the secondary qemu(use image-fleecing) 2. Use Error objects to return error message 3. Address the comments from Max Reitz and Eric Blake Changlong Xie (1): Introduce new APIs to do replication operation Wen Congyang (7): unblock b

[Qemu-devel] [PATCH v16 2/8] Backup: clear all bitmap when doing block checkpoint

2016-03-11 Thread Changlong Xie
From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie --- block/backup.c| 15 +++ include/block/block_int.h | 2 ++ 2 files changed, 17 insertions(+) diff --git a/block/backup.c b/block

[Qemu-devel] [PATCH v16 8/8] support replication driver in blockdev-add

2016-03-11 Thread Changlong Xie
From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie Reviewed-by: Eric Blake --- qapi/block-core.json | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/qapi/block-core.json b

[Qemu-devel] [PATCH v16 3/8] Link backup into block core

2016-03-11 Thread Changlong Xie
From: Wen Congyang Some programs that add a dependency on it will use the block layer directly. Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie Reviewed-by: Stefan Hajnoczi Reviewed-by: Jeff Cody --- block/Makefile.objs | 2

[Qemu-devel] [PATCH v16 4/8] docs: block replication's description

2016-03-11 Thread Changlong Xie
From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie --- docs/block-replication.txt | 238 + 1 file changed, 238 insertions(+) create mode 100644 docs/block

[Qemu-devel] [PATCH v16 6/8] Introduce new APIs to do replication operation

2016-03-11 Thread Changlong Xie
Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie --- Makefile.objs| 1 + qapi/block-core.json | 13 replication.c| 94 +++ replication.h| 175

[Qemu-devel] [PATCH v16 7/8] Implement new driver for block replication

2016-03-11 Thread Changlong Xie
From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie --- block/Makefile.objs | 1 + block/replication.c | 619 2 files changed, 620 insertions(+) create mode

Re: [Qemu-devel] [PATCH v12 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-03-13 Thread Changlong Xie
On 03/11/2016 08:21 PM, Alberto Garcia wrote: On Thu 10 Mar 2016 03:49:40 AM CET, Changlong Xie wrote: @@ -81,6 +82,8 @@ typedef struct BDRVQuorumState { bool rewrite_corrupted;/* true if the driver must rewrite-on-read corrupted * block if Quorum is reached

Re: [Qemu-devel] [PATCH] quorum: Fix crash in quorum_aio_cb()

2016-03-13 Thread Changlong Xie
k it's a good idea to leave it initialized in case we change that in the future. Yes. And now that we're at it, shouldn't we call quorum_report_bad() in FIFO mode as well? Or is there any reason not to do it? IMO, no reason not to do it. Thanks -Xie Berto

Re: [Qemu-devel] [PATCH v12 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-03-13 Thread Changlong Xie
On 03/11/2016 08:21 PM, Alberto Garcia wrote: On Thu 10 Mar 2016 03:49:40 AM CET, Changlong Xie wrote: @@ -81,6 +82,8 @@ typedef struct BDRVQuorumState { bool rewrite_corrupted;/* true if the driver must rewrite-on-read corrupted * block if Quorum is reached

[Qemu-devel] [PATCH v2 0/1] Introduce "xen-load-devices-state"

2016-03-14 Thread Changlong Xie
Changelog v2: 1. Rebased to the lastest code 2. Addressed on Eric's comments, fixed coding style Wen Congyang (1): Introduce "xen-load-devices-state" migration/savevm.c | 36 qapi-schema.json | 14 ++ qmp-commands.hx| 27 ++

[Qemu-devel] [PATCH v2 1/1] Introduce "xen-load-devices-state"

2016-03-14 Thread Changlong Xie
1. suspend both primary vm and secondary vm 2. sync the state 3. resume both primary vm and secondary vm In such case, we need to update all devices' state in any time. Signed-off-by: Wen Congyang Signed-off-by: Changlong Xie --- migration/savevm.c | 36 +++

Re: [Qemu-devel] [PATCH v2 0/1] Introduce "xen-load-devices-state"

2016-03-14 Thread Changlong Xie
This patch is needed by COLO Xen, More detail please ref: http://osdir.com/ml/general/2016-03/msg04860.html Thank -Xie On 03/14/2016 04:03 PM, Changlong Xie wrote: Changelog v2: 1. Rebased to the lastest code 2. Addressed on Eric's comments, fixed coding style Wen Congya

[Qemu-devel] [PATCH] tests: ignore test-logging

2016-04-04 Thread Changlong Xie
Commit 3514552e added a new test, but did not mark it for exclusion in .gitignore. Signed-off-by: Changlong Xie --- tests/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/.gitignore b/tests/.gitignore index b7bf13e..898a35f 100644 --- a/tests/.gitignore +++ b/tests

Re: [Qemu-devel] [PATCH] tests: ignore test-logging

2016-04-05 Thread Changlong Xie
On 04/05/2016 02:35 PM, Changlong Xie wrote: Commit 3514552e added a new test, but did not mark it for exclusion in .gitignore. Signed-off-by: Changlong Xie --- tests/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/.gitignore b/tests/.gitignore index b7bf13e..898a35f

[Qemu-devel] [PATCH V2] tests: ignore test-logging

2016-04-05 Thread Changlong Xie
Commit 3514552e added a new test, but did not mark it for exclusion in .gitignore. Signed-off-by: Changlong Xie Reviewed-by: Eric Blake --- tests/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/.gitignore b/tests/.gitignore index 6479b79..a303aaa 100644 --- a/tests

[Qemu-devel] Questions about nbd with QIOChannel

2016-04-07 Thread Changlong Xie
voke qio_channel_wait() and the guest will *HUNG* until i kill nbd server service. It's easy to reproduce. My question: If the scenario i describe above is what we expected? Thanks -Xie

Re: [Qemu-devel] [PATCH] nbd: do not hang nbd_wr_syncv if outside a coroutine and no available data

2016-04-07 Thread Changlong Xie
many bytes have been filled in s->reply. Then a reply can be filled by multiple separate invocations of nbd_reply_ready and the qio_channel_wait() call can be removed completely. Something to consider for 2.7... Reported-by: Changlong Xie Cc: Daniel P. Berrange Signed-off-by: Paolo Bonzini

[Qemu-devel] [PATCH v4 0/1] Introduce "xen-load-devices-state"

2016-04-10 Thread Changlong Xie
Changelog v4: 1. Rebased to the lastest code v3: 1. Addressed on David's commets, fix a bug v2: 1. Rebased to the lastest code 2. Addressed on Eric's comments, fixed coding style Wen Congyang (1): Introduce "xen-load-devices-state" migration/savevm.c | 36

[Qemu-devel] [PATCH v4 1/1] Introduce "xen-load-devices-state"

2016-04-10 Thread Changlong Xie
1. suspend both primary vm and secondary vm 2. sync the state 3. resume both primary vm and secondary vm In such case, we need to update all devices' state in any time. Signed-off-by: Wen Congyang Signed-off-by: Changlong Xie --- migration/savevm.c | 36 +++

Re: [Qemu-devel] [PATCH v12 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-04-10 Thread Changlong Xie
as Wen said: http://lists.nongnu.org/archive/html/qemu-devel/2016-04/msg00898.html Everytime we try to remove a children.i (i < n-1, so it's not the last element of the array[n]), we have to rename children.{i+1, n-1} to children.{i, n-2}. Thanks -Xie I also have another (not

[Qemu-devel] [PATCH v17 1/8] unblock backup operations in backing file

2016-04-11 Thread Changlong Xie
From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: Changlong Xie --- block.c | 17 + 1 file changed, 17 insertions(+) diff --git a/block.c b/block.c index 4bdc6b3..1e5a4fd 100644 --- a/block.c +++ b/block.c @@ -1255,6 +1255,23 @@ void bdrv_set_backing_hd

[Qemu-devel] [PATCH v17 8/8] support replication driver in blockdev-add

2016-04-11 Thread Changlong Xie
From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie Reviewed-by: Eric Blake --- qapi/block-core.json | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/qapi/block-core.json b

[Qemu-devel] [PATCH v17 4/8] docs: block replication's description

2016-04-11 Thread Changlong Xie
From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie --- docs/block-replication.txt | 239 + 1 file changed, 239 insertions(+) create mode 100644 docs/block

[Qemu-devel] [PATCH v17 7/8] Implement new driver for block replication

2016-04-11 Thread Changlong Xie
From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie --- block/Makefile.objs | 1 + block/replication.c | 622 +++ tests/.gitignore | 1 + tests

[Qemu-devel] [PATCH v17 3/8] Link backup into block core

2016-04-11 Thread Changlong Xie
From: Wen Congyang Some programs that add a dependency on it will use the block layer directly. Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie Reviewed-by: Stefan Hajnoczi Reviewed-by: Jeff Cody --- block/Makefile.objs | 2

[Qemu-devel] [PATCH v17 0/8] Block replication for continuous checkpoints

2016-04-11 Thread Changlong Xie
qemu(use image-fleecing) 2. Use Error objects to return error message 3. Address the comments from Max Reitz and Eric Blake Changlong Xie (1): Introduce new APIs to do replication operation Wen Congyang (7): unblock backup operations in backing file Backup: clear all bitmap when doing blo

[Qemu-devel] [PATCH v17 5/8] auto complete active commit

2016-04-11 Thread Changlong Xie
From: Wen Congyang Auto complete mirror job in background to prevent from blocking synchronously Signed-off-by: Wen Congyang Signed-off-by: Changlong Xie --- block/mirror.c| 13 + blockdev.c| 2 +- include/block/block_int.h | 3 ++- qemu-img.c

[Qemu-devel] [PATCH v17 2/8] Backup: clear all bitmap when doing block checkpoint

2016-04-11 Thread Changlong Xie
From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie --- block/backup.c| 17 + include/block/block_int.h | 2 ++ 2 files changed, 19 insertions(+) diff --git a/block/backup.c b/block

[Qemu-devel] [PATCH v17 6/8] Introduce new APIs to do replication operation

2016-04-11 Thread Changlong Xie
Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie --- Makefile.objs| 1 + qapi/block-core.json | 13 replication.c| 96 replication.h| 175

[Qemu-devel] [PATCH v13 0/3] qapi: child add/delete support

2016-04-13 Thread Changlong Xie
ChangLog: v13: 1. Rebase to the newest codes 2. Address commets from Betro and Max p1. Add R-B, fix incorrect syntax p2. Add missing "qemu/cutils.h" since 2.6, and rewrite quorum_add/del_child p3. Remove unnecessary "id", add "since 2.7" v11~v12: 1. Address comments from Max p1. Add R-B p2. Add R-B

[Qemu-devel] [PATCH v13 1/3] Add new block driver interface to add/delete a BDS's child

2016-04-13 Thread Changlong Xie
From: Wen Congyang In some cases, we want to take a quorum child offline, and take another child online. Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie Reviewed-by: Max Reitz Reviewed-by: Alberto Garcia --- block.c

[Qemu-devel] [PATCH v13 3/3] qmp: add monitor command to add/remove a child

2016-04-13 Thread Changlong Xie
: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie Reviewed-by: Max Reitz Reviewed-by: Alberto Garcia --- blockdev.c | 55 qapi/block-core.json | 32 ++ qmp-comman

[Qemu-devel] [PATCH v13 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-04-13 Thread Changlong Xie
From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie --- block.c | 8 +++--- block/quorum.c| 78 +-- include/block/block.h | 4 +++ 3 files

Re: [Qemu-devel] [PATCH v17 6/8] Introduce new APIs to do replication operation

2016-04-13 Thread Changlong Xie
On 04/13/2016 08:47 PM, Stefan Hajnoczi wrote: On Mon, Apr 11, 2016 at 04:22:57PM +0800, Changlong Xie wrote: +/* + * The caller of the function MUST make sure vm stopped + */ +void replication_start_all(ReplicationMode mode, Error **errp) +{ +ReplicationState *rs, *next

Re: [Qemu-devel] [PATCH] accel: make configure_accelerator return void

2016-04-13 Thread Changlong Xie
the code with this path? Thanks -Xie

Re: [Qemu-devel] [PATCH v17 7/8] Implement new driver for block replication

2016-04-13 Thread Changlong Xie
On 04/13/2016 09:02 PM, Stefan Hajnoczi wrote: On Mon, Apr 11, 2016 at 04:22:58PM +0800, Changlong Xie wrote: +static coroutine_fn int replication_co_writev(BlockDriverState *bs, + int64_t sector_num

[Qemu-devel] [PATCH v1 1/2] block: fix description of @stats

2016-04-14 Thread Changlong Xie
Qemu does not support "info blockstats" now. Signed-off-by: Changlong Xie --- block/block-backend.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/block-backend.c b/block/block-backend.c index d74f670..05d5d09 100644 --- a/block/block-backend.c +++ b/b

[Qemu-devel] [PATCH v1 0/2] small fix of block/account

2016-04-14 Thread Changlong Xie
Changlong Xie (2): block: fix description of @stats block: remove redundant stats of block_acct_start() block/accounting.c | 4 ++-- block/block-backend.c | 2 +- dma-helpers.c | 2 +- hw/block/nvme.c| 3 +-- hw/block/virtio-blk.c | 6

[Qemu-devel] [PATCH v1 2/2] block: remove redundant stats of block_acct_start()

2016-04-14 Thread Changlong Xie
Signed-off-by: Changlong Xie --- block/accounting.c | 4 ++-- dma-helpers.c | 2 +- hw/block/nvme.c| 3 +-- hw/block/virtio-blk.c | 6 ++ hw/block/xen_disk.c| 6 ++ hw/ide/atapi.c | 12 hw/ide/core.c

[Qemu-devel] [PATCH v18 3/8] Link backup into block core

2016-04-15 Thread Changlong Xie
From: Wen Congyang Some programs that add a dependency on it will use the block layer directly. Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie Reviewed-by: Stefan Hajnoczi Reviewed-by: Jeff Cody --- block/Makefile.objs | 2

[Qemu-devel] [PATCH v18 5/8] auto complete active commit

2016-04-15 Thread Changlong Xie
From: Wen Congyang Auto complete mirror job in background to prevent from blocking synchronously Signed-off-by: Wen Congyang Signed-off-by: Changlong Xie --- block/mirror.c| 13 + blockdev.c| 2 +- include/block/block_int.h | 3 ++- qemu-img.c

[Qemu-devel] [PATCH v18 2/8] Backup: clear all bitmap when doing block checkpoint

2016-04-15 Thread Changlong Xie
From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie --- block/backup.c| 17 + include/block/block_int.h | 2 ++ 2 files changed, 19 insertions(+) diff --git a/block/backup.c b/block

[Qemu-devel] [PATCH v18 1/8] unblock backup operations in backing file

2016-04-15 Thread Changlong Xie
From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: Changlong Xie --- block.c | 17 + 1 file changed, 17 insertions(+) diff --git a/block.c b/block.c index 4bdc6b3..1e5a4fd 100644 --- a/block.c +++ b/block.c @@ -1255,6 +1255,23 @@ void bdrv_set_backing_hd

[Qemu-devel] [PATCH v18 0/8] Block replication for continuous checkpoints

2016-04-15 Thread Changlong Xie
ive disk, hidden disk and nbd target uses the same AioContext 4. Add a testcase to test new hbitmap API V2: 1. Redesign the secondary qemu(use image-fleecing) 2. Use Error objects to return error message 3. Address the comments from Max Reitz and Eric Blake Changlong Xie (1): Introduce new APIs to do re

[Qemu-devel] [PATCH v18 4/8] docs: block replication's description

2016-04-15 Thread Changlong Xie
From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie --- docs/block-replication.txt | 239 + 1 file changed, 239 insertions(+) create mode 100644 docs/block

[Qemu-devel] [PATCH v18 7/8] Implement new driver for block replication

2016-04-15 Thread Changlong Xie
From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie --- block/Makefile.objs | 1 + block/replication.c | 625 +++ tests/.gitignore | 1 + tests

[Qemu-devel] [PATCH v18 8/8] support replication driver in blockdev-add

2016-04-15 Thread Changlong Xie
From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie Reviewed-by: Eric Blake --- qapi/block-core.json | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/qapi/block-core.json b

[Qemu-devel] [PATCH v18 6/8] Introduce new APIs to do replication operation

2016-04-15 Thread Changlong Xie
Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie --- Makefile.objs| 1 + qapi/block-core.json | 13 replication.c| 105 ++ replication.h| 176

Re: [Qemu-devel] [PATCH v1 1/2] block: fix description of @stats

2016-04-17 Thread Changlong Xie
On 04/17/2016 05:59 AM, Max Reitz wrote: On 15.04.2016 07:46, Changlong Xie wrote: Qemu does not support "info blockstats" now. It doesn't? Mine is more than happy to accept that command: $ x86_64-softmmu/qemu-system-x86_64 -nodefaults \ -drive if=none,id=drv0

Re: [Qemu-devel] [PATCH v1 2/2] block: remove redundant stats of block_acct_start()

2016-04-17 Thread Changlong Xie
On 04/17/2016 06:11 AM, Max Reitz wrote: I'd like to say that my inertia is keeping me from applying this patch, but I'd feel like a hypocrite for saying that, considering it would have taken much less time than writing this response... Pls feel free to ignore this patch, i just went through ke

Re: [Qemu-devel] [PATCH 1/2] block: Invalidate all children

2016-04-19 Thread Changlong Xie
On 04/19/2016 09:42 AM, Fam Zheng wrote: Currently we only recurse to bs->file, which will miss the children in quorum and VMDK. Recurse into the whole subtree to avoid that. Signed-off-by: Fam Zheng --- block.c | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) di

Re: [Qemu-devel] [PATCH v4 0/1] Introduce "xen-load-devices-state"

2016-04-19 Thread Changlong Xie
ping... On 04/11/2016 11:56 AM, Changlong Xie wrote: Changelog v4: 1. Rebased to the lastest code v3: 1. Addressed on David's commets, fix a bug v2: 1. Rebased to the lastest code 2. Addressed on Eric's comments, fixed coding style Wen Congyang (1): Introduce "xen-loa

Re: [Qemu-devel] [PATCH v13 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-04-19 Thread Changlong Xie
ping... On 04/13/2016 04:33 PM, Changlong Xie wrote: From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie --- block.c | 8 +++--- block/quorum.c| 78

Re: [Qemu-devel] [PATCH v18 0/8] Block replication for continuous checkpoints

2016-04-25 Thread Changlong Xie
The main migration code for COLO looks OK now,and they depend on my block part. So i'd like to ping here. Thanks -Xie On 04/15/2016 04:10 PM, Changlong Xie wrote: Block replication is a very important feature which is used for continuous checkpoints(for example: COLO). You ca

Re: [Qemu-devel] [PATCH COLO-Frame v16 23/35] COLO failover: Don't do failover during loading VM's state

2016-05-06 Thread Changlong Xie
id *colo_process_incoming_thread(void *opaque) } out: + vmstate_loading = false; An redundant blank. It seems there are many coding style issues in whole colo.c that you did't notice. Thanks -Xie /* Throw the unreported error message after exited from loop */ if (local_err) { error_report_err(local_err);

Re: [Qemu-devel] [PATCH v18 7/8] Implement new driver for block replication

2016-05-06 Thread Changlong Xie
On 04/15/2016 04:10 PM, Changlong Xie wrote: From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie --- block/Makefile.objs | 1 + block/replication.c | 625

Re: [Qemu-devel] [PATCH v13 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-05-09 Thread Changlong Xie
On 05/06/2016 11:20 PM, Max Reitz wrote: On 13.04.2016 10:33, Changlong Xie wrote: From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie --- block.c | 8 +++--- block/quorum.c| 78

Re: [Qemu-devel] [PATCH v13 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-05-09 Thread Changlong Xie
On 05/09/2016 11:52 PM, Alberto Garcia wrote: On Wed 13 Apr 2016 10:33:08 AM CEST, Changlong Xie wrote: Sorry for the late reply! Never mind : ) The patch looks good, I have some additional comments on top of what Max Wrote, nothing serious though :) @@ -67,6 +68,9 @@ typedef struct

[Qemu-devel] [PATCH v14 1/3] Add new block driver interface to add/delete a BDS's child

2016-05-10 Thread Changlong Xie
From: Wen Congyang In some cases, we want to take a quorum child offline, and take another child online. Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie Reviewed-by: Max Reitz Reviewed-by: Alberto Garcia --- block.c

[Qemu-devel] [PATCH v14 0/3] qapi: child add/delete support

2016-05-10 Thread Changlong Xie
ChangLog: v14: 1. Address commets from Betro and Max p2: introduce bdrv_drained_begin/end, rename last_index, remove redundant assert codes v13: 1. Rebase to the newest codes 2. Address commets from Betro and Max p1. Add R-B, fix incorrect syntax p2. Add missing "qemu/cutils.h" since 2.6, and rewri

[Qemu-devel] [PATCH v14 3/3] qmp: add monitor command to add/remove a child

2016-05-10 Thread Changlong Xie
: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie Reviewed-by: Max Reitz Reviewed-by: Alberto Garcia --- blockdev.c | 55 qapi/block-core.json | 32 ++ qmp-comman

[Qemu-devel] [PATCH v14 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-05-10 Thread Changlong Xie
From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie --- block.c | 8 +++--- block/quorum.c| 78 +-- include/block/block.h | 4 +++ 3 files

[Qemu-devel] [PATCH] rfifolock: no need to get thread identifier when nesting

2016-05-10 Thread Changlong Xie
Signed-off-by: Changlong Xie --- util/rfifolock.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/util/rfifolock.c b/util/rfifolock.c index c22f5fe..f406cc1 100644 --- a/util/rfifolock.c +++ b/util/rfifolock.c @@ -50,6 +50,7 @@ void rfifolock_lock(RFifoLock *r) if (r->nesting

Re: [Qemu-devel] [PATCH v18 7/8] Implement new driver for block replication

2016-05-10 Thread Changlong Xie
On 05/06/2016 11:46 PM, Stefan Hajnoczi wrote: On Fri, Apr 15, 2016 at 04:10:37PM +0800, Changlong Xie wrote: +static void replication_close(BlockDriverState *bs) +{ +BDRVReplicationState *s = bs->opaque; + +if (s->mode == REPLICATION_MODE_SECONDARY) { +g_free(s-&

Re: [Qemu-devel] [PATCH] rfifolock: no need to get thread identifier when nesting

2016-05-10 Thread Changlong Xie
On 05/10/2016 05:38 PM, Denis V. Lunev wrote: On 05/10/2016 12:16 PM, Changlong Xie wrote: Signed-off-by: Changlong Xie --- util/rfifolock.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/util/rfifolock.c b/util/rfifolock.c index c22f5fe..f406cc1 100644 --- a/util/rfifolock.c +++ b

[Qemu-devel] [PATCH v2] rfifolock: no need to get thread identifier when nesting

2016-05-10 Thread Changlong Xie
Signed-off-by: Changlong Xie --- util/rfifolock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/rfifolock.c b/util/rfifolock.c index c22f5fe..084c2f0 100644 --- a/util/rfifolock.c +++ b/util/rfifolock.c @@ -58,9 +58,9 @@ void rfifolock_lock(RFifoLock *r

Re: [Qemu-devel] [Qemu-block] [PATCH v16 2/8] Backup: clear all bitmap when doing block checkpoint

2016-03-18 Thread Changlong Xie
On 03/17/2016 02:48 AM, Jeff Cody wrote: On Fri, Mar 11, 2016 at 06:34:09PM +0800, Changlong Xie wrote: From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie --- block/backup.c| 15

Re: [Qemu-devel] [PATCH v2 1/1] Introduce "xen-load-devices-state"

2016-03-21 Thread Changlong Xie
ping.. On 03/14/2016 04:03 PM, Changlong Xie wrote: From: Wen Congyang Introduce a "xen-load-devices-state" QAPI command that can be used to load the state of all devices, but not the RAM or the block devices of the VM. We only have hmp commands savevm/loadvm, and qmp command

Re: [Qemu-devel] [PATCH v2 1/1] Introduce "xen-load-devices-state"

2016-03-23 Thread Changlong Xie
On 03/22/2016 08:22 PM, Dr. David Alan Gilbert wrote: * Changlong Xie (xiecl.f...@cn.fujitsu.com) wrote: From: Wen Congyang Introduce a "xen-load-devices-state" QAPI command that can be used to load the state of all devices, but not the RAM or the block devices of the VM. We onl

Re: [Qemu-devel] [PATCH v2 1/1] Introduce "xen-load-devices-state"

2016-03-23 Thread Changlong Xie
On 03/23/2016 05:41 PM, Dr. David Alan Gilbert wrote: * Wen Congyang (we...@cn.fujitsu.com) wrote: On 03/23/2016 04:56 PM, Dr. David Alan Gilbert wrote: * Changlong Xie (xiecl.f...@cn.fujitsu.com) wrote: On 03/22/2016 08:22 PM, Dr. David Alan Gilbert wrote: * Changlong Xie (xiecl.f

[Qemu-devel] [PATCH v3 0/1] Introduce "xen-load-devices-state"

2016-03-23 Thread Changlong Xie
Changelog v3: 1. Addressed on David's commets, fix a bug v2: 1. Rebased to the lastest code 2. Addressed on Eric's comments, fixed coding style Wen Congyang (1): Introduce "xen-load-devices-state" migration/savevm.c | 36 qapi-schema.json | 14 +++

[Qemu-devel] [PATCH v3 1/1] Introduce "xen-load-devices-state"

2016-03-23 Thread Changlong Xie
1. suspend both primary vm and secondary vm 2. sync the state 3. resume both primary vm and secondary vm In such case, we need to update all devices' state in any time. Signed-off-by: Wen Congyang Signed-off-by: Changlong Xie --- migration/savevm.c | 36 +++

<    1   2   3   4   5   6   7   >