[Qemu-devel] [PATCH] trace: Fix format specifiers for existing arguments

2015-12-24 Thread valentin
From: Valentin Rakush This patch fixes compilation errors when --enable-trace-backend=stderr option is used for configuration GEN trace/generated-events.c CCtrace/generated-events.o In file included from /home/vrakush/workspace/qemu/include/trace.h:4:0, from trace

[Qemu-devel] [PATCH v3 0/4] target-openrisc: Machine improvements take three

2014-10-05 Thread Valentin Manea
Hi, After some extra feedback I made a new version of the openrisc patches. However this time around I create a new "advanced" simulator that includes all the new peripherals. I would appreciate some feedback. Thanks, Valentin

[Qemu-devel] [PATCH v3 1/4] target-openrisc: New machine with IDE support

2014-10-05 Thread Valentin Manea
Create new OpenRISC machine(asim) with default IDE support. It will incude more peripherals in order to run a fully fledged Linux computer. Signed-off-by: Valentin Manea --- default-configs/or32-softmmu.mak | 3 + hw/openrisc/Makefile.objs| 1 + hw/openrisc/openrisc_asim.c

[Qemu-devel] [PATCH v3 2/4] hw/display: Add OpenCores FB device support

2014-10-05 Thread Valentin Manea
>From edfd91e325a8c1806140c7468e187781d0b20ea9 Mon Sep 17 00:00:00 2001 From: Valentin Manea Date: Sun, 21 Sep 2014 10:57:55 +0300 Subject: [PATCH 2/4] target-openrisc: Add OpenCores FB device support Add support for the OpenCores Framebuffer device and enable it by default in the OpenRISC a

[Qemu-devel] [PATCH v3 3/4] hw/input: Add OpenCores keyboard device support

2014-10-05 Thread Valentin Manea
Add support for the OpenCores keyboard device to the default OpenRisc machine. The OpenCores keyboard device is a simple open source keyboard device created by the OpenCores project(http://opencores.org/). By default it just forwards Linux like keycodes. Signed-off-by: Valentin Manea

[Qemu-devel] [PATCH v3 4/4] hw/input: Add LPC32XX touchscreen device

2014-10-05 Thread Valentin Manea
The LPC32XX is a simple MMIO touch screen device with a Linux device driver. The device is suitable for small machines which require mouse input but have no suitable bus(SPI, I2C). Add the LPC32XX device to the default OpenRisc machine. Signed-off-by: Valentin Manea --- default-configs/or32

[Qemu-devel] [PATCH 1/4] target-openrisc: Add IDE support to default machine

2014-08-22 Thread Valentin Manea
Add MMIO ide device support to the default openrisc machine. Base address and IRQ line are the same as the or1ksim. Signed-off-by: Valentin Manea --- default-configs/or32-softmmu.mak | 3 +++ hw/openrisc/openrisc_sim.c | 32 2 files changed, 35

[Qemu-devel] [PATCH 4/4] target-openrisc: Add LPC32XX touchscreen device

2014-08-22 Thread Valentin Manea
The LPC32XX is a simple MMIO touch screen device with a Linux device driver. The device is suitable for small machines which require mouse input but have no suitable bus(SPI, I2C). Add the LPC32XX device to the default OpenRisc machine. Signed-off-by: Valentin Manea --- default-configs/or32

[Qemu-devel] [PATCH 2/4] target-openrisc: Add OpenCores FB device support

2014-08-22 Thread Valentin Manea
Add support for the OpenCores Framebuffer device and enable it by default in the OpenRISC machine. The OpenCores display device is a simple open source framebuffer device created http://opencores.org/project,vgafb Signed-off-by: Valentin Manea --- default-configs/or32-softmmu.mak | 1 + hw

[Qemu-devel] [PATCH 3/4] target-openrisc: Add OpenCores keyboard device support

2014-08-22 Thread Valentin Manea
Add support for the OpenCores keyboard device to the default OpenRisc machine. The OpenCores keyboard device is a simple open source keyboard device created by the OpenCores project(http://opencores.org/). By default it just forwards Linux like keycodes. Signed-off-by: Valentin Manea --- hw

[Qemu-devel] [PATCH 0/4] target-openrisc: Some openrisc improvements

2014-08-22 Thread Valentin Manea
Hi, I would like to share this series of patches to improve the openrisc machine. Mostly my goal is to have the same features as the web based machine and be able to boot qemu with exactly the same images. Some feedback would be appreciated. Regards, Valentin

Re: [Qemu-devel] [PATCH 2/4] target-openrisc: Add OpenCores FB device support

2014-08-22 Thread Valentin Manea
Hi Jia, On 2014-08-22 19:00, Jia Liu wrote: > Hi Valentin, > Is here a line wrapped? > I think it should looks like: > + * Based on work by Sebastian Macke for jor1k > + * http://s-macke.github.io/jor1k/ > rather than > + http://s-macke.github.io/jor1k/ > Oh, you are c

[Qemu-devel] [PATCH v2 0/4] target-openrisc: Machine improvements take two

2014-08-22 Thread Valentin Manea
, Valentin

[Qemu-devel] [PATCH v2 0/4] target-openrisc: Machine improvements take two

2014-08-22 Thread Valentin Manea
, Valentin

[Qemu-devel] [PATCH v2 1/4] target-openrisc: Add IDE support to default machine

2014-08-22 Thread Valentin Manea
Add MMIO ide device support to the default openrisc machine. Base address and IRQ line are the same as the or1ksim. Signed-off-by: Valentin Manea --- default-configs/or32-softmmu.mak | 3 +++ hw/openrisc/openrisc_sim.c | 32 2 files changed, 35

[Qemu-devel] [PATCH v2 2/4] target-openrisc: Add OpenCores FB device support

2014-08-22 Thread Valentin Manea
Add support for the OpenCores Framebuffer device and enable it by default in the OpenRISC machine. The OpenCores display device is a simple open source framebuffer device created http://opencores.org/project,vgafb Signed-off-by: Valentin Manea --- default-configs/or32-softmmu.mak | 1 + hw

[Qemu-devel] [PATCH v2 2/4] target-openrisc: Add OpenCores FB device support

2014-08-22 Thread Valentin Manea
Add support for the OpenCores Framebuffer device and enable it by default in the OpenRISC machine. The OpenCores display device is a simple open source framebuffer device created http://opencores.org/project,vgafb Signed-off-by: Valentin Manea --- default-configs/or32-softmmu.mak | 1 + hw

[Qemu-devel] [PATCH v2 3/4] target-openrisc: Add OpenCores keyboard device support

2014-08-22 Thread Valentin Manea
Add support for the OpenCores keyboard device to the default OpenRisc machine. The OpenCores keyboard device is a simple open source keyboard device created by the OpenCores project(http://opencores.org/). By default it just forwards Linux like keycodes. Signed-off-by: Valentin Manea --- hw

[Qemu-devel] [PATCH v2 4/4] target-openrisc: Add LPC32XX touchscreen device

2014-08-22 Thread Valentin Manea
The LPC32XX is a simple MMIO touch screen device with a Linux device driver. The device is suitable for small machines which require mouse input but have no suitable bus(SPI, I2C). Add the LPC32XX device to the default OpenRisc machine. Signed-off-by: Valentin Manea --- default-configs/or32

Re: [Qemu-devel] [PATCH 0/4] target-openrisc: Some openrisc improvements

2014-08-22 Thread Valentin Manea
Hi Jia, On 2014-08-22 19:11, Jia Liu wrote: > Hi Valentin, > > Thank you very much! > May you please upload the test linux image to somewhere, and tell us > your test steps? > Make me can test your change. I've resent the patches including the needed images(vmlinux and

Re: [Qemu-devel] [PATCH v2 4/4] target-openrisc: Add LPC32XX touchscreen device

2014-08-22 Thread Valentin Manea
t; > which also leads to nicer review tree layouts: > > 0/4 > + 1/4 > | + Re: 1/4 > + 2/4 > | + Re: 2/4 > + 3/4 > | + Re: 3/4 > + 4/4 > + Re: 4/4 > Point taken, it makes more sense this way. Sorry, I haven't been doing this for a long time. Valentin

[Qemu-devel] [PATCH] IDE: MMIO IDE device control should be little endian

2014-08-31 Thread Valentin Manea
Set the IDE MMIO memory type to little endian. The ATA specs identify words part of the control commands encoded as little endian. While this has no impact on little endian systems, it's required for big endian systems(eg OpenRisc). Signed-off-by: Valentin Manea --- hw/ide/mmio.c | 4 ++

Re: [Qemu-devel] [Qemu-trivial] [PATCH] IDE: MMIO IDE device control should be little endian

2014-08-31 Thread Valentin Manea
On 2014-08-28 14:13, Stefan Hajnoczi wrote: > Hi Valentin, > Please resend the patch to qemu-devel@nongnu.org and CC Kevin Wolf > and Stefan Hajnoczi . > > All patches must go through the mailing list so the community has a > chance to review and comment before a committer

Re: [Qemu-devel] [PATCH] IDE: MMIO IDE device control should be little endian

2014-09-07 Thread Valentin Manea
Hi, Did anybody get the chance to review this patch? It would be quite nice to integrate it before all the other openrisc changes, to get the IDE working also. Thanks, Valentin On 2014-08-31 11:32, Valentin Manea wrote: > > Set the IDE MMIO memory type to little endian. The ATA

Re: [Qemu-devel] [PATCH] IDE: MMIO IDE device control should be little endian

2014-09-09 Thread Valentin Manea
would simply have rejected it. Really sorry, my mail client was playing tricks on me. I will make sure to triple check next time. Regards, Valentin

[Qemu-devel] Big Endian qemu_pixelformat_from_pixman and qemu_default_pixman_format

2014-09-14 Thread Valentin Manea
Hi Gerd, I'm working on improving the OpenRISC support for QEMU and recently I got in one problem with qemu_pixelformat_from_pixman(). It seems quite recently the ui/console.c code has started using it for big endian as well but the new change breaks my existing framebuffer patches. The proble

[Qemu-devel] VFIO bug with Sata controler (AsMedia1061)

2013-12-01 Thread Valentin Meriel
Hello, I want to report to you a really big bug. vfio passthrough dont works with Sata controler (an AsMedia 1061) ! When i try to use vfio with this controler it work only once. When i use vfio for VGA i can reboot (or shutdown and start again) my VM with out problem, but for any other PCI card

[Qemu-devel] [PATCH v2] qom, qmp, hmp, qapi: create qom-type-list for class properties

2016-01-22 Thread Valentin Rakush
This patch adds support for qom-type-prop-list command to list object class properties. A later patch will use this functionality to implement x86_64-cpu properties. Signed-off-by: Valentin Rakush Cc: Luiz Capitulino Cc: Eric Blake Cc: Markus Armbruster Cc: Andreas Färber Cc: Daniel P

[Qemu-devel] [PATCH v3] qom, qmp, hmp, qapi: create qom-type-prop-list for class properties

2016-01-22 Thread Valentin Rakush
This patch adds support for qom-type-prop-list command to list object class properties. A later patch will use this functionality to implement x86_64-cpu properties. Signed-off-by: Valentin Rakush Cc: Luiz Capitulino Cc: Eric Blake Cc: Markus Armbruster Cc: Andreas Färber Cc: Daniel P

[Qemu-devel] [PATCH v4] qom, qmp, hmp, qapi: create qom-type-prop-list for class properties

2016-01-22 Thread Valentin Rakush
This patch adds support for qom-type-prop-list command to list object class properties. A later patch will use this functionality to implement x86_64-cpu properties. Signed-off-by: Valentin Rakush Cc: Luiz Capitulino Cc: Eric Blake Cc: Markus Armbruster Cc: Andreas Färber Cc: Daniel P

Re: [Qemu-devel] [PATCH v4] qom, qmp, hmp, qapi: create qom-type-prop-list for class properties

2016-01-22 Thread Valentin Rakush
ted command with monitor. But would it be ok to add QMP and HMP tests to this patch? Or may be submit tests with another patch, because this one is already reviewed? I do not see much QMP/HMP tests so I am hesitating if this is a good idea. Thank you, Valentin On Fri, Jan 22, 2016 at 10:0

[Qemu-devel] [PATCH v5] qom, qmp, hmp, qapi: create qom-type-prop-list for class properties

2016-01-25 Thread Valentin Rakush
This patch adds support for qom-type-prop-list command to list object class properties. A later patch will use this functionality to implement x86_64-cpu properties. Signed-off-by: Valentin Rakush Cc: Luiz Capitulino Cc: Eric Blake Cc: Markus Armbruster Cc: Andreas Färber Cc: Daniel P

Re: [Qemu-devel] [RFC] target-i386: Display i386 CPUID properties

2016-01-25 Thread Valentin Rakush
command that will return properties for any class, but not only for devices. There is another related thread http://lists.nongnu.org/archive/html/qemu-devel/2016-01/msg04348.html If there are any additional requirements or concerns, please let me know, and I will change the patch. Regards, Valentin

Re: [Qemu-devel] [PATCH v4] qom, qmp, hmp, qapi: create qom-type-prop-list for class properties

2016-01-26 Thread Valentin Rakush
Hi Eric, On Mon, Jan 25, 2016 at 8:43 PM, Eric Blake wrote: > On 01/22/2016 01:20 PM, Valentin Rakush wrote: > > Hi Eric, hi Daniel, > > > > Re dashes in the command name > > > > AFAICC, the QOM related command in HMP use dash "-". For example, > qo

Re: [Qemu-devel] [PATCH v5] qom, qmp, hmp, qapi: create qom-type-prop-list for class properties

2016-01-27 Thread Valentin Rakush
should refactor source code that already uses qmp_device_list_properties. For example, libvirt is already uses device-list-properties command. I will do more research. Regards, Valentin On Wed, Jan 27, 2016 at 1:19 AM, Daniel P. Berrange wrote: > On Tue, Jan 26, 2016 at 03:26:35PM -0200, Eduardo

Re: [Qemu-devel] [PATCH v5] qom, qmp, hmp, qapi: create qom-type-prop-list for class properties

2016-01-29 Thread Valentin Rakush
with TYPE_MACHINE GlobalProperty. Then we will use these properties for all other types of classes. Of course, we can leave device_list_properties as it is and use qom-type-prop-list instead. What do you think? Does these design options make sense for you? Thank you, Valentin On Wed, Jan

Re: [Qemu-devel] [PATCH v5] qom, qmp, hmp, qapi: create qom-type-prop-list for class properties

2016-01-31 Thread Valentin Rakush
ss GHashTable *properties; */ } > 5) -cpu options: > > Ditto. the list will be incomplete unless all CPU subclasses are > converted to use only class-properties, or the new command uses > object_new(). This is a use case that I initially tried to implement. Regards, Valentin On Fr

Re: [Qemu-devel] [PATCH v5] qom, qmp, hmp, qapi: create qom-type-prop-list for class properties

2016-02-07 Thread Valentin Rakush
ies into the target-i386/cpu.c and print them when necessary. And after our discussion qmp_device_list_properties is a already available for this but cannot_destroy_with_object_finalize_yet flag should be set to false. Please let me know if this is wrong approach. Thank you, Valentin On Tue, Feb 2, 2

[Qemu-devel] [PATCH RFC] qmp, target-i386: device_list_properties for TYPE_CPU

2016-02-12 Thread Valentin Rakush
qmp_device_list_properties and only target-i386 to allow TYPE_CPU class properties to be quered with QMP interface and with -device core2duo-x86_64-cpu,help command line. Signed-off-by: Valentin Rakush Cc: Luiz Capitulino Cc: Eric Blake Cc: Markus Armbruster Cc: Andreas Färber Cc: Daniel P. Berrange Cc

[Qemu-devel] [RFC] target-i386: Display i386 CPUID properties

2016-01-12 Thread Valentin Rakush
. Output formatting: - list cpu properties per CPUID - list cpu properties along with values 5. and more ... Signed-off-by: Valentin Rakush --- include/qom/cpu.h| 2 + include/qom/object.h | 46 +++ qom/cpu.c| 50 qom/object.c | 220

Re: [Qemu-devel] [RFC] target-i386: Display i386 CPUID properties

2016-01-14 Thread Valentin Rakush
On Tue, Jan 12, 2016 at 5:50 PM, Daniel P. Berrange wrote: > On Tue, Jan 12, 2016 at 05:36:27PM +0300, Valentin Rakush wrote: > > This is RFC because implementation depends on the upcoming class > > properties > > http://lists.nongnu.org/archive/html/qemu-devel/2015-08/msg03

[Qemu-devel] [PATCH] qom, qmp, hmp, qapi: create qom-type-list for class properties

2016-01-20 Thread Valentin Rakush
This patch adds support for qom-type-list command that supposed to list object class properties. Will use this functionality further to implement x86_64 cpu properties. Additionally object_class_property_iterator_init function is implemented for consistency. Signed-off-by: Valentin Rakush

Re: [PATCH v0 0/4] backends/hostmem: add an ability to specify prealloc timeout

2023-01-23 Thread Valentin Sinitsyn
Hello, On 23.01.2023 19:14, Daniil Tatianin wrote: On 1/23/23 4:47 PM, Daniel P. Berrangé wrote: On Mon, Jan 23, 2023 at 04:30:03PM +0300, Daniil Tatianin wrote: On 1/23/23 11:57 AM, David Hildenbrand wrote: On 20.01.23 14:47, Daniil Tatianin wrote: This series introduces new qemu_prealloc_m

Re: [PATCH v1] hw/i386/amd_iommu: clean up broken event logging

2021-11-17 Thread Valentin Sinitsyn
On 18.11.2021 00:03, Roman Kagan wrote: On Wed, Nov 17, 2021 at 11:13:27PM +0500, Valentin Sinitsyn wrote: On 17.11.2021 19:46, Daniil Tatianin wrote: -/* - * AMDVi event structure - *0:15 -> DeviceID - *55:63 -> event type + miscellaneous info - *63:127 -> related add

Re: [PATCH v1] hw/i386/amd_iommu: clean up broken event logging

2021-11-17 Thread Valentin Sinitsyn
Hi, On 17.11.2021 19:46, Daniil Tatianin wrote: - Don't create evt buffer in every function where we want to log, instead make amdvi_log_event construct the buffer in-place using the arguments it was given. - Correctly place address & info in the event buffer. Previously both would get

[PATCH] armv7m_nvic: set DHCSR.DEBUGEN when debugger is attached

2022-02-03 Thread Valentin Ghita
-by: Valentin Ghita --- gdbstub.c | 10 ++ hw/intc/armv7m_nvic.c | 4 include/exec/gdbstub.h | 6 ++ 3 files changed, 20 insertions(+) diff --git a/gdbstub.c b/gdbstub.c index 3c14c6a038..d4e39db8e7 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -3585,6 +3585,16 @@ int

Re: [PATCH] armv7m_nvic: set DHCSR.DEBUGEN when debugger is attached

2022-02-04 Thread Valentin Ghita
On Thu, Feb 3, 2022 at 7:42 PM Alex Bennée wrote: > > Valentin Ghita writes: > > > The DEBUGEN bit is set by the debugger when it is connected to the > > core. Software can use this bit to check if a debug session is active. > > > > Add a function in gd

[Qemu-devel] [PATCH] PPC: MMU compatibility check.

2017-01-24 Thread Valentin Plotkin
exit(-1); +} + ppcemb_tlb_t *tlb = &env->tlb.tlbe[0]; tlb->attr = 0; -- 2.5.5 Valentin Plotkin calib...@sdf.org SDF Public Access UNIX System - http://sdf.org

Re: [Qemu-devel] [Qemu-ppc] [PATCH] PPC: MMU compatibility check.

2017-01-24 Thread Valentin Plotkin
On Tue, 24 Jan 2017, Thomas Huth wrote: Date: Tue, 24 Jan 2017 21:32:44 +0100 From: Thomas Huth To: Valentin Plotkin , qemu-triv...@nongnu.org Cc: qemu-...@nongnu.org, qemu-devel@nongnu.org Subject: Re: [Qemu-ppc] [PATCH] PPC: MMU compatibility check. On 24.01.2017 19:56, Valentin Plotkin

[Qemu-devel] [PATCH v2] target-ppc: Add MMU model check for booke machines

2017-01-25 Thread Valentin Plotkin
Machines bamboo, e500 and virtex-ml507 assume a certain MMU model, otherwise resulting in unpredictable behavior. Add apropriate checks into *_init functions. Signed-off-by: Valentin --- hw/ppc/e500.c | 6 ++ hw/ppc/ppc440_bamboo.c | 6 ++ hw/ppc/virtex_ml507.c | 7 +++ 3

[Qemu-devel] [PATCH v2.1] target-ppc: Add MMU model check for booke machines

2017-01-26 Thread Valentin Plotkin
From: Valentin Plotkin Machines bamboo, e500 and virtex-ml507 assume a certain MMU model, otherwise resulting in unpredictable behavior. Add apropriate checks into *_init functions. Signed-off-by: Valentin Plotkin --- hw/ppc/e500.c | 6 ++ hw/ppc/ppc440_bamboo.c | 6 ++ hw

[Qemu-devel] [Bug 1800156] [NEW] windows 8.1 loose grab/leave window on windowed

2018-10-26 Thread Valentin Fort
Public bug reported: Hello, i am new to QEMU and i encounter that annoying issue (windowed) when i move the mouse a bit too much then it leave the window. Windows 8.1, Latest QEMU (Windows binaries). ** Affects: qemu Importance: Undecided Status: New ** Summary changed: - windows

Re: [BUG FIX][PATCH v3 0/3] vhost-user-blk: fix bug on device disconnection during initialization

2021-04-01 Thread Valentin Sinitsyn
On 01.04.2021 14:21, Denis Plotnikov wrote: This is a series fixing a bug in host-user-blk. More specifically, it's not just a bug but crasher. Valentine Is there any chance for it to be considered for the next rc? Thanks! Denis On 29.03.2021 16:44, Denis Plotnikov wrote: ping! On 25.03

[Bug 1915531] Re: qemu-user child process hangs when forking due to glib allocation

2021-05-13 Thread Valentin David
-user/syscall.c:6422 #14 0x7f54e191950a in start_thread (arg=) at pthread_create.c:477 #15 0x7f54e19a52a3 in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95 Thread 2: #1 0x7f54e18a8d6e in qemu_futex_wait (f=0x7f54e1dc7038 , val=4294967295) at /var/home/valentin

[Bug 1915531] [NEW] qemu-user child process hangs when forking due to glib allocation

2021-02-12 Thread Valentin David
0x7f54e18a8d6e in qemu_futex_wait (f=0x7f54e1dc7038 , val=4294967295) at /var/home/valentin/repos/qemu/include/qemu/futex.h:29 #2 0x7f54e18a8f32 in qemu_event_wait (ev=0x7f54e1dc7038 ) at ../util/qemu-thread-posix.c:460 #3 0x7f54e18c0196 in call_rcu_thread (opaque=0x0) at ../util

[Bug 1864984] [NEW] "nr_entries is too big" when using virgl

2020-02-27 Thread Valentin David
Public bug reported: I have a bootable image where GNOME Shell fails because it hits a limit in virtio-gpu. In `hw/display/virtio-gpu.c`, there is a limit for `nr_entries` at 16384. There is no explanation for that limit. But there does not seem to be any limit on the kernel side. Raising this l

[PATCH] hw/smbios/smbios.c: Add missing NUL terminal to string from path= parameter

2025-04-05 Thread Valentin David
Without it, it seems the data gets garbage at the end of the string. Signed-off-by: Valentin David --- hw/smbios/smbios.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/smbios/smbios.c b/hw/smbios/smbios.c index 02a09eb9cd..7522e9a172 100644 --- a/hw/smbios/smbios.c +++ b/hw/smbios

Re: [PATCH] smbios: Fix buffer overrun when using path= option

2025-04-04 Thread Valentin David
On Thu, Apr 3, 2025 at 9:37 PM Philippe Mathieu-Daudé wrote: > Also I was hoping I could get feedback from Valentin. > > Sorry, I did not realize that you wanted my feedback. Daan's patch looks fine to me. I have manually tested it and it fixes my issue.

Re: [PATCH] smbios: Fix buffer overrun when using path= option

2025-04-04 Thread Valentin David
Yes. On Fri, Apr 4, 2025 at 5:02 PM Philippe Mathieu-Daudé wrote: > On 4/4/25 16:46, Valentin David wrote: > > On Thu, Apr 3, 2025 at 9:37 PM Philippe Mathieu-Daudé > <mailto:phi...@linaro.org>> wrote: > > > > Also I was hoping I could get feedback from V