I submitted a first version some days ago, which homogeneized the
implementation, as suggested by Laurent Vivier. It received some
feedback from Eric Blake. A patchset (v3) is ready for review:
https://patchew.org/QEMU/20190306031221.GA53@03612eec87fc/#
The feature requested in this issue is inclu
Public bug reported:
As shown in https://github.com/beehive-
lab/mambo/issues/19#issuecomment-407420602, with len==0 mmap returns
success (NULL, 0) instead of failure (MAP_FAILED, -1) in a x86_64 host
executing a ELF 64-bit LSB executable, ARM aarch64 binary.
Steps to reproduce the bug:
- (cross
I did some research and found that this bug is present since 2003:
- 2003/05/13:
https://github.com/qemu/qemu/commit/54936004fddc52c321cb3f9a9a51140e782bed5d#diff-2bf4728e0473404c39c97190bd02b2f8
-
https://github.com/qemu/qemu/blob/54936004fddc52c321cb3f9a9a51140e782bed5d/linux-user/mmap.c#L18
** Summary changed:
- qemu-user-aarch64: mmap returns success (NULL, 0) instead of failure
(MAP_FAILED, -1) with len==0
+ qemu-user: mmap should return failure (MAP_FAILED, -1) instead of success
(NULL, 0) when len==0
--
You received this bug notification because you are a member of qemu-
deve
Following
https://wiki.qemu.org/Contribute/SubmitAPatch#Make_code_motion_patches_easy_to_review:
@@ -1,5 +1,5 @@
---
--- a/linux-user/mmap.c
-if (len == 0)
-goto the_end;
--
+++ b/linux-user/mmap.c
+if (len == 0) {
+errno = EINVAL;
+goto fail;
+}
--
You recei
** Changed in: qemu
Status: New => In Progress
** Changed in: qemu (Ubuntu)
Status: New => In Progress
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1783362
Title:
qemu-user: mmap sh
Alex, Laurent, I'm new to this management/development system. So, first
off, thanks for working on this bug.
I have a few (probably silly) questions:
1. What is 'the r-b' that Alex used in #14?
2. When should I change the status of the bug? I can already see it in GitHub's
mirror and in https://
** Changed in: qemu
Status: In Progress => Fix Committed
** Changed in: qemu (Ubuntu)
Status: In Progress => Fix Committed
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1783362
Title:
git://github.com/vivier/qemu.git, and generally I prepare my pull
request on linux-user-for-3.0 branch (the release number changes).
Thanks again.
Regards,
umarcor
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.
** Changed in: qemu
Status: Fix Committed => Fix Released
** Changed in: qemu (Ubuntu)
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1783362
Title
This patch breaks backward compatibility.
Both '--persistent' and '--credential' default to 'no'. Hence, '-p no'
or '-c no' are redundant. Overall, accepting an argument might be
misleading because options are, indeed, boolean. This patch makes both
options boolean in getopt, so if any of them is
Spaces are removed before '; then', for consistency with other scripts
in the project.
Signed-off-by: umarcor
---
scripts/qemu-binfmt-conf.sh | 36 ++--
1 file changed, 18 insertions(+), 18 deletions(-)
diff --git a/scripts/qemu-binfmt-conf.sh b/sc
Public bug reported:
I'd like to ask for the addition of option '--targets' to scripts/qemu-
binfmt-conf.sh, in order to allow registering the interpreters for the
given list of architectures only, instead of using all of the ones
defined in qemu_target_list. The following is a possible patch that
13 matches
Mail list logo
