Re: [Qemu-devel] [RFC PATCH] arm boot: added QOM device definition

2012-02-08 Thread Peter Crosthwaite
On Wed, Feb 8, 2012 at 11:10 PM, Alexander Graf wrote: > > On 08.02.2012, at 14:04, Peter Crosthwaite wrote: > > > > On Wed, Feb 8, 2012 at 10:41 PM, Alexander Graf wrote: > >> >> On 08.02.2012, at 13:27, Paul Brook wrote: >> >> >> 2012/

Re: [Qemu-devel] [RFC PATCH] arm boot: added QOM device definition

2012-02-08 Thread Peter Crosthwaite
On Wed, Feb 8, 2012 at 11:35 PM, Alexander Graf wrote: > > On 08.02.2012, at 14:30, Peter Crosthwaite wrote: > > > > On Wed, Feb 8, 2012 at 11:10 PM, Alexander Graf wrote: > >> >> On 08.02.2012, at 14:04, Peter Crosthwaite wrote: >> >> >>

Re: [Qemu-devel] [RFC PATCH] arm boot: added QOM device definition

2012-02-08 Thread Peter Crosthwaite
2012/2/9 Paul Brook > > So if we consider this bootloader a device and its -dtb argument a > property > > of that device, then what you are implying is that every device property > of > > every device in a machine must be managed by the machine model? Isn't the > > dynamic machine model work that

Re: [Qemu-devel] [RFC PATCH] arm boot: added QOM device definition

2012-02-08 Thread Peter Crosthwaite
So here are some of the problems im trying to solve with the bootloader: Smp bootstrap secondary CPUs while loading an elf (currently elfs will be assumed to be not kernels). Change the kernel, initrd and dtb load address on the command line. Use my own SMP secondary bootloop. My intention with t

Re: [Qemu-devel] [RFC PATCH] arm boot: added QOM device definition

2012-02-08 Thread Peter Crosthwaite
erlties. > > Ok, that sounds more workable :). So i would add my initrd_addr property to the bootloader as a qdev prop as I suggested before, then something like: qemu-system-arm -M verstailepb -property /foo/bar/arm_linux_loader.0,initrd_addr=0x1000 ? Paul > Peter

[Qemu-devel] [Bug 928204] Re: build failure gentoo

2012-02-08 Thread Peter Johnson
qemu 0.11.1 package: CCx86_64-linux-user/host-utils.o CCx86_64-linux-user/tcg/tcg.o CCx86_64-linux-user/tcg/tcg-runtime.o CCx86_64-linux-user/fpu/softfloat-native.o CCx86_64-linux-user/op_helper.o {standard input}: Assembler messages: {standard input}:3270769: Warning:

Re: [Qemu-devel] [RFC PATCH] arm boot: added QOM device definition

2012-02-08 Thread Peter Crosthwaite
herits for the arm boot device and instantiate that? Regards, Peter 2012/2/9 Anthony Liguori > On 02/08/2012 10:15 AM, Paul Brook wrote: > >> Ok, that sounds more workable :). So i would add my initrd_addr property >>> to >>> the bootloader as a qdev prop as

Re: [Qemu-devel] Broken realview

2012-02-08 Thread Peter Maydell
On 9 February 2012 05:16, Evgeny Voevodin wrote: > Since last QOM patch set landed into master, realview-pbx-a9, > realview-eb-mpcore (suppose that other too) abort with error: > > qemu/hw/qdev-properties.c:1161: qdev_prop_set_uint32: Assertion `!errp' > failed. > Aborted The realview etc board m

[Qemu-devel] [PATCH] ARM devboards: Set arm_sysctl properties before init, not after

2012-02-08 Thread Peter Maydell
The ARM devboard models (vexpress-a9, realview, versatilepb, etc) were accidentally trying to set one of the arm_sysctl properties after device init. This has now become a fatal error; set the property before device init where it should be done instead. Signed-off-by: Peter Maydell --- If

Re: [Qemu-devel] Broken realview

2012-02-08 Thread Peter Maydell
On 9 February 2012 05:16, Evgeny Voevodin wrote: > Since last QOM patch set landed into master, realview-pbx-a9, > realview-eb-mpcore (suppose that other too) abort with error: > > qemu/hw/qdev-properties.c:1161: qdev_prop_set_uint32: Assertion `!errp' > failed. Incidentally, this is a rather unh

Re: [Qemu-devel] Broken realview

2012-02-08 Thread Peter Maydell
On 9 February 2012 06:13, Evgeny Voevodin wrote: > It seems that we have to rebase our exynos boards again ). So, am I right > supposing that exynos will not be applied until all QOM patch sets landed? Anthony claims there aren't any more QOM patchsets which touch all the files in the tree, so no

[Qemu-devel] [PATCH] hw/arm_sysctl: Drop legacy init function

2012-02-08 Thread Peter Maydell
Drop the legacy init function arm_sysctl_init(), since it has no users left any more. This allows us to drop the awkward '1' from the actual device init function. Signed-off-by: Peter Maydell --- The legacy function also had the 'set property after init' bug (in fact this is

Re: [Qemu-devel] [PATCH v2] qom: Unify type registration

2012-02-09 Thread Peter Maydell
On 9 February 2012 14:20, Andreas Färber wrote: > Replace device_init() with generalized type_init(). > > While at it, unify naming convention: type_init([$prefix_]register_types) > Also, type_init() is a function, so add preceding blank line where > necessary and don't put a semicolon after the c

[Qemu-devel] [Bug 929638] Re: qemu 1.0 unable to compile on the pandaboard ES

2012-02-09 Thread Peter Maydell
(1) This isn't qemu 1.0 as you say in the bug title, it's qemu master. (2) qemu 1.0 does not work on ARM hosts -- see the release notes. (3) at least one of the problems which meant we marked it as unsupported is still unfixed in master, so this isn't going to work (4) the specific problem you've

Re: [Qemu-devel] [Bug 929638] Re: qemu 1.0 unable to compile on the pandaboard ES

2012-02-09 Thread Peter Maydell
On 9 February 2012 18:23, Andreas Färber wrote: > Am 09.02.2012 18:07, schrieb Peter Maydell: >> (2) qemu 1.0 does not work on ARM hosts -- see the release notes. >> (3) at least one of the problems which meant we marked it as unsupported is >> still unfixed in master, s

Re: [Qemu-devel] [Bug 929638] Re: qemu 1.0 unable to compile on the pandaboard ES

2012-02-09 Thread Peter Maydell
On 9 February 2012 19:12, Alexander Graf wrote: > > On 09.02.2012, at 20:11, Peter Maydell wrote: > >> On 9 February 2012 18:23, Andreas Färber wrote: >>> Am 09.02.2012 18:07, schrieb Peter Maydell: >>>> (2) qemu 1.0 does not work on ARM hosts -- see the rel

[Qemu-devel] [PATCH 3/3] Remove unnecessary includes of primecell.h

2012-02-09 Thread Peter Maydell
The primecell.h header now only has the definitions of constants indicating the usage of the arm_sysctl GPIO lines; remove obsolete includes of it from source files which don't care about those GPIO lines. Signed-off-by: Peter Maydell --- hw/highbank.c |1 - hw/integratorcp.c |

[Qemu-devel] [PATCH 2/3] hw/primecell.h: Remove obsolete pl080_init() declaration

2012-02-09 Thread Peter Maydell
Remove an obsolete declaration of pl080_init(), which has been incorrect since the conversion of pl080 to qdev back in 2009. Signed-off-by: Peter Maydell --- hw/primecell.h |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/hw/primecell.h b/hw/primecell.h index e709ad3

[Qemu-devel] [PATCH 0/3] primecell.h cleanups

2012-02-09 Thread Peter Maydell
than nameless arrays of GPIO lines we'll be able to drop the remaining two #defines and delete the header altogether... Peter Maydell (3): hw/arm_sysctl: Drop legacy init function hw/primecell.h: Remove obsolete pl080_init() declaration Remove unnecessary includes of primecell.h hw/ar

[Qemu-devel] [PATCH 1/3] hw/arm_sysctl: Drop legacy init function

2012-02-09 Thread Peter Maydell
Drop the legacy init function arm_sysctl_init(), since it has no users left any more. This allows us to drop the awkward '1' from the actual device init function. Signed-off-by: Peter Maydell Acked-by: Andreas Färber --- hw/arm_sysctl.c | 16 ++-- hw/primecell.h |

Re: [Qemu-devel] [PATCH v14 02/10] ARM: Samsung exynos4210-based boards emulation

2012-02-09 Thread Peter Maydell
On 9 February 2012 08:42, Evgeny Voevodin wrote: > Add initial support of NURI and SMDKC210 boards > > Signed-off-by: Evgeny Voevodin Doesn't compile: CCarm-softmmu/exynos4210.o /home/petmay01/git/qemu/hw/exynos4210.c: In function ‘exynos4210_init’: /home/petmay01/git/qemu/hw/exynos4210.c:

Re: [Qemu-devel] KVM call agenda for tuesday 31

2012-02-09 Thread Peter Maydell
Ping re the VMState and variable sized arrays issue. I don't see any consensus in this discussion for a different approach, so should we just commit Mitsyanko's patchset? - PMM On 31 January 2012 13:15, Andreas Färber wrote: > Am 31.01.2012 00:53, schrieb Anthony Liguori: >> On 01/30/2012 05:41

Re: [Qemu-devel] [PATCH v1 1/1] ./configure: add option for disabling VirtFS

2012-02-09 Thread Peter Maydell
On 7 February 2012 20:44, Meador Inge wrote: > Signed-off-by: Meador Inge > --- >  Makefile  |    4 >  configure |   16 +--- >  2 files changed, 17 insertions(+), 3 deletions(-) > > diff --git a/Makefile b/Makefile > index 47acf3d..030619c 100644 > --- a/Makefile > +++ b/Makefile

Re: [Qemu-devel] KVM call agenda for tuesday 31

2012-02-09 Thread Peter Maydell
On 9 February 2012 22:37, Anthony Liguori wrote: > I don't know if I mentioned this, but do we really need variable sizes? > > Can we just use a fixed size (pre-allocated) array and then use a > VMSTATE_SUB_ARRAY? > > If it's truly variable size with no upper bound, then that's actually a > securi

[Qemu-devel] qemu-kvm-1.0 crashes with threaded vnc server?

2012-02-09 Thread Peter Lieven
cannot image of any other part of qemu-kvm using libz except for VNC server. Thanks, Peter

[Qemu-devel] qemu-kvm-1.0 regression with usb tablet after live migration

2012-02-09 Thread Peter Lieven
to PS/2 mouse. If I do the same with qemu-kvm-0.12.5 with the very same VM its working fine. Can anyone imagine what introduced this flaw? Thanks, Peter

Re: [Qemu-devel] [PATCH 5/5] Add Cortex-A15 CPU definition

2012-02-09 Thread Peter Maydell
On 10 February 2012 01:23, Paul Brook wrote: >> Add a definition of a Cortex-A15 CPU. Note that for the moment we do >> not implement any of: >>  * Large Physical Address Extensions (LPAE) >>  * Virtualization Extensions >>  * Generic Timer > > Are there feature bits that the guest can check befor

Re: [Qemu-devel] [RFC PATCH] arm boot: added QOM device definition

2012-02-09 Thread Peter Crosthwaite
On Thu, Feb 9, 2012 at 11:22 PM, Andreas Färber wrote: > Am 08.02.2012 08:55, schrieb Peter A. G. Crosthwaite: > > From: "Peter A. G. Crosthwaite" > > > > Create a QOM device for bootstrapping linux on arm. Wraps the existing > > arm_boot code and calls arm

Re: [Qemu-devel] [PATCH v2 1/1] ./configure: add option for disabling VirtFS

2012-02-09 Thread Peter Maydell
On 10 February 2012 02:06, Meador Inge wrote: > +  if test "$virtfs" != no ; then > +      if [ "$cap" = "yes" -a "$linux" = "yes" -a "$attr" = "yes" ] ; then The test -a operator is deprecated by POSIX; use test "$cap" = yes && test "$linux" = yes && test "$attr" = yes instead. -- PMM

Re: [Qemu-devel] [PATCH v3 2/4] cadence_ttc: initial version of device model

2012-02-11 Thread Peter Crosthwaite
2012/2/12 Paul Brook > > +static void cadence_timer_sync(CadenceTimerState *s) > > +{ > >... > > +r = (int64_t)cadence_timer_get_steps(s, s->cpu_time - old_time); > > +x = (int64_t)s->reg_value + ((s->reg_count & COUNTER_CTRL_DEC) ? -r > : > > r); + > > +for (i = 0; i < 3; ++i) { > >

Re: [Qemu-devel] qemu-kvm-1.0 crashes with threaded vnc server?

2012-02-13 Thread Peter Lieven
Am 11.02.2012 um 09:55 schrieb Corentin Chary: > On Thu, Feb 9, 2012 at 7:08 PM, Peter Lieven wrote: >> Hi, >> >> is anyone aware if there are still problems when enabling the threaded vnc >> server? >> I saw some VMs crashing when using a qemu-kvm

Re: [Qemu-devel] [PATCH] oslib: make error handling more reasonable

2012-02-13 Thread Peter Maydell
On 13 February 2012 14:04, Markus Armbruster wrote: > I consider abort() on OOM somewhat eccentric.  abort() is for > programming errors.  Resource shortage is an environmental error that is > sometimes (but not always) caused by a programming error. > > I'd rather inconvenience programmers (by ma

Re: [Qemu-devel] [PATCH 0/3] New sigaltstack method for coroutine

2012-02-13 Thread Peter Maydell
On 13 February 2012 14:42, Alex Barcelo wrote: > This series of patches implements coroutines method with > sigaltstack. > > The flow of creation and management of the coroutines is > quite similar to the coroutine-ucontext.c. The way to use > sigaltstack to achieve the needed stack manipulation i

Re: [Qemu-devel] [PATCH v15 00/10] ARM: Samsung Exynos4210-based boards support.

2012-02-14 Thread Peter Maydell
On 14 February 2012 10:27, Evgeny Voevodin wrote: > On 10.02.2012 09:36, Evgeny Voevodin wrote: >> This set of patches adds support for Samsung Exynos4210-based boards NURI >> and SMDKC210. > Ping... > Is somebody going to review? It is on my todo list, but I was flying back from a conference sa

[Qemu-devel] [PATCH] hw/pl031: Actually raise interrupt on timer expiry

2012-02-14 Thread Peter Maydell
ff-by: Peter Maydell --- Looks like our PL031 has always had this bug since it was added in 2007... Daniel Forsgren reported this, suggested the fix and pointed me at the test program. Thanks! https://bugs.launchpad.net/qemu-linaro/+bug/931940 hw/pl031.c |2 +- 1 files changed, 1 insertions(

Re: [Qemu-devel] [PATCH v15 00/10] ARM: Samsung Exynos4210-based boards support.

2012-02-14 Thread Peter Maydell
On 10 February 2012 05:36, Evgeny Voevodin wrote: > This set of patches adds support for Samsung Exynos4210-based boards NURI and > SMDKC210. > Tested on Linux kernel v3.x series. > Boot smdkc210 board with root filesystem on NFS disk and serial port #0 > redirected to terminal > # qemu-system-

Re: [Qemu-devel] [PATCH v15 00/10] ARM: Samsung Exynos4210-based boards support.

2012-02-15 Thread Peter Maydell
On 15 February 2012 04:16, Evgeny Voevodin wrote: >> On 14.02.2012 23:51, Peter Maydell wrote: >>> Have you tried booting this with the 'earlyprintk' kernel option? >>> I tried this with a 3.2.0 kernel and the exynos4 defconfig and it >>> crashes >

Re: [Qemu-devel] [RFC][PATCH 08/16 v6] target-i386: add API to get dump info

2012-02-15 Thread Peter Maydell
On 9 February 2012 03:26, Wen Congyang wrote: > +int cpu_get_dump_info(ArchDumpInfo *info) > +{ > +    bool lma = false; > +    RAMBlock *block; > + > +#ifdef TARGET_X86_64 > +    lma = !!(first_cpu->hflags & HF_LMA_MASK); > +#endif > + > +    if (lma) { > +        info->d_machine = EM_X86_64; > +

Re: [Qemu-devel] qemu-kvm-1.0 regression with usb tablet after live migration

2012-02-15 Thread Peter Lieven
Anyone? Peter Lieven wrote: > Hi, > > i recently started updating our VMs to qemu-kvm 1.0. Since that I see > that the usb tablet device (used for as pointer device for accurate > mouse positioning) becomes unavailable after live migrating. > If I migrate a few times a Windows 7

Re: [Qemu-devel] [PATCH v15 00/10] ARM: Samsung Exynos4210-based boards support.

2012-02-15 Thread Peter Maydell
On 10 February 2012 05:36, Evgeny Voevodin wrote: > This set of patches adds support for Samsung Exynos4210-based boards NURI and > SMDKC210. Whole series: Reviewed-by: Peter Maydell -- PMM

Re: [Qemu-devel] [PATCH] hw/pl031: Actually raise interrupt on timer expiry

2012-02-15 Thread Peter Maydell
On 15 February 2012 11:23, Andreas Färber wrote: > Am 14.02.2012 18:40, schrieb Peter Maydell: >> Fix a typo in pl031_interrupt() which meant we were setting a bit >> in the interrupt mask rather than the interrupt status register >> and thus not actually raising an interrupt

Re: [Qemu-devel] [PATCH v2 7/9] hw/vexpress.c: Instantiate the motherboard CLCD

2012-02-15 Thread Peter Maydell
On 10 February 2012 02:51, Paul Brook wrote: >> I do hope we find a solution to deal with n displays in the future. I >> consider that a post-QOM topic and maybe Anthony's planned DisplayState >> refactoring helps with that. > > It used to work.  Not particularly pretty or user friendly, but defin

[Qemu-devel] [PATCH v5 6/7] arm_boot: Pass base address of GIC CPU interface, not whole GIC

2012-02-15 Thread Peter Maydell
address directly. Signed-off-by: Peter Maydell --- hw/arm-misc.h |2 +- hw/arm_boot.c |8 hw/realview.c | 12 +++- hw/vexpress.c |6 -- 4 files changed, 16 insertions(+), 12 deletions(-) diff --git a/hw/arm-misc.h b/hw/arm-misc.h index 5e5204b..306013a 100644 --- a

[Qemu-devel] [PATCH v5 4/7] hw/vexpress.c: Factor out daughterboard-specific initialization

2012-02-15 Thread Peter Maydell
Factor out daughterboard specifics into a data structure and daughterboard initialization function, in preparation for adding vexpress-a15 support. Signed-off-by: Peter Maydell --- hw/vexpress.c | 118 - 1 files changed, 83 insertions

[Qemu-devel] [PATCH v5 1/7] hw/a15mpcore.c: Add Cortex-A15 private peripheral model

2012-02-15 Thread Peter Maydell
Add a model of the Cortex-A15 memory mapped private peripheral space. This is fairly simple because the only memory mapped bit of the A15 is the GIC. Note that we don't currently model a VGIC and therefore don't map the VGIC related bits of the GIC. Signed-off-by: Pet

[Qemu-devel] [PATCH v5 7/7] hw/vexpress.c: Add vexpress-a15 machine

2012-02-15 Thread Peter Maydell
Add the vexpress-a15 machine, and the A-Series memory map it uses. Signed-off-by: Peter Maydell Reviewed-by: Andreas Färber --- hw/vexpress.c | 141 + 1 files changed, 141 insertions(+), 0 deletions(-) diff --git a/hw/vexpress.c b/hw

[Qemu-devel] [PATCH v5 0/7] Add support for vexpress-a15

2012-02-15 Thread Peter Maydell
r comment in one file * rebased on current master after the QOM.3 series landing Changes v2->v3: * the target-arm patches are now in master * dropped spurious 'const' from 'factor out daughterboard' patch * rebased on current master and updated a15mpcore.c with QOM changes Pet

[Qemu-devel] [PATCH v5 2/7] hw/vexpress.c: Make motherboard peripheral memory map table-driven

2012-02-15 Thread Peter Maydell
y A9. Signed-off-by: Peter Maydell Reviewed-by: Andreas Färber --- hw/vexpress.c | 137 +++-- 1 files changed, 103 insertions(+), 34 deletions(-) diff --git a/hw/vexpress.c b/hw/vexpress.c index 43f47a6..38ae05f 100644 --- a/hw/vexpress.c

Re: [Qemu-devel] [PATCH v5 6/7] arm_boot: Pass base address of GIC CPU interface, not whole GIC

2012-02-15 Thread Peter Maydell
On 15 February 2012 14:36, Peter Maydell wrote: > The arm_boot secondary boot loader code needs the address of > the GIC CPU interface. Obtaining this from the base address > of the private peripheral region was possible for A9 and 11MPcore, > but the A15 puts the GIC CPU interface in

Re: [Qemu-devel] QEMU Mascot Competition

2012-02-15 Thread Peter Maydell
On 15 February 2012 15:37, Anthony Liguori wrote: > On 02/15/2012 09:23 AM, Jan Kiszka wrote: >> Are there 8 candidates? Just to make sure we miss none (threaded >> numbered postings would have been nice). > > Yeah, git-send-email can't attach images and I didn't want to it further to > write a py

Re: [Qemu-devel] [PATCH v1] ./configure: use -lole32 when building with mingw32

2012-02-15 Thread Peter Maydell
On 15 February 2012 16:41, Meador Inge wrote: > glib calls 'CoTaskMemFree' which is defined by ole32.dll. > Therefore when building with mingw32 -lole32 should be in > 'LIBS'. Not that I'm objecting to the patch, but isn't this technically a bug in the pkg-config for glib with mingw32 that we're

Re: [Qemu-devel] [PATCH v1 0/1] Fix GDB semihosting

2012-02-15 Thread Peter Maydell
On 15 February 2012 16:55, Meador Inge wrote: > This patch fixes the problem be staying in the 'RS_SYSCALL' state until next > packet read comes in.  Therefore keeping any 'T' statuses from being sent > back to the GDB client while the syscall is still being processed. Wouldn't it be more logical

[Qemu-devel] [PATCH v5 3/7] hw/vexpress.c: Move secondary CPU boot code to SRAM

2012-02-15 Thread Peter Maydell
" RAM page we were using before. Signed-off-by: Peter Maydell --- hw/vexpress.c | 16 ++-- 1 files changed, 2 insertions(+), 14 deletions(-) diff --git a/hw/vexpress.c b/hw/vexpress.c index 38ae05f..6d8eee2 100644 --- a/hw/vexpress.c +++ b/hw/vexpress.c @@ -30,13 +30,9 @@

Re: [Qemu-devel] [PATCH v1 0/1] Fix GDB semihosting

2012-02-15 Thread Peter Maydell
I wrote: > This patch works (in that it fixes this problem with a test case I have > coincidentally received from another reporter this week), although I > notice that doing read/write syscalls via gdb is dreadfully slow > because there seems to be ~1second delay between gdb sending its response >

[Qemu-devel] [PATCH v5 5/7] hw/vexpress.c: Instantiate the motherboard CLCD

2012-02-15 Thread Peter Maydell
mux which video output to pass through to the outside world. Signed-off-by: Peter Maydell Reviewed-by: Andreas Färber --- hw/vexpress.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/vexpress.c b/hw/vexpress.c index 8239ea1..43ad206 100644 --- a/hw/vexpress.c +++ b/hw/

Re: [Qemu-devel] [PATCH v2] MAINTAINERS: Add hw/highbank.c maintainer

2012-02-15 Thread Peter Maydell
I've taken this into arm-devs.next (fixing up the trivial conflict with the Exynos new entry in the process). thanks -- PMM On 6 February 2012 14:05, Mark Langsdorf wrote: > Signed-off-by: Mark Langsdorf > --- > Changes from v1 >        Put entry in alphabetical order >        Added maintainers

Re: [Qemu-devel] [PATCH 1/2] slirp: remove duplicate definition

2012-02-15 Thread Peter Maydell
On 15 February 2012 23:02, Andreas Färber wrote: > Am 15.02.2012 10:38, schrieb Michael S. Tsirkin: >> why does slirp have all these >> defines in the first place? >> >> slirp/mbuf.h:#define m_nextpkt  m_hdr.mh_nextpkt >> slirp/mbuf.h:#define ifs_next m_nextpkt >> >> Seriously, #define for a field

Re: [Qemu-devel] [PATCH v16 00/10] ARM: Samsung Exynos4210-based boards support.

2012-02-16 Thread Peter Maydell
On 16 February 2012 04:44, Evgeny Voevodin wrote: > On 16.02.2012 08:40, Evgeny Voevodin wrote: >> >> This set of patches adds support for Samsung Exynos4210-based boards NURI >> and SMDKC210. >> Tested on Linux kernel v3.x series. > > > Guys, I think that this is a time to apply this patch series

Re: [Qemu-devel] [PATCH v5 0/7] Add support for vexpress-a15

2012-02-16 Thread Peter Maydell
On 15 February 2012 14:36, Peter Maydell wrote: > This patchset adds support for the Versatile Express A15 daughterboard. > The resulting model is capable of booting a Linux kernel which has > been configured for Cortex-A15 with the Versatile Express "extended > memory map&quo

Re: [Qemu-devel] [PATCH] slirp: kill ugly macros

2012-02-16 Thread Peter Maydell
On 16 February 2012 11:06, Kevin Wolf wrote: > What are all these m_ and mh_ prefixes for struct fields even about? > When I have an mbuf, I know perfectly well that it is one, and that > m_hdr is a header of it. That's the dead hand of Sixth Edition Unix and its C compiler that put all struct fi

Re: [Qemu-devel] [PATCH] [TRIVIAL] Removed unused pl080_init().

2012-02-16 Thread Peter Maydell
On 16 February 2012 17:36, Alexander Barabash wrote: > >    Removed unused pl080_init(). I posted the equivalent of this patch recently and it is in arm-devs.next -- please don't commit to qemu-trivial. Thanks -- PMM

Re: [Qemu-devel] [PATCH] [TRIVIAL] Replace object_delete() with object_unref().

2012-02-16 Thread Peter Maydell
Object model lifecycle changes aren't trivial IMHO. [no comment on actual patch contents implied] -- PMM On 16 February 2012 17:38, Alexander Barabash wrote: > >    Replace object_delete() with object_unref(). > >    In the existing implementation, object_delete() >    calls object_unref(), then

Re: [Qemu-devel] [PATCH] Add object_property_get_child().

2012-02-16 Thread Peter Maydell
On 16 February 2012 17:39, Alexander Barabash wrote: > >    Add object_property_get_child(). > >    Adding a direct accessor to a child property. > >    In the existing implementation, object_property_get() must be used, >    with with a visitor, implementing the 'type_str' callback, >    receivin

Re: [Qemu-devel] [PATCH] [TRIVIAL] Removed unused arm_sysctl_init().

2012-02-16 Thread Peter Maydell
On 16 February 2012 17:37, Alexander Barabash wrote: > >    Removed unused arm_sysctl_init(). >    Renamed arm_sysctl_init1() into arm_sysctl_init(). > >    Signed-off-by: Alexander Barabash This also is textually identical to a patch I just submitted this week. Are you sure you aren't somehow l

Re: [Qemu-devel] [PATCH] [TRIVIAL] Removed unused arm_sysctl_init().

2012-02-16 Thread Peter Maydell
On 16 February 2012 18:18, Peter Maydell wrote: > On 16 February 2012 17:37, Alexander Barabash > wrote: >> >>    Removed unused arm_sysctl_init(). >>    Renamed arm_sysctl_init1() into arm_sysctl_init(). >> >>    Signed-off-by: Alexander Barabash > > T

Re: [Qemu-devel] [PATCH v1 0/1] Fix GDB semihosting

2012-02-16 Thread Peter Maydell
On 16 February 2012 18:39, Meador Inge wrote: > On 02/15/2012 02:14 PM, Peter Maydell wrote: >> I think the right way to deal with both the problem you were seeing >> and this related issue is simply not to try to send the syscall >> request until we have really stopped the C

Re: [Qemu-devel] [PATCH v3 1/1] ./configure: add option for disabling VirtFS

2012-02-17 Thread Peter Maydell
On 17 February 2012 08:22, Aneesh Kumar K.V wrote: > On Thu, 9 Feb 2012 20:31:17 -0600, Meador Inge > wrote: >> --- a/configure >> +++ b/configure >> @@ -121,6 +121,7 @@ docs="" >>  fdt="" >>  nptl="" >>  sdl="" >> +virtfs="" > > do we want to say > > virtfs="yes" No. The standard pattern for c

[Qemu-devel] [PATCH 04/22] ARM: exynos4210: PWM support.

2012-02-17 Thread Peter Maydell
From: Evgeny Voevodin Signed-off-by: Evgeny Voevodin Signed-off-by: Peter Maydell --- Makefile.target |2 +- hw/exynos4210.c | 12 ++ hw/exynos4210_pwm.c | 422 +++ 3 files changed, 435 insertions(+), 1 deletions(-) create mode

[Qemu-devel] [PATCH 11/22] hw/a15mpcore.c: Add Cortex-A15 private peripheral model

2012-02-17 Thread Peter Maydell
Add a model of the Cortex-A15 memory mapped private peripheral space. This is fairly simple because the only memory mapped bit of the A15 is the GIC. Note that we don't currently model a VGIC and therefore don't map the VGIC related bits of the GIC. Signed-off-by: Pet

[Qemu-devel] [PATCH 12/22] hw/vexpress.c: Make motherboard peripheral memory map table-driven

2012-02-17 Thread Peter Maydell
y A9. Signed-off-by: Peter Maydell Reviewed-by: Andreas Färber --- hw/vexpress.c | 137 +++-- 1 files changed, 103 insertions(+), 34 deletions(-) diff --git a/hw/vexpress.c b/hw/vexpress.c index 43f47a6..38ae05f 100644 --- a/hw/vexpress.c

[Qemu-devel] [PATCH 19/22] hw/primecell.h: Remove obsolete pl080_init() declaration

2012-02-17 Thread Peter Maydell
Remove an obsolete declaration of pl080_init(), which has been incorrect since the conversion of pl080 to qdev back in 2009. Signed-off-by: Peter Maydell --- hw/primecell.h |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/hw/primecell.h b/hw/primecell.h index e709ad3

[Qemu-devel] [PATCH 13/22] hw/vexpress.c: Move secondary CPU boot code to SRAM

2012-02-17 Thread Peter Maydell
" RAM page we were using before. Signed-off-by: Peter Maydell --- hw/vexpress.c | 16 ++-- 1 files changed, 2 insertions(+), 14 deletions(-) diff --git a/hw/vexpress.c b/hw/vexpress.c index 38ae05f..6d8eee2 100644 --- a/hw/vexpress.c +++ b/hw/vexpress.c @@ -30,13 +30,9 @@

[Qemu-devel] [PATCH 10/22] MAINTAINERS: Add maintainers for Exynos SOC.

2012-02-17 Thread Peter Maydell
From: Evgeny Voevodin Signed-off-by: Evgeny Voevodin Acked-by: Andreas Färber Signed-off-by: Peter Maydell --- MAINTAINERS |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 173e893..e55ea0f 100644 --- a/MAINTAINERS +++ b

[Qemu-devel] [PATCH 16/22] arm_boot: Pass base address of GIC CPU interface, not whole GIC

2012-02-17 Thread Peter Maydell
address directly. Signed-off-by: Peter Maydell --- hw/arm-misc.h |2 +- hw/arm_boot.c |8 hw/exynos4_boards.c |3 ++- hw/realview.c | 12 +++- hw/vexpress.c |6 -- 5 files changed, 18 insertions(+), 13 deletions(-) diff --git a/hw/arm

[Qemu-devel] [PATCH 07/22] hw/lan9118: Add basic 16-bit mode support.

2012-02-17 Thread Peter Maydell
From: Evgeny Voevodin Signed-off-by: Evgeny Voevodin Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- hw/lan9118.c | 124 +++--- 1 files changed, 118 insertions(+), 6 deletions(-) diff --git a/hw/lan9118.c b/hw/lan9118.c index

[Qemu-devel] [PATCH 03/22] ARM: exynos4210: UART support

2012-02-17 Thread Peter Maydell
From: Maksim Kozlov Add basic support of exynos4210 UART Signed-off-by: Maksim Kozlov Signed-off-by: Evgeny Voevodin Signed-off-by: Peter Maydell --- Makefile.target |2 +- hw/exynos4210.c | 29 +++ hw/exynos4210.h |9 + hw/exynos4210_uart.c | 676

[Qemu-devel] [PATCH 01/22] ARM: exynos4210: IRQ subsystem support.

2012-02-17 Thread Peter Maydell
From: Evgeny Voevodin Signed-off-by: Evgeny Voevodin Signed-off-by: Peter Maydell --- Makefile.target |1 + hw/exynos4210.h | 82 hw/exynos4210_combiner.c | 469 ++ hw/exynos4210_gic.c | 458

[Qemu-devel] [PATCH 20/22] Remove unnecessary includes of primecell.h

2012-02-17 Thread Peter Maydell
The primecell.h header now only has the definitions of constants indicating the usage of the arm_sysctl GPIO lines; remove obsolete includes of it from source files which don't care about those GPIO lines. Signed-off-by: Peter Maydell --- hw/highbank.c |1 - hw/integratorcp.c |

[Qemu-devel] [PATCH 15/22] hw/vexpress.c: Instantiate the motherboard CLCD

2012-02-17 Thread Peter Maydell
mux which video output to pass through to the outside world. Signed-off-by: Peter Maydell Reviewed-by: Andreas Färber --- hw/vexpress.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/vexpress.c b/hw/vexpress.c index 8239ea1..43ad206 100644 --- a/hw/vexpress.c +++ b/hw/

[Qemu-devel] [PATCH 17/22] hw/vexpress.c: Add vexpress-a15 machine

2012-02-17 Thread Peter Maydell
Add the vexpress-a15 machine, and the A-Series memory map it uses. Signed-off-by: Peter Maydell Reviewed-by: Andreas Färber --- hw/vexpress.c | 141 + 1 files changed, 141 insertions(+), 0 deletions(-) diff --git a/hw/vexpress.c b/hw

[Qemu-devel] [PATCH 22/22] hw/pl031: Actually raise interrupt on timer expiry

2012-02-17 Thread Peter Maydell
ed-by: Daniel Forsgren Signed-off-by: Peter Maydell Acked-by: Andreas Färber --- hw/pl031.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/pl031.c b/hw/pl031.c index 05b5b11..69abc4f 100644 --- a/hw/pl031.c +++ b/hw/pl031.c @@ -76,7 +76,7 @@ static void pl031_interrupt

[Qemu-devel] [PATCH 06/22] ARM: exynos4210: MCT support.

2012-02-17 Thread Peter Maydell
From: Evgeny Voevodin Signed-off-by: Evgeny Voevodin Signed-off-by: Peter Maydell --- Makefile.target |2 +- hw/exynos4210.c | 19 + hw/exynos4210_mct.c | 1488 +++ 3 files changed, 1508 insertions(+), 1 deletions(-) create mode

[Qemu-devel] [PATCH 08/22] hw/exynos4210.c: Add LAN support for SMDKC210.

2012-02-17 Thread Peter Maydell
From: Evgeny Voevodin SMDKC210 uses lan9215 chip, but lan9118 in 16-bit mode seems to be enough. Signed-off-by: Evgeny Voevodin Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- hw/exynos4_boards.c | 27 +-- 1 files changed, 25 insertions(+), 2 deletions

[Qemu-devel] [PATCH 14/22] hw/vexpress.c: Factor out daughterboard-specific initialization

2012-02-17 Thread Peter Maydell
Factor out daughterboard specifics into a data structure and daughterboard initialization function, in preparation for adding vexpress-a15 support. Signed-off-by: Peter Maydell --- hw/vexpress.c | 118 - 1 files changed, 83 insertions

[Qemu-devel] [PATCH 02/22] ARM: Samsung exynos4210-based boards emulation

2012-02-17 Thread Peter Maydell
From: Evgeny Voevodin Add initial support of NURI and SMDKC210 boards Signed-off-by: Evgeny Voevodin Signed-off-by: Peter Maydell --- Makefile.target |3 +- hw/exynos4210.c | 191 +++ hw/exynos4210.h | 40 +++ hw

[Qemu-devel] [PATCH 21/22] MAINTAINERS: Add hw/highbank.c maintainer

2012-02-17 Thread Peter Maydell
From: Mark Langsdorf Signed-off-by: Mark Langsdorf Signed-off-by: Peter Maydell --- MAINTAINERS |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index e55ea0f..8eb80ea 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -191,6 +191,12 @@ M

[Qemu-devel] [PATCH 18/22] hw/arm_sysctl: Drop legacy init function

2012-02-17 Thread Peter Maydell
Drop the legacy init function arm_sysctl_init(), since it has no users left any more. This allows us to drop the awkward '1' from the actual device init function. Signed-off-by: Peter Maydell Acked-by: Andreas Färber --- hw/arm_sysctl.c | 16 ++-- hw/primecell.h |

[Qemu-devel] [PULL 00/22] arm-devs queue

2012-02-17 Thread Peter Maydell
implementation Peter Maydell (11): hw/a15mpcore.c: Add Cortex-A15 private peripheral model hw/vexpress.c: Make motherboard peripheral memory map table-driven hw/vexpress.c: Move secondary CPU boot code to SRAM hw/vexpress.c: Factor out daughterboard-specific initialization

[Qemu-devel] [PATCH 05/22] ARM: exynos4210: basic Power Management Unit implementation

2012-02-17 Thread Peter Maydell
-by: Evgeny Voevodin Signed-off-by: Peter Maydell --- Makefile.target |1 + hw/exynos4210.c |9 + hw/exynos4210_pmu.c | 499 +++ 3 files changed, 509 insertions(+), 0 deletions(-) create mode 100644 hw/exynos4210_pmu.c diff --git a

Re: [Qemu-devel] [PATCH 2/2] qdev: print error message before aborting

2012-02-17 Thread Peter Maydell
On 14 February 2012 09:19, Paolo Bonzini wrote: > qdev_prop_set_* functions are always called by machine init functions > that should know what they're doing, so they abort on error.  Still, > an assert(!errp) does not aid debugging.  Print an error before aborting. So now you get: qemu-system-ar

[Qemu-devel] omap_i2c: distinction between OMAP2_INTR_REV and OMAP2_GC_REV?

2012-02-17 Thread Peter Maydell
I'm looking at cleaning up some more omap3 patches, and have been working on the omap_i2c related ones. At the moment in omap_i2c.c there are the following #defines for the I2C module revision (as exposed via the revision register): #define OMAP2_INTR_REV 0x34 #define OMAP2_GC_REV 0x34 (plus a

[Qemu-devel] [RFC v2 1/6] linux-headers: Add ARM KVM headers (not for upstream)

2012-10-10 Thread Peter Maydell
This commit adds the ARM KVM headers. This is not to go to QEMU upstream -- the correct path there is that the KVM code will be committed to a mainline upstream kernel, and then upstream QEMU can do a bulk header update from the upstream kernel, which will allow us to drop this temporary commit. T

[Qemu-devel] [RFC v2 2/6] ARM: KVM: Add support for KVM on ARM architecture

2012-10-10 Thread Peter Maydell
From: Christoffer Dall Add basic support for KVM on ARM architecture. Signed-off-by: Christoffer Dall [PMM: Minor tweaks and code cleanup, switch to ONE_REG] Signed-off-by: Peter Maydell --- hw/arm_pic.c | 28 target-arm/Makefile.objs |1 + target-arm/cpu.h

[Qemu-devel] [RFC v2 4/6] hw/kvm/arm_gic: Implement support for KVM in-kernel ARM GIC

2012-10-10 Thread Peter Maydell
Implement support for using the KVM in-kernel GIC for ARM. Signed-off-by: Peter Maydell --- hw/a15mpcore.c |8 ++- hw/arm/Makefile.objs |1 + hw/kvm/arm_gic.c | 162 ++ 3 files changed, 170 insertions(+), 1 deletion(-) create

Re: [Qemu-devel] [PATCH 0/2] signal: Preparing safe sigprocmask wrapper on qemu-user

2012-10-10 Thread Peter Maydell
On 8 October 2012 19:42, Alex Barcelo wrote: > okay, now I see that this lacks a lot of "presentation". > Before sending a v2, is there something more that I should correct? Well, yes, your cover letter could be a little more verbose, but I think mostly it's just that nobody's got round to revie

[Qemu-devel] [RFC v2 5/6] ARM KVM: save and load VFP registers from kernel

2012-10-10 Thread Peter Maydell
ff-by: Peter Maydell --- target-arm/kvm.c | 78 +++--- 1 file changed, 75 insertions(+), 3 deletions(-) diff --git a/target-arm/kvm.c b/target-arm/kvm.c index fee60e1..f17e7fd 100644 --- a/target-arm/kvm.c +++ b/target-arm/kvm.c @@ -39,10 +39,28 @

[Qemu-devel] [RFC v2 6/6] configure: Enable KVM on ARM

2012-10-10 Thread Peter Maydell
Enable KVM on ARM hosts, now that all the necessary components for it exist. Signed-off-by: Peter Maydell --- configure |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index c4a7837..f87bcd6 100755 --- a/configure +++ b/configure @@ -3886,7 +3886,7

[Qemu-devel] [RFC v2 0/6] QEMU: Support KVM on ARM

2012-10-10 Thread Peter Maydell
ist. If anybody feels any of the todo-type stuff is a blocker to these patches being committed that would be good to know too :-)) Git tree if preferred: git://git.linaro.org/people/pmaydell/qemu-arm.git kvm-arm-v12 Peter Maydell (6): linux-headers: Add ARM KVM headers (not for upstream) ARM: K

Re: [Qemu-devel] [PATCH 1/2] signal: added a wrapper for sigprocmask function

2012-10-10 Thread Peter Maydell
On 29 September 2012 17:11, Alex Barcelo wrote: Hi; thanks for this patch. > A transparent wrapper for sigprocmask function. As I mentioned in my reply to the cover letter, this needs a Signed-off-by: line. The commit message could also be a bit more verbose, for instance something like: Crea

[Qemu-devel] [RFC v2 3/6] hw/arm_gic: Add presave/postload hooks

2012-10-10 Thread Peter Maydell
Add presave/postload hooks to the ARM GIC common base class. These will be used by the KVM in-kernel GIC subclass to sync state between kernel and userspace when migrating. Signed-off-by: Peter Maydell --- hw/arm_gic_common.c | 10 ++ hw/arm_gic_internal.h |2 ++ 2 files changed

<    1   2   3   4   5   6   7   8   9   10   >