Re: [Qemu-devel] [PATCH 5/6] add visitor for parsing hz[KMG] input string

2012-12-05 Thread mdroth
On Tue, Dec 04, 2012 at 05:34:42PM -0200, Eduardo Habkost wrote: > From: Igor Mammedov > > Signed-off-by: Igor Mammedov > Acked-by: Andreas Färber > --- > qapi/qapi-visit-core.c | 11 +++ > qapi/qapi-visit-core.h | 2 ++ > qapi/string-input-visitor.c | 22 +++

Re: [Qemu-devel] [PATCH 5/6] add visitor for parsing hz[KMG] input string

2012-12-05 Thread mdroth
On Wed, Dec 05, 2012 at 05:21:50PM -0200, Eduardo Habkost wrote: > On Wed, Dec 05, 2012 at 11:52:29AM -0600, mdroth wrote: > > On Tue, Dec 04, 2012 at 05:34:42PM -0200, Eduardo Habkost wrote: > [...] > > > diff --git a/qapi/string-input-visitor.c b/qapi/string-input-visitor.

Re: [Qemu-devel] [RFC 2/3] virtio-balloon: re-enable balloon stats

2012-12-06 Thread mdroth
On Tue, Dec 04, 2012 at 01:04:47PM -0200, Luiz Capitulino wrote: > The statistics are now available through device properties via a > polling mechanism. First, a client has to enable polling, then it > can query the stats. > > The following control properties are introduced: > > o stats-polling-

Re: [Qemu-devel] [RFC 3/3] docs: document virtio-balloon stats

2012-12-06 Thread mdroth
On Thu, Dec 06, 2012 at 01:31:09PM -0200, Luiz Capitulino wrote: > On Thu, 6 Dec 2012 13:24:11 + > "Daniel P. Berrange" wrote: > > > On Tue, Dec 04, 2012 at 01:04:48PM -0200, Luiz Capitulino wrote: > > > Signed-off-by: Luiz Capitulino > > > --- > > > docs/virtio-balloon-stats.txt | 73 > >

Re: [Qemu-devel] [PATCH 2/2] target-i386: use visit_type_unit_suffixed_int() to parse tsc_freq property value

2012-12-06 Thread mdroth
On Thu, Dec 06, 2012 at 10:12:05PM +0100, Igor Mammedov wrote: > Signed-off-by: Igor Mammedov Reviewed-by: Michael Roth > --- > v2: >- replace visit_type_freq() with visit_type_unit_suffixed_int() > in x86_cpuid_set_tsc_freq() > --- > target-i386/cpu.c | 2 +- > 1 file changed, 1 in

Re: [Qemu-devel] [PATCH 1/2] qapi: add visitor for parsing int[KMGT] input string

2012-12-06 Thread mdroth
On Thu, Dec 06, 2012 at 10:12:04PM +0100, Igor Mammedov wrote: > Caller of visit_type_unit_suffixed_int() will have to specify > value of 'K' suffix via unit argument. > For Kbytes it's 1024, for Khz it's 1000. > > Signed-off-by: Igor Mammedov Reviewed-by: Michael Roth > --- > v2: > - conve

Re: [Qemu-devel] [PATCH v7 2/2] qemu-ga: sample fsfreeze hooks

2012-12-07 Thread mdroth
On Fri, Dec 07, 2012 at 11:55:16AM -0200, Luiz Capitulino wrote: > On Fri, 07 Dec 2012 17:39:32 +0900 > Tomoki Sekiyama wrote: > > > Adds sample hook scripts for --fsfreeze-hook option of qemu-ga. > > - fsfreeze-hook : execute scripts in fsfreeze-hook.d/ > > - fsfreeze-hook.d/mysql-flush.sh.s

Re: [Qemu-devel] [PATCH 2/2] target-i386: use visit_type_unit_suffixed_int() to parse tsc_freq property value

2012-12-10 Thread mdroth
On Mon, Dec 10, 2012 at 05:13:45PM +0100, Igor Mammedov wrote: > On Fri, 7 Dec 2012 18:09:06 -0200 > Eduardo Habkost wrote: > > > On Fri, Dec 07, 2012 at 08:00:09PM +0100, Andreas Färber wrote: > > > Am 06.12.2012 22:12, schrieb Igor Mammedov: > > > > Signed-off-by: Igor Mammedov > > > > --- > >

Re: [Qemu-devel] [PATCH 1/2] qapi: add visitor for parsing int[KMGT] input string

2012-12-10 Thread mdroth
On Mon, Dec 10, 2012 at 05:01:38PM +0100, Igor Mammedov wrote: > On Fri, 07 Dec 2012 19:57:35 +0100 > Andreas Färber wrote: > > > Am 06.12.2012 22:12, schrieb Igor Mammedov: > > > Caller of visit_type_unit_suffixed_int() will have to specify > > > value of 'K' suffix via unit argument. > > > For

Re: [Qemu-devel] [PATCH 0/3] re-enable balloon stats

2012-12-11 Thread mdroth
On Tue, Dec 11, 2012 at 03:14:02PM +, Dietmar Maurer wrote: > > > > I'm not sure I like this for two reasons. First, there will be cases > > > > where the user doesn't want this to be enabled. Second, we'll be > > > > forcing an interval on users. > > > > > > So when should we set the stats-pol

Re: [Qemu-devel] [PATCH 0/3] re-enable balloon stats

2012-12-11 Thread mdroth
On Tue, Dec 11, 2012 at 04:28:40PM -0200, Luiz Capitulino wrote: > On Tue, 11 Dec 2012 11:38:08 -0600 > mdroth wrote: > > > On Tue, Dec 11, 2012 at 03:14:02PM +, Dietmar Maurer wrote: > > > > > > I'm not sure I like this for two reasons. First, there wi

[Qemu-devel] [ANNOUNCE] QEMU 1.2.2 Stable released

2012-12-11 Thread mdroth
Hi everyone, I am pleased to announce that the QEMU v1.2.2 stable release is now available at: http://wiki.qemu.org/download/qemu-1.2.2.tar.bz2 The official stable-1.2 repository has also been updated to v1.2.2: http://git.qemu.org/?p=qemu-stable-1.2.git;a=summary This release includes 43 buil

Re: [Qemu-devel] [RFC] Time resync by qemu-ga

2013-01-02 Thread mdroth
On Fri, Dec 28, 2012 at 12:29:15AM +0800, Lei Li wrote: > Hi guys, > > I am working on the time drift issue as background info here. > > http://mid.gmane.org/87pq5r5otp@codemonkey.ws > > As Anthony proposed, one part of the solutions is that we want > to add a qemu-ga command to resync the g

Re: [Qemu-devel] Using QEMU guest agent to run programs from guest path

2013-01-02 Thread mdroth
On Mon, Dec 31, 2012 at 06:14:59PM -0200, Erlon Cruz wrote: > Hi, > > > I needed to run an external program in a guest machine. Once this must be > triggered by the host, I first thought in qemu-ga. > Is that possible? In QEMU help page and in the code I couldn't find such > capability. > So Im t

Re: [Qemu-devel] [PATCH] qga: add missing commas in json docs

2013-01-02 Thread mdroth
On Wed, Jan 02, 2013 at 09:15:11AM -0700, Eric Blake wrote: > * qga/qapi-schema.json: Use valid JSON. > > Signed-off-by: Eric Blake Thanks, applied to qga branch > --- > qga/qapi-schema.json | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/qga/qapi-schema.json b/qg

Re: [Qemu-devel] Using QEMU guest agent to run programs from guest path]

2013-01-03 Thread mdroth
On Thu, Jan 03, 2013 at 11:06:02AM -0200, Erlon Cruz wrote: > On Wed, Jan 2, 2013 at 9:04 PM, mdroth wrote: > > > On Mon, Dec 31, 2012 at 06:14:59PM -0200, Erlon Cruz wrote: > > > Hi, > > > > > > > > > I needed to run an external program in a gue

[Qemu-devel] [ANNOUNCE] QEMU 1.3.1 Stable released

2013-01-28 Thread mdroth
Hi everyone, I am pleased to announce that the QEMU v1.3.1 stable release is now available at: http://wiki.qemu.org/download/qemu-1.3.1.tar.bz2 The official stable-1.3 repository has also been updated to v1.3.1: http://git.qemu.org/?p=qemu-stable-1.3.git;a=summary This release includes 29 buil

Re: [Qemu-devel] [PATCH for-1.4] Revert "e1000: no need auto-negotiation if link was down"

2013-02-01 Thread mdroth
On Fri, Feb 01, 2013 at 03:20:59PM +0800, Amos Kong wrote: > On Thu, Jan 31, 2013 at 05:43:51PM -0600, Michael Roth wrote: > > This reverts commit 84dd2120247a7d25ff1bb337de21c0e76816ad2d. > > > > I'm not sure what issue the original commit was meant to fix, or if > > the logic is actually wrong,

Re: [Qemu-devel] [PATCH for-1.4] Revert "e1000: no need auto-negotiation if link was down"

2013-02-01 Thread mdroth
On Fri, Feb 01, 2013 at 03:53:22PM +0800, Amos Kong wrote: > On Fri, Feb 01, 2013 at 03:20:59PM +0800, Amos Kong wrote: > > On Thu, Jan 31, 2013 at 05:43:51PM -0600, Michael Roth wrote: > > > This reverts commit 84dd2120247a7d25ff1bb337de21c0e76816ad2d. > > > > > > I'm not sure what issue the orig

Re: [Qemu-devel] [PATCH 1/2] qga: add guest-get-time command

2013-02-05 Thread mdroth
On Wed, Jan 30, 2013 at 03:37:25PM +0800, Lei Li wrote: > On 01/29/2013 04:24 AM, Anthony Liguori wrote: > >Eric Blake writes: > > > >>On 01/27/2013 11:14 AM, Lei Li wrote: > >>>Signed-off-by: Lei Li > >>>--- > >>> include/qapi/qmp/qerror.h |3 +++ > >>> qga/commands-posix.c | 30

Re: [Qemu-devel] [PATCH for-1.4 01/12] qmp: Fix design bug and read beyond buffer in memchar-write

2013-02-06 Thread mdroth
On Wed, Feb 06, 2013 at 10:06:03AM +0100, Markus Armbruster wrote: > Markus Armbruster writes: > > > Eric Blake writes: > > > >> On 02/05/2013 09:22 AM, Markus Armbruster wrote: > >>> Command memchar-write takes data and size parameter. Begs the > >>> question what happens when data doesn't mat

Re: [Qemu-devel] [PATCH for-1.4 01/12] qmp: Fix design bug and read beyond buffer in memchar-write

2013-02-06 Thread mdroth
On Wed, Feb 06, 2013 at 09:14:12PM +0100, Markus Armbruster wrote: > mdroth writes: > > > On Wed, Feb 06, 2013 at 10:06:03AM +0100, Markus Armbruster wrote: > >> Markus Armbruster writes: > >> > >> > Eric Blake writes: > >> > &

Re: [Qemu-devel] [PATCH for-1.4] qapi: Improve chardev-add documentation

2013-02-12 Thread mdroth
On Tue, Feb 12, 2013 at 05:56:00PM +0100, Markus Armbruster wrote: > Gerd Hoffmann writes: > > > Hi, > > > >> But why nested discriminators? > >> > >> regular files: type=file > >> serial : type=port, data.type=serial > >> parallel : type=port, data.type=parallel > >> >

Re: [Qemu-devel] [RFC PATCH 03/10] qemu-ga: Add an configure option to specify path to Windows VSS SDK

2013-02-14 Thread mdroth
+"") vss_win32_include="" ;; > +*\ *) # The SDK is installed in "Program Files" by default, but we cannot > + # handle path with spaces. So we copy the headers into ".sdk/sdk". > + vss_win32_include="-I$source_path/.

Re: [Qemu-devel] [RFC PATCH 03/10] qemu-ga: Add an configure option to specify path to Windows VSS SDK

2013-02-18 Thread mdroth
On Fri, Feb 15, 2013 at 12:55:49PM +0900, Tomoki Sekiyama wrote: > On 2013/02/15 9:47, mdroth wrote: > [...] > > > > Hi Tomoki, > > Hi, > > > Did you happen to run into this issue compiling the test program? > > > > [mdroth@vm qemu-build]$ ls ~/w/v

Re: [Qemu-devel] [RFC PATCH 04/10] qemu-ga: Add Windows VSS provider to quiesce applications on fsfreeze

2013-02-18 Thread mdroth
ven't quite gotten them all worked out. I've posted what I've gotten so far below, but with those changes applied I'm still running into this one on FC18: [mdroth@vm5 qemu-build]$ rm -rf * && ~/w/qemu3.git/configure --enable-guest-agent --cross-prefix=i686-w64-mingw32- -

Re: [Qemu-devel] [PATCH] qga: cast to int for DWORD type

2013-02-20 Thread mdroth
On Mon, Jan 28, 2013 at 12:49:09PM +0800, Lei Li wrote: > This patch fixes a compiler warning when cross-build: > > qga/service-win32.c: In function 'printf_win_error': > qga/service-win32.c:32:5: warning: format '%d' expects argument of type 'int', > but argument 3 has t

Re: [Qemu-devel] [PATCH] qemu-ga: fix confusing GAChannelMethod comparison

2013-02-20 Thread mdroth
On Tue, Feb 19, 2013 at 03:12:34PM +0100, Stefan Hajnoczi wrote: > In commit 7868e26e5930f49ca942311885776b938dcf3b77 > ("qemu-ga: add initial win32 support") support was added for qemu-ga on > Windows using virtio-serial. Other channel methods (ISA serial and UNIX > domain socket) are not support

Re: [Qemu-devel] [PATCH] move qemu-ga from bin to libexec dir, use $HELPERS

2013-02-21 Thread mdroth
On Sat, Feb 16, 2013 at 10:28:31PM +0400, Michael Tokarev wrote: > This patch does 3 things: > > 1. Renames HELPERS-y Makefile variable to HELPERS > 2. Moves its definition from Makefile to configure > 3. Moves qemu-ga binary from TOOLS to HELPERS. > > The effects are: > > 1. qemu-ga binary is n

Re: [Qemu-devel] [PATCH] move qemu-ga from bin to libexec dir, use $HELPERS

2013-02-21 Thread mdroth
On Thu, Feb 21, 2013 at 03:39:44PM +0100, Paolo Bonzini wrote: > Il 21/02/2013 15:30, Michael Tokarev ha scritto: > > 21.02.2013 17:35, Paolo Bonzini wrote: > >> Il 16/02/2013 19:28, Michael Tokarev ha scritto: > >>> This patch does 3 things: > >>> > >>> 1. Renames HELPERS-y Makefile variable to HE

Re: [Qemu-devel] [PATCH 3/9] event poll: make epoll work for normal fd

2013-02-21 Thread mdroth
On Thu, Feb 21, 2013 at 08:54:47PM +0800, Liu Ping Fan wrote: > From: Liu Ping Fan > > When event poll can work with normal fd, we can port them > onto the event loop. > > Signed-off-by: Liu Ping Fan > --- > hw/dataplane/event-poll.c | 36 > hw/dataplane/

Re: [Qemu-devel] [PATCH 5/9] event poll: enable event poll handle more than one event each time

2013-02-21 Thread mdroth
On Thu, Feb 21, 2013 at 08:54:49PM +0800, Liu Ping Fan wrote: > From: Liu Ping Fan > > Set handled event count at initialized time for the dedicated > thread. > > Signed-off-by: Liu Ping Fan > --- > hw/dataplane/event-poll.c | 31 ++- > hw/dataplane/event-poll.h |

Re: [Qemu-devel] [PATCH 6/9] virtio net: introduce dataplane for virtio net

2013-02-21 Thread mdroth
On Thu, Feb 21, 2013 at 08:54:50PM +0800, Liu Ping Fan wrote: > From: Liu Ping Fan > > This is a emulation to virtio-blk dataplane, which push the data > handling out of biglock. And it is a try to implement this process > in userspace, while vhost-net in kernel. > > Signed-off-by: Liu Ping Fan

Re: [Qemu-devel] [PATCH 0/9] introduce virtio net dataplane

2013-02-21 Thread mdroth
On Thu, Feb 21, 2013 at 06:05:44PM +0100, Paolo Bonzini wrote: > Il 21/02/2013 17:33, Stefan Hajnoczi ha scritto: > > Interesting patch series. I want to share my thoughts on the status of > > dataplane and what I'm currently working on. There will probably be > > some overlap that we can coordin

Re: [Qemu-devel] [PATCH] dataplane: remove EventPoll in favor of AioContext

2013-02-21 Thread mdroth
On Thu, Feb 21, 2013 at 05:29:55PM +0100, Paolo Bonzini wrote: > During the review of the dataplane code, the EventPoll API morphed itself > (not concidentially) into something very very similar to an AioContext. > Thus, it is trivial to convert virtio-blk-dataplane to use AioContext, > and a first

Re: [Qemu-devel] [PATCH] slirp: fixed potential use-after-free of a socket

2013-02-21 Thread mdroth
On Fri, Feb 15, 2013 at 12:00:13PM +0100, Vitaly Chipounov wrote: > A socket may still have references to it in various queues > at the time it is freed, causing memory corruptions. > > Signed-off-by: Vitaly Chipounov > --- > slirp/socket.c | 29 + > 1 file changed,

Re: [Qemu-devel] [PATCH] slirp: fixed potential use-after-free of a socket

2013-02-21 Thread mdroth
On Thu, Feb 21, 2013 at 03:47:25PM -0600, mdroth wrote: > On Fri, Feb 15, 2013 at 12:00:13PM +0100, Vitaly Chipounov wrote: > > A socket may still have references to it in various queues > > at the time it is freed, causing memory corruptions. > > > > Signed-off-by: Vit

Re: [Qemu-devel] [PATCH] fix wrong output with 'info chardev' for tcp socket.

2013-02-21 Thread mdroth
On Fri, Feb 22, 2013 at 12:29:44AM +0400, Michael Tokarev wrote: > 22.02.2013 00:20, Serge E. Hallyn wrote: > > The snprintf format isn't taking into account the new 'left' and > > 'right' variables (for ipv6 []) when placing the ':', which should > > go immediately before the port. > > This fixes

Re: [Qemu-devel] BUG: RTC issue when Windows guest is idle

2013-02-21 Thread mdroth
On Thu, Feb 21, 2013 at 06:16:10PM +, Matthew Anderson wrote: > If this isn't the correct list just let me know, > > I've run into a bug whereby a Windows guest (tested on Server 2008R2 and > 2012) no longer receives RTC ticks when it has been idle for a random amount > of time. HPET is disa

Re: [Qemu-devel] [PATCH 0/9] introduce virtio net dataplane

2013-02-21 Thread mdroth
On Thu, Feb 21, 2013 at 11:12:01PM +0100, Paolo Bonzini wrote: > Il 21/02/2013 22:07, mdroth ha scritto: > >> > > >> > 100% agree. In particular hw/dataplane/event-poll.c should be the first > >> > to go away, but AioContext provides the functional

Re: [Qemu-devel] GTK UI is now the default

2013-02-22 Thread mdroth
On Fri, Feb 22, 2013 at 04:48:47PM +0100, Paolo Bonzini wrote: > Il 22/02/2013 16:17, Anthony Liguori ha scritto: > >> > FWIW I'd be in favor of making grab-on-hover the default. > > It really breaks window manager key bindings. If you alt-tab between > > windows and you happen to end up with the

Re: [Qemu-devel] 'info help'

2013-02-22 Thread mdroth
On Fri, Feb 22, 2013 at 05:10:29PM +, Serge E. Hallyn wrote: > Hi, > > up to and including 1.3.0, monitor.c:do_info(), if it got no arg or an > unknown arg, would do help_cmd(mon, "info"); That behavior is gone in > 1.4.0, so that 'info', 'info help', and 'info whatever' just say unknown > ar

Re: [Qemu-devel] [Bug 1131757] [NEW] QEMU 1.4.0 fails to boot sparc64 linux image

2013-02-22 Thread mdroth
initial load. From the blog you mentioned you can prevent this with the -prom-env 'auto-boot?=false' option, which seems to work for me on both 1.3.0 and 1.4.0: mdroth@loki:~/w/qemu-build2$ sparc64-softmmu/qemu-system-sparc64 -kernel ~/w/qemu-test-images/sparc/sparc-test/vmlinux-2.6.11+tcx

Re: [Qemu-devel] [PATCH 0/9] introduce virtio net dataplane

2013-02-25 Thread mdroth
On Fri, Feb 22, 2013 at 09:53:11AM +0100, Paolo Bonzini wrote: > Il 22/02/2013 00:38, mdroth ha scritto: > > On Thu, Feb 21, 2013 at 11:12:01PM +0100, Paolo Bonzini wrote: > >> Il 21/02/2013 22:07, mdroth ha scritto: > >>>>> > >>>>> 100% agr

Re: [Qemu-devel] [PATCH 1/9] chardev: add support for qapi-based chardev initialization

2013-02-25 Thread mdroth
On Mon, Feb 25, 2013 at 10:03:33AM +0100, Gerd Hoffmann wrote: > This patch add support for a new way to initialize chardev devices. > Instead of calling a initialization function with a QemuOpts we will > now create a (qapi) ChardevBackend, optionally call a function to > fill ChardevBackend from

Re: [Qemu-devel] [PATCH 1/3] two new file wrappers

2013-02-27 Thread mdroth
On Wed, Feb 27, 2013 at 08:46:19AM -0500, Stefan Berger wrote: > On 02/26/2013 09:19 PM, Anthony Liguori wrote: > >jsch...@linux.vnet.ibm.com writes: > > > >I think we've moved away from using qemu-file for anything other than > >migration. > > Our goal was to use the abstraction of a QEMUFile for

Re: [Qemu-devel] [PATCH 2/3] asn1 ber visitors

2013-02-27 Thread mdroth
On Wed, Feb 27, 2013 at 02:03:45PM -0600, Joel Schopp wrote: > Thanks for the feedback. > > On 02/27/2013 02:28 AM, Andreas Färber wrote: > >Am 27.02.2013 00:03, schrieb jsch...@linux.vnet.ibm.com: > >>These patches implement asn1 ber visitors for encoding and decoding data. > > > >Would be good t

Re: [Qemu-devel] [PATCH 1/3] two new file wrappers

2013-02-27 Thread mdroth
On Wed, Feb 27, 2013 at 03:56:27PM -0600, mdroth wrote: > On Wed, Feb 27, 2013 at 08:46:19AM -0500, Stefan Berger wrote: > > On 02/26/2013 09:19 PM, Anthony Liguori wrote: > > >jsch...@linux.vnet.ibm.com writes: > > > > > >I think we've moved away fro

Re: [Qemu-devel] [PATCH 2/3] asn1 ber visitors

2013-02-27 Thread mdroth
On Wed, Feb 27, 2013 at 06:24:45PM -0500, Stefan Berger wrote: > On 02/27/2013 05:57 PM, mdroth wrote: > >On Tue, Feb 26, 2013 at 05:03:56PM -0600, jsch...@linux.vnet.ibm.com wrote: > >>These patches implement asn1 ber visitors for encoding and decoding data. > >>Referen

Re: [Qemu-devel] The state of testing

2013-03-04 Thread mdroth
On Mon, Mar 04, 2013 at 05:22:34PM +0100, Gerd Hoffmann wrote: > Hi, > > > How are things looking with device emulation, migration, monitor, char, etc? > > At the moment autotest/virt-test is pretty much the only workable thing > for non-trivial devices because libqtest lacks infrastructure for

Re: [Qemu-devel] [PATCH 1/2] qga: add guest-get-time command

2013-03-04 Thread mdroth
On Mon, Mar 04, 2013 at 05:16:29PM +0800, Lei Li wrote: > Signed-off-by: Lei Li Reviewed-by: Michael Roth > --- > qga/commands-posix.c | 16 > qga/qapi-schema.json | 13 + > 2 files changed, 29 insertions(+) > > diff --git a/qga/commands-posix.c b/qga/commands-pos

Re: [Qemu-devel] [PATCH 2/2] qga: add guest-set-time command

2013-03-04 Thread mdroth
On Mon, Mar 04, 2013 at 05:16:30PM +0800, Lei Li wrote: > Signed-off-by: Lei Li > --- > qga/commands-posix.c | 54 > > qga/qapi-schema.json | 27 ++ > 2 files changed, 81 insertions(+) > > diff --git a/qga/commands-pos

Re: [Qemu-devel] [PATCH] qemu-ga: make guest-sync-delimited available during fsfreeze

2013-03-04 Thread mdroth
On Fri, Mar 01, 2013 at 11:53:40AM -0600, Michael Roth wrote: > We currently maintain a whitelist of commands that are safe during > fsfreeze. During fsfreeze, we disable all commands that aren't part of > that whitelist. > > guest-sync-delimited meets the criteria for being whitelisted, and is >

Re: [Qemu-devel] [PATCH 2/3] qga: implement qmp_guest_get_vcpus() for Linux with sysfs

2013-03-05 Thread mdroth
On Mon, Mar 04, 2013 at 11:19:56PM +0100, Laszlo Ersek wrote: > > Signed-off-by: Laszlo Ersek > --- > qga/commands-posix.c | 87 > ++ > 1 files changed, 87 insertions(+), 0 deletions(-) > > diff --git a/qga/commands-posix.c b/qga/commands-posix

Re: [Qemu-devel] [PATCH 3/3] qga: implement qmp_guest_set_vcpus() for Linux with sysfs

2013-03-05 Thread mdroth
On Mon, Mar 04, 2013 at 11:19:57PM +0100, Laszlo Ersek wrote: > > Signed-off-by: Laszlo Ersek > --- > qga/commands-posix.c | 51 > ++ > 1 files changed, 51 insertions(+), 0 deletions(-) > > diff --git a/qga/commands-posix.c b/qga/commands-posix

Re: [Qemu-devel] [PATCH 2/3] qga: implement qmp_guest_get_vcpus() for Linux with sysfs

2013-03-05 Thread mdroth
On Tue, Mar 05, 2013 at 01:22:03PM -0700, Eric Blake wrote: > On 03/05/2013 01:03 PM, mdroth wrote: > > >> +buf = g_strdup_printf("/sys/devices/system/cpu/cpu%ld/online", > >> + current); > >> +f = f

Re: [Qemu-devel] [PATCH 0/3] *** make netlayer re-entrant ***

2013-03-05 Thread mdroth
On Sun, Mar 03, 2013 at 09:21:19PM +0800, Liu Ping Fan wrote: > From: Liu Ping Fan > > This series aim to make netlayer re-entrant, so netlayer can > run out of biglock safely. I think most of the locking considerations are still applicable either way, but this series seems to be written under t

Re: [Qemu-devel] [PATCH 2/3] qga: implement qmp_guest_get_vcpus() for Linux with sysfs

2013-03-05 Thread mdroth
On Tue, Mar 05, 2013 at 10:34:08PM +0100, Laszlo Ersek wrote: > On 03/05/13 21:25, Eric Blake wrote: > > > On 03/04/2013 03:19 PM, Laszlo Ersek wrote: > >> Signed-off-by: Laszlo Ersek > >> --- > >> GuestLogicalProcessorList *qmp_guest_get_vcpus(Error **errp) > >> { > >> +#if defined(__linux__)

Re: [Qemu-devel] [PATCH] qemu-ga: use key-value store to avoid recycling fd handles after restart

2013-03-05 Thread mdroth
On Fri, Mar 01, 2013 at 11:40:27AM -0600, Michael Roth wrote: > Hosts hold on to handles provided by guest-file-open for periods that can > span beyond the life of the qemu-ga process that issued them. Since these > are issued starting from 0 on every restart, we run the risk of issuing > duplicate

Re: [Qemu-devel] [PATCH 0/2 v5] Time resync support by qemu-ga

2013-03-05 Thread mdroth
On Tue, Mar 05, 2013 at 05:39:10PM +0800, Lei Li wrote: > This patch series attempts to add time resync support > to qemu-ga by introducing qemu-ga commands guest-get-time > and guest-set-time. Thanks, applied to qga branch. > > Right now, when a guest is paused or migrated to a file > then load

Re: [Qemu-devel] [PATCH v2 1/3] qga: introduce guest-get-vcpus / guest-set-vcpus with stubs

2013-03-06 Thread mdroth
On Wed, Mar 06, 2013 at 11:48:14PM +0100, Laszlo Ersek wrote: > On 03/06/13 23:32, Eric Blake wrote: > > On 03/06/2013 02:59 PM, Laszlo Ersek wrote: > > >> +## > >> +# @GuestLogicalProcessor: > >> +# > >> +# @logical-id: Arbitrary guest-specific unique identifier of the VCPU. > >> +# > >> +# @onli

Re: [Qemu-devel] [RFC PATCH 0/2] port network layer onto glib

2013-03-13 Thread mdroth
On Wed, Mar 13, 2013 at 05:21:02PM +0100, Paolo Bonzini wrote: > Il 13/03/2013 13:34, Anthony Liguori ha scritto: > > Paolo Bonzini writes: > > > >> Il 13/03/2013 06:59, Liu Ping Fan ha scritto: > >>> These series aim to port network backend onto glib, and > >>> prepare for moving towards making

Re: [Qemu-devel] [PATCH 1/2] qga: add windows implementation for guest-get-time

2013-03-13 Thread mdroth
On Wed, Mar 13, 2013 at 06:10:30PM +0800, li...@linux.vnet.ibm.com wrote: > From: Lei Li > > Signed-off-by: Lei Li > --- > qga/commands-win32.c | 32 > 1 files changed, 32 insertions(+), 0 deletions(-) > > diff --git a/qga/commands-win32.c b/qga/commands-win3

Re: [Qemu-devel] [PATCH 1/2] qga: add windows implementation for guest-get-time

2013-03-13 Thread mdroth
On Wed, Mar 13, 2013 at 03:07:52PM -0500, mdroth wrote: > On Wed, Mar 13, 2013 at 06:10:30PM +0800, li...@linux.vnet.ibm.com wrote: > > From: Lei Li > > > > Signed-off-by: Lei Li > > --- > > qga/commands-win32.c | 32 > >

Re: [Qemu-devel] [PATCH 2/2] qga: add windows implementation for guest-set-time

2013-03-13 Thread mdroth
On Wed, Mar 13, 2013 at 06:10:31PM +0800, li...@linux.vnet.ibm.com wrote: > From: Lei Li > > Signed-off-by: Lei Li > --- > qga/commands-win32.c | 34 ++ > 1 files changed, 34 insertions(+), 0 deletions(-) > > diff --git a/qga/commands-win32.c b/qga/commands-wi

Re: [Qemu-devel] [PATCH 5/9] qapi_sized_buffer

2013-03-13 Thread mdroth
On Wed, Mar 13, 2013 at 01:56:24PM -0500, Joel Schopp wrote: > Add a sized buffer interface to qapi. Isn't this just a special case of the visit_*_carray() interfaces? We should avoid new interfaces if possible, since it adds to feature disparities between visitor implementations. > > Cc: Michae

Re: [Qemu-devel] [PATCH 4/9] qemu_qsb.diff

2013-03-13 Thread mdroth
On Wed, Mar 13, 2013 at 01:56:23PM -0500, Joel Schopp wrote: > This patch adds support functions for operating on in memory sized file > buffers. There's been some past refactorings to remove non-migration users of QEMUFile, and AFAIK that's still the case today. QEMUFile satisfies funky requirem

Re: [Qemu-devel] [PATCH 4/9] qemu_qsb.diff

2013-03-13 Thread mdroth
On Wed, Mar 13, 2013 at 05:28:56PM -0400, Stefan Berger wrote: > On 03/13/2013 05:11 PM, mdroth wrote: > >On Wed, Mar 13, 2013 at 01:56:23PM -0500, Joel Schopp wrote: > >>This patch adds support functions for operating on in memory sized file > >>buffers. > >There

Re: [Qemu-devel] [PATCH 4/9] qemu_qsb.diff

2013-03-13 Thread mdroth
On Wed, Mar 13, 2013 at 05:41:33PM -0500, mdroth wrote: > On Wed, Mar 13, 2013 at 05:28:56PM -0400, Stefan Berger wrote: > > On 03/13/2013 05:11 PM, mdroth wrote: > > >On Wed, Mar 13, 2013 at 01:56:23PM -0500, Joel Schopp wrote: > > >>This patch adds support functi

Re: [Qemu-devel] [PATCH 5/9] qapi_sized_buffer

2013-03-13 Thread mdroth
On Wed, Mar 13, 2013 at 06:00:24PM -0400, Stefan Berger wrote: > On 03/13/2013 04:52 PM, mdroth wrote: > >On Wed, Mar 13, 2013 at 01:56:24PM -0500, Joel Schopp wrote: > >>Add a sized buffer interface to qapi. > >Isn't this just a special case of the visit_*_carray() i

Re: [Qemu-devel] [PATCH 5/9] qapi_sized_buffer

2013-03-14 Thread mdroth
On Wed, Mar 13, 2013 at 09:48:11PM -0400, Stefan Berger wrote: > On 03/13/2013 07:18 PM, mdroth wrote: > >On Wed, Mar 13, 2013 at 06:00:24PM -0400, Stefan Berger wrote: > >>On 03/13/2013 04:52 PM, mdroth wrote: > >> > >Visitors don't have any knowledge o

Re: [Qemu-devel] [PATCH 1/2] qga: add windows implementation for guest-get-time

2013-03-14 Thread mdroth
On Thu, Mar 14, 2013 at 03:07:50PM +0800, Lei Li wrote: > Signed-off-by: Lei Li > --- > qga/commands-win32.c | 33 + > 1 file changed, 33 insertions(+) > > diff --git a/qga/commands-win32.c b/qga/commands-win32.c > index 7e8ecb3..e24fb4a 100644 > --- a/qga/command

Re: [Qemu-devel] [PATCH 2/2] qga: add windows implementation for guest-set-time

2013-03-14 Thread mdroth
On Thu, Mar 14, 2013 at 03:07:51PM +0800, Lei Li wrote: > Signed-off-by: Lei Li > --- > qga/commands-win32.c | 33 + > 1 file changed, 33 insertions(+) > > diff --git a/qga/commands-win32.c b/qga/commands-win32.c > index e24fb4a..8064c3a 100644 > --- a/qga/command

Re: [Qemu-devel] [PATCH 5/9] qapi_sized_buffer

2013-03-14 Thread mdroth
On Thu, Mar 14, 2013 at 09:39:14AM -0400, Stefan Berger wrote: > On 03/14/2013 08:18 AM, mdroth wrote: > >On Wed, Mar 13, 2013 at 09:48:11PM -0400, Stefan Berger wrote: > >>On 03/13/2013 07:18 PM, mdroth wrote: > >>>On Wed, Mar 13, 2013 at 06:00:24PM -0400, Stefan Ber

Re: [Qemu-devel] [PATCH 5/9] qapi_sized_buffer

2013-03-14 Thread mdroth
On Thu, Mar 14, 2013 at 10:51:49AM -0400, Stefan Berger wrote: > On 03/14/2013 10:28 AM, mdroth wrote: > >On Thu, Mar 14, 2013 at 09:39:14AM -0400, Stefan Berger wrote: > >>On 03/14/2013 08:18 AM, mdroth wrote: > >>>On Wed, Mar 13, 2013 at 09:48:11PM -0400, Stefan Ber

Re: [Qemu-devel] [PATCH 5/9] qapi_sized_buffer

2013-03-14 Thread mdroth
On Thu, Mar 14, 2013 at 11:24:03AM -0400, Stefan Berger wrote: > On 03/14/2013 11:11 AM, mdroth wrote: > >On Thu, Mar 14, 2013 at 10:51:49AM -0400, Stefan Berger wrote: > >>On 03/14/2013 10:28 AM, mdroth wrote: > >>>On Thu, Mar 14, 2013 at 09:39:14AM -0400, Stefan Ber

Re: [Qemu-devel] [PATCH 1/2] qga: add windows implementation for guest-get-time

2013-03-14 Thread mdroth
On Thu, Mar 14, 2013 at 11:05:52PM +0800, Lei Li wrote: > Signed-off-by: Lei Li > --- > qga/commands-win32.c | 29 + > 1 file changed, 29 insertions(+) > > diff --git a/qga/commands-win32.c b/qga/commands-win32.c > index 7e8ecb3..b395bd5 100644 > --- a/qga/commands-wi

Re: [Qemu-devel] [PATCH 0/2 v6] Add Windows support for time resync by qemu-ga

2013-03-14 Thread mdroth
On Thu, Mar 14, 2013 at 11:05:51PM +0800, Lei Li wrote: > This patch series attempts to add Windows implementation > for qemu-ga commands guest-get-time and guest-set-time. > > The previous thread about the interfaces introduced and > the POSIX-specific command implementation has already > been a

Re: [Qemu-devel] [PATCH 2/2] qga schema: document generic QERR_UNSUPPORTED

2013-03-15 Thread mdroth
On Fri, Mar 15, 2013 at 07:07:51PM +0100, Laszlo Ersek wrote: > Part of the wording was shamelessly stolen from Michael Roth's email. :) series: Reviewed-by: Michael Roth > > Suggested-by: Michael Roth > Signed-off-by: Laszlo Ersek > --- > qga/qapi-schema.json | 11 +++ > 1 files

[Qemu-devel] [ANNOUNCE] QEMU 1.4.1 Stable released

2013-04-15 Thread mdroth
Hi everyone, I am pleased to announce that the QEMU v1.4.1 stable release is now available at: http://wiki.qemu.org/download/qemu-1.4.1.tar.bz2 The official stable-1.4 repository has also been updated to v1.4.1: http://git.qemu.org/?p=qemu-stable-1.4.git;a=summary This release includes 57 buil

Re: [Qemu-devel] [qapi] Cannot use list of strings

2013-04-16 Thread mdroth
works, the same approach can probably be taken for all "native" qapi types: str, bool, [u]int[(8|16|32|64)] > > akong just hit this too. > > I think it's a question for aliguori, luiz, or mdroth. > > Stefan >

Re: [Qemu-devel] [PATCH v2] qapi: add struct strList and visit_type_strList()

2013-04-24 Thread mdroth
7;bool') and have them handle code generation for these like they would for any user-defined type. This approach works too, but I think this solution is more complete. I'm still working out some bits with the unit tests but I've pushed my WIP here for reference: https://github.co

Re: [Qemu-devel] [RFC 0/9] QContext: QOM class to support multiple event loops

2013-05-06 Thread mdroth
On Mon, May 06, 2013 at 09:54:14AM +0200, Paolo Bonzini wrote: > Il 03/05/2013 18:03, Michael Roth ha scritto: > > These patches apply on top of qemu.git master, and can also be obtained > > from: > > git://github.com/mdroth/qemu.git qcontext > > > > OVERVIEW

Re: [Qemu-devel] [RFC 0/9] QContext: QOM class to support multiple event loops

2013-05-06 Thread mdroth
On Mon, May 06, 2013 at 07:25:24AM -0500, Anthony Liguori wrote: > Paolo Bonzini writes: > > > Il 03/05/2013 18:03, Michael Roth ha scritto: > >> These patches apply on top of qemu.git master, and can also be obtained > >> from: > >> git://github.com/mdrot

Re: [Qemu-devel] [RFC 0/9] QContext: QOM class to support multiple event loops

2013-05-06 Thread mdroth
On Mon, May 06, 2013 at 11:26:06AM +0800, liu ping fan wrote: > On Sat, May 4, 2013 at 12:03 AM, Michael Roth > wrote: > > These patches apply on top of qemu.git master, and can also be obtained > > from: > > git://github.com/mdroth/qemu.git qcontext > > &g

Re: [Qemu-devel] [PATCH 2/9] qom: add object_property_add_unnamed_child

2013-05-06 Thread mdroth
On Mon, May 06, 2013 at 09:44:13AM +0200, Paolo Bonzini wrote: > Il 03/05/2013 18:03, Michael Roth ha scritto: > > This interface allows us to add a child property without specifying a > > name. Instead, a unique name is created and passed back after adding > > the property. > > > > Signed-off-by:

Re: [Qemu-devel] [PATCH 1/9] qom: add qom_init_completion

2013-05-06 Thread mdroth
On Mon, May 06, 2013 at 09:45:22AM +0200, Paolo Bonzini wrote: > Il 03/05/2013 18:03, Michael Roth ha scritto: > > This is similar in concept to "realize", though semantics are a > > bit more open-ended: > > > > And object might in some cases need a number of properties to be > > specified before

Re: [Qemu-devel] [PATCH 7/9] iohandler: associate with main event loop via a QSource

2013-05-06 Thread mdroth
On Mon, May 06, 2013 at 09:53:12AM +0200, Paolo Bonzini wrote: > Il 03/05/2013 18:03, Michael Roth ha scritto: > > This introduces a GlibQContext wrapper around the main GMainContext > > event loop, and associates iohandlers with it via a QSource (which > > GlibQContext creates a GSource from so th

Re: [Qemu-devel] [PATCH 9/9] dataplane: use a QContext event loop in place of custom thread

2013-05-06 Thread mdroth
On Mon, May 06, 2013 at 09:54:03AM +0200, Paolo Bonzini wrote: > Il 03/05/2013 18:03, Michael Roth ha scritto: > > virtio-blk dataplane currently creates/manages it's own thread to > > offload work to a separate event loop. > > > > This patch insteads allows us to specify a QContext-based event lo

Re: [Qemu-devel] [PATCH 1/2] qga: distinguish binary modes in "guest_file_open_modes" map

2013-05-07 Thread mdroth
On Tue, May 07, 2013 at 11:27:03AM -0600, Eric Blake wrote: > On 05/07/2013 10:56 AM, Laszlo Ersek wrote: > > In Windows guests this may make a difference. > > > > Suggested-by: Eric Blake > > Signed-off-by: Laszlo Ersek > > --- > > qga/commands-posix.c | 22 -- > > 1 file

Re: [Qemu-devel] [PATCH] qga: set umask 0077 when daemonizing (CVE-2013-2007)

2013-05-07 Thread mdroth
On Tue, May 07, 2013 at 09:55:06AM -0600, Eric Blake wrote: > On 05/07/2013 05:47 AM, Anthony Liguori wrote: > > From: Laszlo Ersek > > > > The qemu guest agent creates a bunch of files with insecure permissions > > when started in daemon mode. For example: > > > > -rw-rw-rw- 1 root root /var/

Re: [Qemu-devel] [PATCH 6/8] qapi: add native list coverage for visitor serialization tests

2013-05-09 Thread mdroth
On Thu, May 09, 2013 at 02:31:03PM +0200, Laszlo Ersek wrote: > On 05/09/13 01:33, Michael Roth wrote: > > > +case PTYPE_NUMBER: { > > +numberList *ptr; > > +char *double1, *double2; > > +if (cur_head) { > > +ptr = cur_head; > > +

Re: [Qemu-devel] [PATCH 0/8] qapi: add support for lists of native types

2013-05-09 Thread mdroth
On Thu, May 09, 2013 at 03:31:08PM +0200, Laszlo Ersek wrote: > On 05/09/13 01:33, Michael Roth wrote: > > These patches apply on top of qemu.git master, and can also be obtained > > from: > > git://github.com/mdroth/qemu.git qapi-native-lists > > > > Sending

Re: [Qemu-devel] [PATCH 01/10] qapi: qapi-types.py, native list support

2013-05-10 Thread mdroth
On Fri, May 10, 2013 at 11:04:22AM +0800, Amos Kong wrote: > On Thu, May 09, 2013 at 09:20:53PM -0500, Michael Roth wrote: > > Teach type generators about native types so they can generate the > > appropriate linked list types. > > > > Signed-off-by: Michael Roth > > --- > > scripts/qapi-types.p

Re: [Qemu-devel] [PATCH 06/10] json-parser: fix handling of large whole number values

2013-05-10 Thread mdroth
On Fri, May 10, 2013 at 02:47:18PM +0200, Laszlo Ersek wrote: > On 05/10/13 14:22, Eric Blake wrote: > > On 05/09/2013 08:20 PM, Michael Roth wrote: > >> Currently our JSON parser assumes that numbers lacking a mantissa are > >> integers and attempts to store them as QInt/int64 values. This breaks

Re: [Qemu-devel] [PATCH 06/10] json-parser: fix handling of large whole number values

2013-05-10 Thread mdroth
his triggering the change is if they did something like: obj = qobject_from_jsonf("{'myInt': %f}", whole_valued_float); which would be evil, and thankfully such cases don't appear to exist: mdroth@loki:~/w/qemu.git$ ack-grep qobject_from_json | grep "%f" tests/

Re: [Qemu-devel] [PATCH 01/10] qapi: qapi-types.py, native list support

2013-05-10 Thread mdroth
On Fri, May 10, 2013 at 10:07:45AM -0400, Luiz Capitulino wrote: > On Thu, 9 May 2013 21:20:53 -0500 > Michael Roth wrote: > > > Teach type generators about native types so they can generate the > > appropriate linked list types. > > > > Signed-off-by: Michael Roth > > --- > > scripts/qapi-ty

Re: [Qemu-devel] [PATCH 06/10] json-parser: fix handling of large whole number values

2013-05-10 Thread mdroth
On Fri, May 10, 2013 at 11:17:17AM -0400, Luiz Capitulino wrote: > On Thu, 9 May 2013 21:20:58 -0500 > Michael Roth wrote: > > > Currently our JSON parser assumes that numbers lacking a mantissa are > > integers and attempts to store them as QInt/int64 values. This breaks in > > the case where t

Re: [Qemu-devel] [PATCH 04/10] qapi: enable generation of native list code

2013-05-10 Thread mdroth
On Fri, May 10, 2013 at 10:10:03AM -0400, Luiz Capitulino wrote: > On Thu, 9 May 2013 21:20:56 -0500 > Michael Roth wrote: > > > Also, fix a dependency issue with libqemuutil: qemu-sockets.c needs > > qapi-types.c/qapi-visit.c > > > > Signed-off-by: Michael Roth > > --- > > Makefile |6 ++

Re: [Qemu-devel] [PATCH v2 0/2] qga umask fix addenda

2013-05-10 Thread mdroth
be a reasonable > assumption when the input fd is valid.) > > Laszlo Ersek (2): > qga: distinguish binary modes in "guest_file_open_modes" map > qga: unlink just created guest-file if fchmod() or fdopen() fails on > it Thanks, applied to qga branch: https://gi

  1   2   3   >