[Qemu-devel] [PATCH v4 17/22] vhost-user-test: move wait_for_fds() out

From: Marc-André Lureau This function is a precondition for most vhost-user tests. Signed-off-by: Marc-André Lureau --- tests/vhost-user-test.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/tests/vhost-user-test.c b/tests/vhost-user-test.c index 228acb6

[Qemu-devel] [PATCH v4 16/22] vhost user: add rarp sending after live migration for legacy guest

From: Thibaut Collet A new vhost user message is added to allow QEMU to ask to vhost user backend to broadcast a fake RARP after live migration for guest without GUEST_ANNOUNCE capability. This new message is sent only if the backend supports the new VHOST_USER_PROTOCOL_F_RARP protocol feature.

[Qemu-devel] [PATCH v4 12/22] vhost: only use shared log if in use by backend

From: Marc-André Lureau Do not allocate a shared log if the backend doesn't support it. Signed-off-by: Marc-André Lureau --- hw/virtio/vhost-user.c| 9 + hw/virtio/vhost.c | 15 ++- include/hw/virtio/vhost-backend.h | 4 3 files changed, 2

[Qemu-devel] [PATCH v4 18/22] vhost-user-test: remove useless static check

From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- tests/vhost-user-test.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/vhost-user-test.c b/tests/vhost-user-test.c index 551a664..68badf9 100644 --- a/tests/vhost-user-test.c +++ b/tests/vhost-user-test.c @@ -262,7 +262,6 @@

[Qemu-devel] [PATCH v4 13/22] vhost-user: document migration log

From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- docs/specs/vhost-user.txt | 42 ++ 1 file changed, 42 insertions(+) diff --git a/docs/specs/vhost-user.txt b/docs/specs/vhost-user.txt index 0062baa..0322bcf 100644 --- a/docs/specs/vhost-user.

[Qemu-devel] [PATCH v4 20/22] vhost-user-test: learn to tweak various qemu arguments

From: Marc-André Lureau Add a new macro to make the qemu command line with other values of memory size, and specific chardev id. Signed-off-by: Marc-André Lureau --- tests/vhost-user-test.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/tests/vhost-user-test

[Qemu-devel] [PATCH v4 21/22] vhost-user-test: add live-migration test

From: Marc-André Lureau This test checks that the log fd is given to the migration source, and mark dirty pages during migration. Signed-off-by: Marc-André Lureau --- tests/vhost-user-test.c | 162 +++- 1 file changed, 159 insertions(+), 3 deletions(

[Qemu-devel] [PATCH v4 22/22] vhost-user-test: check ownership during migration

From: Marc-André Lureau Check that backend source and destination do not have simultaneous ownership during migration. Signed-off-by: Marc-André Lureau --- tests/vhost-user-test.c | 38 ++ 1 file changed, 38 insertions(+) diff --git a/tests/vhost-user-test.

[Qemu-devel] [PATCH v4 15/22] vhost user: add support of live migration

From: Thibaut Collet Some vhost user backends are able to support live migration. To provide this service the following features must be added: 1. Add the VIRTIO_NET_F_GUEST_ANNOUNCE capability to vhost-net when netdev backend is vhost-user. 2. Provide a nop receive callback to vhost-user.

[Qemu-devel] [PATCH v4 19/22] vhost-user-test: wrap server in TestServer struct

From: Marc-André Lureau In the coming patches, a test will use several servers simultaneously. Wrap the server in a struct, out of the global scope. Signed-off-by: Marc-André Lureau --- tests/vhost-user-test.c | 146 ++-- 1 file changed, 92 insertion

[Qemu-devel] [PULL] remove libcacard

From: Marc-André Lureau The following changes since commit 27c7275a56948f48f536e2d1599b22355f5714ac: Merge remote-tracking branch 'remotes/kraxel/tags/pull-ipxe-20150903-1' into staging (2015-09-22 19:22:23 +0100) are available in the git repository at: https://github.com/elmarco/qemu tag

[Qemu-devel] [PULL] remove libcacard

From: Marc-André Lureau The following changes since commit 684bb5770ec5d72a66620f64fc5d9672bf8d3509: Merge remote-tracking branch 'remotes/dgibson/tags/spapr-next-20150923' into staging (2015-09-23 16:52:54 +0100) are available in the git repository at: https://github.com/elmarco/qemu tag

[Qemu-devel] [PATCH v4 02/47] msix: add VMSTATE_MSIX_TEST

From: Marc-André Lureau ivshmem is going to use MSIX state conditionally. Signed-off-by: Marc-André Lureau --- include/hw/pci/msix.h | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/include/hw/pci/msix.h b/include/hw/pci/msix.h index 954d82b..72e5f93 100644

[Qemu-devel] [PATCH v4 00/47] ivshmem improvements

From: Marc-André Lureau Hi, This series is mostly about adding the client/server code from David Marchand, code cleanups, and little improvements and fixes for ivshmem. Finally there is some ivshmem tests (they work fine without kvm btw). Git: https://github.com/elmarco/qemu.git ivshmem branch

[Qemu-devel] [PATCH v4 01/47] char: add qemu_chr_free()

From: Marc-André Lureau If a chardev is allowed to be created outside of QMP, then it must be also possible to free it. This is useful for ivshmem that creates chardev anonymously and must be able to free them. Signed-off-by: Marc-André Lureau Acked-by: Paolo Bonzini --- include/sysemu/char.h

[Qemu-devel] [PATCH v4 08/47] ivshmem: remove useless doorbell field

From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Claudio Fontana --- hw/misc/ivshmem.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index 7138b8d..dea4096 100644 --- a/hw/misc/ivshmem.c +++ b/hw/misc/ivshmem.c @@ -71,7 +71,6 @@ t

[Qemu-devel] [PATCH v4 06/47] ivshmem: remove unnecessary dup()

From: Marc-André Lureau qemu_chr_fe_get_msgfd() transfers ownership, there is no need to dup the fd. Signed-off-by: Marc-André Lureau --- hw/misc/ivshmem.c | 21 ++--- 1 file changed, 6 insertions(+), 15 deletions(-) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index dd1

[Qemu-devel] [PATCH v4 05/47] ivshmem: factor out the incoming fifo handling

From: Marc-André Lureau Make a new function fifo_update_and_get() that can be reused by other functions (in next commits). Signed-off-by: Marc-André Lureau --- hw/misc/ivshmem.c | 59 --- 1 file changed, 39 insertions(+), 20 deletions(-) dif

[Qemu-devel] [PATCH v4 09/47] ivshmem: more qdev conversion

From: Marc-André Lureau Use the latest qemu device modeling API, in particular, convert to realize to fix the error handling; right now a botched device_add ivhsmem command kills the VM. Signed-off-by: Marc-André Lureau --- hw/misc/ivshmem.c | 119 +++---

[Qemu-devel] [PATCH v4 03/47] ivhsmem: read do not accept more than sizeof(long)

From: Marc-André Lureau ivshmem_read() only reads sizeof(long) from the input buffer. Accepting more could lead to fifo8 abort() on 32bit systems if fifo is not empty. A following patch will change the protocol to 64-bit little-endian instead. Signed-off-by: Marc-André Lureau --- hw/misc/ivs

[Qemu-devel] [PATCH v4 07/47] ivshmem: remove superflous ivshmem_attr field

From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- hw/misc/ivshmem.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index fbeb731..7138b8d 100644 --- a/hw/misc/ivshmem.c +++ b/hw/misc/ivshmem.c @@ -85,7 +85,6

[Qemu-devel] [PATCH v4 04/47] ivshmem: fix number of bytes to push to fifo

From: Marc-André Lureau If the fifo has 0 bytes, and the read is of size 1, the call to fifo8_push_all() will copy off boundary data. Signed-off-by: Marc-André Lureau --- hw/misc/ivshmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c

[Qemu-devel] [PATCH v4 10/47] ivshmem: remove last exit(1)

From: Marc-André Lureau Failing to create a chardev shouldn't be fatal. Signed-off-by: Marc-André Lureau --- hw/misc/ivshmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index 62547c0..e7224b9 100644 --- a/hw/misc/ivshmem.c +++ b/h

[Qemu-devel] [PATCH v4 20/47] ivshmem: simplify a bit the code

From: Marc-André Lureau Use some more explicit variables to simplify the code. nth_eventfd variable is the current eventfd to be manipulated. Signed-off-by: Marc-André Lureau --- hw/misc/ivshmem.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git

[Qemu-devel] [PATCH v4 11/47] ivshmem: limit maximum number of peers to G_MAXUINT16

From: Marc-André Lureau Limit the maximum number of peers to MAXUINT16. This is more realistic and better matches the limit of the doorbell register. Signed-off-by: Marc-André Lureau Reviewed-by: Claudio Fontana --- hw/misc/ivshmem.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)

[Qemu-devel] [PATCH v4 14/47] ivshmem: remove useless ivshmem_update_irq() val argument

From: Marc-André Lureau val isn't used in ivshmem_update_irq() function. Signed-off-by: Marc-André Lureau Reviewed-by: Claudio Fontana --- hw/misc/ivshmem.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index 19640bb..374ecff

[Qemu-devel] [PATCH v4 13/47] ivshmem: allocate eventfds in resize_peers()

From: Marc-André Lureau It simplifies a bit the code to allocate the array when setting the number of peers instead of lazily when receiving the first vector. Signed-off-by: Marc-André Lureau --- hw/misc/ivshmem.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/

[Qemu-devel] [PATCH v4 29/47] ivshmem: error on too many eventfd received

From: Marc-André Lureau The number of eventfd that can be handled per peer is limited by the number of vectors. Return an error when receiving too many of them. Signed-off-by: Marc-André Lureau --- hw/misc/ivshmem.c | 8 1 file changed, 8 insertions(+) diff --git a/hw/misc/ivshmem.c

[Qemu-devel] [PATCH v4 17/47] ivshmem: improve debug messages

From: Marc-André Lureau Some misc improvements to ivshmem debug. Signed-off-by: Marc-André Lureau --- hw/misc/ivshmem.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index c4c130d..71a71fc 100644 --- a/hw/misc/ivshmem.c +++

[Qemu-devel] [PATCH v4 16/47] ivshmem: remove max_peer field

From: Marc-André Lureau max_peer isn't really useful, it tracks the maximum received VM id, but that quickly matches nb_peers, the size of the peers array. Since VM come and go, there might be sparse peers so it doesn't help much in general to have this value around. Signed-off-by: Marc-André Lu

[Qemu-devel] [PATCH v4 12/47] ivshmem: simplify around increase_dynamic_storage()

From: Marc-André Lureau Set the number of peers and array allocation in a single place. Rename to better reflect the function content. Signed-off-by: Marc-André Lureau Reviewed-by: Claudio Fontana --- hw/misc/ivshmem.c | 27 +++ 1 file changed, 11 insertions(+), 16 del

[Qemu-devel] [PATCH v4 40/47] tests: add ivshmem qtest

From: Marc-André Lureau Adds 4 ivshmemtests: - single qemu instance and basic IO - pair of instances, check memory sharing - pair of instances with server, and MSIX - hot plug/unplug A temporary shm is created as well as a directory to place server socket, both should be clear on exit and abort.

[Qemu-devel] [PATCH v4 15/47] ivshmem: initialize max_peer to -1

From: Marc-André Lureau There is no peer when device is initialized, do not let doorbell for inexisting peer 0. Signed-off-by: Marc-André Lureau Reviewed-by: Claudio Fontana --- hw/misc/ivshmem.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/misc/ivshmem.c b/hw/mi

[Qemu-devel] [PATCH v4 25/47] ivshmem: check shm isn't already initialized

From: Marc-André Lureau The server should not change the shm, and this isn't handled by qemu. Signed-off-by: Marc-André Lureau --- hw/misc/ivshmem.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index ea80548..21ef260 100644 --- a/hw/misc/ivshm

[Qemu-devel] [PATCH v4 32/47] ivshmem-client: check the number of vectors

From: Marc-André Lureau Check the number of vectors received from the server, to avoid out of bound array access. Signed-off-by: Marc-André Lureau --- contrib/ivshmem-client/ivshmem-client.c | 4 1 file changed, 4 insertions(+) diff --git a/contrib/ivshmem-client/ivshmem-client.c b/cont

[Qemu-devel] [PATCH v4 21/47] ivshmem: use common return

From: Marc-André Lureau Both if branches return, move this out to common end. Signed-off-by: Marc-André Lureau Reviewed-by: Claudio Fontana --- hw/misc/ivshmem.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index c59d9ed..8ebc907

[Qemu-devel] [PATCH v4 24/47] ivshmem: shmfd can be 0

From: Marc-André Lureau 0 is a valid fd value, so change conditions and set -1 value early Signed-off-by: Marc-André Lureau Reviewed-by: Claudio Fontana --- hw/misc/ivshmem.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index

[Qemu-devel] [PATCH v4 22/47] ivshmem: use common is_power_of_2()

From: Marc-André Lureau The common version correctly checks for 0 value case. Signed-off-by: Marc-André Lureau Reviewed-by: Claudio Fontana --- hw/misc/ivshmem.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index 8ebc907..8207a

[Qemu-devel] [PATCH v4 42/47] ivshmem: use strtosz()

From: Marc-André Lureau Use the common qemu utility function to parse the memory size. Signed-off-by: Marc-André Lureau --- hw/misc/ivshmem.c | 36 +--- 1 file changed, 5 insertions(+), 31 deletions(-) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index 27

[Qemu-devel] [PATCH v4 31/47] contrib: add ivshmem client and server

From: David Marchand When using ivshmem devices, notifications between guests can be sent as interrupts using a ivshmem-server (typical use described in documentation). The client is provided as a debug tool. Signed-off-by: Olivier Matz Signed-off-by: David Marchand [fix a valgrind warning, op

[Qemu-devel] [PATCH v4 18/47] ivshmem: improve error handling

From: Marc-André Lureau The test whether the chardev is an AF_UNIX socket rejects "-chardev socket,id=chr0,path=/tmp/foo,server,nowait -device ivshmem,chardev=chr0", but fails to explain why. Use an explicit error on why a chardev may be rejected. Signed-off-by: Marc-André Lureau --- hw/misc/

[Qemu-devel] [PATCH v4 19/47] ivshmem: print error on invalid peer id

From: Marc-André Lureau The server shouldn't send invalid peer id, so print an error if it's the case. Signed-off-by: Marc-André Lureau Reviewed-by: Claudio Fontana --- hw/misc/ivshmem.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index ed1b6f7..6

[Qemu-devel] [PATCH v4 23/47] ivshmem: migrate with VMStateDescription

From: Marc-André Lureau load_state_old() is used to keep compatibility with version 0. Signed-off-by: Marc-André Lureau --- hw/misc/ivshmem.c | 141 ++ 1 file changed, 88 insertions(+), 53 deletions(-) diff --git a/hw/misc/ivshmem.c b/hw/mis

[Qemu-devel] [PATCH v4 27/47] ivshmem: fix pci_ivshmem_exit()

From: Marc-André Lureau Free all objects owned by the device, making sure the device is free, fixing hot-unplug. Signed-off-by: Marc-André Lureau --- hw/misc/ivshmem.c | 38 +++--- 1 file changed, 35 insertions(+), 3 deletions(-) diff --git a/hw/misc/ivshmem.c

[Qemu-devel] [PATCH v4 41/47] ivshmem: do not keep shm_fd open

From: Marc-André Lureau Remove shm_fd from device state, closing it as early as possible to avoid leaks. Signed-off-by: Marc-André Lureau --- hw/misc/ivshmem.c | 16 +--- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index fc1d

[Qemu-devel] [PATCH v4 28/47] ivshmem: replace 'guest' for 'peer' appropriately

From: Marc-André Lureau The terms 'guest' and 'peer' are used sometime interchangeably which may be confusing. Instead, use 'peer' for the remote instances of ivshmem clients, and 'guest' for the local VM. Signed-off-by: Marc-André Lureau Reviewed-by: Claudio Fontana --- hw/misc/ivshmem.c | 2

[Qemu-devel] [PATCH v4 26/47] ivshmem: add device description

From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Claudio Fontana --- hw/misc/ivshmem.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index 21ef260..9be4d1e 100644 --- a/hw/misc/ivshmem.c +++ b/hw/misc/ivshmem.c @@ -924,6 +924,7 @

[Qemu-devel] [PATCH v4 44/47] ivshmem: remove EventfdEntry.vector

From: Marc-André Lureau No need to store an extra int for the vector number when it can be computed easily by looking at the position in the array. Signed-off-by: Marc-André Lureau --- hw/misc/ivshmem.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/misc/ivshmem

[Qemu-devel] [PATCH v4 33/47] ivshmem-server: use a uint16 for client ID

From: Marc-André Lureau In practice, the number of VM is limited to MAXUINT16 in ivshmem, so use the same limit on the server (removes a theorical infinite loop) Signed-off-by: Marc-André Lureau --- contrib/ivshmem-server/ivshmem-server.c | 11 ++- contrib/ivshmem-server/ivshmem-server

[Qemu-devel] [PATCH v4 30/47] ivshmem: reset mask on device reset

From: Marc-André Lureau The interrupt mask is a state value, it should be reset, like the interrupt status. Signed-off-by: Marc-André Lureau --- hw/misc/ivshmem.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index 3231a46..9974f25 100644 --- a/hw/mi

[Qemu-devel] [PATCH v4 43/47] ivshmem: add hostmem backend

From: Marc-André Lureau Instead of handling allocation, teach ivshmem to use a memory backend. This allows to use hugetlbfs backed memory now. Signed-off-by: Marc-André Lureau Reviewed-by: Claudio Fontana --- hw/misc/ivshmem.c| 84 +--- test

[Qemu-devel] [PATCH v4 35/47] docs: update ivshmem device spec

From: David Marchand Add some notes on the parts needed to use ivshmem devices: more specifically, explain the purpose of an ivshmem server and the basic concept to use the ivshmem devices in guests. Move some parts of the documentation and re-organise it. Signed-off-by: David Marchand Reviewed

[Qemu-devel] [PATCH v4 34/47] ivshmem-server: fix hugetlbfs support

From: Marc-André Lureau As pointed out on the ML by Andrew Jones, glibc no longer permits creating POSIX shm on hugetlbfs directly. When given a hugetlbfs path, create a shareable file there. Signed-off-by: Marc-André Lureau Reviewed-by: Vladimir Sementsov-Ogievskiy --- contrib/ivshmem-server

[Qemu-devel] [PATCH v4 45/47] ivshmem: rename MSI eventfd_table

From: Marc-André Lureau The array is used to have vector specific data, so use a more descriptive name. Signed-off-by: Marc-André Lureau --- hw/misc/ivshmem.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index 6199

[Qemu-devel] [PATCH v4 37/47] contrib: remove unnecessary strdup()

From: Marc-André Lureau getopt() optarg points to argv memory, no need to dup those values, fixes small leaks detected by clang-analyzer. Signed-off-by: Marc-André Lureau Reviewed-by: Vladimir Sementsov-Ogievskiy --- contrib/ivshmem-client/main.c | 2 +- contrib/ivshmem-server/main.c | 6 +++-

[Qemu-devel] [PATCH v4 36/47] ivshmem: add check on protocol version in QEMU

From: David Marchand Send a protocol version as the first message from server, clients must close communication if they don't support this protocol version. Older QEMUs should be fine with this change in the protocol since they overrides their own vm_id on reception of an id associated to no eve

[Qemu-devel] [PATCH v4 46/47] ivshmem: use kvm irqfd for msi notifications

From: Marc-André Lureau Use irqfd for improving context switch when notifying the guest. If the host doesn't support kvm irqfd, regular msi notifications are still supported. Note: the ivshmem implementation doesn't allow switching between MSI and IO interrupts, this patch doesn't either. Signe

[Qemu-devel] [PATCH v4 38/47] msix: implement pba write (but read-only)

From: Marc-André Lureau qpci_msix_pending() writes on pba region, causing qemu to SEGV: Program received signal SIGSEGV, Segmentation fault. [Switching to Thread 0x77fba8c0 (LWP 25882)] 0x in ?? () (gdb) bt #0 0x in () #1 0x556556c5 in m

[Qemu-devel] [PATCH v4 47/47] ivshmem: use little-endian int64_t for the protocol

From: Marc-André Lureau The current ivshmem protocol uses 'long' for integers. But the sizeof(long) depends on the host and the endianess is not defined, which may cause portability troubles. Instead, switch to using little-endian int64_t. This breaks the protocol, except on x64 little-endian ho

[Qemu-devel] [PATCH v4 39/47] qtest: add qtest_add_abrt_handler()

From: Marc-André Lureau Allow a test to add abort handlers, use GHook for all handlers. There is currently no way to remove a handler, but it could be later added if needed. Signed-off-by: Marc-André Lureau --- tests/libqtest.c | 37 - tests/libqtest.h | 2

[Qemu-devel] [PATCH v5 02/21] configure: probe for memfd

From: Marc-André Lureau Check if memfd_create() is part of system libc. Signed-off-by: Marc-André Lureau --- configure | 19 +++ 1 file changed, 19 insertions(+) diff --git a/configure b/configure index 52f5b79..a7cdfa4 100755 --- a/configure +++ b/configure @@ -3455,6 +3455,2

[Qemu-devel] [PATCH v5 01/21] vhost-user: unit test for new messages

From: "Michael S. Tsirkin" Data is empty for now, but do make sure master sets the new feature bit flag. Signed-off-by: Michael S. Tsirkin --- tests/vhost-user-test.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/tests/vhost-user-test.c b/tests/vhost-user-test.c inde

[Qemu-devel] [PATCH v5 04/21] util: add memfd helpers

From: Marc-André Lureau Add qemu_memfd_alloc/free() helpers. The function helps to allocate and seal a memfd, and implements an open/unlink/mmap fallback for system that do not support memfd. Signed-off-by: Marc-André Lureau --- include/qemu/memfd.h | 4 +++ util/memfd.c | 74 +++

[Qemu-devel] [PATCH v5 09/21] vhost-user: add a migration blocker

From: Marc-André Lureau If VHOST_USER_PROTOCOL_F_LOG_SHMFD is not announced, block vhost-user migration. Signed-off-by: Marc-André Lureau --- hw/virtio/vhost-user.c | 13 + 1 file changed, 13 insertions(+) diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c index 6420efd.

[Qemu-devel] [PATCH v5 00/21] vhost-user: add migration support

From: Marc-André Lureau Hi, The following series implement shareable log for vhost-user to support memory tracking during live migration. On qemu-side, the solution is fairly straightfoward since vhost already supports the dirty log, only vhost-user couldn't access the log memory until then. Th

[Qemu-devel] [PATCH v5 05/21] vhost: alloc shareable log

From: Marc-André Lureau If the backend is of type VHOST_BACKEND_TYPE_USER, allocate shareable memory. Next patch will only allocate when the backend has the required feature. vhost_log_get() now uses 2 globals "vhost_log" and "vhost_log_shm", that way there is a common non-shareable log and a co

[Qemu-devel] [PATCH v5 11/21] vhost: only use shared log if in use by backend

From: Marc-André Lureau Do not allocate a shared log if the backend doesn't support it. Signed-off-by: Marc-André Lureau --- hw/virtio/vhost-user.c| 9 + hw/virtio/vhost.c | 15 ++- include/hw/virtio/vhost-backend.h | 4 3 files changed, 2

[Qemu-devel] [PATCH v5 07/21] vhost: add vhost_set_log_base op

From: Marc-André Lureau Split VHOST_SET_LOG_BASE call in a seperate function callback, so that type safety works and more arguments can be added in the next patches. Signed-off-by: Marc-André Lureau --- hw/virtio/vhost-backend.c | 8 hw/virtio/vhost-user.c| 17 +++

[Qemu-devel] [PATCH v5 06/21] vhost: document log resizing

From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- hw/virtio/vhost.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c index bf88618..7bc3862 100644 --- a/hw/virtio/vhost.c +++ b/hw/virtio/vhost.c @@ -364,6 +364,8 @@ static inline void vhost_d

[Qemu-devel] [PATCH v5 03/21] util: add linux-only memfd fallback

From: Marc-André Lureau Implement memfd_create() fallback if not available in system libc. memfd_create() is still not included in glibc today, atlhough it's been available since Linux 3.17 in Oct 2014. memfd has numerous advantages over traditional shm/mmap for ipc memory sharing with fd handle

[Qemu-devel] [PATCH v5 10/21] vhost: use a function for each call

From: Marc-André Lureau Replace the generic vhost_call() by specific functions for each function call to help with type safety and changing arguments. While doing this, I found that "unsigned long long" and "uint64_t" were used interchangeably and causing compilation warnings, using uint64_t ins

[Qemu-devel] [PATCH v5 08/21] vhost-user: send log shm fd along with log_base

From: Marc-André Lureau Send the shm for the dirty pages logging if the backend supports VHOST_USER_PROTOCOL_F_LOG_SHMFD. Wait for a reply to make sure the old log is no longer used. Signed-off-by: Marc-André Lureau --- hw/virtio/vhost-backend.c | 3 ++- hw/virtio/vhost-user.c

[Qemu-devel] [PATCH v5 14/21] vhost user: add support of live migration

From: Thibaut Collet Some vhost user backends are able to support live migration. To provide this service the following features must be added: 1. Add the VIRTIO_NET_F_GUEST_ANNOUNCE capability to vhost-net when netdev backend is vhost-user. 2. Provide a nop receive callback to vhost-user.

[Qemu-devel] [PATCH v5 19/21] vhost-user-test: learn to tweak various qemu arguments

From: Marc-André Lureau Add a new macro to make the qemu command line with other values of memory size, and specific chardev id. Signed-off-by: Marc-André Lureau --- tests/vhost-user-test.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/tests/vhost-user-test

[Qemu-devel] [PATCH v5 12/21] vhost-user: document migration log

From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- docs/specs/vhost-user.txt | 48 +-- 1 file changed, 46 insertions(+), 2 deletions(-) diff --git a/docs/specs/vhost-user.txt b/docs/specs/vhost-user.txt index 4eadad1..e0292a0 100644 --- a/d

[Qemu-devel] [PATCH v5 17/21] vhost-user-test: remove useless static check

From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- tests/vhost-user-test.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/vhost-user-test.c b/tests/vhost-user-test.c index 88714ff..6662ca9 100644 --- a/tests/vhost-user-test.c +++ b/tests/vhost-user-test.c @@ -262,7 +262,6 @@

[Qemu-devel] [PATCH v5 16/21] vhost-user-test: move wait_for_fds() out

From: Marc-André Lureau This function is a precondition for most vhost-user tests. Signed-off-by: Marc-André Lureau --- tests/vhost-user-test.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/tests/vhost-user-test.c b/tests/vhost-user-test.c index 77b7b68

[Qemu-devel] [PATCH v5 21/21] vhost-user-test: check ownership during migration

From: Marc-André Lureau Check that backend source and destination do not have simultaneous ownership during migration. Signed-off-by: Marc-André Lureau --- tests/vhost-user-test.c | 38 ++ 1 file changed, 38 insertions(+) diff --git a/tests/vhost-user-test.

[Qemu-devel] [PATCH v5 13/21] net: add trace_vhost_user_event

From: Marc-André Lureau Replace error_report() and use tracing instead. It's not an error to get a connection or a disconnection, so silence this and trace it instead. Signed-off-by: Marc-André Lureau --- net/vhost-user.c | 4 ++-- trace-events | 3 +++ 2 files changed, 5 insertions(+), 2

[Qemu-devel] [PATCH v5 18/21] vhost-user-test: wrap server in TestServer struct

From: Marc-André Lureau In the coming patches, a test will use several servers simultaneously. Wrap the server in a struct, out of the global scope. Signed-off-by: Marc-André Lureau --- tests/vhost-user-test.c | 146 ++-- 1 file changed, 92 insertion

[Qemu-devel] [PATCH v5 15/21] vhost user: add rarp sending after live migration for legacy guest

From: Thibaut Collet A new vhost user message is added to allow QEMU to ask to vhost user backend to broadcast a fake RARP after live migration for guest without GUEST_ANNOUNCE capability. This new message is sent only if the backend supports the new VHOST_USER_PROTOCOL_F_RARP protocol feature.

[Qemu-devel] [PATCH v5 20/21] vhost-user-test: add live-migration test

From: Marc-André Lureau This test checks that the log fd is given to the migration source, and mark dirty pages during migration. Signed-off-by: Marc-André Lureau --- tests/vhost-user-test.c | 171 +++- 1 file changed, 168 insertions(+), 3 deletions(

[Qemu-devel] [PATCH 02/36] qapi: add missing @

From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- qapi/block.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qapi/block.json b/qapi/block.json index aad645c..84022f1 100644 --- a/qapi/block.json +++ b/qapi/block.json @@ -6,7 +6,7 @@ { 'include': 'block-core.

[Qemu-devel] [PATCH 03/36] qapi: add some line spacing to help doc parser

From: Marc-André Lureau Paragraphs are seperated by empty lines. Signed-off-by: Marc-André Lureau --- qapi-schema.json | 14 ++ qapi/block-core.json | 26 ++ 2 files changed, 40 insertions(+) diff --git a/qapi-schema.json b/qapi-schema.json index 3e2e53

[Qemu-devel] [PATCH 06/36] qapi: move documentation bits in schema files

From: Marc-André Lureau Moving the remaining bits of documentation to the schema files. Signed-off-by: Marc-André Lureau --- qapi-schema.json | 48 ++- qmp-commands.hx | 62 2 files changed, 47 in

[Qemu-devel] [PATCH 04/36] monitor: use qapi for qmp_capabilities command

From: Marc-André Lureau This was initially done to add qmp_capabilities documentation to the schema. Then I figured it would also help to get rid of the "middle mode" monitor dispatch code. Signed-off-by: Marc-André Lureau --- monitor.c| 4 ++-- qapi-schema.json | 17 +

[Qemu-devel] [PATCH 08/36] qapi: add qapi2texi script

From: Marc-André Lureau As the name suggests, the qapi2texi script converts JSON QAPI description into a standalone texi file suitable for different target formats. It parses the following kind of blocks with some little variations: ## # = Section # == Subsection # # Some text foo wit

[Qemu-devel] [PATCH 00/36] post-Eric's fixes, QAPI improvements

From: Marc-André Lureau Hi, I have grown a qapi branch during the past 2 months that was post-poned for review until the introspection and other fixes got merged or ready. It could be splitted roughly in 3 parts, but since they depend on each other, it make sense to send as one: 1. generate QA

[Qemu-devel] [PATCH 07/36] qapi: add some headings in docs

From: Marc-André Lureau Add some missing double-#, the doc parser can't easily distinguish doc comments from comments to be ignored otherwise. Also add some more section headings. Signed-off-by: Marc-André Lureau --- qapi-schema.json | 12 ++-- qapi/block-core.json | 6 -- qa

[Qemu-devel] [PATCH 10/36] texi2pod: learn quotation, deftp and deftypefn

From: Marc-André Lureau Learn a few more markups used for API documentation. Signed-off-by: Marc-André Lureau --- scripts/texi2pod.pl | 44 +++- 1 file changed, 43 insertions(+), 1 deletion(-) diff --git a/scripts/texi2pod.pl b/scripts/texi2pod.pl index

[Qemu-devel] [PATCH 15/36] monitor: register gen:false commands manually

From: Marc-André Lureau Since some commands are using 'gen': false, they are not registered automatically by the generator. Register manually instead. Signed-off-by: Marc-André Lureau --- monitor.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/monitor.c b/monitor.c index 410c

[Qemu-devel] [PATCH 01/36] qapi: add comment block before ChardevDummy

From: Marc-André Lureau This is mainly to please the doc generation that requires comment block before the declaration. Signed-off-by: Marc-André Lureau --- qapi-schema.json | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/qapi-schema.json b/qapi-schema.json index 516c9

[Qemu-devel] [PATCH 12/36] build-sys: generate qmp-commands.txt

From: Marc-André Lureau Not sure this is really necessary, but it's easy to provide Signed-off-by: Marc-André Lureau --- Makefile | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 918ad4e..5e09e88 100644 --- a/Makefile +++ b/Makefile @@ -525,8 +

[Qemu-devel] [PATCH 11/36] build-sys: generate QAPI doc based on json

From: Marc-André Lureau Learn to generate info/html/pdf/man documentation for QEMU and agent QMP APIs. This allows to provide missing agent documentation, and should help getting rid of the duplicate documentation in qmp-commands.hx. Signed-off-by: Marc-André Lureau --- Makefile | 36

[Qemu-devel] [RFC PATCH 2/2] vhost-user: delete chardev on cleanup

From: Marc-André Lureau Remove the chardev implicitely when cleaning up the netdev. This prevents from reusing the chardev since it would be in an incorrect state for the server. Signed-off-by: Marc-André Lureau --- net/vhost-user.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/vhost

[Qemu-devel] [RFC PATCH 1/2] vhost-user: release chardev on cleanup

From: Marc-André Lureau On init, vhost-user does qemu_chr_fe_claim_no_fail(). Do the opposite on cleanup to allow removing or reusing the chardev. Signed-off-by: Marc-André Lureau --- net/vhost-user.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/vhost-user.c b/net/vhost-user.c ind

[Qemu-devel] [RFC PATCH 0/2] vhost-user: release chardev on cleanup

From: Marc-André Lureau The following 2 one-liners remove the chardev from the vhost-user netdev it is attached to. This prevents from further reuse of the chardev that would likely fail to setup again with the backend depending on their state. Related to: https://bugzilla.redhat.com/show_bug.cg

[Qemu-devel] [PATCH] qapi-schema: remove legacy<> from doc

From: Marc-André Lureau The legacy<> type is no longer used since 7ce7ffe02. Signed-off-by: Marc-André Lureau --- qapi-schema.json | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/qapi-schema.json b/qapi-schema.json index 67fef37..884d476 100644 --- a/qapi-sc

[Qemu-devel] [PATCH] qom/object.h: remove some child/parent doc

From: Marc-André Lureau It looks like this documentation is obsolete: a child object may lookup its parent stored in the Object struct. Signed-off-by: Marc-André Lureau --- include/qom/object.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/include/qom/object.h b/include/qom/object.h in

[Qemu-devel] [PATCH] specs/vhost-user.txt: fix name of messages

From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- docs/specs/vhost-user.txt | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/docs/specs/vhost-user.txt b/docs/specs/vhost-user.txt index 0322bcf..1bc6adb 100644 --- a/docs/specs/vhost-user.txt +++ b

<    1   2   3   4   5   6   7   8   9   10   >