[PATCH v3 0/2] cocoa: keyboard quality of life

2021-05-04 Thread gustavo
From: Gustavo Noronha Silva v3 removes a rogue ; that made its way into v2 and makes the swap-option-command parameter off by default, so existing behaviour is maintained, as suggested by BALATON Zoltan. - This series adds two new options to the cocoa display: - full-grab causes it to

[PATCH v3 2/2] ui/cocoa: add option to swap Option and Command, enable by default

2021-05-04 Thread gustavo
From: Gustavo Noronha Silva On Mac OS X the Option key maps to Alt and Command to Super/Meta. This change swaps them around so that Alt is the key closer to the space bar and Meta/Super is between Control and Alt, like on non-Mac keyboards. It is a cocoa display option, disabled by default

[PATCH v3 1/2] ui/cocoa: capture all keys and combos when mouse is grabbed

2021-05-04 Thread gustavo
From: Gustavo Noronha Silva Applications such as Gnome may use Alt-Tab and Super-Tab for different purposes, some use Ctrl-arrows so we want to allow qemu to handle everything when it captures the mouse/keyboard. However, Mac OS handles some combos like Command-Tab and Ctrl-arrows at an earlier

[PATCH v4 1/2] ui/cocoa: capture all keys and combos when mouse is grabbed

2021-05-11 Thread gustavo
From: Gustavo Noronha Silva Applications such as Gnome may use Alt-Tab and Super-Tab for different purposes, some use Ctrl-arrows so we want to allow qemu to handle everything when it captures the mouse/keyboard. However, Mac OS handles some combos like Command-Tab and Ctrl-arrows at an earlier

[PATCH v4 2/2] ui/cocoa: add option to swap Option and Command

2021-05-11 Thread gustavo
From: Gustavo Noronha Silva On Mac OS X the Option key maps to Alt and Command to Super/Meta. This change swaps them around so that Alt is the key closer to the space bar and Meta/Super is between Control and Alt, like on non-Mac keyboards. It is a cocoa display option, disabled by default

[PATCH v4 0/2] cocoa: keyboard quality of life

2021-05-11 Thread gustavo
From: Gustavo Noronha Silva v4 moves the code to add the tap to the set function, which not only sidesteps the issue pointed out by Akihiko Odaki but simply makes sense - full-grab is not a runtime toggle and there is no reason to have the tap set up if it's not turned on. It also fixe

[PATCH 2/2] ui/cocoa: add option to swap Option and Command, enable by default

2021-04-29 Thread gustavo
From: Gustavo Noronha Silva On Mac OS X the Option key maps to Alt and Command to Super/Meta. This change swaps them around so that Alt is the key closer to the space bar and Meta/Super is between Control and Alt, like on non-Mac keyboards. It is a cocoa display option, enabled by default

[PATCH 1/2] ui/cocoa: capture all keys and combos when mouse is grabbed

2021-04-29 Thread gustavo
From: Gustavo Noronha Silva Applications such as Gnome may use Alt-Tab and Super-Tab for different purposes, some use Ctrl-arrows so we want to allow qemu to handle everything when it captures the mouse/keyboard. However, Mac OS handles some combos like Command-Tab and Ctrl-arrows at an earlier

[PATCH 0/2] cocoa: keyboard quality of life

2021-04-29 Thread gustavo
From: Gustavo Noronha Silva This series adds two new options to the cocoa display: - full-grab causes it to use a global tap to steal system combos away from Mac OS X, so they can be handled by the VM - swap-option-command does what it says on the tin; while that is something you can

[PATCH v2 1/2] ui/cocoa: capture all keys and combos when mouse is grabbed

2021-04-30 Thread gustavo
From: Gustavo Noronha Silva Applications such as Gnome may use Alt-Tab and Super-Tab for different purposes, some use Ctrl-arrows so we want to allow qemu to handle everything when it captures the mouse/keyboard. However, Mac OS handles some combos like Command-Tab and Ctrl-arrows at an earlier

[PATCH v2 0/2] cocoa: keyboard quality of life

2021-04-30 Thread gustavo
From: Gustavo Noronha Silva v2 fixes QAPI issues pointed out by Markus and comes with his Acked-By. I tried also applying Gerd's suggestion of flipping the flags on modifiers, but turns out it is more intricate than that, as we then also need to flip the keyCode that is used on the switch

[PATCH v2 2/2] ui/cocoa: add option to swap Option and Command, enable by default

2021-04-30 Thread gustavo
From: Gustavo Noronha Silva On Mac OS X the Option key maps to Alt and Command to Super/Meta. This change swaps them around so that Alt is the key closer to the space bar and Meta/Super is between Control and Alt, like on non-Mac keyboards. It is a cocoa display option, enabled by default

[PATCH v5 1/2] ui/cocoa: capture all keys and combos when mouse is grabbed

2021-07-13 Thread gustavo
From: Gustavo Noronha Silva Applications such as Gnome may use Alt-Tab and Super-Tab for different purposes, some use Ctrl-arrows so we want to allow qemu to handle everything when it captures the mouse/keyboard. However, Mac OS handles some combos like Command-Tab and Ctrl-arrows at an earlier

[PATCH v5 0/2] cocoa: keyboard quality of life

2021-07-13 Thread gustavo
From: Gustavo Noronha Silva v5 addresses the casting issue pointed out by Akihiko Odaki. Sorry it took me so long to update the patches, but here they are! Hopefully we can get them in now ;D Btw I also changed my email address slightly (.dev.br instead of .eti.br). - This series adds two

[PATCH v5 2/2] ui/cocoa: add option to swap Option and Command

2021-07-13 Thread gustavo
From: Gustavo Noronha Silva On Mac OS X the Option key maps to Alt and Command to Super/Meta. This change swaps them around so that Alt is the key closer to the space bar and Meta/Super is between Control and Alt, like on non-Mac keyboards. It is a cocoa display option, disabled by default

Re: [Qemu-devel] [PATCH] linux-user: Handle images where lowest vaddr is not page aligned

2011-05-17 Thread Gustavo Niemeyer
> Thanks for tracking this down! Indeed, thanks a lot for the very fast action on this. -- Gustavo Niemeyer http://niemeyer.net http://niemeyer.net/blog http://niemeyer.net/twitter

[Qemu-devel] [Bug 988909] [NEW] Assert failed in arp_table.c

2012-04-26 Thread Gustavo Padovan
Public bug reported: With latest git (8001954) hen running: qemu-system-64 -hda $VDISK -kernel arch/x86/boot/bzImage \ -append "ro root=/dev/hda1 console=ttyS0 init=/bin/systemd" \ -curses \ -net nic -smp 3 -m 312 $@ I'm getting this: qemu-system-x86_64: slirp/arp_tab

[Qemu-devel] [Bug 1470720] Re: high IRQ-TLB generates network interruptions

2015-07-01 Thread gustavo panizzo
maybe first part is not clear, here it goes again this happens on some hypervisors at random times, not all hypervisors at the same time, and affects all vm on the hypervisor -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://b

[Qemu-devel] [Bug 1470720] [NEW] high IRQ-TLB generates network interruptions

2015-07-01 Thread gustavo panizzo
Public bug reported: we are having a problem in our hosts, all the vm running on them suddenly, and for some seconds, lost network connectivity. the root cause appears to be the increase of irb-tlb from low values (less than 20) to more than >100k, that spike only last for some seconds then ever

[Qemu-devel] [Bug 1470720] Re: high IRQ-TLB generates network interruptions

2015-07-03 Thread gustavo panizzo
overcommit ratio on latest server i had the problem is 3.6 (3.6 vcpu for each cpu), would that be part of the problem? i see other servers that never had the problem with over commit ratios as high as 4.1 -- You received this bug notification because you are a member of qemu- devel-ml, which is

[Qemu-devel] [Bug 988909] Re: Assert failed in arp_table.c

2012-04-26 Thread Gustavo Padovan
Well, if I remove the assertion everything works, but this might not be the right fix. The bug maybe somewhere else. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/988909 Title: Assert failed in arp

[Qemu-devel] Interactive Unix 4

2009-11-19 Thread Gustavo Alves
r had experience before with qemu, how this problem can the debugged? Someone had previous experience with this issue? Anyone can give-me some directions? Thanks Gustavo

[Qemu-devel] kqemu compiler error

2007-08-08 Thread Gustavo Serra
Hi, I am using slack11, kernel 2.6.22, after ./compile; make, I had the errors: CC [M] /home/serra/kqemu-1.3.0pre11/kqemu-linux.o /home/serra/kqemu-1.3.0pre11/kqemu-linux.c: In function `kqemu_lock_user_page': /home/serra/kqemu-1.3.0pre11/kqemu-linux.c:82: error: dereferencing pointer to incomp

[PATCH 1/2] gdbstub: Add Xfer:siginfo:read stub

2024-03-03 Thread Gustavo Romero
ignal, like the fault address/insn when the SIGSEGV is caught. The siginfo is also used by GDB to find out the si_code automatically and show additional info to the user in some cases. This is only a QEMU user mode and Linux-only feature. Signed-off-by: Gustavo Romero --- gdbstub/gdb

[PATCH 2/2] tests/tcg: Add multiarch test for Xfer:siginfo:read stub

2024-03-03 Thread Gustavo Romero
Add multiarch test for testing if Xfer:siginfo:read query is properly handled by gdbstub. Signed-off-by: Gustavo Romero --- tests/tcg/multiarch/Makefile.target | 10 ++- .../gdbstub/test-qxfer-siginfo-read.py| 26 +++ tests/tcg/multiarch/segfault.c

Re: [PATCH 2/2] tests/tcg: Add multiarch test for Xfer:siginfo:read stub

2024-03-04 Thread Gustavo Romero
Hi Richard! On 3/4/24 2:21 PM, Richard Henderson wrote: On 3/3/24 09:26, Gustavo Romero wrote: Add multiarch test for testing if Xfer:siginfo:read query is properly handled by gdbstub. Signed-off-by: Gustavo Romero ---   tests/tcg/multiarch/Makefile.target   | 10

Re: [PATCH 2/2] tests/tcg: Add multiarch test for Xfer:siginfo:read stub

2024-03-07 Thread Gustavo Romero
Hi Richard, On 3/4/24 7:51 PM, Richard Henderson wrote: On 3/4/24 10:59, Gustavo Romero wrote: Perhaps just abort for SIGABRT instead? Although this can make a simpler test, the test can't control the si_addr value easily, which I think is interesting to be tested. Why do you prefer SI

Re: [PATCH 1/2] gdbstub: Add Xfer:siginfo:read stub

2024-03-07 Thread Gustavo Romero
On 3/4/24 2:18 PM, Richard Henderson wrote: On 3/3/24 09:26, Gustavo Romero wrote: +    /* Filter out si_type from si_code. See comment in siginfo_noswap(). */ > +    tmp_siginfo = ts->sync_signal.info; +    tmp_siginfo.si_code = sextract32(tmp_siginfo.si_code, 0, 16); This is incorre

[PATCH v2 1/5] gdbstub: Rename back gdb_handlesig

2024-03-07 Thread Gustavo Romero
Rename gdb_handlesig_reason back to gdb_handlesig. There is no need to add a wrapper for gdb_handlesig and rename it when a new parameter is added. Signed-off-by: Gustavo Romero --- gdbstub/user.c | 8 include/gdbstub/user.h | 15 ++- linux-user/main.c | 2

[PATCH v2 3/5] gdbstub: Save target's siginfo

2024-03-07 Thread Gustavo Romero
Save target's siginfo into gdbserver_state so it can be used later, for example, in any stub that requires the target's si_signo and si_code. This change affects only linux-user mode. Signed-off-by: Gustavo Romero Suggested-by: Richard Henderson --- gdbstub/internals.h| 3 ++

[PATCH v2 4/5] gdbstub: Add Xfer:siginfo:read stub

2024-03-07 Thread Gustavo Romero
s on the signal, like the fault address/insn when the SIGSEGV is caught. Signed-off-by: Gustavo Romero --- gdbstub/gdbstub.c | 8 gdbstub/internals.h | 1 + gdbstub/user-target.c | 23 +++ 3 files changed, 32 insertions(+) diff --git a/gdbstub/gdbstub.c b/gd

[PATCH v2 5/5] tests/tcg: Add multiarch test for Xfer:siginfo:read stub

2024-03-07 Thread Gustavo Romero
Add multiarch test for testing if Xfer:siginfo:read query is properly handled by gdbstub. Signed-off-by: Gustavo Romero --- tests/tcg/multiarch/Makefile.target | 10 ++- .../gdbstub/test-qxfer-siginfo-read.py| 26 +++ tests/tcg/multiarch/segfault.c

[PATCH v2 2/5] linux-user: Move tswap_siginfo out of target code

2024-03-07 Thread Gustavo Romero
Move tswap_siginfo from target code to handle_pending_signal. This will allow some cleanups and having the siginfo ready to be used in gdbstub. Signed-off-by: Gustavo Romero Suggested-by: Richard Henderson --- linux-user/aarch64/signal.c | 2 +- linux-user/alpha/signal.c | 2

Re: [PATCH v2 0/6] Add ivshmem-flat device

2024-02-20 Thread Gustavo Romero
uld send a v3; or if I can take it and address the fixes needed myself and then I post the v3. Please advise :) Anyways, I have some comments about it, which I'll write inline, per patch. Cheers, Gustavo

Re: [PATCH v2 2/6] hw/misc/ivshmem-flat: Allow device to wire itself on sysbus

2024-02-20 Thread Gustavo Romero
On 2/16/24 11:44 AM, Philippe Mathieu-Daudé wrote: From: Gustavo Romero The following is an example on how to create the ivshmem-flat device on a Stellaris machine: $ qemu-system-arm -cpu cortex-m3 -machine lm3s6965evb -nographic -net none -chardev stdio,id=con,mux=on

Re: [PATCH v2 2/6] hw/misc/ivshmem-flat: Allow device to wire itself on sysbus

2024-02-20 Thread Gustavo Romero
On 2/16/24 11:44 AM, Philippe Mathieu-Daudé wrote: From: Gustavo Romero The following is an example on how to create the ivshmem-flat device on a Stellaris machine: $ qemu-system-arm -cpu cortex-m3 -machine lm3s6965evb -nographic -net none -chardev stdio,id=con,mux=on

Re: [PATCH v2 6/6] tests/qtest: Add ivshmem-flat test

2024-02-20 Thread Gustavo Romero
On 2/16/24 11:44 AM, Philippe Mathieu-Daudé wrote: From: Gustavo Romero Add qtest for the ivshmem-flat device. This needs a commit message. All tests are failing is this commit due to the last changes. So we need to tweak it (see my comments inline). Also, I think we need to mark it

Re: [PATCH] test/qtest: Add an API function to capture IRQ toggling

2024-02-21 Thread Gustavo Romero
Hi Phil, Apologies, I missed this and I just found it when preparing now the v3 for ivshmem-flat. On 12/13/23 6:15 AM, Philippe Mathieu-Daudé wrote: On 13/11/23 18:33, Gustavo Romero wrote: Currently the QTest API does not provide a function to allow capturing when an IRQ line is toggled

[PATCH 6/6] tests/qtest: Add ivshmem-flat test

2024-02-22 Thread Gustavo Romero
off-by: Philippe Mathieu-Daudé Signed-off-by: Gustavo Romero --- tests/qtest/ivshmem-flat-test.c | 338 tests/qtest/meson.build | 2 + 2 files changed, 340 insertions(+) create mode 100644 tests/qtest/ivshmem-flat-test.c diff --git a/tests/qtest/ivshme

[PATCH 3/6] hw/arm: Allow some machines to use the ivshmem-flat device

2024-02-22 Thread Gustavo Romero
Allow Arm machine lm3s6965evb and the mps2 ones, like the mps2-an385, to use the ivshmem-flat device. Message-ID: <20231127052024.435743-2-gustavo.rom...@linaro.org> Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Gustavo Romero --- hw/arm/mps2.c | 3 +++ hw/arm/stellaris

[PATCH 2/6] hw/misc/ivshmem-flat: Allow device to wire itself on sysbus

2024-02-22 Thread Gustavo Romero
s for status and control (notification) are mapped to the MMIO region at 'x-bus-address-iomem', whilst the shared memory region start is mapped at address specified by 'x-bus-address-shmem'. Message-ID: <20231127052024.435743-2-gustavo.rom...@linaro.org> Signed-off-by: Phi

[PATCH 5/6] tests/qtest: Reorganize common code in ivshmem-test

2024-02-22 Thread Gustavo Romero
ed in meson.build. Message-ID: <20231127052024.435743-3-gustavo.rom...@linaro.org> Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Gustavo Romero --- tests/qtest/ivshmem-test.c | 113 ++ tests/qtest/ivshmem-utils.c | 156 tests/qtest/ivshme

[PATCH 4/6] hw/misc/ivshmem: Rename ivshmem to ivshmem-pci

2024-02-22 Thread Gustavo Romero
Because now there is also an MMIO ivshmem device (ivshmem-flat.c), and ivshmem.c is a PCI specific implementation, rename it to ivshmem-pci.c. Reviewed-by: Philippe Mathieu-Daudé Message-ID: <20231127052024.435743-5-gustavo.rom...@linaro.org> Signed-off-by: Gustavo Romero --- h

[PATCH 0/6] Add ivshmem-flat device

2024-02-22 Thread Gustavo Romero
mr1: 0 0 mmr2: 6 6 mmr3: 0 0 Data ok. 4194304 byte(s) checked. The arm VM should report something like: *** Got interrupt at vector 0! *** Writting constant 0xb5b5b5b5 to shmem... done! *** Notifying back peer ID 6 at vector 0... Cheers, Gustavo Gustavo Romero (6): hw/misc/ivshmem: Add ivshmem-f

[PATCH 1/6] hw/misc/ivshmem: Add ivshmem-flat device

2024-02-22 Thread Gustavo Romero
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1134 Message-ID: <20231127052024.435743-2-gustavo.rom...@linaro.org> Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Gustavo Romero --- docs/system/devices/ivshmem-flat.rst | 33 ++ hw/misc/Kconfig | 5 + h

Re: [PATCH v2 0/6] target/arm: assorted mte fixes

2024-02-06 Thread Gustavo Romero
15 ++ target/arm/tcg/translate-sve.c| 80 ++- 7 files changed, 78 insertions(+), 66 deletions(-) Tested-by: Gustavo Romero Thanks!

Re: [PATCH v2 1/6] linux-user/aarch64: Extend PR_SET_TAGGED_ADDR_CTRL for FEAT_MTE3

2024-02-06 Thread Gustavo Romero
& PR_MTE_TCF_SYNC) { +tcf = 1; +} +env->cp15.sctlr_el[1] = deposit64(env->cp15.sctlr_el[1], 38, 2, tcf); /* * Write PR_MTE_TAG to GCR_EL1[Exclude]. Reviewed-by: Gustavo Romero

Re: [PATCH v3 1/6] linux-user/aarch64: Choose SYNC as the preferred MTE mode

2024-02-07 Thread Gustavo Romero
On 2/6/24 11:52 PM, Richard Henderson wrote: The API does not generate an error for setting ASYNC | SYNC; that merely constrains the selection vs the per-cpu default. For qemu linux-user, choose SYNC as the default. Cc: qemu-sta...@nongnu.org Reported-by: Gustavo Romero Signed-off-by

Re: [PATCH v3 0/6] target/arm: assorted mte fixes

2024-02-07 Thread Gustavo Romero
-- expecting no different result -- so: Tested-by: Gustavo Romero If that t-b tag doesn't make sense, feel free to drop it :) Thanks for fixing it! Cheers, Gustavo

Re: [PATCH 2/2] tests/tcg: Add multiarch test for Xfer:siginfo:read stub

2024-03-08 Thread Gustavo Romero
On 3/7/24 4:31 PM, Richard Henderson wrote: On 3/7/24 07:50, Gustavo Romero wrote: Hi Richard, On 3/4/24 7:51 PM, Richard Henderson wrote: On 3/4/24 10:59, Gustavo Romero wrote: Perhaps just abort for SIGABRT instead? Although this can make a simpler test, the test can't contro

Re: [PATCH v2 3/5] gdbstub: Save target's siginfo

2024-03-08 Thread Gustavo Romero
Hi Alex, On 3/7/24 7:33 PM, Alex Bennée wrote: Richard Henderson writes: On 3/7/24 08:26, Gustavo Romero wrote: Save target's siginfo into gdbserver_state so it can be used later, for example, in any stub that requires the target's si_signo and si_code. This change affects only

Re: [PATCH v2 4/5] gdbstub: Add Xfer:siginfo:read stub

2024-03-08 Thread Gustavo Romero
Hi Richard! On 3/7/24 6:13 PM, Richard Henderson wrote: On 3/7/24 08:26, Gustavo Romero wrote: +void gdb_handle_query_xfer_siginfo(GArray *params, void *user_ctx) +{ +    unsigned long offset, len; +    uint8_t *siginfo_offset; + +    offset = get_param(params, 0)->val_ul; +    len = get_pa

Re: [PATCH v2 3/5] gdbstub: Save target's siginfo

2024-03-08 Thread Gustavo Romero
Hi Richard, On 3/7/24 6:09 PM, Richard Henderson wrote: On 3/7/24 08:26, Gustavo Romero wrote: Save target's siginfo into gdbserver_state so it can be used later, for example, in any stub that requires the target's si_signo and si_code. This change affects only linux-user mode. Sig

[PATCH v3 2/5] linux-user: Move tswap_siginfo out of target code

2024-03-08 Thread Gustavo Romero
Move tswap_siginfo from target code to handle_pending_signal. This will allow some cleanups and having the siginfo ready to be used in gdbstub. Signed-off-by: Gustavo Romero Suggested-by: Richard Henderson Reviewed-by: Richard Henderson --- linux-user/aarch64/signal.c | 2 +- linux-user

[PATCH v3 0/5] Add stub to handle Xfer:siginfo:read query

2024-03-08 Thread Gustavo Romero
l/qemu-devel/2024-03/msg00423.html v2: https://lists.gnu.org/archive/html/qemu-devel/2024-03/msg01858.html Cheers, Gustavo Gustavo Romero (5): gdbstub: Rename back gdb_handlesig linux-user: Move tswap_siginfo out of target code gdbstub: Save target's siginfo gdbstub: Add Xfer:sigi

[PATCH v3 4/5] gdbstub: Add Xfer:siginfo:read stub

2024-03-08 Thread Gustavo Romero
s on the signal, like the fault address/insn when the SIGSEGV is caught. Signed-off-by: Gustavo Romero --- gdbstub/gdbstub.c | 8 gdbstub/internals.h | 1 + gdbstub/user.c | 23 +++ 3 files changed, 32 insertions(+) diff --git a/gdbstub/gdbstub.c b/gdbstub/

[PATCH v3 3/5] gdbstub: Save target's siginfo

2024-03-08 Thread Gustavo Romero
Save target's siginfo into gdbserver_state so it can be used later, for example, in any stub that requires the target's si_signo and si_code. This change affects only linux-user mode. Signed-off-by: Gustavo Romero Suggested-by: Richard Henderson --- bsd-user/main.c| 2 +-

[PATCH v3 1/5] gdbstub: Rename back gdb_handlesig

2024-03-08 Thread Gustavo Romero
Rename gdb_handlesig_reason back to gdb_handlesig. There is no need to add a wrapper for gdb_handlesig and rename it when a new parameter is added. Signed-off-by: Gustavo Romero Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson --- gdbstub/user.c | 8 include/gdbstub

[PATCH v3 5/5] tests/tcg: Add multiarch test for Xfer:siginfo:read stub

2024-03-08 Thread Gustavo Romero
Add multiarch test for testing if Xfer:siginfo:read query is properly handled by gdbstub. Signed-off-by: Gustavo Romero Reviewed-by: Richard Henderson --- tests/tcg/multiarch/Makefile.target | 10 ++- .../gdbstub/test-qxfer-siginfo-read.py| 26 +++ tests

Re: [PATCH 0/6] Add ivshmem-flat device

2024-04-22 Thread Gustavo Romero
Hi Markus, Thanks for interesting in the ivshmem-flat device. Bill Mills (cc:ed) is the best person to answer your question, so please find his answer below. On 2/28/24 3:29 AM, Markus Armbruster wrote: Gustavo Romero writes: [...] This patchset introduces a new device, ivshmem-flat

Re: [PATCH v5 0/9] TCG plugins new inline operations

2024-05-02 Thread Gustavo Romero
1/9, 2/9, 6/9, 7/9, and 8/9 is missing. Is this intentional? Cheers, Gustavo

Re: [PATCH v5 0/9] TCG plugins new inline operations

2024-05-02 Thread Gustavo Romero
On 5/2/24 4:45 PM, Pierrick Bouvier wrote: Hi Gustavo, On 5/2/24 12:16, Gustavo Romero wrote: Hi Pierrick, On 5/2/24 3:08 PM, Pierrick Bouvier wrote: This series implement two new operations for plugins: - Store inline allows to write a specific value to a scoreboard. - Conditional callback

Re: [PATCH v5 0/9] TCG plugins new inline operations

2024-05-02 Thread Gustavo Romero
Hi Pierrick, On 5/2/24 5:09 PM, Gustavo Romero wrote: On 5/2/24 4:45 PM, Pierrick Bouvier wrote: Hi Gustavo, On 5/2/24 12:16, Gustavo Romero wrote: Hi Pierrick, On 5/2/24 3:08 PM, Pierrick Bouvier wrote: This series implement two new operations for plugins: - Store inline allows to write a

[PATCH v2 0/2] target/arm: Enable FEAT_Debugv8p8 for -cpu max

2024-06-21 Thread Gustavo Romero
Enable FEAT_Debugv8p8 on Arm max CPU. v2: - Revert to the original comment above call to aa32_max_features() Gustavo Romero (2): target/arm: Move initialization of debug ID registers target/arm: Enable FEAT_Debugv8p8 for -cpu max target/arm/cpu.h | 2 ++ target/arm/tcg/cpu32.c | 34

[PATCH v2 2/2] target/arm: Enable FEAT_Debugv8p8 for -cpu max

2024-06-21 Thread Gustavo Romero
Enable FEAT_Debugv8p8 for max CPU. This feature is out of scope for QEMU since it concerns the external debug interface for JTAG, but is mandatory in Armv8.8 implementations, hence it is reported as supported in the ID registers. Signed-off-by: Gustavo Romero --- target/arm/tcg/cpu32.c | 6

[PATCH v2 1/2] target/arm: Move initialization of debug ID registers

2024-06-21 Thread Gustavo Romero
Move the initialization of the debug ID registers to aa32_max_features, which is used to set the 32-bit ID registers. This ensures that the debug ID registers are consistently set for the max CPU in a single place. Signed-off-by: Gustavo Romero --- target/arm/cpu.h | 2 ++ target/arm/tcg

Re: [PATCH 1/2] target/arm: Move initialization of debug ID registers

2024-06-21 Thread Gustavo Romero
Hi Richard, On 6/20/24 3:21 PM, Richard Henderson wrote: On 6/20/24 11:13, Gustavo Romero wrote: @@ -1268,7 +1268,10 @@ void aarch64_max_tcg_initfn(Object *obj)   t = FIELD_DP64(t, ID_AA64SMFR0, FA64, 1); /* FEAT_SME_FA64 */   cpu->isar.id_aa64smfr0 = t; -    /* Replicate the s

[PATCH v4 4/9] target/arm: Fix exception case in allocation_tag_mem_probe

2024-06-23 Thread Gustavo Romero
If page in 'ptr_access' is inaccessible and probe is 'true' allocation_tag_mem_probe should not throw an exception, but currently it does, so fix it. Signed-off-by: Gustavo Romero Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson --- target/arm/tcg/mte_helper.c | 3

[PATCH v4 1/9] gdbstub: Clean up process_string_cmd

2024-06-23 Thread Gustavo Romero
Change 'process_string_cmd' to return true on success and false on failure, instead of 0 and -1. Signed-off-by: Gustavo Romero Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson --- gdbstub/gdbstub.c | 40 1 file changed, 20 inserti

[PATCH v4 0/9] Add MTE stubs for aarch64 user mode

2024-06-23 Thread Gustavo Romero
review) - Added g_assert()s in new gdb_extend_* API functions to ensure all CPUs have the same features/query/set tables (Alex's review) - Move load_tag1 and store_tag1 to mte_helpers.h marking them as "static inline" (Richard's review) - Move mte_user_helper

[PATCH v4 9/9] tests/tcg/aarch64: Add MTE gdbstub tests

2024-06-23 Thread Gustavo Romero
Add tests to exercise the MTE stubs. The tests will only run if a version of GDB that supports MTE is available in the test environment. Signed-off-by: Gustavo Romero --- configure | 11 +++ tests/tcg/aarch64/Makefile.target | 14 +++- tests/tcg/aarch64/gdbstub

[PATCH v4 5/9] target/arm: Make some MTE helpers widely available

2024-06-23 Thread Gustavo Romero
Make the MTE helpers allocation_tag_mem_probe, load_tag1, and store_tag1 available to other subsystems. Signed-off-by: Gustavo Romero Reviewed-by: Richard Henderson --- target/arm/tcg/mte_helper.c | 54 +++ target/arm/tcg/mte_helper.h | 74

[PATCH v4 3/9] gdbstub: Add support for target-specific stubs

2024-06-23 Thread Gustavo Romero
faces to extend the qSupported string, the query handler table, and the set handler table, allowing target-specific stub implementations. Signed-off-by: Gustavo Romero Reviewed-by: Alex Bennée --- gdbstub/gdbstub.c | 102 ++--- include/gdbstub/commands.h

[PATCH v4 8/9] gdbstub: Add support for MTE in user mode

2024-06-23 Thread Gustavo Romero
d to control the MTE fault type at runtime. Signed-off-by: Gustavo Romero --- configs/targets/aarch64-linux-user.mak | 2 +- gdb-xml/aarch64-mte.xml| 11 ++ target/arm/cpu.c | 1 + target/arm/gdbstub.c | 46 ++ ta

[PATCH v4 6/9] target/arm: Factor out code for setting MTE TCF0 field

2024-06-23 Thread Gustavo Romero
-off-by: Gustavo Romero --- linux-user/aarch64/mte_user_helper.h | 38 linux-user/aarch64/target_prctl.h| 22 ++-- 2 files changed, 40 insertions(+), 20 deletions(-) create mode 100644 linux-user/aarch64/mte_user_helper.h diff --git a/linux-user/aarch64

[PATCH v4 7/9] gdbstub: Make get cpu and hex conversion functions non-internal

2024-06-23 Thread Gustavo Romero
Make the gdb_first_attached_cpu and gdb_hextomem non-internal so they are not confined to use only in gdbstub.c. Signed-off-by: Gustavo Romero Reviewed-by: Richard Henderson --- gdbstub/internals.h| 2 -- include/exec/gdbstub.h | 5 + include/gdbstub/commands.h | 6 ++ 3

[PATCH v4 2/9] gdbstub: Move GdbCmdParseEntry into a new header file

2024-06-23 Thread Gustavo Romero
commit also makes gdb_put_packet public since is used in gdbstub command handling. Signed-off-by: Gustavo Romero Reviewed-by: Alex Bennée --- gdbstub/gdbstub.c | 134 ++--- gdbstub/internals.h| 22 -- gdbstub/syscalls.c | 7 +- gdbstub

Re: [PATCH v3 3/9] gdbstub: Add support for target-specific stubs

2024-06-23 Thread Gustavo Romero
Hi Alex, On 6/21/24 5:11 AM, Alex Bennée wrote: Gustavo Romero writes: Currently, it's not possible to have stubs specific to a given target, even though there are GDB features which are target-specific, like, for instance, memory tagging. This commit intro

Re: [PATCH v3 5/9] target/arm: Make some MTE helpers widely available

2024-06-23 Thread Gustavo Romero
Hi Richard, On 6/21/24 1:31 AM, Richard Henderson wrote: On 6/16/24 23:28, Gustavo Romero wrote: @@ -287,7 +256,7 @@ uint64_t HELPER(addsubg)(CPUARMState *env, uint64_t ptr,   return address_with_allocation_tag(ptr + offset, rtag);   } -static int load_tag1(uint64_t ptr, uint8_t *mem

Re: [PATCH v3 6/9] target/arm: Factor out code for setting MTE TCF0 field

2024-06-23 Thread Gustavo Romero
Hi Richard, On 6/21/24 1:35 AM, Richard Henderson wrote: On 6/16/24 23:28, Gustavo Romero wrote: Factor out the code used for setting the MTE TCF0 field from the prctl code into a convenient function. Other subsystems, like gdbstub, need to set this field as well, so keep it as a separate

Re: [PATCH v2 0/9] Add MTE stubs for aarch64 user mode

2024-06-23 Thread Gustavo Romero
Hi Alex, On 6/17/24 6:50 AM, Alex Bennée wrote: Gustavo Romero writes: Hi Alex, On 6/14/24 12:49 PM, Alex Bennée wrote: Gustavo Romero writes: This patchset adds the stubs necessary to support GDB memory tagging commands on QEMU aarch64 user mode. These new stubs handle the

[PATCH v3 2/3] target/arm: Move initialization of debug ID registers

2024-06-24 Thread Gustavo Romero
Move the initialization of the debug ID registers to aa32_max_features, which is used to set the 32-bit ID registers. This ensures that the debug ID registers are consistently set for the max CPU in a single place. Signed-off-by: Gustavo Romero Reviewed-by: Richard Henderson --- target/arm

[PATCH v3 1/3] target/arm: Fix indentation

2024-06-24 Thread Gustavo Romero
Fix comment indentation adding a missing space. Signed-off-by: Gustavo Romero Reviewed-by: Richard Henderson --- target/arm/tcg/cpu64.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/arm/tcg/cpu64.c b/target/arm/tcg/cpu64.c index 0899251eef..71e1bfcd4e 100644 --- a

[PATCH v3 0/3] target/arm: Enable FEAT_Debugv8p8 for -cpu max

2024-06-24 Thread Gustavo Romero
Enable FEAT_Debugv8p8 on Arm max CPU. v2: - Revert to the original comment above call to aa32_max_features() v3: - Added feature entry to docs/system/arm/emulation.rst - Explicitly set t=0 before using it to set DBGDEVID reg. - Put indent fix in a separate patch Cheers, Gustavo Gustavo

[PATCH v3 3/3] target/arm: Enable FEAT_Debugv8p8 for -cpu max

2024-06-24 Thread Gustavo Romero
Enable FEAT_Debugv8p8 for max CPU. This feature is out of scope for QEMU since it concerns the external debug interface for JTAG, but is mandatory in Armv8.8 implementations, hence it is reported as supported in the ID registers. Signed-off-by: Gustavo Romero Reviewed-by: Richard Henderson

Re: [PATCH v2 1/2] target/arm: Move initialization of debug ID registers

2024-06-24 Thread Gustavo Romero
Hi Peter! On 6/24/24 10:26 AM, Peter Maydell wrote: On Fri, 21 Jun 2024 at 15:39, Gustavo Romero wrote: Move the initialization of the debug ID registers to aa32_max_features, which is used to set the 32-bit ID registers. This ensures that the debug ID registers are consistently set for the

Re: [PATCH v2 2/2] target/arm: Enable FEAT_Debugv8p8 for -cpu max

2024-06-24 Thread Gustavo Romero
Hi Peter, On 6/24/24 10:27 AM, Peter Maydell wrote: On Fri, 21 Jun 2024 at 15:39, Gustavo Romero wrote: Enable FEAT_Debugv8p8 for max CPU. This feature is out of scope for QEMU since it concerns the external debug interface for JTAG, but is mandatory in Armv8.8 implementations, hence it is

[PATCH v5 1/9] gdbstub: Clean up process_string_cmd

2024-06-26 Thread Gustavo Romero
Change 'process_string_cmd' to return true on success and false on failure, instead of 0 and -1. Signed-off-by: Gustavo Romero Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson --- gdbstub/gdbstub.c | 40 1 file changed, 20 inserti

[PATCH v5 8/9] gdbstub: Add support for MTE in user mode

2024-06-26 Thread Gustavo Romero
d to control the MTE fault type at runtime. Signed-off-by: Gustavo Romero --- configs/targets/aarch64-linux-user.mak | 2 +- gdb-xml/aarch64-mte.xml| 11 ++ target/arm/cpu.c | 1 + target/arm/gdbstub.c | 46 ++ ta

[PATCH v5 9/9] tests/tcg/aarch64: Add MTE gdbstub tests

2024-06-26 Thread Gustavo Romero
Add tests to exercise the MTE stubs. The tests will only run if a version of GDB that supports MTE is available in the test environment. Signed-off-by: Gustavo Romero --- configure | 4 ++ tests/tcg/aarch64/Makefile.target | 14 +++- tests/tcg/aarch64/gdbstub

[PATCH v5 0/9] Add MTE stubs for aarch64 user mode

2024-06-26 Thread Gustavo Romero
er/aarch64/ and include it from gdbstub64.c (Richard's review) v5: - Made load_tag1, store_tag1, and arm_set_mte_tcf0 non-inlined for code modularity (Phil's review) - MTE tests: GDB_HAS_MTE is now only set for aarch64 targets (Alex's suggestion) Cheers, Gustavo Gustav

[PATCH v5 4/9] target/arm: Fix exception case in allocation_tag_mem_probe

2024-06-26 Thread Gustavo Romero
If page in 'ptr_access' is inaccessible and probe is 'true' allocation_tag_mem_probe should not throw an exception, but currently it does, so fix it. Signed-off-by: Gustavo Romero Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson --- target/arm/tcg/mte_helper.c | 3

[PATCH v5 6/9] target/arm: Factor out code for setting MTE TCF0 field

2024-06-26 Thread Gustavo Romero
-off-by: Gustavo Romero --- linux-user/aarch64/meson.build | 2 ++ linux-user/aarch64/mte_user_helper.c | 34 linux-user/aarch64/mte_user_helper.h | 25 linux-user/aarch64/target_prctl.h| 22 ++ 4 files changed, 63

[PATCH v5 5/9] target/arm: Make some MTE helpers widely available

2024-06-26 Thread Gustavo Romero
Make the MTE helpers allocation_tag_mem_probe, load_tag1, and store_tag1 available to other subsystems. Signed-off-by: Gustavo Romero Reviewed-by: Richard Henderson --- target/arm/tcg/mte_helper.c | 45 - target/arm/tcg/mte_helper.h | 66

[PATCH v5 7/9] gdbstub: Make get cpu and hex conversion functions non-internal

2024-06-26 Thread Gustavo Romero
Make the gdb_first_attached_cpu and gdb_hextomem non-internal so they are not confined to use only in gdbstub.c. Signed-off-by: Gustavo Romero Reviewed-by: Richard Henderson --- gdbstub/internals.h| 2 -- include/exec/gdbstub.h | 5 + include/gdbstub/commands.h | 6 ++ 3

[PATCH v5 3/9] gdbstub: Add support for target-specific stubs

2024-06-26 Thread Gustavo Romero
faces to extend the qSupported string, the query handler table, and the set handler table, allowing target-specific stub implementations. Signed-off-by: Gustavo Romero Reviewed-by: Alex Bennée --- gdbstub/gdbstub.c | 102 ++--- include/gdbstub/commands.h

[PATCH v5 2/9] gdbstub: Move GdbCmdParseEntry into a new header file

2024-06-26 Thread Gustavo Romero
commit also makes gdb_put_packet public since is used in gdbstub command handling. Signed-off-by: Gustavo Romero Reviewed-by: Alex Bennée --- gdbstub/gdbstub.c | 134 ++--- gdbstub/internals.h| 22 -- gdbstub/syscalls.c | 7 +- gdbstub

Re: [PATCH v4 5/9] target/arm: Make some MTE helpers widely available

2024-06-26 Thread Gustavo Romero
Hi Phil, Richard On 6/24/24 4:47 AM, Philippe Mathieu-Daudé wrote: Hi Gustavo, On 24/6/24 07:30, Gustavo Romero wrote: Make the MTE helpers allocation_tag_mem_probe, load_tag1, and store_tag1 available to other subsystems. Again, you can make them available externally by removing the static

Re: [PATCH v5 2/9] gdbstub: Move GdbCmdParseEntry into a new header file

2024-06-27 Thread Gustavo Romero
Hi Phil, On 6/27/24 3:02 AM, Philippe Mathieu-Daudé wrote: On 27/6/24 06:13, Gustavo Romero wrote: Move GdbCmdParseEntry and its associated types into a separate header file to allow the use of GdbCmdParseEntry and other gdbstub command functions outside of gdbstub.c. Since GdbCmdParseEntry

Re: [PATCH v5 7/9] gdbstub: Make get cpu and hex conversion functions non-internal

2024-06-27 Thread Gustavo Romero
Hi Phil, Alex, On 6/27/24 9:26 AM, Philippe Mathieu-Daudé wrote: On 27/6/24 13:05, Alex Bennée wrote: Philippe Mathieu-Daudé writes: On 27/6/24 06:13, Gustavo Romero wrote: Make the gdb_first_attached_cpu and gdb_hextomem non-internal so they are not confined to use only in gdbstub.c

  1   2   3   4   5   6   >