Re: [Qemu-devel] [PULL v3 00/18] Record/replay core for 2.5-rc1

2015-11-07 Thread dovgaluk
Paolo Bonzini писал 2015-11-06 15:59: On 06/11/2015 13:26, Peter Maydell wrote: Applied, thanks. Let's hope it doesn't break too much :-) (Seriously, it's good to see this getting into the tree finally. Do we have some documentation we can point to in the release notes about how to use it?) U

Re: [Qemu-devel] MTTCG Tasks (kvmforum summary)

2015-09-04 Thread dovgaluk
Hi! Alex Bennée писал 2015-09-04 10:49: * What to do about icount? What is the impact of multi-thread on icount? Do we need to disable it for MTTCG or can it be correct per-cpu? Can it be updated lock-step? Why can't we have separate icount for each CPU? Then virtual timer will be assigned to

Re: [Qemu-devel] MTTCG Tasks (kvmforum summary)

2015-09-04 Thread dovgaluk
Lluís Vilanova писал 2015-09-04 16:00: Mark Burton writes: [...] * What to do about icount? What is the impact of multi-thread on icount? Do we need to disable it for MTTCG or can it be correct per-cpu? Can it be updated lock-step? We need some input from the guys that use icount the most.

Re: [Qemu-devel] [PATCH v3 0/5] Deterministic replay extensions

2016-03-06 Thread dovgaluk
Ping? Pavel Dovgalyuk Pavel Dovgalyuk писал 2016-03-01 14:07: This set of patches is related to the reverse execution and deterministic replay of qemu execution. It includes recording and replaying of serial devices and block devices operations. With these patches one can record and determin

Race condition in overlayed qcow2?

2020-02-19 Thread dovgaluk
Hi! I encountered a problem with record/replay of QEMU execution and figured out the following, when QEMU is started with one virtual disk connected to the qcow2 image with applied 'snapshot' option. The patch d710cf575ad5fb3ab329204620de45bfe50caa53 "block/qcow2: introduce parallel subreque

Re: Race condition in overlayed qcow2?

2020-02-20 Thread dovgaluk
Vladimir Sementsov-Ogievskiy писал 2020-02-19 19:07: 19.02.2020 17:32, dovgaluk wrote: I encountered a problem with record/replay of QEMU execution and figured out the following, when QEMU is started with one virtual disk connected to the qcow2 image with applied 'snapshot' option.

Re: Race condition in overlayed qcow2?

2020-02-21 Thread dovgaluk
Vladimir Sementsov-Ogievskiy писал 2020-02-20 12:36: 20.02.2020 12:05, Vladimir Sementsov-Ogievskiy wrote: 20.02.2020 11:31, dovgaluk wrote: Vladimir Sementsov-Ogievskiy писал 2020-02-19 19:07: 19.02.2020 17:32, dovgaluk wrote: I encountered a problem with record/replay of QEMU execution and

Re: [RFC PATCH 06/10] hw/avr: Add ATmega microcontrollers

2019-11-28 Thread dovgaluk
Aleksandar Markovic писал 2019-11-28 12:28: On Thursday, November 28, 2019, Philippe Mathieu-Daudé wrote: Add famous ATmega MCUs: - middle range: ATmega168 and ATmega328 - high range: ATmega1280 and ATmega2560 Signed-off-by: Philippe Mathieu-Daudé --- Philippe, hi. Thank you for the impe

Re: [RFC PATCH 06/10] hw/avr: Add ATmega microcontrollers

2019-11-28 Thread dovgaluk
Aleksandar Markovic писал 2019-11-28 13:20: On Thursday, November 28, 2019, dovgaluk wrote: Aleksandar Markovic писал 2019-11-28 12:28: On Thursday, November 28, 2019, Philippe Mathieu-Daudé wrote: Add famous ATmega MCUs: - middle range: ATmega168 and ATmega328 - high range: ATmega1280 and

Re: [PATCH v3 0/5] More record/replay acceptance tests

2021-09-27 Thread dovgaluk
Dovgaluk (1): tests/acceptance: Linux boot test for record/replay Pavel Dovgalyuk (4): tests/acceptance: add replay kernel test for s390 tests/acceptance: add replay kernel test for openrisc tests/acceptance: add replay kernel test for nios2 tests/acceptance: add replay

Re: [Qemu-devel] [PATCH v6 00/25] Fixing record/replay and adding reverse debugging

2018-10-01 Thread dovgaluk
Artem Pisarenko писал 2018-09-30 14:01: Feature still broken :( Thanks for testing. Brief description of my tests. Guest image is Linux, which just powers off after kernel boots (instead of proceeding to user-space /init or /sbin/init). Base cmdline: qemu-system-x86_64 -nodefaults -machine

Re: [Qemu-devel] [PATCH v6 00/25] Fixing record/replay and adding reverse debugging

2018-10-02 Thread dovgaluk
ues I encounter. I'll try 'info monitor' command tomorrow, but no guarantees that I'll be able to reproduce issue again. Speaking about '-nographic' and SDL... I've noted that UI greatly minimizes possibility of hanging (but not avoids it completely) when using ico

Re: [Qemu-devel] [PATCH v5 00/24] Fixing record/replay and adding reverse debugging

2018-09-12 Thread dovgaluk
Hi, Ciro! I found several issues in your command lines. Ciro Santilli писал 2018-08-08 02:13: OK, finally got some time to try it out, I'm using c42634d8e3428cfa60672c3ba89cabefc720cde9 from rr-180725. Replay works well as far as I can tell, so I moved to the reverse debugging: /home/ciro/bak

Re: [PATCH] icount: make dma reads deterministic

2020-03-03 Thread dovgaluk
Kevin Wolf писал 2020-03-02 19:19: Am 02.03.2020 um 13:59 hat Pavel Dovgalyuk geschrieben: Windows guest sometimes makes DMA requests with overlapping target addresses. This leads to the following structure of iov for the block driver: addr size1 addr size2 addr size3 It means that three adjac

Re: [Qemu-devel] [PATCH v12 00/25] Fixing record/replay and adding reverse debugging

2019-02-11 Thread dovgaluk
Markus Armbruster писал 2019-02-12 10:14: "Pavel Dovgalyuk" writes: Ping? Are you pinging for more review, or for someone to merge this? From my point of view this patch set is ready. Pavel Dovgalyuk

Re: [Qemu-devel] [PATCH for-4.1 00/24] Fix record/replay and add reverse debugging

2019-06-27 Thread dovgaluk
Paolo, what about merging reviewed and acked patches before the soft freeze? Pavel Dovgalyuk Pavel Dovgalyuk писал 2019-06-21 11:20: GDB remote protocol supports reverse debugging of the targets. It includes 'reverse step' and 'reverse continue' operations. The first one finds the previous s

Re: [Qemu-devel] [PULL 15/36] memory: fix race between TCG and accesses to dirty bitmap

2019-08-26 Thread dovgaluk
This patch breaks the execution recording. While vCPU tries to lock replay mutex in main while loop, vga causes dirty memory sync and do_run_on_cpu call. This call waits for vCPU to process the work queue. Pavel Dovgalyuk Paolo Bonzini писал 2019-08-20 09:59: There is a race between TCG and acc

Re: Race condition in overlayed qcow2?

2020-02-21 Thread dovgaluk
Vladimir Sementsov-Ogievskiy писал 2020-02-21 13:09: 21.02.2020 12:49, dovgaluk wrote: Vladimir Sementsov-Ogievskiy писал 2020-02-20 12:36: 1 or 2 are ok, and 4 or 8 lead to the failures. That is strange. I could think, that it was caused by the bugs in deterministic CPU execution, but the

Re: Race condition in overlayed qcow2?

2020-02-24 Thread dovgaluk
Vladimir Sementsov-Ogievskiy писал 2020-02-21 16:23: 21.02.2020 15:35, dovgaluk wrote: Vladimir Sementsov-Ogievskiy писал 2020-02-21 13:09: 21.02.2020 12:49, dovgaluk wrote: Vladimir Sementsov-Ogievskiy писал 2020-02-20 12:36: 1 or 2 are ok, and 4 or 8 lead to the failures. That is strange

Re: Race condition in overlayed qcow2?

2020-02-24 Thread dovgaluk
Vladimir Sementsov-Ogievskiy писал 2020-02-25 10:27: 25.02.2020 8:58, dovgaluk wrote: Vladimir Sementsov-Ogievskiy писал 2020-02-21 16:23: 21.02.2020 15:35, dovgaluk wrote: Vladimir Sementsov-Ogievskiy писал 2020-02-21 13:09: 21.02.2020 12:49, dovgaluk wrote: Vladimir Sementsov-Ogievskiy

[Qemu-devel] [PATCH] Save/load PC speaker internal state

2012-08-27 Thread Pavel Dovgaluk
Save PC speaker state to remove differences between system states after saving the snapshot and after loading it again. This patch is needed for deterministic replay of the execution. Signed-off-by: Pavel Dovgalyuk --- hw/pcspk.c | 18 ++ 1 files changed, 18 insertions(+), 0 del

[Qemu-devel] [PATCH] Save/load PC speaker internal state (v2)

2012-08-27 Thread Pavel Dovgaluk
Save PC speaker state to remove differences between system states after saving the snapshot and after loading it again. This patch is needed for deterministic replay of the execution. v2: Do not save the data that cannot affect the guest code behavior. Signed-off-by: Pavel Dovgalyuk --- hw/pcspk

Re: [Qemu-devel] [PATCH] Save/load PC speaker internal state

2012-08-28 Thread Pavel Dovgaluk
> -Original Message- > From: Peter Maydell [mailto:peter.mayd...@linaro.org] > Sent: Monday, August 27, 2012 4:50 PM > To: Pavel Dovgaluk > Cc: qemu-devel > Subject: Re: [Qemu-devel] [PATCH] Save/load PC speaker internal state > > On 27 August 2012 13:21, Pavel D

[Qemu-devel] [PATCH] Restore FPU round state after loading the VM state

2012-06-20 Thread Pavel Dovgaluk
Restore FPU round state after loading the VM state. This patch fixes different behavior after loading VM state with different FPU flags set. Signed-off-by: Pavel Dovgalyuk --- target-i386/cpu.c |1 + target-i386/cpu.h |2 ++ target-i386/machine.c |2 +- target-i386/op_he

Re: [Qemu-devel] [PATCH] Save/load PC speaker internal state (v2)

2012-08-29 Thread Pavel Dovgaluk
> -Original Message- > From: Jan Kiszka [mailto:jan.kis...@web.de] > Sent: Tuesday, August 28, 2012 11:13 AM > To: Pavel Dovgaluk > Cc: 'qemu-devel' > Subject: Re: [PATCH] Save/load PC speaker internal state (v2) > > On 2012-08-28 08:58, Pavel Dovgaluk w

[Qemu-devel] [PATCH] Added cleanup for Win32 TAP interface

2013-03-13 Thread Pavel Dovgaluk
Added cleanup for Win32 TAP interface. Signed-off-by: Pavel Dovgalyuk --- net/tap-win32.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/net/tap-win32.c b/net/tap-win32.c index 91e9e84..1c1176c 100644 --- a/net/tap-win32.c +++ b/net/tap-win32.c @@ -99,6 +99,7 @@ t

Re: [Qemu-devel] [PULL 13/21] apic_common: vapic_paddr synchronization fix

2014-09-19 Thread Pavel Dovgaluk
Hi, Paolo! > From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > From: Pavel Dovgalyuk > > This patch postpones vapic_paddr initialization, which is performed > during migration. When vapic_paddr is synchronized within the migration > process, apic_common functio

Re: [Qemu-devel] [PULL 13/21] apic_common: vapic_paddr synchronization fix

2014-09-19 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Il 19/09/2014 12:43, Pavel Dovgaluk ha scritto: > > I've tested this patch with replay. I enabled VM reset (which was > > previously disabled for > replay) > > while load

Re: [Qemu-devel] [PULL 13/21] apic_common: vapic_paddr synchronization fix

2014-09-22 Thread Pavel Dovgaluk
> -Original Message- > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Friday, September 19, 2014 5:42 PM > To: Pavel Dovgaluk; qemu-devel@nongnu.org > Subject: Re: [PULL 13/21] apic_common: vapic_paddr synchronization fix > > Il 19/09/2014 14:50, Pave

Re: [Qemu-devel] [PULL 13/21] apic_common: vapic_paddr synchronization fix

2014-09-26 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > > This patch postpones vapic_paddr initialization, which is performed > during migration. When vapic_paddr is synchronized within the migration > process, apic_common functions could operate with incorrect apic

[Qemu-devel] [PATCH] i386 ROR r8/r16 instruction fix

2013-04-14 Thread Pavel Dovgaluk
Fixed EFLAGS corruption by ROR r8/r16 instruction located at the end of the TB. Signed-off-by: Pavel Dovgalyuk --- target-i386/translate.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/target-i386/translate.c b/target-i386/translate.c index 233f24f..40f891d 100644 ---

Re: [Qemu-devel] [PATCH] Added cleanup for Win32 TAP interface

2013-04-16 Thread Pavel Dovgaluk
Hello! > From: Stefan Weil [mailto:s...@weilnetz.de] > Am 15.04.2013 17:55, schrieb Paolo Bonzini: > > Il 13/03/2013 13:23, Pavel Dovgaluk ha scritto: > >> Added cleanup for Win32 TAP interface. Signed-off-by: Pavel > >> Dovgalyuk > > Stefan, did this slip? Pa

Re: [Qemu-devel] [PATCH] exec: save exception_index field

2014-08-25 Thread Pavel Dovgaluk
> From: Andreas Färber [mailto:afaer...@suse.de] > Am 31.07.2014 07:41, schrieb Pavel Dovgaluk: > > This patch adds subsection with exception_index field to the VMState for > > correct saving the CPU state. > > Without this patch simulator could miss the pending exception

Re: [Qemu-devel] [RFC PATCH v3 07/49] kvmapic: fixing loading vmstate

2014-08-25 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Il 31/07/2014 17:21, Pavel Dovgalyuk ha scritto: > > Pre load is necessary, because we switched off resetting VM while > > loading in the replay mode. > > Then you should not add it now, but rather when you add replay. Treat > this part of the

Re: [Qemu-devel] [RFC PATCH v3 15/49] softmmu: fixing usage of cpu_st/ld* from helpers

2014-08-26 Thread Pavel Dovgaluk
> From: Alex Bennée [mailto:alex.ben...@linaro.org] > Pavel Dovgalyuk writes: > > > MMU helper functions are called from generated code and other helper > > functions. In both cases they try to get function's return address for > > using it while restoring virtual CPU state. > > > > When MMU helpe

Re: [Qemu-devel] [PATCH 09/12] rtl8139: adding new fields to vmstate

2014-08-27 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Il 26/08/2014 09:15, Pavel Dovgalyuk ha scritto: > > This patch adds virtual clock-dependent timers to VMState to allow correct > > saving and restoring the state of RTL8139 network controller. > > > > Signed-off

Re: [Qemu-devel] [PATCH 09/12] rtl8139: adding new fields to vmstate

2014-08-27 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Il 27/08/2014 12:15, Pavel Dovgaluk ha scritto: > >> > Again, this is only needed in your record/replay system (and you haven't > >> > yet quite explained why the design has this limitation), so it should

Re: [Qemu-devel] [PATCH 09/12] rtl8139: adding new fields to vmstate

2014-08-27 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Il 27/08/2014 12:30, Pavel Dovgaluk ha scritto: > >> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > >> Il 27/08/2014 12:15, Pavel Dovgaluk ha scritto: > >>>>> Again, this is only needed in

Re: [Qemu-devel] [PATCH 06/12] kvmvapic: fixing loading vmstate

2014-08-27 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Il 26/08/2014 09:15, Pavel Dovgalyuk ha scritto: > > vapic state should not be synchronized with APIC while loading, > > because APIC state could be not loaded yet at that moment. > > We just save vapic_paddr in

Re: [Qemu-devel] [PATCH 06/12] kvmvapic: fixing loading vmstate

2014-08-27 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Il 27/08/2014 14:16, Pavel Dovgaluk ha scritto: > >> > Can you use a vm_change_state_handler, or a QEMU_CLOCK_VIRTUAL timer > >> > with expiration time in the past (e.g. at time zero) to run the sync > >>

Re: [Qemu-devel] [PATCH 09/12] rtl8139: adding new fields to vmstate

2014-08-28 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Il 27/08/2014 12:48, Pavel Dovgaluk ha scritto: > >> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > >> Il 27/08/2014 12:30, Pavel Dovgaluk ha scritto: > >>>> From:

Re: [Qemu-devel] [PATCH] i386: fix breakpoints handling in icount mode

2014-10-22 Thread Pavel Dovgaluk
> From: Frederic Konrad [mailto:fred.kon...@greensocs.com] > On 22/10/2014 13:38, Pavel Dovgalyuk wrote: > > Hi Pavel, > > This patch fixes instructions counting when execution is stopped on > > breakpoint (e.g. set from gdb). Without a patch extra instruction is > > translated > > and icount is

Re: [Qemu-devel] [PATCH] i386: fix breakpoints handling in icount mode

2014-10-23 Thread Pavel Dovgaluk
> From: Frederic Konrad [mailto:fred.kon...@greensocs.com] > On 23/10/2014 07:57, Pavel Dovgaluk wrote: > >> From: Frederic Konrad [mailto:fred.kon...@greensocs.com] > >> On 22/10/2014 13:38, Pavel Dovgalyuk wrote: > >> > >> Hi Pavel, > >>> Th

Re: [Qemu-devel] [PATCH] i386: fix breakpoints handling in icount mode

2014-10-23 Thread Pavel Dovgaluk
> From: Frederic Konrad [mailto:fred.kon...@greensocs.com] > On 23/10/2014 09:52, Pavel Dovgaluk wrote: > >> From: Frederic Konrad [mailto:fred.kon...@greensocs.com] > >> On 23/10/2014 07:57, Pavel Dovgaluk wrote: > >>>> From: Frederic Konrad [mailto:fred.kon

Re: [Qemu-devel] [PATCH] arm: fix TB alignment check

2014-10-23 Thread Pavel Dovgaluk
> From: Richard Henderson [mailto:rth7...@gmail.com] On Behalf Of Richard > Henderson > On 10/21/2014 05:14 AM, Pavel Dovgalyuk wrote: > > Sometimes page faults happen during the translation of the target > > instructions. > > To avoid the faults in the middle of the TB we have to stop translatio

Re: [Qemu-devel] [PATCH v2 12/12] pl031: add missed field to vmstate

2014-09-02 Thread Pavel Dovgaluk
> From: Peter Maydell [mailto:peter.mayd...@linaro.org] > On 28 August 2014 12:19, Pavel Dovgalyuk wrote: > > This patch adds timer which uses virtual clock to the VMState. > > Such timers are required for saving because virtual clock is the part > > of the virtual machine state. > > > > Signed-of

Re: [Qemu-devel] [RFC PATCH v6 00/14] Reverse execution.

2014-09-08 Thread Pavel Dovgaluk
> From: Frederic Konrad [mailto:fred.kon...@greensocs.com] > On 08/09/2014 10:29, Paolo Bonzini wrote: > > Il 08/09/2014 10:09, Frederic Konrad ha scritto: > >> By the way how do you want to have this discussion? > >> > >> At the KVM forum? Or by phone on KVM phone call? > > Or both. :) > > > > Ser

Re: [Qemu-devel] [PATCH 06/12] kvmvapic: fixing loading vmstate

2014-09-09 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Il 27/08/2014 15:03, Pavel Dovgaluk ha scritto: > >> > Hmm, probably not. The bug would not be other timers accessing the > >> > APIC, because that would also call apic_sync_vapic and the only effect &g

Re: [Qemu-devel] [PATCH v2 08/12] hpet: fixing saving and loading process

2014-09-09 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Il 28/08/2014 13:58, Paolo Bonzini ha scritto: > > This also breaks migration to 2.1, unless you use -no-hpet. > > Actually, this is also only needed for your record/replay implementation. Ok, I'll move it to t

Re: [Qemu-devel] [PATCH 02/10] apic_common: vapic_paddr synchronization fix

2014-09-09 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Sent: Tuesday, September 09, 2014 4:30 PM > To: qemu-devel@nongnu.org > Cc: quint...@redhat.com; amit.s...@redhat.com; dgilb...@redhat.com; > pavel.dovga...@ispras.ru > Subject: [PATCH 02/10] apic_common: vapic_

Re: [Qemu-devel] [PATCH 07/10] serial: fixing vmstate for save/restore

2014-09-10 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Il 09/09/2014 15:59, Juan Quintela ha scritto: > > But poll_msl is "more" interesting, because we are not "reseting it". > > > > So, we have that if we are migrating from an old version, we would have > > poll_msl == -1, and we used to have it to

Re: [Qemu-devel] [RFC PATCH v2 00/49] Series short description

2014-07-28 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Il 17/07/2014 13:01, Pavel Dovgalyuk ha scritto: > > This set of patches is related to the reverse execution and deterministic > > replay of qemu execution Our implementation of deterministic replay can > > be u

Re: [Qemu-devel] [RFC PATCH v2 10/49] rtl8139: adding new fields to vmstate

2014-07-28 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Il 17/07/2014 13:02, Pavel Dovgalyuk ha scritto: > > This patch adds virtual clock-dependent timers to VMState to allow correct > > saving and restoring the state of RTL8139 network controller. > > > > Signed-off

Re: [Qemu-devel] [RFC PATCH v2 07/49] kvmapic: fixing loading vmstate

2014-07-29 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Il 17/07/2014 13:02, Pavel Dovgalyuk ha scritto: > > diff --git a/hw/intc/apic_common.c b/hw/intc/apic_common.c > > index ce3d903..9d75ee0 100644 > > --- a/hw/intc/apic_common.c > > +++ b/hw/intc/apic_common.c >

Re: [Qemu-devel] [RFC PATCH v2 06/49] serial: fixing vmstate for save/restore

2014-07-30 Thread Pavel Dovgaluk
> -Original Message- > From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Sent: Monday, July 28, 2014 1:59 PM > To: Pavel Dovgalyuk; qemu-devel@nongnu.org > Cc: peter.mayd...@linaro.org; peter.crosthwa...@xilinx.com; > mark.bur...@greensocs.com; > r...@is

Re: [Qemu-devel] [RFC PATCH v2 00/49] Series short description

2014-07-30 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > >> - patch 16 should also use subsections, and perhaps apply to all other > >> CPUs too? > > > > We implemented replay only for i386 and ARM. If we'll change other > > targets, it will not > > add record/replay

Re: [Qemu-devel] [RFC PATCH v2 10/49] rtl8139: adding new fields to vmstate

2014-07-30 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Il 28/07/2014 11:54, Pavel Dovgaluk ha scritto: > >>> > > +VMSTATE_TIMER_V(timer, RTL8139State, 5), > >> > > >> > timer need not be migrated, be

[Qemu-devel] [PATCH] exec: save exception_index field

2014-07-30 Thread Pavel Dovgaluk
This patch adds subsection with exception_index field to the VMState for correct saving the CPU state. Without this patch simulator could miss the pending exception in the saved virtual machine state. Signed-off-by: Pavel Dovgalyuk --- exec.c | 35 +++ 1 files c

Re: [Qemu-devel] [RFC PATCH v2 00/49] Series short description

2014-07-30 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Il 30/07/2014 09:44, Pavel Dovgaluk ha scritto: > >> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > >> Bonzini > >>>> - patch 16 should also use subsections, and per

[Qemu-devel] [PATCH] Fix ioapic vmstate

2011-06-17 Thread Pavel Dovgaluk
This patch fixes save/restore vmstate of IOAPIC. When irr member of IOAPICState is not saved and loaded, restoring becomes non-deterministic, because irr is kept from state of VM that was before loading. Signed-off-by: Pavel Dovgalyuk --- hw/ioapic.c |1 + 1 files changed, 1 insertions(+

[Qemu-devel] [PATCH] ANSI escape characters support for Windows console

2012-05-29 Thread Pavel Dovgaluk
This patch adds support of ANSI escape characters used in readline module to impelementation of stdio character device for Windows. Signed-off-by: Pavel Dovgalyuk --- qemu-char.c | 48 ++-- 1 files changed, 38 insertions(+), 10 deletions(-) diff --g

[Qemu-devel] [PATCH v3] Prevent disk data loss when closing qemu

2012-05-29 Thread Pavel Dovgaluk
Prevent disk data loss when closing qemu console window under Windows 7. v3. Comment for Sleep() parameter was updated. Signed-off-by: Pavel Dovgalyuk --- os-win32.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/os-win32.c b/os-win32.c index ad76370..66c39b8 1006

Re: [Qemu-devel] [PATCH 1.1 v2] Prevent disk data loss when closing qemu

2012-05-29 Thread Pavel Dovgaluk
> From: Anthony Liguori [mailto:anth...@codemonkey.ws] > Sent: Thursday, May 24, 2012 5:12 PM > On 05/24/2012 05:10 AM, Paolo Bonzini wrote: > > Il 24/05/2012 09:42, Pavel Dovgaluk ha scritto: > >> Prevent disk data loss when closing qemu console window > >> unde

[Qemu-devel] [PATCH v3] Prevent disk data loss when closing qemu

2012-05-29 Thread Pavel Dovgaluk
Prevent disk data loss when closing qemu console window under Windows 7. v3. Comment for Sleep() parameter was updated. Signed-off-by: Pavel Dovgalyuk --- os-win32.c |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/os-win32.c b/os-win32.c index ad76370..13892ba 100

Re: [Qemu-devel] [PATCH v3] Prevent disk data loss when closing qemu

2012-05-29 Thread Pavel Dovgaluk
> From: Anthony Liguori [mailto:anth...@codemonkey.ws] > Sent: Wednesday, May 30, 2012 6:29 AM > On 05/29/2012 09:26 PM, Pavel Dovgaluk wrote: > > Prevent disk data loss when closing qemu console window > > under Windows 7. > > > > v3. Comment for Sleep() paramete

[Qemu-devel] Fiber switching and stack protection

2012-04-06 Thread Pavel Dovgaluk
appened in qemu_coroutine_switch of coroutine-win32.c file. But when I remove -fstack-protector-all option from makefile nothing changes - an exception occurs again. Does anyone have an idea about such behavior? Pavel Dovgaluk

Re: [Qemu-devel] Fiber switching and stack protection

2012-04-13 Thread Pavel Dovgaluk
> -Original Message- > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Thursday, April 12, 2012 8:57 PM > To: Stefan Weil > Cc: Kevin Wolf; 'qemu-devel'; Pavel Dovgaluk > Subject: Re: [Qemu-devel] Fiber switching and stack protection > > I

Re: [Qemu-devel] Fiber switching and stack protection

2012-04-15 Thread Pavel Dovgaluk
ine *to_, >CoroutineAction action) { I applied your patch to qemu 1.0 and it stopped crashing. By the way, I also created implementation of coroutine-win32.c, which uses WinAPI TLS functions directly (without using __thread specifiers). It works fine too. Pavel Dovgaluk

[Qemu-devel] [PATCH] Using TLS instead of __thread in coroutines implementation for win32

2012-04-16 Thread Pavel Dovgaluk
This patch directly uses WinAPI TLS instead of __thread specifier. It was created because of gcc-mingw error which causes incorrect operation of __thread variables. Signed-off-by: Pavel Dovgalyuk --- diff --git a/coroutine-win32.c b/coroutine-win32.c index 4179609..cd8c597 --- a/coroutine-win32.c

Re: [Qemu-devel] Fiber switching and stack protection

2012-04-16 Thread Pavel Dovgaluk
> Il 16/04/2012 08:24, Pavel Dovgaluk ha scritto: > > By the way, I also created implementation of coroutine-win32.c, > > which uses WinAPI TLS functions directly (without using __thread > > specifiers). > > It works fine too. > > Cool, can you submit it? I

[Qemu-devel] [PATCH] Fix serial interface vmstate

2011-06-21 Thread Pavel Dovgaluk
This patch fixes save/restore of serial interface's state. It includes changing of fcr setter function (it now does not invoke an interrupt while loading vmstate), and saving/restoring all fields that describe the state of serial interface (including timers). Signed-off-by: Pavel Dovgalyuk --

Re: [Qemu-devel] [PATCH] Fix serial interface vmstate

2011-06-21 Thread Pavel Dovgaluk
> "Pavel Dovgaluk" wrote: > > This patch fixes save/restore of serial interface's state. > > It includes changing of fcr setter function (it now does not invoke > > an interrupt while loading vmstate), and saving/restoring all > > fields that describ

Re: [Qemu-devel] [PATCH] Fix serial interface vmstate

2011-06-22 Thread Pavel Dovgaluk
imeout_ipending, SerialState, 4), > >>> +VMSTATE_TIMER_V(transmit_timer, SerialState, 4), > >>> +VMSTATE_INT32_V(poll_msl, SerialState, 4), > >>> +VMSTATE_TIMER_V(modem_status_poll, SerialState, 4), > >>> VMSTATE_END_OF_LIST() > >>> } > >>> }; > >> > >> Anyways, I think that it is better to split the change in two patches. > >> One that refactor the common code in another function. And the other I thought about splitting. First change is not for refactoring, it is also a bugfix of non-deterministic loading of serial interface state. Both part of my patch relate to the same problem - non-deterministic load. > >> that adds the VMSTATE bits, I can add the subsection part if you want. > > > > What is the purpose of subsections? > > To skip the new fields whenever possible. That would allow to continue > saving a vmstate on a new version of qemu and then restoring it on an > older one. Do you have an idea how to implement "needed" function for my case? Because I think, these fields should always be saved and loaded, because they are related to the main state of the interface, not the kind of optional substate. > So you have to implement a handler that checks the serial state on > savevm whether any of the new fields contains a state that requires to > be saved. Of any of them do, we have to throw that time-traveling over > board and create the subsection. If not, we can continue to write the > old state. That might be the case here if the guest does not use the > serial port or if the port is idle at the time of saving. If the port is disabled, the state will not be saved, isn't it? Pavel Dovgaluk

Re: [Qemu-devel] [PATCH] Fix serial interface vmstate

2011-06-22 Thread Pavel Dovgaluk
ers are saved only if they are pending, thr_ipending is saved only when it is nonzero, and so on. Do you mean that? Pavel Dovgaluk

Re: [Qemu-devel] [PATCH] Fix serial interface vmstate

2011-06-22 Thread Pavel Dovgaluk
> On 2011-06-22 11:15, Pavel Dovgaluk wrote: > >>>>> What is the purpose of subsections? > >>>> > >>>> To skip the new fields whenever possible. That would allow to continue > >>>> saving a vmstate on a new version of qemu and t

Re: [Qemu-devel] [PATCH] Fix processing of the MMU faults caused by the helper functions

2013-12-04 Thread Pavel Dovgaluk
Hello! Will anyone comment this patch? Pavel Dovgaluk > -Original Message- > From: qemu-devel-bounces+pavel.dovgaluk=ispras...@nongnu.org > [mailto:qemu-devel- > bounces+pavel.dovgaluk=ispras...@nongnu.org] On Behalf Of Pavel Dovgaluk > Sent: Monday, November 18, 20

[Qemu-devel] [PATCH] Fix processing of the MMU faults caused by the helper functions

2013-11-18 Thread Pavel Dovgaluk
ction, the return address will point to that helper. That is why CPU state cannot be restored in the case of MMU fault. This patch introduces several inline helpers to load return address at the right place. Signed-off-by: Pavel Dovgaluk --- include/exec/exec-all.h |

Re: [Qemu-devel] memory access trace from qemu

2014-04-18 Thread Pavel Dovgaluk
other functions and files. Pavel Dovgaluk From: qemu-devel-bounces+pavel.dovgaluk=ispras...@nongnu.org [mailto:qemu-devel-bounces+pavel.dovgaluk=ispras...@nongnu.org] On Behalf Of Pete Stevenson Sent: Friday, April 18, 2014 3:31 AM To: qemu-devel@nongnu.org Subject: [Qemu-devel] memory access

Re: [Qemu-devel] [RFC PATCH v8 16/21] replay: bottom halves

2015-02-11 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 22/01/2015 09:53, Pavel Dovgalyuk wrote: > > This patch introduces bottom half event for replay queue. It saves the > > events > > into the queue and process them at the checkpoints and instructions > > execution. > > Which bottom halves mu

Re: [Qemu-devel] [RFC PATCH v8 21/21] replay: recording of the user input

2015-02-11 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > On 22/01/2015 09:53, Pavel Dovgalyuk wrote: > > +void replay_input_event(QemuConsole *src, InputEvent *evt) > > +{ > > +if (replay_mode == REPLAY_MODE_PLAY) { > > +/* Nothing */ > > +} else if (re

Re: [Qemu-devel] [RFC PATCH v8 21/21] replay: recording of the user input

2015-02-12 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > On 22/01/2015 09:53, Pavel Dovgalyuk wrote: > > +if (replay_mode != REPLAY_MODE_PLAY) { > > +evt = qemu_input_event_new_key(key, down); > > +if (QTAILQ_EMPTY(&kbd_queue)) { > > +qe

Re: [Qemu-devel] [RFC PATCH v8 20/21] replay: command line options

2015-02-12 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 09/02/2015 13:15, Pavel Dovgaluk wrote: > >> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > >>> break; > >>> case QEMU_OPTION_audio_help: > >>>

Re: [Qemu-devel] [RFC PATCH v8 08/21] cpu: replay instructions sequence

2015-02-16 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > On 02/02/2015 13:42, Pavel Dovgaluk wrote: > >> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > >> On 02/02/2015 13:28, Pavel Dovgaluk wrote: > >>>>>>>

Re: [Qemu-devel] [RFC PATCH v8 08/21] cpu: replay instructions sequence

2015-02-16 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > On 16/02/2015 13:26, Pavel Dovgaluk wrote: > >>> > > I think in this case there are no events at all - just reading timers > >>> > > values > >>> > &

Re: [Qemu-devel] [RFC PATCH v8 08/21] cpu: replay instructions sequence

2015-02-16 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > On 16/02/2015 14:27, Pavel Dovgaluk wrote: > >> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > >> Bonzini > >> On 16/02/2015 13:26, Pavel Dovga

Re: [Qemu-devel] [RFC PATCH v8 08/21] cpu: replay instructions sequence

2015-02-17 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > On 16/02/2015 14:37, Pavel Dovgaluk wrote: > >> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > >> Bonzini > >> On 16/02/2015 14:27, Pavel Dovgal

Re: [Qemu-devel] [RFC PATCH v8 08/21] cpu: replay instructions sequence

2015-02-17 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 17/02/2015 09:43, Pavel Dovgaluk wrote: > >> > int64_t deadline = qemu_clock_deadline_ns_all(QEMU_CLOCK_VIRTUAL); > >> > if (deadline == 0) { > >> > qemu_clock_notify(QEMU_CLOCK_VIR

Re: [Qemu-devel] [RFC PATCH v9 22/23] replay: command line options

2015-02-20 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > On 18/02/2015 12:57, Pavel Dovgalyuk wrote: > > @@ -2751,6 +2757,7 @@ int main(int argc, char **argv, char **envp) > > { > > int i; > > int snapshot, linux_boot; > > +const char *icount_option = NU

Re: [Qemu-devel] [RFC PATCH v9 00/23] Deterministic replay core

2015-02-27 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > On 18/02/2015 12:55, Pavel Dovgalyuk wrote: > > This set of patches is related to the reverse execution and deterministic > > replay of qemu execution. This implementation of deterministic replay can > > be used

Re: [Qemu-devel] [RFC PATCH v8 00/21] Deterministic replay core

2015-01-28 Thread Pavel Dovgaluk
Ping? Pavel Dovgalyuk > -Original Message- > From: Pavel Dovgalyuk [mailto:pavel.dovga...@ispras.ru] > Sent: Thursday, January 22, 2015 11:52 AM > To: qemu-devel@nongnu.org > Cc: peter.mayd...@linaro.org; peter.crosthwa...@xilinx.com; ebl...@redhat.com; > mark.bur...@greensocs.com; r...@i

Re: [Qemu-devel] [RFC PATCH v8 04/21] replay: internal functions for replay log

2015-01-30 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 22/01/2015 09:51, Pavel Dovgalyuk wrote: > > This patch adds functions to perform read and write operations > > with replay log. > > > > Signed-off-by: Pavel Dovgalyuk > > --- > > +void replay_check_error(void) > > Could this be static? (I h

Re: [Qemu-devel] [RFC PATCH v8 08/21] cpu: replay instructions sequence

2015-02-02 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 22/01/2015 09:52, Pavel Dovgalyuk wrote: > > This patch adds calls to replay functions into the icount setup block. > > In record mode number of executed instructions is written to the log. > > In replay mode number of istructions to execute i

Re: [Qemu-devel] [RFC PATCH v8 08/21] cpu: replay instructions sequence

2015-02-02 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 02/02/2015 13:28, Pavel Dovgaluk wrote: > >>> > > cpu->exception_index = EXCP_INTERRUPT; > >>> > > next_tb = 0; > >&g

Re: [Qemu-devel] [RFC PATCH v8 09/21] replay: interrupts and exceptions

2015-02-02 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 22/01/2015 09:52, Pavel Dovgalyuk wrote: > > +if (replay_mode == REPLAY_MODE_RECORD) { > > +replay_save_instructions(); > > +replay_put_event(EVENT_EXCEPTION); > > +return true; > > Missing mutex lock/unlock. I th

Re: [Qemu-devel] [RFC PATCH v8 00/21] Deterministic replay core

2015-02-02 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > On 22/01/2015 09:51, Pavel Dovgalyuk wrote: > > These patches include only core function of the replay, > > excluding the support for replaying serial, audio, network, and USB devices' > > operations. Reverse deb

Re: [Qemu-devel] [RFC PATCH v8 11/21] replay: recording and replaying clock ticks

2015-02-03 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 22/01/2015 09:52, Pavel Dovgalyuk wrote: > > Clock ticks are considered as the sources of non-deterministic data for > > virtual machine. This patch implements saving the clock values when they > > are acquired (virtual, host clock, rdtsc, and

Re: [Qemu-devel] [RFC PATCH v8 11/21] replay: recording and replaying clock ticks

2015-02-03 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 03/02/2015 11:51, Pavel Dovgaluk wrote: > >> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > >> On 22/01/2015 09:52, Pavel Dovgalyuk wrote: > >>> Clock ticks are considered as the sources of non-determin

Re: [Qemu-devel] [RFC PATCH v8 12/21] replay: recording and replaying different timers

2015-02-03 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 22/01/2015 09:52, Pavel Dovgalyuk wrote: > > This patch introduces functions for recording and replaying realtime > > sources, > > that do not use qemu-clock interface. These include return value of time() > > function in time_t and struct tm

Re: [Qemu-devel] [PATCH] win64: perform correct setjmp calls

2015-02-09 Thread Pavel Dovgaluk
> From: Stefan Weil [mailto:s...@weilnetz.de] > Am 09.02.2015 um 08:55 schrieb Pavel Dovgalyuk: > > On w64, setjmp is implemented by _setjmp which needs a second parameter. > > This parameter should be NULL to allow using longjump from generated code. > > This patch replaces all usages of setjmp.h

Re: [Qemu-devel] [RFC PATCH v8 20/21] replay: command line options

2015-02-09 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 22/01/2015 09:53, Pavel Dovgalyuk wrote: > > This patch introduces command line options for enabling recording or > > replaying > > virtual machine behavior. "-record" option starts recording of the execution > > and saves it into the log, sp

  1   2   3   >