Re: [Qemu-devel] [v2 3/3] hmp: fix MemdevList memory leak

2014-08-17 Thread chen.fan.f...@cn.fujitsu.com
On Tue, 2014-08-12 at 12:00 +1000, Peter Crosthwaite wrote: > On Mon, Aug 4, 2014 at 2:21 PM, Chen Fan wrote: > > the memdev_list in hmp_info_memdev() is never freed. > > so we use existent method qapi_free_MemdevList() to free it. > > and also we can use qapi_free_MemdevList() to replace list lo

Re: [Qemu-devel] [RESEND v2 0/3] Fix some memory leaks about query memdev

2014-08-24 Thread chen.fan.f...@cn.fujitsu.com
ping... This patches have been reviewed-by, only need someone ack it. Thanks, Chen On Mon, 2014-08-18 at 14:46 +0800, Chen Fan wrote: > when using valgrind to test the command "query memdev", I had > found some memory leaks. the test result: > > ==13802== 4 bytes in 1 blocks are definitely los

Re: [Qemu-devel] [RESEND v2 0/3] Fix some memory leaks about query memdev

2014-08-27 Thread chen.fan.f...@cn.fujitsu.com
ping ? On Mon, 2014-08-18 at 14:46 +0800, Chen Fan wrote: > when using valgrind to test the command "query memdev", I had > found some memory leaks. the test result: > > ==13802== 4 bytes in 1 blocks are definitely lost in loss record 125 of 8,508 > ==13802==at 0x4A08934: malloc (vg_replace_

Re: [Qemu-devel] [RFC 0/3] cpu: add device_add foo-x86_64-cpu support

2014-05-21 Thread chen.fan.f...@cn.fujitsu.com
Hi, I think if we want to use 'device/device_add' to implement CPU, we must do some check before qemu_init_vcpu(). how can we to do that? Thanks, Chen On Tue, 2014-05-13 at 18:08 +0800, Chen Fan wrote: > this patches tried to make cpu hotplug with device_add, > and made -device foo-x86_64-cp

Re: [Qemu-devel] [Qemu-trivial] [RESEND v2 0/3] Fix some memory leaks about query memdev

2014-08-31 Thread chen.fan.f...@cn.fujitsu.com
On Fri, 2014-08-29 at 20:29 +0400, Michael Tokarev wrote: > 18.08.2014 10:46, Chen Fan wrote: > > when using valgrind to test the command "query memdev", I had > > found some memory leaks. the test result: > ... > > Applied all 3 to -trivial. Usually these are not really trivial. > Please note t

Re: [Qemu-devel] [PATCH] gtk.c: Fix memory leak in gd_set_keycode_type()

2014-09-03 Thread chen.fan.f...@cn.fujitsu.com
ping... On Tue, 2014-09-02 at 14:33 +0800, Chen Fan wrote: > this memory leak is introduced by the original > commit 3158a3482b0093e41f2b2596fba50774ea31ae08 > > valgrind out showing: > ==14553== 21,459 (72 direct, 21,387 indirect) bytes in 1 blocks are > definitely > lost in loss record 8

Re: [Qemu-devel] [PATCH] po: Add Chinese translation

2014-07-31 Thread chen.fan.f...@cn.fujitsu.com
On Thu, 2014-07-31 at 10:44 +0800, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > po/zh_CN.po | 86 > + > 1 file changed, 86 insertions(+) > create mode 100644 po/zh_CN.po > > diff --git a/po/zh_CN.po b/po/zh_CN.po > new file mo

Re: [Qemu-devel] [PATCH 2/3] qom/object.c: fix string_output_get_string() memory leak

2014-08-03 Thread chen.fan.f...@cn.fujitsu.com
On Fri, 2014-08-01 at 23:26 +1000, Peter Crosthwaite wrote: > On Fri, Aug 1, 2014 at 8:22 PM, Chen Fan wrote: > > string_output_get_string() always return the data the sov->string > > "returns the data sov->string points to and never frees it" > > Although "sov" is a little out of context howev

Re: [Qemu-devel] [PATCH 3/3] hmp: fix MemdevList memory leak

2014-08-03 Thread chen.fan.f...@cn.fujitsu.com
On Fri, 2014-08-01 at 23:38 +1000, Peter Crosthwaite wrote: > On Fri, Aug 1, 2014 at 8:22 PM, Chen Fan wrote: > > Signed-off-by: Chen Fan > > --- > > hmp.c | 9 ++--- > > 1 file changed, 6 insertions(+), 3 deletions(-) > > > > diff --git a/hmp.c b/hmp.c > > index 2414cc7..0b1c830 100644 > >

Re: [Qemu-devel] [PATCH 2/3] qom/object.c: fix string_output_get_string() memory leak

2014-08-03 Thread chen.fan.f...@cn.fujitsu.com
On Fri, 2014-08-01 at 23:26 +1000, Peter Crosthwaite wrote: > On Fri, Aug 1, 2014 at 8:22 PM, Chen Fan wrote: > > string_output_get_string() always return the data the sov->string > > "returns the data sov->string points to and never frees it" > > Although "sov" is a little out of context howev

Re: [Qemu-devel] [PATCH v2 0/3] prebuild cpu QOM tree /machine/node/socket/core ->link-cpu

2014-04-01 Thread chen.fan.f...@cn.fujitsu.com
Ping... On Thu, 2014-03-20 at 14:33 +0800, Chen Fan wrote: > at present, after hotplug a discontinuous cpu id on source, then done > migration, > on target, it will fail to add the unoccupied cpu id which was skipped at > source, > this cause is on target Qemu prebuild CPU with continuous cpu_i

Re: [Qemu-devel] [RFC 1/3] using CPUMASK bitmaps to calculate cpu index

2014-05-27 Thread chen.fan.f...@cn.fujitsu.com
On Thu, 2014-05-22 at 15:26 +0200, Igor Mammedov wrote: > On Tue, 13 May 2014 18:08:47 +0800 > Chen Fan wrote: > > > instead of seeking the number of CPUs, using CPUMASK bitmaps to > > calculate the cpu index, also would be a gread benefit to remove > > cpu index. > How would it help to remove c