[Bug 1869858] Re: qemu can't start Windows10arm64 19H1(with kvm)

2020-04-30 Thread chen
And I am try Windows 10 build 19613,but was cant not start,too(sorry,My english It's not well) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1869858 Title: qemu can't start Windows10arm64 19H1(with

[Bug 1869858] Re: qemu can't start Windows10arm64 19H1(with kvm)

2020-04-30 Thread chen
I try use latest qemu,but It was the same -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1869858 Title: qemu can't start Windows10arm64 19H1(with kvm) Status in QEMU: Incomplete Bug description:

Re: [Qemu-devel] CPU utilization between physical CPU and virtual CPU in KVM

2012-10-15 Thread Dennis Chen
Any body can be help about this or a little bit clues? Thanks! On Mon, Oct 8, 2012 at 3:01 PM, Dennis Chen wrote: > Hi All, > > I am confused by the following observed scenario: > > In my 4-CPU (KVM supported, 2 core with 2 thread for each) host > machine box, I create only

[Qemu-devel] qemu doesn't handle big frame in codes for emulating e1000 NIC

2012-07-03 Thread Rugang Chen
I use "e1000" NIC in virtual guest, and the driver in the guest has disable LPE(write "~E1000_RCTL_LPE" to "E1000_RCTL" register of e1000 NIC). But the virtual NIC still forward big frame(bigger than MTU set to the driver) to the driver. And in the file "hw/e1000.c", I don't say any codes that han

[Qemu-devel] CPU utilization between physical CPU and virtual CPU in KVM

2012-10-08 Thread Dennis Chen
Hi All, I am confused by the following observed scenario: In my 4-CPU (KVM supported, 2 core with 2 thread for each) host machine box, I create only one VM with 3-vCPU through virsh/libvirt tools and also I pin this VM process to the physical processor 3. I guess the CPU utilization for the proce

[Qemu-devel] [PATCH] Use SCSI command to get size of SG device

2012-10-09 Thread Chen HanXiao
When we use SCSI generic device as disk image, function lseek could not get the size of this kind of device. So try to use SCSI command Read Capacity(10) when lseek failed to get the size of SCSI generic device. Signed-off-by: Chen Hanxiao --- block/raw-posix.c | 46

Re: [Qemu-devel] [PATCH] Use SCSI command to get size of SG device

2012-10-09 Thread Chen HanXiao
Hi > -Original Message- > From: Christoph Hellwig [mailto:h...@lst.de] > Sent: Wednesday, October 10, 2012 1:21 AM > To: Chen HanXiao > Cc: qemu-devel@nongnu.org > Subject: Re: [Qemu-devel] [PATCH] Use SCSI command to get size of SG device > > On Tue, Oct 09,

Re: [Qemu-devel] [PATCH] Use SCSI command to get size of SG device

2012-10-10 Thread Chen HanXiao
> -Original Message- > From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Sent: Wednesday, October 10, 2012 2:34 PM > To: Chen HanXiao > Cc: 'Christoph Hellwig'; qemu-devel@nongnu.org > Subject: Re: [PATCH] Use SCSI command t

[Qemu-devel] [RFC][PATCH] cpu: implement CPEJ method for unpluging cpu

2013-08-28 Thread Chen Fan
After OS ejecting a vcpu successful, it will call CPEJ method, there communicate the masked vcpu bitmap to QEMU. Signed-off-by: Chen Fan --- src/acpi-dsdt-cpu-hotplug.dsl | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/acpi-dsdt-cpu-hotplug.dsl b/src/acpi-dsdt-cpu

[Qemu-devel] [RFC][PATCH 2/6] cpus: release allocated vcpu objects and exit vcpu thread

2013-08-28 Thread Chen Fan
After ACPI get a signal to eject a vcpu, then it will notify the vcpu thread of needing to exit, before the vcpu exiting, will release the vcpu related objects. Signed-off-by: Chen Fan --- cpus.c | 36 hw/acpi/piix4.c | 16

[Qemu-devel] [RFC][PATCH 3/6] qom cpu: rename variable 'cpu_added_notifier' to 'cpu_hotplug_notifier'

2013-08-28 Thread Chen Fan
Rename variable 'cpu_added_notifier' to 'cpu_hotplug_notifier', for adding vcpu-remove notifier support. Signed-off-by: Chen Fan --- hw/acpi/piix4.c | 10 +- hw/i386/pc.c| 2 +- include/sysemu/sysemu.h | 2 +- qom/cpu.c | 10

[Qemu-devel] [RFC][PATCH 4/6] qmp: add 'cpu-del' command support

2013-08-28 Thread Chen Fan
Signed-off-by: Chen Fan --- hw/i386/pc.c | 5 + hw/i386/pc_piix.c| 1 + include/hw/boards.h | 2 ++ include/hw/i386/pc.h | 1 + qapi-schema.json | 12 qmp-commands.hx | 23 +++ qmp.c| 9 + 7 files changed, 53

[Qemu-devel] [RFC][PATCH 1/6] piix4: implement function 'cpu_status_write' for vcpu ejection

2013-08-28 Thread Chen Fan
When OS eject a vcpu (like: echo 1 > /sys/bus/acpi/devices/LNXCPUXX/eject), it will call acpi EJ0 method, the firmware will write the new cpumap, QEMU will know which vcpu need to be ejected. Signed-off-by: Chen Fan --- hw/acpi/piix4.c | 35 ++- 1 file chan

[Qemu-devel] [RFC][PATCH 0/6] i386: add cpu hot remove support

2013-08-28 Thread Chen Fan
/gmane.comp.emulators.kvm.devel/114347 for seabios patches: http://comments.gmane.org/gmane.comp.emulators.qemu/230460 Chen Fan (6): piix4: implement function 'cpu_status_write' for vcpu ejection cpus: release allocated vcpu objects and exit vcpu thread qom cpu: rename variable 'cpu

[Qemu-devel] [RFC][PATCH 5/6] qom cpu: add struct CPUNotifier for supporting PLUG and UNPLUG cpu notifier

2013-08-28 Thread Chen Fan
Move struct HotplugEventType from file piix4.c to file qom/cpu.c, and add struct CPUNotifier for supporting PLUG and UNPLUG cpu notifier. Signed-off-by: Chen Fan --- hw/acpi/piix4.c | 8 ++-- include/qom/cpu.h | 10 ++ qom/cpu.c | 6 +- 3 files changed, 17 insertions

[Qemu-devel] [RFC][PATCH 6/6] i386: implement cpu interface 'cpu_common_unrealizefn'

2013-08-28 Thread Chen Fan
Implement cpu interface 'cpu_common_unrealizefn' for emiting vcpu-remove notifier to ACPI, then ACPI could send sci interrupt to OS for hot-remove vcpu. Signed-off-by: Chen Fan --- hw/i386/pc.c | 19 ++- qom/cpu.c| 13 + 2 files changed, 31 insert

Re: [Qemu-devel] [PATCH 1/2] pc-dimm: No numa option shouldn't break hotplug memory feature

2014-09-17 Thread Tang Chen
,maxmem=8G (2) Hotplug memory It will fail and reports: "'DIMM property node has value 0' which exceeds the number of numa nodes: 0" I rememberd Tang Chen had a patch for this bug, this is what Andrey suggested: I thnk that there should be no cases when dimm is plugged (and

Re: [Qemu-devel] [PATCH v2] pc-dimm/numa: Fix stat of memory size in node when hotplug memory

2014-09-18 Thread Chen, Fan
--git a/numa.c b/numa.c > index 3b98135..4e27dd8 100644 > --- a/numa.c > +++ b/numa.c > @@ -35,6 +35,7 @@ > #include "hw/boards.h" > #include "sysemu/hostmem.h" > #include "qmp-commands.h" > +#include "hw/mem/pc-dimm.h" > > Qe

Re: [Qemu-devel] [PATCH 1/2] serial: reset state at startup

2014-09-19 Thread Chen, Tiejun
On 2014/9/19 16:54, Paolo Bonzini wrote: When a serial port is started, its initial state is all zero. Make it consistent with reset state instead. Signed-off-by: Paolo Bonzini --- hw/char/serial.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/char/serial.c b/hw/char/serial.c index

Re: [Qemu-devel] [PATCH 1/2] serial: reset state at startup

2014-09-21 Thread Chen, Tiejun
On 2014/9/19 20:57, Paolo Bonzini wrote: Il 19/09/2014 11:17, Chen, Tiejun ha scritto: On 2014/9/19 16:54, Paolo Bonzini wrote: When a serial port is started, its initial state is all zero. Make it consistent with reset state instead. Signed-off-by: Paolo Bonzini --- hw/char/serial.c | 1

Re: [Qemu-devel] [PATCH 1/2] pc-dimm: No numa option shouldn't break hotplug memory feature

2014-09-22 Thread Tang Chen
reproduce: (1) Start VM: qemu-kvm -m 1024,slots=4,maxmem=8G (2) Hotplug memory It will fail and reports: "'DIMM property node has value 0' which exceeds the number of numa nodes: 0" I rememberd Tang Chen had a patch for this bug, this is what Andrey suggested: I thnk that there s

Re: [Qemu-devel] [PATCH 1/2] pc-dimm: No numa option shouldn't break hotplug memory feature

2014-09-23 Thread Tang Chen
On 09/23/2014 04:40 PM, Igor Mammedov wrote: .. It's fine to use SRAT for these purposes on baremetal NUMA systems since due to used chipset constrains it's possible statically allocate ranges for every possible DIMM socket. However SRAT(which is optional table BTW) entries are not mandatory

Re: [Qemu-devel] [PATCH 1/2] pc-dimm: No numa option shouldn't break hotplug memory feature

2014-09-23 Thread Tang Chen
On 09/23/2014 06:11 PM, zhanghailiang wrote: On 2014/9/23 16:58, Tang Chen wrote: On 09/23/2014 04:40 PM, Igor Mammedov wrote: .. It's fine to use SRAT for these purposes on baremetal NUMA systems since due to used chipset constrains it's possible statically allocate ranges

Re: [Qemu-devel] [RESEND PATCH v3 5/8] pc-dimm: Add pc_dimm_unrealize() for memory hot unplug support.

2014-09-24 Thread Tang Chen
Hi Igor, Zhang, On 09/12/2014 09:17 PM, Igor Mammedov wrote: .. Actually, this patch also fix the bug *when hotplug memory failing in the place where after pc_dimm_plug but before the end of device_set_realized, it does not clear the work done by pc_dimm_plug*. For there is no callback like

Re: [Qemu-devel] [PATCH 11/30] qdev: HotplugHandler: provide unplug callback

2014-09-24 Thread Tang Chen
On 09/24/2014 07:48 PM, Igor Mammedov wrote: it to be called for actual device removal and will allow to separate request and removal handling phases of x86-CPU devices and also it's a handler to be called for synchronously removable devices. Signed-off-by: Igor Mammedov --- unplug handling fo

Re: [Qemu-devel] [PATCH 09/30] access BusState.allow_hotplug using wraper qbus_is_hotpluggable()

2014-09-24 Thread Tang Chen
On 09/24/2014 07:47 PM, Igor Mammedov wrote: it would allow transparently switch detection if Bus is hotpluggable from allow_hotplug field to hotplug_handler link and drop allow_hotplug field once all users are converted to hotplug handler API. Signed-off-by: Igor Mammedov --- hw/core/qdev.c

Re: [Qemu-devel] [PATCH 13/30] qdev: hotplug: set handler only if HOTPLUG_HANDLER interface is supported

2014-09-24 Thread Tang Chen
On 09/24/2014 07:48 PM, Igor Mammedov wrote: Check if 'handler' implements HOTPLUG_HANDLER interface before setting it, if it's not then do nothing and leave bus not hotpluggable. That would allow to reuse the same code for creating bus for example 'scsi_bus_new()' for both hotpluggable and not

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough

2014-09-27 Thread Chen, Tiejun
On 2014/9/3 9:40, Kay, Allen M wrote: -Original Message- From: Chen, Tiejun Sent: Monday, September 01, 2014 12:50 AM To: Michael S. Tsirkin Cc: xen-de...@lists.xensource.com; Kay, Allen M; qemu-devel@nongnu.org; Konrad Rzeszutek Wilk Subject: Re: [Qemu-devel] [Xen-devel] [PATCH 2/2

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough

2014-09-27 Thread Chen, Tiejun
On 2014/9/28 10:59, Chen, Tiejun wrote: On 2014/9/3 9:40, Kay, Allen M wrote: -Original Message- From: Chen, Tiejun Sent: Monday, September 01, 2014 12:50 AM To: Michael S. Tsirkin Cc: xen-de...@lists.xensource.com; Kay, Allen M; qemu-devel@nongnu.org; Konrad Rzeszutek Wilk Subject

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough

2014-09-29 Thread Chen, Tiejun
On 2014/9/29 18:01, Michael S. Tsirkin wrote: On Sun, Sep 28, 2014 at 10:59:05AM +0800, Chen, Tiejun wrote: On 2014/9/3 9:40, Kay, Allen M wrote: -Original Message- From: Chen, Tiejun Sent: Monday, September 01, 2014 12:50 AM To: Michael S. Tsirkin Cc: xen-de...@lists.xensource.com

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough

2014-10-06 Thread Chen, Tiejun
Ping... Thanks Tiejun On 2014/9/30 10:43, Chen, Tiejun wrote: On 2014/9/29 18:01, Michael S. Tsirkin wrote: On Sun, Sep 28, 2014 at 10:59:05AM +0800, Chen, Tiejun wrote: On 2014/9/3 9:40, Kay, Allen M wrote: -Original Message- From: Chen, Tiejun Sent: Monday, September 01, 2014

[Qemu-devel] [RFC][PATCH] gpu:drm:i915:intel_detect_pch: back to check devfn instead of check class type

2014-06-19 Thread Tiejun Chen
rough support into qemu upstream, and with some discussion, we wouldn't set the bridge class type and just expose this devfn. So we just go back to check devfn to make life normal. Signed-off-by: Tiejun Chen --- drivers/gpu/drm/i915/i915_drv.c | 19 +++ 1 file changed, 3

Re: [Qemu-devel] [RFC][PATCH] gpu:drm:i915:intel_detect_pch: back to check devfn instead of check class type

2014-06-20 Thread Chen, Tiejun
Just ping, any comments? Thanks Tiejun On 2014/6/19 17:53, Tiejun Chen wrote: Originally the reason to probe ISA bridge instead of Dev31:Fun0 is to make graphics device passthrough work easy for VMM, that only need to expose ISA bridge to let driver know the real hardware underneath. This is a

[Qemu-devel] [PATCH trivial] block.c: Remove useless 'buf' variable

2014-06-21 Thread Chen Gang
'buf' is not used actually, so remove it and related snprintf() statement. Signed-off-by: Chen Gang --- block.c | 2 -- dtc | 1 - 2 files changed, 3 deletions(-) delete mode 16 dtc diff --git a/block.c b/block.c index 43abe96..74af8d7 100644 --- a/block.c +++ b/block.c

[Qemu-devel] [PATCH trivial] block.c: Correct the return value and the failure object when failure occurs

2014-06-21 Thread Chen Gang
When failure occurs, 'ret' need be set, or may return 0 to indicate success. And error_propagate() also need be called only one time within a function. Signed-off-by: Chen Gang --- block.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block.c b/block.c ind

Re: [Qemu-devel] [PATCH trivial] block.c: Remove useless 'buf' variable

2014-06-21 Thread Chen Gang
On 06/21/2014 11:03 PM, Michael Tokarev wrote: > 21.06.2014 17:00, Chen Gang wrote: >> 'buf' is not used actually, so remove it and related snprintf() statement. > > Applied to -trivial, after removing wrong reference to dtc submodule removal. > Please don'

Re: [Qemu-devel] [RFC][PATCH] gpu:drm:i915:intel_detect_pch: back to check devfn instead of check class type

2014-06-22 Thread Chen, Tiejun
this ISA bridge. And especially, we wouldn't provide that ISA bridge with an explicit class type in qemu-upstream, so we need to the i915 driver to probe pch by checking devfn. This should work both on the native case and the virtualized case. Thanks Tiejun -Daniel On Fri, Jun 20, 20

Re: [Qemu-devel] [RFC][PATCH] gpu:drm:i915:intel_detect_pch: back to check devfn instead of check class type

2014-06-22 Thread Chen, Tiejun
On 2014/6/20 20:48, Paolo Bonzini wrote: Il 19/06/2014 11:53, Tiejun Chen ha scritto: so this mean that isa bridge is still represented with Dev31:Func0 like the native OS. Furthermore, currently we're pushing VGA passthrough support into qemu upstream, and with some discussion, we wouldn&

Re: [Qemu-devel] [PATCH trivial] block.c: Correct the return value and the failure object when failure occurs

2014-06-23 Thread Chen Gang
local_err); > goto close_and_fail; > } > } > That's fine to me, I shall send patch v2 for it. Thanks. -- Chen Gang Open share and attitude like air water and life which God blessed

[Qemu-devel] [PATCH trivial v2] block.c: Add return value for bdrv_append_temp_snapshot() to avoid incorrect failure processing issue

2014-06-23 Thread Chen Gang
turn value internally. So let bdrv_append_temp_snapshot() internal return value outside, and let all things normal, then fix the issue too. Signed-off-by: Chen Gang --- block.c | 7 --- include/block/block.h | 2 +- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a

Re: [Qemu-devel] [PATCH trivial v2] block.c: Add return value for bdrv_append_temp_snapshot() to avoid incorrect failure processing issue

2014-06-23 Thread Chen Gang
On 06/24/2014 10:25 AM, Fam Zheng wrote: > On Mon, 06/23 23:28, Chen Gang wrote: >> When failure occurs, 'ret' need be set, or may return 0 to indicate success. > > s/need/needs/ > >> And error_propagate() also need be called only one time within a function. &g

[Qemu-devel] [v5][PATCH 1/5] xen, gfx passthrough: basic graphics passthrough support

2014-06-24 Thread Tiejun Chen
Chen Cc: Weidong Han --- v5: * Just rebase. v4: * Fix some typos in the patch head description. * Improve some comments. * Given that xen_pt_register_vga_regions()/xen_pt_unregister_vga_regions() are called unconditionally, so we just return 0 there. * Remove one spurious change. v3: * Fix

[Qemu-devel] [v5][PATCH 0/5] xen: add Intel IGD passthrough support

2014-06-24 Thread Tiejun Chen
es in Xen config file: gfx_passthru=1 pci=['00:02.0@2'] Now successfully boot Ubuntu 14.04/Windows 7 guests with IGD assigned in Haswell desktop with Latest Xen + Qemu upstream. Tiejun Chen (5): xen, gfx passthrough:

[Qemu-devel] [v5][PATCH 5/5] xen, gfx passthrough: add opregion mapping

2014-06-24 Thread Tiejun Chen
by: Tiejun Chen Cc: Jean Guyader --- v5: * Nothing is changed. v4: * Nothing is changed. v3: * Fix some typos. * Add more comments to make that readable. * To unmap igd_opregion when call xen_pt_unregister_vga_regions(). * Improve some return paths. * We need to map 3 pages for opregion as

[Qemu-devel] [v5][PATCH 3/5] xen, gfx passthrough: support Intel IGD passthrough with VT-D

2014-06-24 Thread Tiejun Chen
Some registers of Intel IGD are mapped in host bridge, so it needs to passthrough these registers of physical host bridge to guest because emulated host bridge in guest doesn't have these mappings. The original patch is from Weidong Han Signed-off-by: Yang Zhang Signed-off-by: Tiejun Che

[Qemu-devel] [v5][PATCH 2/5] xen, gfx passthrough: create pseudo intel isa bridge

2014-06-24 Thread Tiejun Chen
-off-by: Tiejun Chen Cc: Allen Kay --- v5: * Don't set this ISA class property, instead, just fake this ISA bridge with 00:1f.0. v4: * Remove some unnecessary "return" in void foo(). v3: * Fix some typos. * Improve some return paths. v2: * Nothing is changed. hw/xen/xen_pt_

[Qemu-devel] [v5][PATCH 4/5] xen, gfx passthrough: create host bridge to passthrough

2014-06-24 Thread Tiejun Chen
Implement that pci host bridge to specific to passthrough. Actually this just inherit the standard one. Signed-off-by: Tiejun Chen --- v5: * Nothing is changed. v4: * Fix one typo in the patch head description. * Use (xen_enabled() && xen_has_gfx_passthru) to make sure we only work

Re: [Qemu-devel] [Intel-gfx] [RFC][PATCH] gpu:drm:i915:intel_detect_pch: back to check devfn instead of check class type

2014-06-24 Thread Chen, Tiejun
On 2014/6/24 10:59, Zhenyu Wang wrote: On 2014.06.19 17:53:51 +0800, Tiejun Chen wrote: Originally the reason to probe ISA bridge instead of Dev31:Fun0 is to make graphics device passthrough work easy for VMM, that only need to expose ISA bridge to let driver know the real hardware underneath

Re: [Qemu-devel] [v2][PATCH 4/8] xen, gfx passthrough: reserve 00:02.0 for INTEL IGD

2014-06-24 Thread Chen, Tiejun
On 2014/5/19 19:22, Gerd Hoffmann wrote: Hi, I think '-vga none' just guarantees the qemu vga cards doesn't occupy 00:02.0, but this doesn't mean others use this specific slot since in qemu internal, we always pass -1 to assign a slot automatically to register a PCI device. So in some cases,

Re: [Qemu-devel] [v4][PATCH 3/5] I440FX_PCI_DEVICE: add pci_type to index

2014-08-10 Thread Chen, Tiejun
On 2014/8/11 4:27, Michael S. Tsirkin wrote: On Thu, Aug 07, 2014 at 09:40:49AM +0800, Chen, Tiejun wrote: On 2014/8/7 5:07, Michael S. Tsirkin wrote: On Wed, Aug 06, 2014 at 06:17:02PM +0800, Chen, Tiejun wrote: On 2014/8/6 17:45, Michael S. Tsirkin wrote: On Wed, Aug 06, 2014 at 02:50

Re: [Qemu-devel] [PATCH] dump.c: Fix memory leak issue in cleanup processing for dump_init()

2014-08-11 Thread Chen Gang
If this patch need still be improvement (e.g. need let dump_cleanup function as a generic one, or other cases), please let me know, and I shall send patch v2 for it. Thanks. On 08/04/2014 09:51 PM, Chen Gang wrote: > On 08/03/2014 11:56 PM, Laszlo Ersek wrote: >> comments below >&

Re: [Qemu-devel] [v4][PATCH 3/5] I440FX_PCI_DEVICE: add pci_type to index

2014-08-12 Thread Chen, Tiejun
On 2014/8/12 16:54, Michael S. Tsirkin wrote: On Mon, Aug 11, 2014 at 10:50:48AM +0800, Chen, Tiejun wrote: On 2014/8/11 4:27, Michael S. Tsirkin wrote: On Thu, Aug 07, 2014 at 09:40:49AM +0800, Chen, Tiejun wrote: On 2014/8/7 5:07, Michael S. Tsirkin wrote: On Wed, Aug 06, 2014 at 06:17

Re: [Qemu-devel] [v4][PATCH 3/5] I440FX_PCI_DEVICE: add pci_type to index

2014-08-12 Thread Chen, Tiejun
On 2014/8/12 17:25, Chen, Tiejun wrote: On 2014/8/12 16:54, Michael S. Tsirkin wrote: On Mon, Aug 11, 2014 at 10:50:48AM +0800, Chen, Tiejun wrote: On 2014/8/11 4:27, Michael S. Tsirkin wrote: On Thu, Aug 07, 2014 at 09:40:49AM +0800, Chen, Tiejun wrote: On 2014/8/7 5:07, Michael S

[Qemu-devel] [v5][PATCH 2/4] pc_init1: pass parameters just with types

2014-08-12 Thread Tiejun Chen
Pass types to configure pc_init1(). Signed-off-by: Tiejun Chen --- hw/i386/pc_piix.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) v5: * Nothing is changed. v4: * New patch to work for patch #1 diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index bf26550

[Qemu-devel] [v5][PATCH 0/4] xen: introduce new machine for IGD passthrough

2014-08-12 Thread Tiejun Chen
-machine pc As we discussed we need to create a separate machine to support current IGD passthrough. Michael S. Tsirkin (1): i440fx: make types configurable at run-time Tiejun Chen (3): pc_init1: pass parameters just with

[Qemu-devel] [v5][PATCH 4/4] xen:hw:i386:pc_piix: introduce new machine for IGD passthrough

2014-08-12 Thread Tiejun Chen
Now we can introduce a new machine, xenigd, specific to IGD passthrough. This can avoid involving other common codes. Signed-off-by: Tiejun Chen --- hw/i386/pc_piix.c | 43 +++ 1 file changed, 43 insertions(+) v5: * Nothing is changed. v4: * Rebase

[Qemu-devel] [v5][PATCH 1/4] i440fx: make types configurable at run-time

2014-08-12 Thread Tiejun Chen
From: "Michael S. Tsirkin" Xen wants to supply a different pci and host devices, inheriting i440fx devices. Make types configurable. Signed-off-by: Michael S. Tsirkin Signed-off-by: Tiejun Chen --- hw/i386/pc_piix.c| 4 +++- hw/pci-host/piix.c | 9 - include/hw/i38

[Qemu-devel] [v5][PATCH 3/4] xen:hw:pci-host:piix: create host bridge to passthrough

2014-08-12 Thread Tiejun Chen
Implement a pci host bridge specific to passthrough. Actually this just inherits the standard one. Signed-off-by: Tiejun Chen --- hw/pci-host/piix.c | 15 +++ include/hw/i386/pc.h | 2 ++ 2 files changed, 17 insertions(+) v5: * Simplify to make sure its really inherited from

Re: [Qemu-devel] [PATCH] dump.c: Fix memory leak issue in cleanup processing for dump_init()

2014-08-12 Thread Chen Gang
On 08/12/2014 11:43 PM, Laszlo Ersek wrote: > On 08/03/14 17:28, Chen Gang wrote: >> In dump_init(), when failure occurs, need notice about 'fd' and memory >> mapping. So call dump_cleanup() for it (need let all initializations at >> front). >> >> Als

Re: [Qemu-devel] [v5][PATCH 0/4] xen: introduce new machine for IGD passthrough

2014-08-13 Thread Chen, Tiejun
Michael, Any further comments to this revision? Thanks Tiejun On 2014/8/12 17:49, Tiejun Chen wrote: v5: * Simplify to make sure its really inherited from the standard one in patch #3 * Then drop the original patch #3 v4: * Rebase on latest tree * Drop patch #2 * Regenerate patches after

Re: [Qemu-devel] [v5][PATCH 0/4] xen: introduce new machine for IGD passthrough

2014-08-14 Thread Chen, Tiejun
On 2014/8/14 15:09, Michael S. Tsirkin wrote: On Tue, Aug 12, 2014 at 05:49:13PM +0800, Tiejun Chen wrote: v5: * Simplify to make sure its really inherited from the standard one in patch #3 * Then drop the original patch #3 v4: * Rebase on latest tree * Drop patch #2 * Regenerate patches

Re: [Qemu-devel] [PATCH] dump.c: Fix memory leak issue in cleanup processing for dump_init()

2014-08-14 Thread Chen Gang
On 08/15/2014 04:49 AM, Luiz Capitulino wrote: > On Sun, 03 Aug 2014 23:28:56 +0800 > Chen Gang wrote: > >> > In dump_init(), when failure occurs, need notice about 'fd' and memory >> > mapping. So call dump_cleanup() for it (need let all initializations at

Re: [Qemu-devel] [v5][PATCH 4/4] xen:hw:i386:pc_piix: introduce new machine for IGD passthrough

2014-08-14 Thread Chen, Tiejun
On 2014/8/15 0:03, Michael S. Tsirkin wrote: On Tue, Aug 12, 2014 at 05:49:17PM +0800, Tiejun Chen wrote: Now we can introduce a new machine, xenigd, specific to IGD passthrough. This can avoid involving other common codes. Signed-off-by: Tiejun Chen This broke make check since the new

[Qemu-devel] [RESEND v2 1/3] query-memdev: fix potential memory leaks

2014-08-17 Thread Chen Fan
Signed-off-by: Chen Fan Reviewed-by: Peter Crosthwaite Reviewed-by: Hu Tao --- numa.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/numa.c b/numa.c index c78cec9..aa772aa 100644 --- a/numa.c +++ b/numa.c @@ -318,10 +318,11 @@ void

[Qemu-devel] [RESEND v2 0/3] Fix some memory leaks about query memdev

2014-08-17 Thread Chen Fan
9) ==15046==by 0x2BCDEF: fd_chr_read (qemu-char.c:213) Chen Fan (3): query-memdev: fix potential memory leaks qom/object.c: fix string_output_get_string() memory leak hmp: fix MemdevList memory leak hmp.c| 8 ++-- numa.c | 15 +++ qom/object.c | 12 +

[Qemu-devel] [RESEND v2 3/3] hmp: fix MemdevList memory leak

2014-08-17 Thread Chen Fan
the memdev_list in hmp_info_memdev() is never freed. so we use existent method qapi_free_MemdevList() to free it. and also we can use qapi_free_MemdevList() to replace list loops to clean up the memdev list in error path. Signed-off-by: Chen Fan Reviewed-by: Peter Crosthwaite Reviewed-by: Hu

[Qemu-devel] [RESEND v2 2/3] qom/object.c: fix string_output_get_string() memory leak

2014-08-17 Thread Chen Fan
string_output_get_string() uses g_string_free(str, false) to transfer the 'str' pointer to callers and never free it. Signed-off-by: Chen Fan Reviewed-by: Peter Crosthwaite Reviewed-by: Hu Tao --- hmp.c| 6 -- qom/object.c | 12 ++-- 2 files changed, 14 insert

Re: [Qemu-devel] How to create PCH to support those existing driver

2014-08-18 Thread Chen, Tiejun
On 2014/8/18 16:21, Michael S. Tsirkin wrote: On Mon, Aug 18, 2014 at 11:06:29AM +0800, Chen, Tiejun wrote: On 2014/8/17 18:32, Michael S. Tsirkin wrote: On Fri, Aug 15, 2014 at 09:58:40AM +0800, Chen, Tiejun wrote: Michael and Paolo, Please re-post discussion on list. These off list ones

[Qemu-devel] [PATCH v3 3/8] pc: Add memory hot unplug support for pc machine.

2014-08-18 Thread Tang Chen
From: Hu Tao Implement device unplug callback for PCMachine. And it now only support pc-dimm hot-remove. The callback will call piix4 or ich9 callbacks introduced in previous patches. Signed-off-by: Hu Tao Signed-off-by: Tang Chen --- hw/i386/pc.c | 32 1

[Qemu-devel] [PATCH v3 5/8] pc-dimm: Add pc_dimm_unrealize() for memory hot unplug support.

2014-08-18 Thread Tang Chen
From: Hu Tao Implement unrealize function for pc-dimm device. It delete subregion from hotplug region, and delete ram address range from guest ram list. Signed-off-by: Hu Tao Signed-off-by: Tang Chen --- hw/mem/pc-dimm.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/hw/mem

[Qemu-devel] [PATCH v3 2/8] acpi, ich9: Add memory hot unplug support for ich9.

2014-08-18 Thread Tang Chen
Implement ich9_pm_device_unplug_cb() to support memory hot-remove, calling acpi_memory_unplug_cb(). And itself will be called in ich9_device_unplug_cb(). Signed-off-by: Tang Chen --- hw/acpi/ich9.c | 12 hw/isa/lpc_ich9.c | 5 +++-- include/hw/acpi/ich9.h | 2 ++ 3

[Qemu-devel] [PATCH v3 1/8] acpi, piix4: Add memory hot unplug support for piix4.

2014-08-18 Thread Tang Chen
From: Hu Tao Implement acpi_memory_unplug_cb(), sending an sci to guest to trigger memory hot-remove, and call it in piix4_device_unplug_cb(). Signed-off-by: Hu Tao Signed-off-by: Tang Chen --- hw/acpi/memory_hotplug.c | 25 + hw/acpi/piix4.c

[Qemu-devel] [PATCH v3 6/8] acpi: Add hardware implementation for memory hot unplug.

2014-08-18 Thread Tang Chen
ister when triggering memory hot-remove in guest. Signed-off-by: Hu Tao Signed-off-by: Tang Chen --- hw/acpi/memory_hotplug.c | 52 ++-- include/hw/acpi/acpi.h | 14 +++ include/hw/acpi/memory_hotplug.h | 1 + 3 files changed, 65 insert

[Qemu-devel] [PATCH v3 7/8] pc, acpi bios: Add memory hot unplug interface.

2014-08-18 Thread Tang Chen
From: Hu Tao This patch implements MEMORY_SLOT_EJECT_METHOD according to ACPI spec. Signed-off-by: Hu Tao Signed-off-by: Tang Chen --- hw/i386/ssdt-mem.dsl | 5 + hw/i386/ssdt-misc.dsl| 15 ++- include/hw/acpi/pc-hotplug.h | 2 ++ 3 files changed, 21

[Qemu-devel] [PATCH v3 0/8] QEmu memory hot unplug support.

2014-08-18 Thread Tang Chen
ess devices. pc-dimm: Add pc_dimm_unrealize() for memory hot unplug support. acpi: Add hardware implementation for memory hot unplug. pc, acpi bios: Add memory hot unplug interface. monitor: Add memory hot unplug support for device_del command. Tang Chen (1): acpi, ich9: Add memory hot unp

[Qemu-devel] [PATCH v3 8/8] monitor: Add memory hot unplug support for device_del command.

2014-08-18 Thread Tang Chen
From: Hu Tao Implement find_peripheral_device() to find bus-less device, and call it in qmp_device_del() so that device_del command will be able to remove memory device. Signed-off-by: Hu Tao Signed-off-by: Tang Chen --- include/qom/object.h | 1 + qdev-monitor.c | 26

[Qemu-devel] [PATCH v3 4/8] qdev: Add memory hot unplug support for bus-less devices.

2014-08-18 Thread Tang Chen
From: Hu Tao Implement bus-less device hot-remove in qdev_unplug(). It will call PCMachine callback introduced in previous patch. Signed-off-by: Hu Tao Signed-off-by: Tang Chen --- hw/core/qdev.c | 8 1 file changed, 8 insertions(+) diff --git a/hw/core/qdev.c b/hw/core/qdev.c

[Qemu-devel] [PATCH v3 2/8] acpi, ich9: Add memory hot unplug support for ich9.

2014-08-18 Thread Tang Chen
Implement ich9_pm_device_unplug_cb() to support memory hot-remove, calling acpi_memory_unplug_cb(). And itself will be called in ich9_device_unplug_cb(). Signed-off-by: Tang Chen --- hw/acpi/ich9.c | 12 hw/isa/lpc_ich9.c | 5 +++-- include/hw/acpi/ich9.h | 2 ++ 3

[Qemu-devel] [PATCH v3 4/8] qdev: Add memory hot unplug support for bus-less devices.

2014-08-18 Thread Tang Chen
From: Hu Tao Implement bus-less device hot-remove in qdev_unplug(). It will call PCMachine callback introduced in previous patch. Signed-off-by: Hu Tao Signed-off-by: Tang Chen --- hw/core/qdev.c | 8 1 file changed, 8 insertions(+) diff --git a/hw/core/qdev.c b/hw/core/qdev.c

[Qemu-devel] [PATCH v3 5/8] pc-dimm: Add pc_dimm_unrealize() for memory hot unplug support.

2014-08-18 Thread Tang Chen
From: Hu Tao Implement unrealize function for pc-dimm device. It delete subregion from hotplug region, and delete ram address range from guest ram list. Signed-off-by: Hu Tao Signed-off-by: Tang Chen --- hw/mem/pc-dimm.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/hw/mem

[Qemu-devel] [PATCH v3 3/8] pc: Add memory hot unplug support for pc machine.

2014-08-18 Thread Tang Chen
From: Hu Tao Implement device unplug callback for PCMachine. And it now only support pc-dimm hot-remove. The callback will call piix4 or ich9 callbacks introduced in previous patches. Signed-off-by: Hu Tao Signed-off-by: Tang Chen --- hw/i386/pc.c | 32 1

[Qemu-devel] [PATCH v3 7/8] pc, acpi bios: Add memory hot unplug interface.

2014-08-18 Thread Tang Chen
From: Hu Tao This patch implements MEMORY_SLOT_EJECT_METHOD according to ACPI spec. Signed-off-by: Hu Tao Signed-off-by: Tang Chen --- hw/i386/ssdt-mem.dsl | 5 + hw/i386/ssdt-misc.dsl| 15 ++- include/hw/acpi/pc-hotplug.h | 2 ++ 3 files changed, 21

[Qemu-devel] [PATCH v3 1/8] acpi, piix4: Add memory hot unplug support for piix4.

2014-08-18 Thread Tang Chen
From: Hu Tao Implement acpi_memory_unplug_cb(), sending an sci to guest to trigger memory hot-remove, and call it in piix4_device_unplug_cb(). Signed-off-by: Hu Tao Signed-off-by: Tang Chen --- hw/acpi/memory_hotplug.c | 25 + hw/acpi/piix4.c

[Qemu-devel] [PATCH v3 8/8] monitor: Add memory hot unplug support for device_del command.

2014-08-18 Thread Tang Chen
From: Hu Tao Implement find_peripheral_device() to find bus-less device, and call it in qmp_device_del() so that device_del command will be able to remove memory device. Signed-off-by: Hu Tao Signed-off-by: Tang Chen --- include/qom/object.h | 1 + qdev-monitor.c | 26

[Qemu-devel] [PATCH v3 6/8] acpi: Add hardware implementation for memory hot unplug.

2014-08-18 Thread Tang Chen
ister when triggering memory hot-remove in guest. Signed-off-by: Hu Tao Signed-off-by: Tang Chen --- hw/acpi/memory_hotplug.c | 52 ++-- include/hw/acpi/acpi.h | 14 +++ include/hw/acpi/memory_hotplug.h | 1 + 3 files changed, 65 insert

[Qemu-devel] [PATCH v3 0/8] QEmu memory hot unplug support.

2014-08-18 Thread Tang Chen
ess devices. pc-dimm: Add pc_dimm_unrealize() for memory hot unplug support. acpi: Add hardware implementation for memory hot unplug. pc, acpi bios: Add memory hot unplug interface. monitor: Add memory hot unplug support for device_del command. Tang Chen (1): acpi, ich9: Add memory hot unp

[Qemu-devel] [PATCH 1/1] pc-dimm: Change PCDIMMDevice->node from UINT32 to INT32, and initialize it as -1.

2014-08-18 Thread Tang Chen
de should be initialized to -1. This is for users who do not use NUMA. Signed-off-by: Tang Chen --- hw/mem/pc-dimm.c | 2 +- include/hw/mem/pc-dimm.h | 2 +- include/sysemu/sysemu.h | 6 ++ 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/hw/mem/pc-dimm.c b/hw/mem/pc

Re: [Qemu-devel] How to create PCH to support those existing driver

2014-08-18 Thread Chen, Tiejun
On 2014/8/18 17:58, Michael S. Tsirkin wrote: On Mon, Aug 18, 2014 at 05:01:25PM +0800, Chen, Tiejun wrote: On 2014/8/18 16:21, Michael S. Tsirkin wrote: On Mon, Aug 18, 2014 at 11:06:29AM +0800, Chen, Tiejun wrote: On 2014/8/17 18:32, Michael S. Tsirkin wrote: On Fri, Aug 15, 2014 at 09

[Qemu-devel] [PATCH v2 1/1] pc-dimm: Change PCDIMMDevice->node from UINT32 to INT32, and initialize it as -1.

2014-08-18 Thread Tang Chen
de should be initialized to -1. This is for users who do not use NUMA. Signed-off-by: Tang Chen --- Change log v1 -> v2: 1. Simplify the comment. 2. Move the definition of NO_NODE_ID near where it is used. hw/mem/pc-dimm.c | 7 ++- include/hw/mem/pc-dimm.h | 2 +- 2 files changed,

Re: [Qemu-devel] [PATCH] virt/kvm/assigned-dev.c: Set 'dev->irq_source_id' to '-1' after free it

2014-08-19 Thread Chen Gang
By the way, at present, I use Qemu as user mode program, is there common test with both Qemu and KVM/Xen? And is a PC enough for the common test? Thanks. On 08/20/2014 07:58 AM, Chen Gang wrote: > On 08/19/2014 11:49 PM, Paolo Bonzini wrote: >> Il 19/08/2014 17:44, Chen Gang h

Re: [Qemu-devel] How to create PCH to support those existing driver

2014-08-19 Thread Chen, Tiejun
On 2014/8/20 5:51, Michael S. Tsirkin wrote: On Tue, Aug 19, 2014 at 09:24:03PM +, Kay, Allen M wrote: Allen, Could you reply this? Let me summarized what we have discussed and learned so far: 1) Future Windows/Linux IGD drivers will be modified to restrain from accessing MCH/PCH device

Re: [Qemu-devel] [PATCH] virt/kvm/assigned-dev.c: Set 'dev->irq_source_id' to '-1' after free it

2014-08-20 Thread Chen Gang
On 08/20/2014 08:01 AM, Chen Gang wrote: > > By the way, at present, I use Qemu as user mode program, is there common > test with both Qemu and KVM/Xen? And is a PC enough for the common test? > Oh, I find Qemu have "make check" just like gcc/binutils, so for each of my

[Qemu-devel] [PATCH 0/2] qemu:xen: implement isa bridge specific to IGD passthrough

2014-08-20 Thread Tiejun Chen
Chen (2): hw:xen:xen_pt: register isa bridge specific to IGD passthrough xen:i386:pc_piix: create isa bridge specific to IGD passthrough hw/i386/pc_piix.c | 24 +++- hw/xen/xen_pt.c | 21 + 2 files changed, 44 insertions(+), 1 deletion

[Qemu-devel] [PATCH 1/2] hw:xen:xen_pt: register isa bridge specific to IGD passthrough

2014-08-20 Thread Tiejun Chen
We need this instance to passthrough some config fields of PCH. Signed-off-by: Tiejun Chen --- hw/xen/xen_pt.c | 21 + 1 file changed, 21 insertions(+) diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c index c1bf357..bf72719 100644 --- a/hw/xen/xen_pt.c +++ b/hw/xen/xen_pt.c

[Qemu-devel] [PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough

2014-08-20 Thread Tiejun Chen
Currenjly this ISA bridge should be fixed at 1f.0, and pass the real vendor/device ids as the driver expect. Signed-off-by: Tiejun Chen --- hw/i386/pc_piix.c | 24 +++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough

2014-08-21 Thread Chen, Tiejun
On 2014/8/22 0:16, Konrad Rzeszutek Wilk wrote: On Thu, Aug 21, 2014 at 09:28:28AM +0800, Tiejun Chen wrote: Currenjly this ISA bridge should be fixed at 1f.0, and pass the Currently Fixed. real vendor/device ids as the driver expect. Could you add a bit more description to this patch

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough

2014-08-24 Thread Chen, Tiejun
On 2014/8/24 19:12, Michael S. Tsirkin wrote: On Fri, Aug 22, 2014 at 09:06:20AM +0800, Chen, Tiejun wrote: On 2014/8/22 0:16, Konrad Rzeszutek Wilk wrote: On Thu, Aug 21, 2014 at 09:28:28AM +0800, Tiejun Chen wrote: Currenjly this ISA bridge should be fixed at 1f.0, and pass the Currently

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough

2014-08-25 Thread Chen, Tiejun
On 2014/8/25 13:18, Chen, Tiejun wrote: On 2014/8/24 19:12, Michael S. Tsirkin wrote: On Fri, Aug 22, 2014 at 09:06:20AM +0800, Chen, Tiejun wrote: On 2014/8/22 0:16, Konrad Rzeszutek Wilk wrote: On Thu, Aug 21, 2014 at 09:28:28AM +0800, Tiejun Chen wrote: Currenjly this ISA bridge should be

[Qemu-devel] [PATCH 1/1] Rename piix4_acpi_system_hot_add_init() to piix4_acpi_system_hotplug_init().

2014-08-27 Thread Tang Chen
piix4_acpi_system_hot_add_init() handles not only memory hot add initialization, but the whole memory hotplug initialization. So rename it to piix4_acpi_system_hotplug_init(). Signed-off-by: Tang Chen --- hw/acpi/piix4.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a

[Qemu-devel] [RESEND PATCH v3 0/8] QEmu memory hot unplug support.

2014-08-27 Thread Tang Chen
ine. qdev: Add memory hot unplug support for bus-less devices. pc-dimm: Add pc_dimm_unrealize() for memory hot unplug support. pc, acpi bios: Add memory hot unplug interface. monitor: Add memory hot unplug support for device_del command. Tang Chen (2): acpi, ich9: Add memory hot unp

  1   2   3   4   5   6   7   8   9   10   >