The properties reg/assigned-resources need to encode 64-bit memory
address space as part of phys.hi dword.
00 if configuration space
01 if IO region,
10 if 32-bit MEM region
11 if 64-bit MEM region
Signed-off-by: Nikunj A Dadhania
Reviewed-by: Thomas Huth
---
hw/ppc/spapr_pci.c | 10
Each hardware instance has a platform unique location code. The OF
device tree that describes a part of a hardware entity must include
the “ibm,loc-code” property with a value that represents the location
code for that hardware entity.
Populate ibm,loc-code.
1) PCI passthru devices need to
indentation (Alexey Kardashevskiy)
Nikunj A Dadhania (6):
spapr_pci: encode missing 64-bit memory address space
spapr_pci: encode class code including Prog IF register
spapr_pci: enumerate and add PCI device tree
spapr_pci: set device node unit address as hex
spapr_pci: populate ibm,loc-co
Current code missed the Prog IF register. All Class Code, Subclass,
and Prog IF registers are needed to identify the accurate device type.
For example: USB controllers use the PROG IF for denoting: USB
FullSpeed, HighSpeed or SuperSpeed.
Signed-off-by: Nikunj A Dadhania
Reviewed-by: Thomas Huth
backward compatibility, a flag
"qemu,phb-enumerated" is added to the phb, suggesting to SLOF to not
do device node creation.
Signed-off-by: Nikunj A Dadhania
[ Squashed Michael's drc_index changes ]
Signed-off-by: Michael Roth
Signed-off-by: Nikunj A Dadhania
---
hw/ppc/sp
* phb_index is not being used and if required can be obtained from sphb
* use helper to get drc_index in this function
Suggested-by: Alexey Kardashevskiy
Signed-off-by: Nikunj A Dadhania
---
hw/ppc/spapr_pci.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/hw
Thomas Huth writes:
> On Wed, 3 Jun 2015 16:55:56 +0530
> Nikunj A Dadhania wrote:
>
>> Each hardware instance has a platform unique location code. The OF
>> device tree that describes a part of a hardware entity must include
>> the “ibm,loc-code” property with
Alexander Graf writes:
> As of commit 076b35b5a (machine: add default_ram_size to machine class) we
> no longer have a global default ram size, but instead machine specific
> defaults. When invoking qemu --help we don't know which machine you selected,
> so we can't tell th
Current code missed the Prog IF register. All Class Code, Subclass,
and Prog IF registers are needed to identify the accurate device type.
For example: USB controllers use the PROG IF for denoting: USB
FullSpeed, HighSpeed or SuperSpeed.
Signed-off-by: Nikunj A Dadhania
Reviewed-by: Thomas Huth
T structure as local (David Gibson)
* Re-arrange code to avoid multiple indentation (Alexey Kardashevskiy)
Nikunj A Dadhania (6):
spapr_pci: encode missing 64-bit memory address space
spapr_pci: encode class code including Prog IF register
spapr_pci: enumerate and add PCI device tree
spapr_
* phb_index is not being used and if required can be obtained from sphb
* use helper to get drc_index in this function
Suggested-by: Alexey Kardashevskiy
Signed-off-by: Nikunj A Dadhania
---
hw/ppc/spapr_pci.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/hw
Each hardware instance has a platform unique location code. The OF
device tree that describes a part of a hardware entity must include
the “ibm,loc-code” property with a value that represents the location
code for that hardware entity.
Populate ibm,loc-code.
1) PCI passthru devices need to
The properties reg/assigned-resources need to encode 64-bit memory
address space as part of phys.hi dword.
00 if configuration space
01 if IO region,
10 if 32-bit MEM region
11 if 64-bit MEM region
Signed-off-by: Nikunj A Dadhania
Reviewed-by: Thomas Huth
---
hw/ppc/spapr_pci.c | 10
backward compatibility, a flag
"qemu,phb-enumerated" is added to the phb, suggesting to SLOF to not
do device node creation.
Signed-off-by: Nikunj A Dadhania
[ Squashed Michael's drc_index changes ]
Signed-off-by: Michael Roth
Signed-off-by: Nikunj A Dadhania
---
hw/ppc/sp
Device node names should encode the unit address as hex, while the
code was encodind it as integers.
Also, use FDT_NAME_MAX macro for allocating and composing the name.
Signed-off-by: Nikunj A Dadhania
Reviewed-by: Thomas Huth
---
hw/ppc/spapr_pci.c | 12 +++-
1 file changed, 7
On 18/09/2015 18:29, Claudio Fontana wrote:
> The Virtio Peer shared memory communication device (virtio-peer) is a
> virtual device which allows high performance low latency guest to guest
> communication. It uses a new queue extension feature tentatively called
> VIRTIO_F_
Alexander Graf writes:
> On 25.06.14 06:36, Nikunj A Dadhania wrote:
>> Nikunj A Dadhania writes:
>>
>>> Alexander Graf writes:
>>>
>>>> On 17.06.14 11:59, Nikunj A Dadhania wrote:
>>>>> Alexander Graf writes:
>>>>>&
Alexander Graf writes:
> On 25.06.14 13:27, Nikunj A Dadhania wrote:
>> Alexander Graf writes:
>>
>> Let me put down my understanding:
>>
>> There are two possible way to handle kernel panic:
>> 1) Kdump service running in guest - already working
>
Alexander Graf writes:
>> Am 26.06.2014 um 09:55 schrieb Nikunj A Dadhania :
>>
>> Alexander Graf writes:
>>
>>>> On 25.06.14 13:27, Nikunj A Dadhania wrote:
>>>> Alexander Graf writes:
>>>>
>>>> Let me put down my und
MAX_CPUS 256 is inconsistent with qemu supporting upto 255 cpus. This
MAX_CPUS number was percolated back to "virsh capabilities" with wrong
max_cpus.
Signed-off-by: Nikunj A Dadhania
---
hw/ppc/spapr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/ppc/spapr.
Useful for identifying the guest/host uniquely within the
guest. Adding following properties to the guest root node.
vm,uuid - uuid of the guest
host-model - Host model number
host-serial - Host machine serial number
hypervisor type - Tells its "kvm"
Signed-off-by: Nikunj A Dadhania
-
to make sure that a return to the linux kernel is gauranteed.
CC: Benjamin Herrenschmidt
CC: Anton Blanchard
CC: Alexander Graf
Signed-off-by: Nikunj A Dadhania
---
v2: rebase to ppcnext
v3: Do not stop the VM, and update comments
---
hw/ppc/spapr_rtas.c | 41
Alexey Kardashevskiy writes:
> On 06/27/2014 04:47 PM, Nikunj A Dadhania wrote:
>> PAPR compliant guest calls this in absence of kdump. This finally
>> reaches the guest and can be handled according to the policies set by
>> higher level tools(like taking dump) for further a
Nikunj A Dadhania writes:
> PAPR compliant guest calls this in absence of kdump. This finally
> reaches the guest and can be handled according to the policies set by
> higher level tools(like taking dump) for further analysis by tools like
> crash.
>
> Linux kernel calls
to make sure that a return to the linux kernel is gauranteed.
CC: Benjamin Herrenschmidt
CC: Anton Blanchard
CC: Alexander Graf
Signed-off-by: Nikunj A Dadhania
---
v2: rebase to ppcnext
v3: Do not stop the VM, and update comments
v4: update spapr_register_rtas and qapi_event changes
---
hw
Tyrel Datwyler writes:
> On 06/27/2014 12:37 AM, Nikunj A Dadhania wrote:
>> PAPR compliant guest calls this in absence of kdump. This finally
>> reaches the guest and can be handled according to the policies set by
>> higher level tools(like taking dump) for further a
makes sure that a return to the linux kernel is gauranteed.
CC: Benjamin Herrenschmidt
CC: Anton Blanchard
CC: Alexander Graf
CC: Tyrel Datwyler
Signed-off-by: Nikunj A Dadhania
---
v2: rebase to ppcnext
v3: Do not stop the VM, and update comments
v4: update spapr_register_rtas and qapi_event
Alexander Graf writes:
>> Am 30.06.2014 um 10:35 schrieb Nikunj A Dadhania :
>>
>> +static void rtas_ibm_os_term(PowerPCCPU *cpu,
>> +sPAPREnvironment *spapr,
>> +uint32_t token, uint32_t nargs,
>> +
Alexander Graf writes:
> On 30.06.2014, at 17:49, Tyrel Datwyler
> wrote:
>
>> On 06/30/2014 01:35 AM, Nikunj A Dadhania wrote:
>>> PAPR compliant guest calls this in absence of kdump. This finally
>>> reaches the guest and can be handled according to the polic
Alexey Kardashevskiy writes:
> On 06/30/2014 06:35 PM, Nikunj A Dadhania wrote:
>> PAPR compliant guest calls this in absence of kdump. This finally
>> reaches the guest and can be handled according to the policies set by
>> higher level tools(like taking dump) for further a
Alexey Kardashevskiy writes:
> diff --git a/hw/core/nmi.c b/hw/core/nmi.c
> new file mode 100644
> index 000..db1295f
> --- /dev/null
> +++ b/hw/core/nmi.c
> @@ -0,0 +1,84 @@
[...]
> +
> +static void nmi_children(Object *o, struct do_nmi_s *ns);
> +
[...]
>
Useful for identifying the guest/host uniquely within the
guest. Adding following properties to the guest root node.
vm,uuid - uuid of the guest
host-model - Host model number
host-serial - Host machine serial number
hypervisor type - Tells its "kvm"
Signed-off-by: Nikunj A Dadhani
Alexander Graf writes:
> On 08.07.14 13:04, Nikunj A Dadhania wrote:
>> Alexander Graf writes:
>>
>>> On 08.07.14 07:00, Nikunj A Dadhania wrote:
>>>> Useful for identifying the guest/host uniquely within the
>>>> guest. Adding following prop
Useful for identifying the guest/host uniquely within the
guest. Adding following properties to the guest root node.
vm,uuid - uuid of the guest
host-model - Host model number
host-serial - Host machine serial number
hypervisor type - Tells its "kvm"
Signed-off-by: Nikunj A Dadhani
Alexander Graf writes:
> On 08.07.14 07:00, Nikunj A Dadhania wrote:
>> Useful for identifying the guest/host uniquely within the
>> guest. Adding following properties to the guest root node.
>>
>> vm,uuid - uuid of the guest
>> host-model - Host model number
>
Nikunj A Dadhania writes:
> MAX_CPUS 256 is inconsistent with qemu supporting upto 255 cpus. This
> MAX_CPUS number was percolated back to "virsh capabilities" with wrong
> max_cpus.
Agraf, ping
David Gibson writes:
> On Thu, Jun 11, 2015 at 04:32:26PM +0530, Nikunj A Dadhania wrote:
>> All the PCI enumeration and device node creation was off-loaded to
>> SLOF. With PCI hotplug support, code needed to be added to add device
>> node. This creates multiple copy of the
backward compatibility, a flag
"qemu,phb-enumerated" is added to the phb, suggesting to SLOF to not
do device node creation.
Signed-off-by: Nikunj A Dadhania
[ Squashed Michael's drc_index changes ]
Signed-off-by: Michael Roth
Signed-off-by: Nikunj A Dadhania
---
hw/ppc/sp
ration for boot time device (Michael Roth)
Changelog v1:
* Correct indent problems reported by checkpatch(David Gibson)
* Declare sPAPRFDT structure as local (David Gibson)
* Re-arrange code to avoid multiple indentation (Alexey Kardashevskiy)
Nikunj A Dadhania (3):
spapr_pci: enumerate and add
Each hardware instance has a platform unique location code. The OF
device tree that describes a part of a hardware entity must include
the “ibm,loc-code” property with a value that represents the location
code for that hardware entity.
Populate ibm,loc-code.
1) PCI passthru devices need to
* phb_index is not being used and if required can be obtained from sphb
* use helper to get drc_index in spapr_populate_pci_child_dt()
* Check if drc_index is zero
Suggested-by: Alexey Kardashevskiy
Signed-off-by: Nikunj A Dadhania
---
hw/ppc/spapr_pci.c | 27 +++
1
Hi Zhi,
On Thu, 2012-07-12 at 14:59 +0800, Zhi Yong Wu wrote:
> thanks, it is applied to my vhost_scsi git tree
> git://github.com/wuzhy/qemu.git vhost-scsi
>
Thanks for picking up this patch in your vhost-scsi tree.
As mentioned off-list, I'd like to rebase to a more rece
From: Nicholas Bellinger
As requested by Anthony, here is a patch against target-pending/for-next-merge
to expose an ABI version to userspace via a new VHOST_SCSI_GET_ABI_VERSION
ioctl operation.
As mentioned in the comment, ABI Rev 0 is for pre 2012 out-of-tree code, and
ABI Rev 1 (the current
From: Nicholas Bellinger
Hi Anthony,
Here are the two patches against Zhi's vhost-scsi tree to check for
a supported version (VHOST_SCSI_ABI_VERSION=1) that's now exposed via
the tcm_vhost ioctl.
Please have a look and let me know if this is what you had in mind.
Thanks!
Nicholas
From: Nicholas Bellinger
Rename the main IOCTL structure to vhost_scsi_target so that
it makes a little more sense than vhost_vring_target.
As requested by MST.
Reported-by: Michael S. Tsirkin
Cc: Stefan Hajnoczi
Cc: Anthony Liguori
Cc: Paolo Bonzini
Cc: Zhi Yong Wu
Signed-off-by
/vhost-scsi.c | 17 +
hw/vhost-scsi.h | 11 +++
2 files changed, 28 insertions(+), 0 deletions(-)
diff --git a/hw/vhost-scsi.c b/hw/vhost-scsi.c
index 3e9fa0e..9ab314c 100644
--- a/hw/vhost-scsi.c
+++ b/hw/vhost-scsi.c
@@ -68,6 +68,23 @@ int vhost_scsi_start(VHostSC
roperties
virtio-scsi: Open and initialize /dev/vhost-scsi
virtio-scsi: Start/stop vhost
vhost-scsi: add -vhost-scsi host device
However, thus far I've not been able to get virtio-scsi <-> tcm_vhost
I/O to actually work against the latest qemu.git/master..
So while doing a (manua
On Tue, 2012-07-24 at 09:57 +0200, Jan Kiszka wrote:
> On 2012-07-24 09:42, Nicholas A. Bellinger wrote:
> > Hi Anthony, Stefan & QEMU folks,
> >
> > However, thus far I've not been able to get virtio-scsi <-> tcm_vhost
> > I/O to actual
On Mon, 2012-07-23 at 18:56 -0700, Greg Kroah-Hartman wrote:
> On Tue, Jul 24, 2012 at 01:26:20AM +, Nicholas A. Bellinger wrote:
> > From: Nicholas Bellinger
> >
> > As requested by Anthony, here is a patch against
> > target-pending/for-next-merge
> > to e
On Tue, 2012-07-24 at 13:20 -0700, Nicholas A. Bellinger wrote:
> On Tue, 2012-07-24 at 09:57 +0200, Jan Kiszka wrote:
> > On 2012-07-24 09:42, Nicholas A. Bellinger wrote:
> > > Hi Anthony, Stefan & QEMU folks,
> > >
>
>
>
> > > Howeve
From: Nicholas Bellinger
This QEMU patch sets VirtIOSCSIConfig->max_target=0 for vhost-scsi operation
to restrict virtio-scsi LLD guest scanning to max_id=0 (a single target ID
instance) when connected to individual tcm_vhost endpoints.
This ensures that virtio-scsi LLD only attempts to s
From: Stefan Hajnoczi
This patch adds a new type of host device that drives the vhost_scsi
device. The syntax to add vhost-scsi is:
qemu -vhost-scsi id=vhost-scsi0,wwpn=...,tpgt=123
The virtio-scsi emulated device will make use of vhost-scsi to process
virtio-scsi requests inside the kernel
From: Stefan Hajnoczi
A vhost-scsi device must be bound to a tcm_vhost target port. This will
be done by issuing an ioctl to the device with the wwpn and tgpt. This
patch adds these properties to the virtio-scsi-pci device:
qemu -device virtio-scsi-pci,wwpn=$TARGET_WWN,tgpt=$TPGT
Future
From: Nicholas Bellinger
Hi Anthony + QEMU storage folks,
The following is a reviewable RFC series of vhost-scsi against yesterday's
QEMU.git/master @ commit 401a66357d.
The series is available directly from:
git://git.kernel.org/pub/scm/virt/kvm/nab/qemu-kvm.git vhost-scsi-merg
From: Stefan Hajnoczi
For sanity assert that event notification succeeds.
Signed-off-by: Stefan Hajnoczi
Cc: Anthony Liguori
Cc: Paolo Bonzini
Signed-off-by: Nicholas Bellinger
---
hw/virtio-pci.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/hw/virtio-pci.c
From: Stefan Hajnoczi
Event notifiers that have not had the event_notifier_init() function
called on them are invalid. The event_notifier_valid() function checks
whether or not an event notifier is valild. This can be used to check
whether a notifier is in use or not.
It sometimes useful to
mode is
disabled.
Signed-off-by: Stefan Hajnoczi
Cc: Anthony Liguori
Cc: Paolo Bonzini
Signed-off-by: Nicholas Bellinger
---
hw/virtio-pci.c | 23 ---
hw/virtio.c |7 +++
2 files changed, 27 insertions(+), 3 deletions(-)
diff --git a/hw/virtio-pci.c b/hw/v
insertions(+), 1 deletions(-)
diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c
index 0f0f766..64f2f0d 100644
--- a/hw/virtio-pci.c
+++ b/hw/virtio-pci.c
@@ -1060,6 +1060,8 @@ static int virtio_scsi_exit_pci(PCIDevice *pci_dev)
}
static Property virtio_scsi_properties
12
1 files changed, 12 insertions(+), 0 deletions(-)
diff --git a/hw/virtio-scsi.c b/hw/virtio-scsi.c
index 4a787d3..dea3269 100644
--- a/hw/virtio-scsi.c
+++ b/hw/virtio-scsi.c
@@ -18,6 +18,7 @@
#include "virtio-scsi.h"
#include
#include
+#include "vhost.h"
#def
: Nicholas Bellinger
---
hw/vhost.c |5 +++--
hw/vhost.h |3 ++-
hw/vhost_net.c |2 +-
3 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/hw/vhost.c b/hw/vhost.c
index 0fd8da8..d0ce5aa 100644
--- a/hw/vhost.c
+++ b/hw/vhost.c
@@ -747,14 +747,15 @@ static void
On Wed, 2012-07-25 at 16:10 +0300, Avi Kivity wrote:
> On 07/24/2012 11:45 PM, Nicholas A. Bellinger wrote:
>
> >> > diff --git a/drivers/vhost/tcm_vhost.h b/drivers/vhost/tcm_vhost.h
> >> > index e942df9..3d5378f 100644
> >> > --- a/drivers/vh
On Wed, 2012-07-25 at 12:55 +0100, Stefan Hajnoczi wrote:
> On Tue, Jul 24, 2012 at 01:45:24PM -0700, Nicholas A. Bellinger wrote:
> > On Mon, 2012-07-23 at 18:56 -0700, Greg Kroah-Hartman wrote:
> > > On Tue, Jul 24, 2012 at 01:26:20AM +, Nicholas A. Bellinger wrote:
>
On Wed, 2012-07-25 at 23:35 +0100, Stefan Hajnoczi wrote:
> On Wed, Jul 25, 2012 at 02:14:50PM -0700, Nicholas A. Bellinger wrote:
> > On Wed, 2012-07-25 at 12:55 +0100, Stefan Hajnoczi wrote:
> > > On Tue, Jul 24, 2012 at 01:45:24PM -0700, Nicholas A. Bellinger wrote:
> >
On Thu, 2012-07-26 at 11:58 +0300, Avi Kivity wrote:
> On 07/26/2012 05:34 AM, Nicholas A. Bellinger wrote:
> >
> > In that case, respinning a -v5 for tcm_vhost to start from ABI=0 and
> > will post an updated patch shortly.
> >
> >> The main thing I wou
From: Nicholas Bellinger
Hello KVM + QEMU folks,
This is -v5 of the in-flight tcm_vhost fabric driver for KVM host virtualized
target support using the in-kernel storage stack with for-3.6 code.
The changes since -v4 have been pretty minimal. A new GET_ABI_VERSION ioctl
has been added as
Hello folks,
The RFC-v5 patch for tcm_vhost kernel code was sent out for review a bit
less than 24 hours ago, and thus far there has not been any additional
comments.. Thanks to everyone who has been participating in the various
threads over the past week and giving their feedback!
Also, just a
: Stefan Hajnoczi
Cc: Anthony Liguori
Cc: Zhi Yong Wu
Cc: Paolo Bonzini
Signed-off-by: Nicholas Bellinger
---
drivers/vhost/tcm_vhost.c | 195
drivers/vhost/tcm_vhost.h | 9 +-
2 files changed, 111 insertions(+), 93 deletions(-)
diff --git a/dr
Hi Linus,
Here is the PULL request for the initial merge of tcm_vhost based on
RFC-v5 code with MST's ACK appended to the initial merge commit.
As promised, the commit is available from two different branches for you
to consider merging as for-3.6 code.
The 'for-next-merge' branch based on mainli
Hi Linus,
Ping on the initial tcm_vhost merge for-3.6..? I know it's been a
busier than usual merge window, but hopefully this one is still in your
PULL queue..
Otherwise if there is something else that you'd like to see different
from this PULL request, please let us know.
Thank y
> 122afea9626ab3f717b250a8dd3d5ebf57cdb56c - works (just before Kirill
> > disables THP)
> > 61f5d698cc97600e813ca5cf8e449b1ea1c11492 - breaks (when THP is reenabled)
> >
> > It's pretty reliable; as you say disabling THP makes it work again
> > and putting it back to
On Fri, Apr 15, 2016 at 02:42:33PM +0100, Dr. David Alan Gilbert wrote:
> * Kirill A. Shutemov (kir...@shutemov.name) wrote:
> > On Thu, Apr 14, 2016 at 12:22:30PM -0400, Andrea Arcangeli wrote:
> > > Adding linux-mm too,
> > >
> > > On Thu, Apr 14, 2016
On Wed, Apr 27, 2016 at 02:04:46PM +0200, Andrea Arcangeli wrote:
> After the THP refcounting change, obtaining a compound pages from
> get_user_pages() no longer allows us to assume the entire compound
> page is immediately mappable from a secondary MMU.
>
> A secondary MMU doesn
On Wed, Apr 27, 2016 at 04:59:57PM +0200, Andrea Arcangeli wrote:
> On Wed, Apr 27, 2016 at 04:50:30PM +0300, Kirill A. Shutemov wrote:
> > I know nothing about kvm. How do you protect against pmd splitting between
> > get_user_pages() and the check?
>
> get_user_pages_fast(
Benjamin Herrenschmidt (11):
ppc/xics: Rename existing xics to xics_spapr
ppc/xics: Move SPAPR specific code to a separate file
ppc/xics: Implement H_IPOLL using an accessor
ppc/xics: Remove unused xics_set_irq_type()
ppc/xics: Replace "icp" with "xics" in most places
From: Benjamin Herrenschmidt
Signed-off-by: Benjamin Herrenschmidt
Reviewed-by: David Gibson
Signed-off-by: Nikunj A Dadhania
---
hw/intc/xics.c| 11 ---
include/hw/ppc/xics.h | 1 -
2 files changed, 12 deletions(-)
diff --git a/hw/intc/xics.c b/hw/intc/xics.c
index 40969ee
From: Benjamin Herrenschmidt
This will make life easier for dealing with dynamically configured
ICSes such as PHB3
Signed-off-by: Benjamin Herrenschmidt
Reviewed-by: David Gibson
Signed-off-by: Nikunj A Dadhania
---
include/hw/ppc/xics.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion
From: Benjamin Herrenschmidt
The "ICP" is a different object than the "XICS". For historical reasons,
we have a number of places where we name a variable "icp" while it contains
a XICSState pointer. There *is* an ICPState structure too so this makes
the cod
From: Benjamin Herrenschmidt
Leave the core ICP/ICS logic in xics.c and move the top level
class wrapper, hypercall and RTAS handlers to xics_spapr.c
Signed-off-by: Benjamin Herrenschmidt
[add cpu.h in xics_spapr.c, move set_nr_irqs and set_nr_servers to
xics_spapr.c]
Signed-off-by: Nikunj A
From: Benjamin Herrenschmidt
None of the other presenter functions directly mucks with the
internal state, so don't do it there either.
Signed-off-by: Benjamin Herrenschmidt
Signed-off-by: Nikunj A Dadhania
---
hw/intc/xics.c| 8
hw/intc/xics_spapr.c | 7 ---
inclu
From: Benjamin Herrenschmidt
Useful to debug interrupt problems.
Signed-off-by: Benjamin Herrenschmidt
Signed-off-by: Nikunj A Dadhania
---
hmp-commands-info.hx | 2 ++
hw/intc/xics.c| 38 ++
hw/ppc/ppc.c | 14 ++
include/hw
From: Benjamin Herrenschmidt
The common class doesn't change, the KVM one is sPAPR specific. Rename
variables and functions to xics_spapr.
Retain the type name as "xics" to preserve migration for existing sPAPR
guests.
Signed-off-by: Benjamin Herrenschmidt
Signed-off-by: Ni
From: Benjamin Herrenschmidt
Signed-off-by: Benjamin Herrenschmidt
[Move object allocation and adding child to the helper]
Signed-off-by: Nikunj A Dadhania
---
hw/intc/xics.c| 10 ++
hw/intc/xics_spapr.c | 7 +--
include/hw/ppc/xics.h | 1 +
3 files changed, 12
From: Benjamin Herrenschmidt
This provides MMIO based ICP access as found on POWER8
Signed-off-by: Benjamin Herrenschmidt
Signed-off-by: Nikunj A Dadhania
---
default-configs/ppc64-softmmu.mak | 3 +-
hw/intc/Makefile.objs | 1 +
hw/intc/xics_native.c | 295
From: Benjamin Herrenschmidt
Instead of an array of fixed sized blocks, use a list, as we will need
to have sources with variable number of interrupts. SPAPR only uses
a single entry. Native will create more. If performance becomes an
issue we can add some hashed lookup but for now this will do
Signed-off-by: Nikunj A Dadhania
---
hw/intc/xics.c| 101 +-
hw/intc/xics_spapr.c | 36 ++
include/hw/ppc/xics.h | 11 +-
3 files changed, 97 insertions(+), 51 deletions(-)
diff --git a/hw/intc/xics.c b/hw/intc/xics.c
David Gibson writes:
> diff --git a/include/hw/ppc/xics.h b/include/hw/ppc/xics.h
>> index 9091054..452a978 100644
>> --- a/include/hw/ppc/xics.h
>> +++ b/include/hw/ppc/xics.h
>> @@ -32,20 +32,24 @@
>> #define TYPE_XICS_COMMON "xics-common"
>>
David Gibson writes:
> [ Unknown signature status ]
> On Thu, Jun 23, 2016 at 11:17:21PM +0530, Nikunj A Dadhania wrote:
>> From: Benjamin Herrenschmidt
>>
>> Leave the core ICP/ICS logic in xics.c and move the top level
>> class wrapper, hypercall and
Alexander Graf writes:
>> Am 30.04.2015 um 11:40 schrieb Thomas Huth :
>> On Thu, 30 Apr 2015 11:18:05 +0200
>> Alexander Graf wrote:
>>>> On 30.04.15 06:41, Nikunj A Dadhania wrote:
>>>>
>>>> Hi Paolo,
>>>>
>>>
Current DEFAULT_RAM_SIZE(128MB) enforced by QEMU would not work for
all machines. Introduce a default_ram_size as part of MachineClass.
The below patches has following behaviour:
1) If the user does not provide "-m" option, machine's default ram
size will be picked.
2) The de
Machines types can have different requirement for default ram
size. Introduce a member in the machine class and set the current
default_ram_size to 128MB.
For QEMUMachine types override the value during the registration of
the machine and for MachineClass introduce the generic class init
setting
Signed-off-by: Nikunj A Dadhania
Reviewed-by: Igor Mammedov
Reviewed-by: Thomas Huth
Acked-by: David Gibson
---
hw/ppc/spapr.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index 61ddc79..7fbbae6 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -1794,6
Nikunj A Dadhania writes:
> The patch series creates PCI device tree(DT) nodes in QEMU. The new
> hotplug code needs the device node creation in QEMU. While during
> boot, nodes were created in SLOF. It makes more sense to consolidate
> the code to one place for better maintainabilit
tplug
Nikunj A Dadhania (5):
spapr_pci: remove duplicate macros
spapr_pci: encode missing 64-bit memory address space
spapr_pci: encode class code including Prog IF register
spapr_pci: enumerate and add PCI device tree
spapr_pci: populate ibm,loc-code
hw/ppc/spapr_pci.c
Signed-off-by: Nikunj A Dadhania
---
hw/ppc/spapr_pci.c | 11 ---
1 file changed, 11 deletions(-)
diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c
index 2e7590c..4df3a33 100644
--- a/hw/ppc/spapr_pci.c
+++ b/hw/ppc/spapr_pci.c
@@ -1475,17 +1475,6 @@ PCIHostState *spapr_create_phb
The properties reg/assigned-resources need to encode 64-bit memory
address space as part of phys.hi dword.
00 if configuration space
01 if IO region,
10 if 32-bit MEM region
11 if 64-bit MEM region
Signed-off-by: Nikunj A Dadhania
---
hw/ppc/spapr_pci.c | 10 +-
1 file changed
backward compatibility, a flag
"qemu,phb-enumerated" is added to the phb, suggesting to SLOF to not
do device node creation.
Signed-off-by: Nikunj A Dadhania
---
hw/ppc/spapr_pci.c | 108 ++---
1 file changed, 103 insertions(+), 5 deletion
Current code missed the Prog IF register. All Class Code, Subclass,
and Prog IF registers are needed to identify the accurate device type.
For example: USB controllers use the PROG IF for denoting: USB
FullSpeed, HighSpeed or SuperSpeed.
Signed-off-by: Nikunj A Dadhania
---
hw/ppc/spapr_pci.c
backward compatibility, a flag
"qemu,phb-enumerated" is added to the phb, suggesting to SLOF to not
do device node creation.
Signed-off-by: Nikunj A Dadhania
---
hw/ppc/spapr_pci.c | 108 ++---
1 file changed, 103 insertions(+), 5 deletion
Each hardware instance has a platform unique location code. The OF
device tree that describes a part of a hardware entity must include
the “ibm,loc-code” property with a value that represents the location
code for that hardware entity.
Populate ibm,loc-code.
1) PCI passthru devices need to
From: Michael Roth
We need to set the proper drc_index values in ibm,my-drc-index
fields in order to allow a PCI device that was present at
boot-time to be unplugged.
Previously SLOF handles this, but with QEMU handling the DT we
need to do it there as well.
This patch slightly changes how
401 - 500 of 2369 matches
Mail list logo
