[Qemu-devel] [PATCH v2] ppc: spapr-rtas - implement os-term rtas call

2014-06-12 Thread Nikunj A Dadhania
PAPR compliant guest calls this in absence of kdump. After receiving this call qemu could trigger a guest dump. This guest dump can be used to analyse using crash tool. Signed-off-by: Nikunj A Dadhania --- v2: indentation fixes hw/ppc/spapr_rtas.c | 32 1 file

Re: [Qemu-devel] [PATCH v2] ppc: spapr-rtas - implement os-term rtas call

2014-06-17 Thread Nikunj A Dadhania
Alexander Graf writes: > On 12.06.14 14:09, Nikunj A Dadhania wrote: >> PAPR compliant guest calls this in absence of kdump. After >> receiving this call qemu could trigger a guest dump. This guest dump >> can be used to analyse using crash tool. >> >>

Re: [Qemu-devel] [PATCH v2] ppc: spapr-rtas - implement os-term rtas call

2014-06-17 Thread Nikunj A Dadhania
Alexander Graf writes: > On 17.06.14 11:30, Nikunj A Dadhania wrote: >> Alexander Graf writes: >> >>> On 12.06.14 14:09, Nikunj A Dadhania wrote: >>>> PAPR compliant guest calls this in absence of kdump. After >>>> receiving this call qemu could t

Re: [Qemu-devel] [PATCH v2] ppc: spapr-rtas - implement os-term rtas call

2014-06-17 Thread Nikunj A Dadhania
Alexander Graf writes: > On 17.06.14 11:59, Nikunj A Dadhania wrote: >> Alexander Graf writes: >>> On 17.06.14 11:30, Nikunj A Dadhania wrote: >>>> Alexander Graf writes: >>>>>> +spapr_rtas_register("ibm,os-term", rtas_ibm_os_te

Re: [Qemu-devel] [PATCH v2] ppc: spapr-rtas - implement os-term rtas call

2014-06-24 Thread Nikunj A Dadhania
Nikunj A Dadhania writes: > Alexander Graf writes: > >> On 17.06.14 11:59, Nikunj A Dadhania wrote: >>> Alexander Graf writes: >>>> On 17.06.14 11:30, Nikunj A Dadhania wrote: >>>>> Alexander Graf writes: > >>>&

Re: [Qemu-devel] commit 08521e2 breaks SLOF usb boot

2013-07-24 Thread Nikunj A Dadhania
Paolo Bonzini writes: > Il 14/06/2013 12:32, Nikunj A Dadhania ha scritto: >> Nikunj A Dadhania writes: >>> commit 08521e28c7e6e8cc1f53424a0f845f58d2ed9546 >>> Author: Paolo Bonzini >>> Date: Fri May 24 12:54:01 2013 +0200 >>&

Re: [Qemu-devel] [Qemu-ppc] [PATCH 6/9] spapr: Add ibm, client-architecture-support call

2014-05-18 Thread Nikunj A Dadhania
Alexey Kardashevskiy writes: > The PAPR+ specification defines a ibm,client-architecture-support (CAS) > RTAS call which purpose is to provide a negotiation mechanism for > the guest and the hypervisor to work out the best compatibility parameters. > During the negotiation proces

Re: [Qemu-devel] [PATCH v2 RESEND] Add skip_dump flag to ignore memory region during dump

2014-10-29 Thread Nikunj A Dadhania
Nikunj A Dadhania writes: > The PCI MMIO might be disabled or the device in the reset state. > Make sure we do not dump these memory regions. > > Signed-off-by: Nikunj A Dadhania > Acked-by: Alex Williamson > CC: Paolo Bonzini > --- > > Resending, missed to CC Paolo Ping? Regards Nikunj

Re: [Qemu-devel] [PATCH] virtio-pci: enable bus master for old guests

2014-09-10 Thread Nikunj A Dadhania
n top. >> >> Cc: qemu-sta...@nongnu.org >> Reported-by: Greg Kurz >> Signed-off-by: Jan Kiszka >> Signed-off-by: Michael S. Tsirkin >> --- >> hw/virtio/virtio-pci.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/

Re: [Qemu-devel] [PATCH] virtio-pci: enable bus master for old guests

2014-09-10 Thread Nikunj A Dadhania
above you are talking about virtio-net and here it is >> > virtio-blk. >> > >> > Anyways, the routines still remains same for both of them. From SLOF >> > during init we set DRIVER_OK, and after using the device during the >> > quiesce, called from linu

Re: [Qemu-devel] [PATCH] virtio-pci: enable bus master for old guests

2014-09-10 Thread Nikunj A Dadhania
"Michael S. Tsirkin" writes: > On Wed, Sep 10, 2014 at 01:44:49PM +0530, Nikunj A Dadhania wrote: >> Greg Kurz writes: >> >> > On Mon, 8 Sep 2014 19:05:02 +0300 >> > "Michael S. Tsirkin" wrote: >> > >> >> commit cc94

[Qemu-devel] [PATCH] Skip vfio mmap bar regions during memory dump

2014-09-11 Thread Nikunj A Dadhania
The PCI MMIO might be disabled or the device in the reset state. Make sure we do not dump these memory regions. Signed-off-by: Nikunj A Dadhania --- hw/misc/vfio.c| 2 +- include/exec/memory.h | 27 +++ memory.c | 16

Re: [Qemu-devel] [PATCH] Skip vfio mmap bar regions during memory dump

2014-09-12 Thread Nikunj A Dadhania
Alex Williamson writes: > On Fri, 2014-09-12 at 10:12 +0530, Nikunj A Dadhania wrote: >> The PCI MMIO might be disabled or the device in the reset state. >> Make sure we do not dump these memory regions. >> >> Signed-off-by: Nikunj A Dadhania >> --- >

[Qemu-devel] [PATCH v2] Add skip_dump flag to ignore memory region during dump

2014-09-12 Thread Nikunj A Dadhania
The PCI MMIO might be disabled or the device in the reset state. Make sure we do not dump these memory regions. Signed-off-by: Nikunj A Dadhania --- V1: * Make the flag generic in place of using vfio_mmap (Alex) hw/misc/vfio.c| 1 + include/exec/memory.h | 19

[Qemu-devel] [PATCH v2 RESEND] Add skip_dump flag to ignore memory region during dump

2014-09-14 Thread Nikunj A Dadhania
The PCI MMIO might be disabled or the device in the reset state. Make sure we do not dump these memory regions. Signed-off-by: Nikunj A Dadhania Acked-by: Alex Williamson CC: Paolo Bonzini --- Resending, missed to CC Paolo V1: * Make the flag generic in place of using vfio_mmap (Alex

Re: [Qemu-devel] [PATCH] virtio-scsi: fix object check failure

2014-07-25 Thread Nicholas A. Bellinger
gt;>> > This should never be triggered by vhost-scsi. Perhaps a bug in the > >>>> kernel? > >>> > >>> It can be triggered with rmmod, system suspend, reboot... > >> > >> > >> Yes, but it should not. > >> > >> What

Re: [Qemu-devel] [SeaBIOS] Time to cut a new release?

2011-08-05 Thread Jonathan A. Kollasch
On Fri, Aug 05, 2011 at 04:59:44PM -0600, Marc Jones wrote: > On Thu, Aug 4, 2011 at 7:19 PM, Kevin O'Connor wrote: > > On Thu, Aug 04, 2011 at 02:10:10PM -0500, Anthony Liguori wrote: > >> On 08/04/2011 01:49 PM, Gerd Hoffmann wrote: > >> >Hi, > >> &g

[Qemu-devel] Building qemu.exe on cygwin (0.15.0)

2011-08-18 Thread Rolando A. Lopez
nt is a good sign, considering the amount of changes included in the windows patch for 0.13.0 (or 0.15.0 also needs heavy modifying to be builded on cygwin??) The error are related to multeple definition of _sin, _cos and other related math functions in libmsvcrt.a. I found some info about

Re: [Qemu-devel] IO performance test on the tcm-vhost scsi

2012-06-13 Thread Nicholas A. Bellinger
te > rand-read/write = random read/write > 8k,256k are blocksize of the IO > > In tcm-vhost-iblock test, the emulate_write_cache attr was enabled. > In virtio-blk test, cache=none,aio=native were set. > In scsi-disk test, cache=none,aio=native were set, and LSI HBA was used.

Re: [Qemu-devel] IO performance test on the tcm-vhost scsi

2012-06-14 Thread Nicholas A. Bellinger
On Thu, 2012-06-14 at 17:57 +0800, Cong Meng wrote: > On Wed, 2012-06-13 at 12:08 -0700, Nicholas A. Bellinger wrote: > > On Wed, 2012-06-13 at 18:13 +0800, mengcong wrote: > > > Hi folks, I did an IO performance test on the tcm-vhost scsi. I want to > > > share >

Re: [Qemu-devel] IO performance test on the tcm-vhost scsi

2012-06-14 Thread Nicholas A. Bellinger
ing, I would have expected virtio-blk to be faster! > > Yes, I would have expected something similar. A blktrace would be > useful here because Asias measured the opposite---virtio-scsi being much > slower than virtio-blk. > > > The second question is why is tcm_vhost faster than v

Re: [Qemu-devel] [PATCH 00/16] QEMU vhost-scsi support

2012-04-19 Thread Nicholas A. Bellinger
On Thu, 2012-04-19 at 07:30 -0500, Anthony Liguori wrote: > Hi, > Hi Anthony, > As I've mentioned before in the past, I will apply vhost-* without an > extremely > compelling argument for it. > > The reason we ultimately settled on vhost-net is that in the absence

Re: [Qemu-devel] [PATCH 00/16] QEMU vhost-scsi support

2012-04-20 Thread Nicholas A. Bellinger
On Thu, 2012-04-19 at 19:20 -0500, Anthony Liguori wrote: > Hi Nicholas, > > On 04/19/2012 06:53 PM, Nicholas A. Bellinger wrote: > > On Thu, 2012-04-19 at 07:30 -0500, Anthony Liguori wrote: > >> However, for storage, be it scsi or direct access, the same problem r

Re: [Qemu-devel] [PATCH 00/16] QEMU vhost-scsi support

2012-04-20 Thread Nicholas A. Bellinger
On Fri, 2012-04-20 at 17:50 +1000, ronnie sahlberg wrote: > On Fri, Apr 20, 2012 at 5:00 PM, Nicholas A. Bellinger > wrote: > > On Thu, 2012-04-19 at 19:20 -0500, Anthony Liguori wrote: > >> Hi Nicholas, > >> > > The argument that a SCSI target for virtua

Re: [Qemu-devel] [PATCH 00/16] QEMU vhost-scsi support

2012-04-21 Thread Nicholas A. Bellinger
On Fri, 2012-04-20 at 12:09 +0100, Stefan Hajnoczi wrote: > On Fri, Apr 20, 2012 at 8:46 AM, Paolo Bonzini wrote: > > Il 20/04/2012 09:00, Nicholas A. Bellinger ha scritto: > > - no support for migration (there can be pending SCSI requests at > > migration time, that ne

Re: [Qemu-devel] [BREAKAGE] KVM pulls break MinGW builds

2011-06-24 Thread Jonathan A. Kollasch
On Thu, Jun 23, 2011 at 08:41:15AM +0800, Roy Tam wrote: > The pulls makes KVM enabled by default, which is not available in > MinGW(Win32) environment. Even through I put --disable-kvm switch in > ./configure, I still can't get QEMU compiled: > Similar issues on NetBSD. Jonathan Kollasc

[Qemu-devel] SSH console for qemu

2011-07-06 Thread Nikita A Menkovich
Hello, I'm using qemu with libvirt and I want to create SSH emergency console to linux/unix guests, same way as it is realized in qemu VNC. Maybe someone could help me to determine a place to dive in this question. I think the best way to make it - extend qemu API. But if this could be made

Re: [Qemu-devel] SSH console for qemu

2011-07-07 Thread Nikita A Menkovich
. On 6 July 2011 19:27, Stefan Hajnoczi wrote: > On Wed, Jul 6, 2011 at 3:08 PM, Nikita A Menkovich > wrote: >> I'm using qemu with libvirt and I want to create SSH emergency console >> to linux/unix guests, same way as it is realized in qemu VNC. >> Maybe someone

Re: [Qemu-devel] [libvirt-users] SSH console for qemu

2011-07-07 Thread Nikita A Menkovich
I want to launch very minimal ssh daemon (that listen on selected port and allows only input commands and read output from console) that launch when guest started, and this not run inside a guest. Thanks to the link for patch On 7 July 2011 22:19, Eric Blake wrote: > On 07/07/2011 02:36

Re: [Qemu-devel] [PATCH] spapr: skip adding usb keyboard/mouse in case of -nodefaults

2014-04-03 Thread Nikunj A Dadhania
his breaks libvirt which uses -nodefaults and adds the keyboard and mouse separately. The machine got 2 USB Keyboards and 2 USB Mouses. CC: Paolo Bonzini CC: Mark Wu CC: Andreas Färber Signed-off-by: Nikunj A Dadhania --- Removed the debug statement and fixed indentation breakage: hw/p

Re: [Qemu-devel] [PATCH] spapr: skip adding usb keyboard/mouse in case of -nodefaults

2014-04-03 Thread Nikunj A Dadhania
Andreas Färber writes: > Am 03.04.2014 18:56, schrieb Nikunj A Dadhania: >> The following commit caused the regression in qemu-system-ppc64 >> >> 7effdaa3: spapr: Fix return value of vga initialization >> d44229c5: Fix vga_interface_type for command line argument &#x

[Qemu-devel] [PATCH] spapr: skip adding usb keyboard/mouse in case of -nodefaults

2014-04-03 Thread Nikunj A Dadhania
his breaks libvirt which uses -nodefaults and adds the keyboard and mouse separately. The machine got 2 USB Keyboards and 2 USB Mouses. CC: Paolo Bonzini CC: Mark Wu CC: Andreas Färber Signed-off-by: Nikunj A Dadhania --- hw/ppc/spapr.c | 6 +- include/sysemu/sysemu.h |

Re: [Qemu-devel] [PATCH] spapr: skip adding usb keyboard/mouse in case of -nodefaults

2014-04-03 Thread Nikunj A Dadhania
Paolo Bonzini writes: > Il 03/04/2014 18:56, Nikunj A Dadhania ha scritto: >> The following commit caused the regression in qemu-system-ppc64 >> >> 7effdaa3: spapr: Fix return value of vga initialization >> d44229c5: Fix vga_interface_type for command line argument &#

Re: [Qemu-devel] [PATCH] spapr: skip adding usb keyboard/mouse in case of -nodefaults

2014-04-03 Thread Nikunj A Dadhania
Paolo Bonzini writes: > Il 03/04/2014 21:24, Nikunj A Dadhania ha scritto: >>> > Does libvirt use "-nodefaults -machine usb=true"? It should create the >>> > OHCI controller separately instead of using "-machine". >> I see it creating: >

Re: [Qemu-devel] [PATCH] spapr: skip adding usb keyboard/mouse in case of -nodefaults

2014-04-04 Thread Nikunj A Dadhania
Markus Armbruster writes: > Nikunj A Dadhania writes: > > Have you considered extending QEMUMachineInitArgs instead of adding this > function? Did not think of this option earlier. You mean doing something like this? diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index 3a13231..93

Re: [Qemu-devel] [PATCH] spapr: skip adding usb keyboard/mouse in case of -nodefaults

2014-04-04 Thread Nikunj A Dadhania
Paolo Bonzini writes: > Il 04/04/2014 07:28, Nikunj A Dadhania ha scritto: >>>> >> >>>> >> And -usb is translated to adding "pci-ohci" controller for spapr >>> > >>> > Yeah, but with -nodefaults it's better to use -dev

Re: [Qemu-devel] [RESEND-try-2][PATCH] hw/9pfs: fix P9_STATS_GEN handling

2013-12-23 Thread Kirill A. Shutemov
Aneesh Kumar K.V wrote: > "Kirill A. Shutemov" writes: > > > Kirill A. Shutemov wrote: > >> Currently we have few issues with P9_STATS_GEN: > >> > >> - We don't try to read st_gen anything except files or directories, but > >>

Re: [Qemu-devel] MSI interrupt support with vioscsi.c miniport driver

2014-02-18 Thread Nicholas A. Bellinger
On Mon, 2014-02-10 at 11:05 -0800, Nicholas A. Bellinger wrote: > > > > Hi Yan, > > > > > > > > So recently I've been doing some KVM guest performance comparisons > > > > between the scsi-mq prototype using virtio-scsi + vhost-scsi, and >

Re: [Qemu-devel] MSI interrupt support with vioscsi.c miniport driver

2014-02-18 Thread Nicholas A. Bellinger
On Tue, 2014-02-18 at 13:00 -0800, Nicholas A. Bellinger wrote: > On Mon, 2014-02-10 at 11:05 -0800, Nicholas A. Bellinger wrote: > > > > > > > > Hi Yan, > > > > > > > > > > So recently I've been doing some KVM guest performance co

Re: [Qemu-devel] MSI interrupt support with vioscsi.c miniport driver

2014-02-19 Thread Nicholas A. Bellinger
On Wed, 2014-02-19 at 19:03 +1100, Vadim Rozenfeld wrote: > On Tue, 2014-02-18 at 13:00 -0800, Nicholas A. Bellinger wrote: > > On Mon, 2014-02-10 at 11:05 -0800, Nicholas A. Bellinger wrote: > > > > > > > > > > > > Hi Yan, > > > > &g

Re: [Qemu-devel] [Qemu-ppc] [PATCH 00/28] target-ppc: Altivec 2.07

2014-02-23 Thread Nikunj A Dadhania
esolved in current SLOF tree, Alexey has submitted a latest slof.bin for upstreaming. Regards Nikunj

Re: [Qemu-devel] [Qemu-ppc] [PATCH 00/28] target-ppc: Altivec 2.07

2014-02-26 Thread Nikunj A Dadhania
* [new tag] qemu-slof-20140121 -> qemu-slof-20140121 > * [new tag] qemu-slof-20140204 -> qemu-slof-20140204 > > Since in particular that includes deleting some references > and a forced update on another I thought I would check it > first. Regards, Nikunj

Re: [Qemu-devel] [Qemu-ppc] [PATCH 00/28] target-ppc: Altivec 2.07

2014-02-26 Thread Nikunj A Dadhania
Nikunj A Dadhania writes: > Hi Peter, > > Peter Maydell writes: >>> >>> That'd be awesome! FWIW "upstream" SLOF is at the following git URL: >>> >>> git://github.com/aik/SLOF.git >> >> That would result in the followi

[Qemu-devel] [PATCH] [RESEND-try-3] hw/9pfs: fix P9_STATS_GEN handling

2014-01-28 Thread Kirill A. Shutemov
issues and cleanup code a bit. Signed-off-by: Kirill A. Shutemov Reviewed-by: Daniel P. Berrange Reviewed-by: Aneesh Kumar K.V --- hw/9pfs/cofile.c | 4 hw/9pfs/virtio-9p-handle.c | 8 +++- hw/9pfs/virtio-9p-local.c | 10 ++ hw/9pfs/virtio-9p-proxy.c | 3 ++- hw/9pfs/v

Re: [Qemu-devel] [PATCH] [RESEND-try-3] hw/9pfs: fix P9_STATS_GEN handling

2014-01-28 Thread Kirill A. Shutemov
Michael S. Tsirkin wrote: > On Tue, Jan 28, 2014 at 12:55:51PM +0200, Kirill A. Shutemov wrote: > > Currently we have few issues with P9_STATS_GEN: > > > > - We don't try to read st_gen anything except files or directories, but > >still set P9_STATS_GEN bit i

[Qemu-devel] [PATCH 1/4] hw/9pfs: fix error handing in local_ioc_getversion()

2014-01-28 Thread Kirill A. Shutemov
v9fs_co_st_gen() expects to see error code in errno, not in return code. Let's fix this. Signed-off-by: Kirill A. Shutemov --- hw/9pfs/virtio-9p-local.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/9pfs/virtio-9p-local.c b/hw/9pfs/virtio-9p-local.c

[Qemu-devel] [PATCH 2/4] hw/9pfs: handle undefined FS_IOC_GETVERSION case in handle_ioc_getversion()

2014-01-28 Thread Kirill A. Shutemov
All get_st_gen() implementations except handle_ioc_getversion() have guard for undefined FS_IOC_GETVERSION. Let's add it there too. Signed-off-by: Kirill A. Shutemov --- hw/9pfs/virtio-9p-handle.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/9pfs/virtio-9p-handle.c b/hw

[Qemu-devel] [PATCH 4/4] hw/9pfs: fix P9_STATS_GEN handling

2014-01-28 Thread Kirill A. Shutemov
The solution is to make P9_STATS_GEN failure non-fatal for getattr request. Just don't set P9_STATS_GEN flag in result mask on failure. Signed-off-by: Kirill A. Shutemov --- hw/9pfs/cofile.c| 4 hw/9pfs/virtio-9p.c | 12 ++-- 2 files changed, 10 insertions(+), 6 deletions

[Qemu-devel] [PATCH 3/4] hw/9pfs: make get_st_gen() return ENOTTY error on special files

2014-01-28 Thread Kirill A. Shutemov
Currently we silently ignore getversion requests for anything except file or directory. Let's instead return ENOTTY error to indicate that getversion is not supported. It makes implementation consistent on all not-supported cases. Signed-off-by: Kirill A. Shutemov --- hw/9pfs/virtio-9p-han

[Qemu-devel] MSI interrupt support with vioscsi.c miniport driver

2014-02-07 Thread Nicholas A. Bellinger
rs to be the default setting for the driver included in the offical virtio-win iso builds, right..? Sooo, I'd like to try enabling MSI_SUPPORTED=1 in a test vioscsi.sys build of my own, but before going down the WDK development rabbit whole, I'd like to better understand why you'v

Re: [Qemu-devel] MSI interrupt support with vioscsi.c miniport driver

2014-02-10 Thread Nicholas A. Bellinger
Hi Vadim & Yan, On Sun, 2014-02-09 at 22:35 +1100, Vadim Rozenfeld wrote: > On Sun, 2014-02-09 at 11:24 +0200, Yan Vugenfirer wrote: > > Hi Nicholas, > > > > Adding Vadim Rozenfeld who wrote the virtio-scsi driver. > > > > Best regards, > > Yan. >

Re: [Qemu-devel] [RESEND-try-2][PATCH] hw/9pfs: fix P9_STATS_GEN handling

2013-12-09 Thread Kirill A. Shutemov
Kirill A. Shutemov wrote: > Currently we have few issues with P9_STATS_GEN: > > - We don't try to read st_gen anything except files or directories, but >still set P9_STATS_GEN bit in st_result_mask. It may mislead client: >we present garbage as valid st_gen. > &

Re: [Qemu-devel] [RESEND] [PATCH] hw/9pfs: fix P9_STATS_GEN handling

2013-11-06 Thread Kirill A. Shutemov
On Wed, Nov 06, 2013 at 09:41:47PM +0530, Aneesh Kumar K.V wrote: > "Kirill A. Shutemov" writes: > > > From: "Kirill A. Shutemov" > > > > Currently we have few issues with P9_STATS_GEN: > > > > - We don't try to read st_g

[Qemu-devel] [RESEND-try-2][PATCH] hw/9pfs: fix P9_STATS_GEN handling

2013-11-29 Thread Kirill A. Shutemov
issues and cleanup code a bit. Signed-off-by: Kirill A. Shutemov Reviewed-by: Daniel P. Berrange Reviewed-by: Aneesh Kumar K.V --- hw/9pfs/cofile.c | 4 hw/9pfs/virtio-9p-handle.c | 8 +++- hw/9pfs/virtio-9p-local.c | 10 ++ hw/9pfs/virtio-9p-proxy.c | 3 ++- hw/9pfs/v

Re: [Qemu-devel] virtio-blk-pci: how to tell if it is CD or HDD?

2013-10-17 Thread Nikunj A Dadhania
Alexey Kardashevskiy writes: > > "channel@0" -> ""? This is a generic scsi bus, cannot change this. > "disk@3,2" -> "disk@8302"? This is a generic scsi-cd, cannot > change this either > > >> On top of this, fix

[Qemu-devel] [PATCH] hw/9pfs: fix P9_STATS_GEN handling

2013-10-26 Thread Kirill A. Shutemov
From: "Kirill A. Shutemov" Currently we have few issues with P9_STATS_GEN: - We don't try to read st_gen anything except files or directories, but still set P9_STATS_GEN bit in st_result_mask. It may mislead client: we present garbage as valid st_gen. - If we failed to g

[Qemu-devel] [PATCH] hw/9pfs: fix P9_STATS_GEN handling

2013-10-26 Thread Kirill A. Shutemov
issues and cleanup code a bit. Signed-off-by: Kirill A. Shutemov --- hw/9pfs/cofile.c | 4 hw/9pfs/virtio-9p-handle.c | 8 +++- hw/9pfs/virtio-9p-local.c | 10 ++ hw/9pfs/virtio-9p-proxy.c | 3 ++- hw/9pfs/virtio-9p.c| 12 ++-- 5 files changed, 25 inserti

Re: [Qemu-devel] [PATCH] hw/9pfs: fix P9_STATS_GEN handling

2013-10-30 Thread Kirill A. Shutemov
On Sun, Oct 27, 2013 at 03:41:34AM +0300, Kirill A. Shutemov wrote: > From: "Kirill A. Shutemov" > > Currently we have few issues with P9_STATS_GEN: > > - We don't try to read st_gen anything except files or directories, but >still set P9_STATS_GEN bit

[Qemu-devel] [RESEND] [PATCH] hw/9pfs: fix P9_STATS_GEN handling

2013-11-04 Thread Kirill A. Shutemov
From: "Kirill A. Shutemov" Currently we have few issues with P9_STATS_GEN: - We don't try to read st_gen anything except files or directories, but still set P9_STATS_GEN bit in st_result_mask. It may mislead client: we present garbage as valid st_gen. - If we failed to g

Re: [Qemu-devel] [PATCH] pseries: Update SLOF firmware image to 20140204

2014-03-07 Thread Nikunj A Dadhania
05:52 PM, Alexey Kardashevskiy wrote: >> >> Ping? >> > >> > Anthony / Stefan, could you please update the SLOF.git mirror on >> > git.qemu.org? >> >> >> It has been updated quite a while ago and it did not get included in >> "[Qemu-devel]

[Qemu-devel] Adding dmcrypt to QEMU block drivers

2014-03-17 Thread Hamilton, Peter A.
Hi qemu-devel, I am a member of a development team based out of the Johns Hopkins University Applied Physics Laboratory. Over the past year and a half, we've been working with the OpenStack community on several security features for their Compute and Block Storage services that lev

Re: [Qemu-devel] [PATCH 1/2] hw/ppc/spapr.c Set default boot order

2015-01-26 Thread Nikunj A Dadhania
Alexander Graf writes: > On 23.01.15 23:51, dval...@suse.de wrote: >> From: Dinar Valeev >> >> In order to use -boot once=X option we need to have default list >> where restore to on reset. >> >> Signed-off-by: Dinar Valeev > > Alexey, Nijunj, where is the default boot order stored usually?

[Qemu-devel] [PATCH 1/3] vhost/scsi: Add VIRTIO_SCSI_F_HOTPLUG host_feature bit

2015-01-30 Thread Nicholas A. Bellinger
From: Nicholas Bellinger Cc: Michael S. Tsirkin Cc: Paolo Bonzini Signed-off-by: Nicholas Bellinger --- hw/virtio/virtio-pci.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c index dde1d73..5127efb 100644 --- a/hw/virtio/virtio-pci.c

[Qemu-devel] [PATCH 3/3] vhost/scsi: Add VIRTIO_F_ANY_LAYOUT host_feature bit

2015-01-30 Thread Nicholas A. Bellinger
From: Nicholas Bellinger Signed-off-by: Nicholas Bellinger --- hw/scsi/vhost-scsi.c | 1 + hw/virtio/virtio-pci.c | 2 ++ include/hw/i386/pc.h | 5 + 3 files changed, 8 insertions(+) diff --git a/hw/scsi/vhost-scsi.c b/hw/scsi/vhost-scsi.c index 95f7b99..bfb7005 100644 --- a/hw/scsi

[Qemu-devel] [PATCH 0/3] vhost/scsi: Enable virtio 1.0 host_feature bits

2015-01-30 Thread Nicholas A. Bellinger
From: Nicholas Bellinger Hi MST & Paolo, Here are the associated QEMU vhost/scsi changes to enable KVM host for expose F_HOTPLUG, F_T10_PI, and ANY_LAYOUT feature bits into virtio 1.0 compatible guests. Note this does not include VIRTIO_SCSI_F_CHANGE, which is currently not supported by vhost/s

[Qemu-devel] [PATCH 2/3] vhost/scsi: Add VIRTIO_SCSI_F_T10_PI host_feature bit

2015-01-30 Thread Nicholas A. Bellinger
changed, 22 insertions(+), 2 deletions(-) diff --git a/hw/scsi/vhost-scsi.c b/hw/scsi/vhost-scsi.c index dcb2bc5..95f7b99 100644 --- a/hw/scsi/vhost-scsi.c +++ b/hw/scsi/vhost-scsi.c @@ -31,6 +31,7 @@ static const int kernel_feature_bits[] = { VIRTIO_RING_F_INDIRECT_DESC

Re: [Qemu-devel] [Qemu-ppc] [RFC] pseries: Enable in-kernel H_LOGICAL_CI_{LOAD, STORE} implementations

2015-02-03 Thread Nikunj A Dadhania
MIO. > > To fix this, an in-kernel implementation of these hypercalls has been made, > however, the hypercalls still need to be enabled from qemu. This performs > the necessary calls to do so. > > Signed-off-by: David Gibson Reviewed-by: Nikunj A Dadhania

Re: [Qemu-devel] [PATCH v5 0/2] Introduce default ram size in MachineClass

2015-03-17 Thread Nikunj A Dadhania
Nikunj A Dadhania writes: > Current DEFAULT_RAM_SIZE(128MB) enforced by QEMU would not work for > all machines. Introduce a default_ram_size as part of MachineClass. > > The below patches has following behaviour: > > 1) If the user does not provide "-m" option, mac

[Qemu-devel] [PATCH 1/2] vfio-pci: add flag to identify vfio pci device

2015-03-25 Thread Nikunj A Dadhania
>From PCIDevice there is no way to know if the device has a backing vfio device. sPAPR guests inherits the "ibm,loc-code" from the pci pass through device in hypervisor. This helps in identifying the device if there is any failures using this "ibm,loc-code" for RAS

[Qemu-devel] [PATCH 2/2] spapr: populate ibm,loc-code

2015-03-25 Thread Nikunj A Dadhania
Each hardware instance has a platform unique location code. The OF device tree that describes a part of a hardware entity must include the “ibm,loc-code” property with a value that represents the location code for that hardware entity. Introduce an hcall to populate ibm,loc-cde. 1) PCI passthru

Re: [Qemu-devel] [PATCH 2/2] spapr: populate ibm,loc-code

2015-03-26 Thread Nikunj A Dadhania
Alexey Kardashevskiy writes: > On 03/26/2015 05:42 PM, Nikunj A Dadhania wrote: >> Each hardware instance has a platform unique location code. The OF >> device tree that describes a part of a hardware entity must include >> the “ibm,loc-code” property with a value that re

Re: [Qemu-devel] [PATCH 2/2] spapr: populate ibm,loc-code

2015-03-26 Thread Nikunj A Dadhania
David Gibson writes: > On Thu, Mar 26, 2015 at 12:12:12PM +0530, Nikunj A Dadhania wrote: >> Each hardware instance has a platform unique location code. The OF >> device tree that describes a part of a hardware entity must include >> the “ibm,loc-code” property with a valu

Re: [Qemu-devel] [PATCH 2/2] spapr: populate ibm,loc-code

2015-03-26 Thread Nikunj A Dadhania
Alexey Kardashevskiy writes: >> diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c >> index 95d666e..dd97258 100644 >> --- a/hw/vfio/pci.c >> +++ b/hw/vfio/pci.c >> @@ -3319,6 +3319,24 @@ static void >> vfio_unregister_req_notifier(VFIOPCIDevice *vdev

Re: [Qemu-devel] [PATCH 2/2] spapr: populate ibm,loc-code

2015-03-26 Thread Nikunj A Dadhania
David Gibson writes: > On Fri, Mar 27, 2015 at 10:04:27AM +0530, Nikunj A Dadhania wrote: >> David Gibson writes: >> >> > On Thu, Mar 26, 2015 at 12:12:12PM +0530, Nikunj A Dadhania wrote: >> >> Each hardware instance has a platform unique location

[Qemu-devel] [PATCH v2] spapr: populate ibm,loc-code

2015-03-27 Thread Nikunj A Dadhania
Each hardware instance has a platform unique location code. The OF device tree that describes a part of a hardware entity must include the “ibm,loc-code” property with a value that represents the location code for that hardware entity. Introduce an hcall to populate ibm,loc-code. 1) PCI passthru

Re: [Qemu-devel] [PATCH v2] spapr: populate ibm,loc-code

2015-03-29 Thread Nikunj A Dadhania
Alexey Kardashevskiy writes: > On 03/27/2015 08:49 PM, Nikunj A Dadhania wrote: >> Each hardware instance has a platform unique location code. The OF >> device tree that describes a part of a hardware entity must include >> the “ibm,loc-code” property with a value that re

Re: [Qemu-devel] [PATCH v2] spapr: populate ibm,loc-code

2015-03-29 Thread Nikunj A Dadhania
David Gibson writes: > On Mon, Mar 30, 2015 at 01:18:01PM +1100, Alexey Kardashevskiy wrote: >> On 03/27/2015 08:49 PM, Nikunj A Dadhania wrote: >> >Each hardware instance has a platform unique location code. The OF >> >device tree that describes a part of a hardware

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2] spapr: populate ibm, loc-code

2015-03-29 Thread Nikunj A Dadhania
Nikunj A Dadhania writes: > David Gibson writes: > >> On Mon, Mar 30, 2015 at 01:18:01PM +1100, Alexey Kardashevskiy wrote: >>> On 03/27/2015 08:49 PM, Nikunj A Dadhania wrote: >>> >Each hardware instance has a platform unique location code. The OF >>&g

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2] spapr: populate ibm, loc-code

2015-03-30 Thread Nikunj A Dadhania
Alexey Kardashevskiy writes: > On 03/30/2015 04:34 PM, Nikunj A Dadhania wrote: >> Nikunj A Dadhania writes: >> >>> David Gibson writes: >>> >>>> On Mon, Mar 30, 2015 at 01:18:01PM +1100, Alexey Kardashevskiy wrote: >>>>> On 03/27/

[Qemu-devel] [PATCH v3] spapr: populate ibm,loc-code

2015-03-30 Thread Nikunj A Dadhania
Each hardware instance has a platform unique location code. The OF device tree that describes a part of a hardware entity must include the “ibm,loc-code” property with a value that represents the location code for that hardware entity. Introduce an rtas call to populate ibm,loc-code. 1) PCI

Re: [Qemu-devel] [PATCH v3] spapr: populate ibm,loc-code

2015-03-30 Thread Nikunj A Dadhania
David Gibson writes: > On Tue, Mar 31, 2015 at 01:00:57PM +1100, Alexey Kardashevskiy wrote: >> On 03/30/2015 10:02 PM, Nikunj A Dadhania wrote: >> >Each hardware instance has a platform unique location code. The OF >> >device tree that describes a part of a hardware

Re: [Qemu-devel] [PATCH v3] spapr: populate ibm,loc-code

2015-03-31 Thread Nikunj A Dadhania
Alexey Kardashevskiy writes: > On 03/31/2015 04:15 PM, Nikunj A Dadhania wrote: >> David Gibson writes: >> >>> On Tue, Mar 31, 2015 at 01:00:57PM +1100, Alexey Kardashevskiy wrote: >>>> On 03/30/2015 10:02 PM, Nikunj A Dadhania wrote: >>>>> Ea

Re: [Qemu-devel] [PATCH 1/2] vfio-pci: add flag to identify vfio pci device

2015-03-31 Thread Nikunj A Dadhania
Alex Williamson writes: > On Thu, 2015-03-26 at 12:12 +0530, Nikunj A Dadhania wrote: >> From PCIDevice there is no way to know if the device has a backing >> vfio device. >> >> sPAPR guests inherits the "ibm,loc-code" from the pci pass through >> devi

Re: [Qemu-devel] [PATCH v2] spapr: populate ibm,loc-code

2015-03-31 Thread Nikunj A Dadhania
Michael Roth writes: > Quoting Alexey Kardashevskiy (2015-03-29 22:08:17) >> On 03/30/2015 01:25 PM, David Gibson wrote: >> > On Mon, Mar 30, 2015 at 01:18:01PM +1100, Alexey Kardashevskiy wrote: >> >> On 03/27/2015 08:49 PM, Nikunj A Dadhania wrote: >> >&

[Qemu-devel] [RFC PATCH 2/2] spapr: populate ibm,loc-code

2015-04-22 Thread Nikunj A Dadhania
Each hardware instance has a platform unique location code. The OF device tree that describes a part of a hardware entity must include the “ibm,loc-code” property with a value that represents the location code for that hardware entity. Populate ibm,loc-code. 1) PCI passthru devices need to

[Qemu-devel] [RFC PATCH 1/2] spapr: enumerate and add PCI device tree

2015-04-22 Thread Nikunj A Dadhania
backward compatibility, a flag "qemu,phb-enumerated" is added to the phb, suggesting to SLOF to not do device node creation. Signed-off-by: Nikunj A Dadhania --- hw/ppc/spapr_pci.c | 93 -- 1 file changed, 84 insertions(+), 9 deletions(-)

[Qemu-devel] [RFC PATCH 0/2] spapr: move pci device creation to Qemu

2015-04-22 Thread Nikunj A Dadhania
very complicated with use of RTAS/HCALL Nikunj A Dadhania (2): spapr: enumerate and add PCI device tree spapr: populate ibm,loc-code hw/ppc/spapr_pci.c | 166 - 1 file changed, 153 insertions(+), 13 deletions(-) -- 1.8.3.1

Re: [Qemu-devel] [RFC PATCH 0/2] spapr: move pci device creation to Qemu

2015-04-22 Thread Nikunj A Dadhania
Nikunj A Dadhania writes: > The patch series creates PCI DT nodes in QEMU. The new > hotplug code needs the device node creation in Qemu. While during > boot, nodes were created in SLOF. It makes more sense to consolidate > the code to one place for better maintainability. Based

Re: [Qemu-devel] [Qemu-ppc] [PATCH v8 15/16] spapr_pci: enable basic hotplug operations

2015-04-24 Thread Nikunj A Dadhania
Hi Michael, Couple of issues I found during my testing with pci enumerations patches yesterday: Michael Roth writes: > This enables hotplug of PCI devices to a PHB. Upon hotplug we > generate the OF-nodes required by PAPR specification and > IEEE 1275-1994 "PCI Bus Binding to

Re: [Qemu-devel] [Qemu-ppc] [PATCH v5 0/2] Introduce default ram size in MachineClass

2015-04-27 Thread Nikunj A Dadhania
Nikunj A Dadhania writes: > Nikunj A Dadhania writes: > >> Current DEFAULT_RAM_SIZE(128MB) enforced by QEMU would not work for >> all machines. Introduce a default_ram_size as part of MachineClass. >> >> The below patches has following behaviour: >> &g

Re: [Qemu-devel] [Qemu-ppc] [PATCH v5 0/2] Introduce default ram size in MachineClass

2015-04-27 Thread Nikunj A Dadhania
Nikunj A Dadhania writes: > Nikunj A Dadhania writes: > >> Nikunj A Dadhania writes: >> >>> Current DEFAULT_RAM_SIZE(128MB) enforced by QEMU would not work for >>> all machines. Introduce a default_ram_size as part of MachineClass. >>> >>>

[Qemu-devel] [REBASE PATCH v5 1/2] machine: add default_ram_size to machine class

2015-04-27 Thread Nikunj A Dadhania
Machines types can have different requirement for default ram size. Introduce a member in the machine class and set the current default_ram_size to 128MB. For QEMUMachine types override the value during the registration of the machine and for MachineClass introduce the generic class init setting

[Qemu-devel] [REBASE PATCH v5 2/2] spapr: override default ram size to 1GB

2015-04-27 Thread Nikunj A Dadhania
Signed-off-by: Nikunj A Dadhania Reviewed-by: Igor Mammedov --- hw/ppc/spapr.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index 61ddc79..6616650 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -1794,6 +1794,7 @@ static void spapr_machine_class_init

[Qemu-devel] [REBASE PATCH v5 0/2] Introduce default ram size in MachineClass

2015-04-27 Thread Nikunj A Dadhania
Current DEFAULT_RAM_SIZE(128MB) enforced by QEMU would not work for all machines. Introduce a default_ram_size as part of MachineClass. The below patches has following behaviour: 1) If the user does not provide "-m" option, machine's default ram size will be picked. 2) The de

Re: [Qemu-devel] [RFC PATCH 2/2] spapr: populate ibm,loc-code

2015-04-28 Thread Nikunj A Dadhania
David Gibson writes: > On Wed, Apr 22, 2015 at 04:05:34PM +0530, Nikunj A Dadhania wrote: >> Each hardware instance has a platform unique location code. The OF >> device tree that describes a part of a hardware entity must include >> the “ibm,loc-code” property with a valu

Re: [Qemu-devel] [RFC PATCH 1/2] spapr: enumerate and add PCI device tree

2015-04-28 Thread Nikunj A Dadhania
David Gibson writes: > On Wed, Apr 22, 2015 at 04:05:33PM +0530, Nikunj A Dadhania wrote: >> All the PCI enumeration and device node creation was off-loaded to >> SLOF. With PCI hotplug support, code needed to be added to add device >> node. This creates multiple copy of the

Re: [Qemu-devel] [RFC PATCH 1/2] spapr: enumerate and add PCI device tree

2015-04-28 Thread Nikunj A Dadhania
Alexey Kardashevskiy writes: > On 04/22/2015 08:35 PM, Nikunj A Dadhania wrote: >> All the PCI enumeration and device node creation was off-loaded to >> SLOF. With PCI hotplug support, code needed to be added to add device >> node. This creates multiple copy of the code one

[Qemu-devel] [PATCH v2 0/2] spapr: move pci device creation to Qemu

2015-04-29 Thread Nikunj A Dadhania
to avoid multiple indentation (Alexey Kardashevskiy) Nikunj A Dadhania (2): spapr: enumerate and add PCI device tree spapr: populate ibm,loc-code hw/ppc/spapr_pci.c | 183 + 1 file changed, 170 insertions(+), 13 deletions(-) -- 1.8.3.1

[Qemu-devel] [PATCH v2 1/2] spapr: enumerate and add PCI device tree

2015-04-29 Thread Nikunj A Dadhania
backward compatibility, a flag "qemu,phb-enumerated" is added to the phb, suggesting to SLOF to not do device node creation. Signed-off-by: Nikunj A Dadhania --- hw/ppc/spapr_pci.c | 111 - 1 file changed, 102 insertions(+), 9 deletion

[Qemu-devel] [PATCH v2 2/2] spapr: populate ibm,loc-code

2015-04-29 Thread Nikunj A Dadhania
Each hardware instance has a platform unique location code. The OF device tree that describes a part of a hardware entity must include the “ibm,loc-code” property with a value that represents the location code for that hardware entity. Populate ibm,loc-code. 1) PCI passthru devices need to

<    1   2   3   4   5   6   7   8   9   10   >