RE: [PATCH 1/1] i386/monitor: Fix page table walking issue for LA57 enabled guest

2022-06-23 Thread Zhang, Chen
pping information was collected from "info > mem" for guest with LA57 enabled. > > Signed-off-by: Yuan Yao LGTM. It should same with the excp_helper.c/mmu_translate() la57 implementation. Reviewed-by: Zhang Chen Add Eric and Markus for double check. Thanks Chen >

RE: [PATCH] common-user: Only compile the common user code if have_user is set

2022-06-23 Thread Zhang, Chen
not have an entry in the common-user/host/ folder > (since common-user/meson.build is trying to add such a path via the > include_directories() command). > > Reported-by: Michael Tokarev > Signed-off-by: Thomas Huth Looks good to me. Reviewed-by: Zhang Chen > --- > c

RE: [RFC PATCH 00/12] Introduce QEMU userspace ebpf support

2022-06-30 Thread Zhang, Chen
> -Original Message- > From: Andrew Melnichenko > Sent: Wednesday, June 29, 2022 6:43 PM > To: Zhang, Chen > Cc: Jason Wang ; qemu-dev de...@nongnu.org>; Paolo Bonzini ; Daniel P. > Berrangé ; Eduardo Habkost > ; Eric Blake ; Markus > Armbruster ; Pe

RE: [PATCH] gtk: Add show_tabs=on|off command line option.

2022-07-01 Thread Zhang, Chen
> -Original Message- > From: Qemu-devel bounces+chen.zhang=intel@nongnu.org> On Behalf Of Felix xq > Queißner > Sent: Tuesday, June 28, 2022 12:44 AM > To: qemu-devel@nongnu.org > Cc: kra...@redhat.com; th...@redhat.com; Felix "xq" Queißner > > Subject: [PATCH] gtk: Add show_tabs=on

RE: [PATCH V2 1/4] softmmu/runstate.c: add RunStateTransition support form COLO to PRELAUNCH

2022-07-05 Thread Zhang, Chen
> > > > > > On Fri, Apr 1, 2022 at 11:59 AM Zhang Chen > wrote: > > > > > > > > > > > > > > If the checkpoint occurs when the guest finishes restarting > > > > > > > but has not started running, the runstate_set

RE: [PATCH] replication: compile out some staff when replication is not configured

2023-04-13 Thread Zhang, Chen
nt...@redhat.com; hre...@redhat.com; kw...@redhat.com; Zhang, > Hailiang ; Zhang, Chen > ; lizhij...@fujitsu.com; > wencongya...@huawei.com; xiechanglon...@gmail.com; den- > plotni...@yandex-team.ru; Vladimir Sementsov-Ogievskiy > > Subject: [PATCH] replication: compile

RE: [PATCH] replication: compile out some staff when replication is not configured

2023-04-13 Thread Zhang, Chen
> -Original Message- > From: qemu-devel-bounces+chen.zhang=intel@nongnu.org devel-bounces+chen.zhang=intel@nongnu.org> On Behalf Of Vladimir > Sementsov-Ogievskiy > Sent: Thursday, April 13, 2023 9:47 PM > To: Zhang, Chen ; qemu-devel@nongnu.org > Cc:

RE: [PATCH] replication: compile out some staff when replication is not configured

2023-04-16 Thread Zhang, Chen
> -Original Message- > From: Vladimir Sementsov-Ogievskiy > Sent: Friday, April 14, 2023 5:51 PM > To: Zhang, Chen ; qemu-devel@nongnu.org > Cc: qemu-bl...@nongnu.org; pbonz...@redhat.com; arm...@redhat.com; > ebl...@redhat.com; jasow...@redhat.com; dgilb...@r

RE: [PATCH v2 4/4] configure: add --disable-colo-filters option

2023-04-20 Thread Zhang, Chen
, > Hailiang ; phi...@linaro.org; > th...@redhat.com; berra...@redhat.com; marcandre.lur...@redhat.com; > pbonz...@redhat.com; d...@treblig.org; hre...@redhat.com; > kw...@redhat.com; Zhang, Chen ; > lizhij...@fujitsu.com; Vladimir Sementsov-Ogievskiy team.ru> > Subject: [PATC

RE: [PATCH v2 4/4] configure: add --disable-colo-filters option

2023-04-20 Thread Zhang, Chen
> -Original Message- > From: Vladimir Sementsov-Ogievskiy > Sent: Thursday, April 20, 2023 7:26 PM > To: Zhang, Chen ; qemu-devel@nongnu.org > Cc: qemu-bl...@nongnu.org; michael.r...@amd.com; arm...@redhat.com; > ebl...@redhat.com; jasow...@redhat.com; quint...

RE: [PATCH v2 3/4] build: move COLO under CONFIG_REPLICATION

2023-04-20 Thread Zhang, Chen
, > Hailiang ; phi...@linaro.org; > th...@redhat.com; berra...@redhat.com; marcandre.lur...@redhat.com; > pbonz...@redhat.com; d...@treblig.org; hre...@redhat.com; > kw...@redhat.com; Zhang, Chen ; > lizhij...@fujitsu.com; Vladimir Sementsov-Ogievskiy team.ru> > Subject

RE: [PATCH v2 3/4] build: move COLO under CONFIG_REPLICATION

2023-04-22 Thread Zhang, Chen
> -Original Message- > From: Vladimir Sementsov-Ogievskiy > Sent: Friday, April 21, 2023 4:36 PM > To: Zhang, Chen ; qemu-devel@nongnu.org > Cc: qemu-bl...@nongnu.org; michael.r...@amd.com; arm...@redhat.com; > ebl...@redhat.com; jasow...@redhat.com; quint...

RE: [PATCH v2 4/4] configure: add --disable-colo-filters option

2023-04-22 Thread Zhang, Chen
> -Original Message- > From: Vladimir Sementsov-Ogievskiy > Sent: Friday, April 21, 2023 4:53 PM > To: Zhang, Chen ; qemu-devel@nongnu.org > Cc: qemu-bl...@nongnu.org; michael.r...@amd.com; arm...@redhat.com; > ebl...@redhat.com; jasow...@redhat.com; quint...

RE: [PATCH v2 1/6] tests/qtest: replace qmp_discard_response with qtest_qmp_assert_success

2023-04-22 Thread Zhang, Chen
> -Original Message- > From: Daniel P. Berrangé > Sent: Saturday, April 22, 2023 1:14 AM > To: qemu-devel@nongnu.org > Cc: qemu-bl...@nongnu.org; Paolo Bonzini ; > Thomas Huth ; John Snow ; Li > Zhijian ; Juan Quintela ; > Stefan Hajnoczi ; Zhang, Chen >

RE: [PATCH v2 6/6] tests/migration: Only run auto_converge in slow mode

2023-04-22 Thread Zhang, Chen
> -Original Message- > From: Daniel P. Berrangé > Sent: Saturday, April 22, 2023 1:14 AM > To: qemu-devel@nongnu.org > Cc: qemu-bl...@nongnu.org; Paolo Bonzini ; > Thomas Huth ; John Snow ; Li > Zhijian ; Juan Quintela ; > Stefan Hajnoczi ; Zhang, Chen >

RE: [PATCH v2 6/6] tests/migration: Only run auto_converge in slow mode

2023-04-24 Thread Zhang, Chen
> -Original Message- > From: Daniel P. Berrangé > Sent: Saturday, April 22, 2023 1:14 AM > To: qemu-devel@nongnu.org > Cc: qemu-bl...@nongnu.org; Paolo Bonzini ; > Thomas Huth ; John Snow ; Li > Zhijian ; Juan Quintela ; > Stefan Hajnoczi ; Zhang, Chen >

RE: [PATCH v2 6/6] tests/migration: Only run auto_converge in slow mode

2023-04-24 Thread Zhang, Chen
> -Original Message- > From: Thomas Huth > Sent: Monday, April 24, 2023 2:56 PM > To: quint...@redhat.com; Zhang, Chen > Cc: Daniel P. Berrangé ; qemu-devel@nongnu.org; > qemu-bl...@nongnu.org; Paolo Bonzini ; John > Snow ; Li Zhijian ; Stefan > Hajnoczi ; Laure

RE: [PATCH v3 4/4] configure: add --disable-colo-proxy option

2023-04-28 Thread Zhang, Chen
...@redhat.com; Zhang, Hailiang > ; phi...@linaro.org; th...@redhat.com; > berra...@redhat.com; marcandre.lur...@redhat.com; > pbonz...@redhat.com; d...@treblig.org; hre...@redhat.com; > kw...@redhat.com; Zhang, Chen ; > lizhij...@fujitsu.com > Subject: Re: [PATCH v3 4/4] configure:

RE: [PATCH v4 01/10] block/meson.build: prefer positive condition for replication

2023-05-04 Thread Zhang, Chen
> -Original Message- > From: Vladimir Sementsov-Ogievskiy > Sent: Saturday, April 29, 2023 3:49 AM > To: qemu-devel@nongnu.org > Cc: lukasstra...@web.de; quint...@redhat.com; Zhang, Chen > ; vsement...@yandex-team.ru; Philippe Mathieu- > Daudé ; Kevin Wolf ;

RE: [PATCH v4 02/10] colo: make colo_checkpoint_notify static and provide simpler API

2023-05-04 Thread Zhang, Chen
> -Original Message- > From: Vladimir Sementsov-Ogievskiy > Sent: Saturday, April 29, 2023 3:49 AM > To: qemu-devel@nongnu.org > Cc: lukasstra...@web.de; quint...@redhat.com; Zhang, Chen > ; vsement...@yandex-team.ru; Zhang, Hailiang > ; Peter Xu ; Leonardo > Br

RE: [PATCH v4 04/10] configure: add --disable-colo-proxy option

2023-05-04 Thread Zhang, Chen
> -Original Message- > From: Vladimir Sementsov-Ogievskiy > Sent: Saturday, April 29, 2023 3:49 AM > To: qemu-devel@nongnu.org > Cc: lukasstra...@web.de; quint...@redhat.com; Zhang, Chen > ; vsement...@yandex-team.ru; Paolo Bonzini > ; Marc-André Lureau &

RE: [PATCH v4 05/10] migration: drop colo_incoming_thread from MigrationIncomingState

2023-05-04 Thread Zhang, Chen
> -Original Message- > From: Vladimir Sementsov-Ogievskiy > Sent: Saturday, April 29, 2023 3:49 AM > To: qemu-devel@nongnu.org > Cc: lukasstra...@web.de; quint...@redhat.com; Zhang, Chen > ; vsement...@yandex-team.ru; Peter Xu > ; Leonardo Bras > Subject: [P

RE: [PATCH v4 06/10] migration: process_incoming_migration_co: simplify code flow around ret

2023-05-04 Thread Zhang, Chen
> -Original Message- > From: Vladimir Sementsov-Ogievskiy > Sent: Saturday, April 29, 2023 3:49 AM > To: qemu-devel@nongnu.org > Cc: lukasstra...@web.de; quint...@redhat.com; Zhang, Chen > ; vsement...@yandex-team.ru; Peter Xu > ; Leonardo Bras > Subject: [P

RE: [PATCH v4 07/10] migration: split migration_incoming_co

2023-05-04 Thread Zhang, Chen
> -Original Message- > From: Vladimir Sementsov-Ogievskiy > Sent: Thursday, May 4, 2023 6:52 AM > To: Peter Xu > Cc: qemu-devel@nongnu.org; lukasstra...@web.de; quint...@redhat.com; > Zhang, Chen ; Zhang, Hailiang > ; Leonardo Bras > Subject: Re: [PATCH v4

RE: [PATCH v4 09/10] migration: disallow change capabilities in COLO state

2023-05-04 Thread Zhang, Chen
> -Original Message- > From: Vladimir Sementsov-Ogievskiy > Sent: Saturday, April 29, 2023 3:49 AM > To: qemu-devel@nongnu.org > Cc: lukasstra...@web.de; quint...@redhat.com; Zhang, Chen > ; vsement...@yandex-team.ru; Peter Xu > ; Leonardo Bras > Subject: [P

RE: [PATCH v4 09/10] migration: disallow change capabilities in COLO state

2023-05-04 Thread Zhang, Chen
> -Original Message- > From: Vladimir Sementsov-Ogievskiy > Sent: Thursday, May 4, 2023 4:23 PM > To: Zhang, Chen ; qemu-devel@nongnu.org > Cc: lukasstra...@web.de; quint...@redhat.com; Peter Xu > ; Leonardo Bras > Subject: Re: [PATCH v4 09/10] migration: disallo

RE: [PATCH v4 10/10] migration: block incoming colo when capability is disabled

2023-05-04 Thread Zhang, Chen
> -Original Message- > From: Vladimir Sementsov-Ogievskiy > Sent: Saturday, April 29, 2023 3:49 AM > To: qemu-devel@nongnu.org > Cc: lukasstra...@web.de; quint...@redhat.com; Zhang, Chen > ; vsement...@yandex-team.ru; Peter Xu > ; Leonardo Bras > Subject: [P

RE: [PATCH v4 10/10] migration: block incoming colo when capability is disabled

2023-05-05 Thread Zhang, Chen
> -Original Message- > From: Lukas Straub > Sent: Friday, May 5, 2023 6:46 AM > To: Vladimir Sementsov-Ogievskiy > Cc: qemu-devel@nongnu.org; quint...@redhat.com; Zhang, Chen > ; Peter Xu ; Leonardo Bras > > Subject: Re: [PATCH v4 10/10] migration: block incom

RE: [PATCH v4 00/10] COLO: improve build options

2023-05-05 Thread Zhang, Chen
> -Original Message- > From: Vladimir Sementsov-Ogievskiy > Sent: Saturday, April 29, 2023 3:49 AM > To: qemu-devel@nongnu.org > Cc: lukasstra...@web.de; quint...@redhat.com; Zhang, Chen > ; vsement...@yandex-team.ru > Subject: [PATCH v4 00/10] COLO: improve build

RE: [PATCH 0/3] Some minor fixes for migration states

2022-01-19 Thread Zhang, Chen
Any comments? Ping... Thanks Chen > -Original Message- > From: Zhang, Chen > Sent: Friday, December 31, 2021 2:00 PM > To: Dr. David Alan Gilbert ; Juan Quintela > ; qemu-dev > Cc: Zhang, Chen > Subject: [PATCH 0/3] Some minor fixes for migration states > &

RE: [PATCH 2/3] migration/migration.c: Avoid COLO boot in postcopy migration

2022-01-20 Thread Zhang, Chen
> -Original Message- > From: Dr. David Alan Gilbert > Sent: Thursday, January 20, 2022 3:41 AM > To: Zhang, Chen > Cc: Juan Quintela ; qemu-dev de...@nongnu.org> > Subject: Re: [PATCH 2/3] migration/migration.c: Avoid COLO boot in postcopy > migration &g

RE: [PATCH 1/3] migration/migration.c: Add missed default error handler for migration state

2022-01-20 Thread Zhang, Chen
> -Original Message- > From: Dr. David Alan Gilbert > Sent: Thursday, January 20, 2022 1:52 AM > To: Zhang, Chen > Cc: Juan Quintela ; qemu-dev de...@nongnu.org> > Subject: Re: [PATCH 1/3] migration/migration.c: Add missed default error > handler for migration

[PATCH V2 0/3] Some minor fixes for migration states

2022-01-26 Thread Zhang Chen
This series solved some fixme and comments in code. Please see the details in each patch commit message. --V2: -Fix typo. Zhang Chen (3): migration/migration.c: Add missed default error handler for migration state migration/migration.c: Avoid COLO boot in postcopy migration

[PATCH V2 2/3] migration/migration.c: Avoid COLO boot in postcopy migration

2022-01-26 Thread Zhang Chen
COLO does not support postcopy migration and remove the Fixme. Signed-off-by: Zhang Chen Reviewed-by: Juan Quintela --- migration/migration.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/migration/migration.c b/migration/migration.c index 2afa77da03

RE: [PATCH 2/3] migration/migration.c: Avoid COLO boot in postcopy migration

2022-01-26 Thread Zhang, Chen
> -Original Message- > From: Juan Quintela > Sent: Thursday, January 27, 2022 3:30 AM > To: Zhang, Chen > Cc: Dr. David Alan Gilbert ; qemu-dev de...@nongnu.org> > Subject: Re: [PATCH 2/3] migration/migration.c: Avoid COLO boot in postcopy > migration > &g

[PATCH V2 1/3] migration/migration.c: Add missed default error handler for migration state

2022-01-26 Thread Zhang Chen
In the migration_completion() no other status is expected, for example MIGRATION_STATUS_CANCELLING, MIGRATION_STATUS_CANCELLED, etc. Signed-off-by: Zhang Chen Reviewed-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- migration/migration.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH V2 3/3] migration/migration.c: Remove the MIGRATION_STATUS_ACTIVE when migration finished

2022-01-26 Thread Zhang Chen
The MIGRATION_STATUS_ACTIVE indicates that migration is running. Remove it to be handled by the default operation, It should be part of the unknown ending states. Signed-off-by: Zhang Chen Reviewed-by: Juan Quintela --- migration/migration.c | 6 -- 1 file changed, 6 deletions(-) diff

[PATCH] docs/devel/migration.rst: Updates content from code and fixes minor issues

2022-01-27 Thread Zhang Chen
Signed-off-by: Zhang Chen --- docs/devel/migration.rst | 36 +++- 1 file changed, 23 insertions(+), 13 deletions(-) diff --git a/docs/devel/migration.rst b/docs/devel/migration.rst index 2401253482..9f190d439a 100644 --- a/docs/devel/migration.rst +++ b/docs

RE: [PATCH V5 1/3] net/filter: Optimize transfer protocol for filter-mirror/redirector

2021-11-01 Thread Zhang, Chen
> -Original Message- > From: Jason Wang > Sent: Monday, November 1, 2021 11:46 AM > To: Zhang, Chen > Cc: qemu-dev ; Markus Armbruster > ; Li Zhijian > Subject: Re: [PATCH V5 1/3] net/filter: Optimize transfer protocol for filter- > mirror/redirector > >

RE: [PATCH V5 1/3] net/filter: Optimize transfer protocol for filter-mirror/redirector

2021-11-03 Thread Zhang, Chen
> > > > > > > > > > > > I wonder if we need to introduce new parameter, e.g force_vnet_hdr > > > > here, then we can always send vnet_hdr when it is enabled. > > > > > > > > Otherwise the "vnet_hdr_support" seems meaningless. > > > > > > Yes, Current "vnet_hdr_support" default enabled, and vnet_hd

RE: [PATCH V5 1/3] net/filter: Optimize transfer protocol for filter-mirror/redirector

2021-11-04 Thread Zhang, Chen
> -Original Message- > From: Jason Wang > Sent: Friday, November 5, 2021 11:17 AM > To: Zhang, Chen ; Markus Armbruster > > Cc: qemu-dev ; Li Zhijian > > Subject: Re: [PATCH V5 1/3] net/filter: Optimize transfer protocol for filter- > mirror/redirector

RE: [PATCH V5 1/3] net/filter: Optimize transfer protocol for filter-mirror/redirector

2021-11-04 Thread Zhang, Chen
> -Original Message- > From: Jason Wang > Sent: Friday, November 5, 2021 12:03 PM > To: Zhang, Chen > Cc: Markus Armbruster ; qemu-dev de...@nongnu.org>; Li Zhijian > Subject: Re: [PATCH V5 1/3] net/filter: Optimize transfer protocol for filter- > mirror/redir

RE: [PATCH V5 1/3] net/filter: Optimize transfer protocol for filter-mirror/redirector

2021-11-05 Thread Zhang, Chen
> -Original Message- > From: Jason Wang > Sent: Friday, November 5, 2021 4:30 PM > To: Zhang, Chen > Cc: Markus Armbruster ; qemu-dev de...@nongnu.org>; Li Zhijian > Subject: Re: [PATCH V5 1/3] net/filter: Optimize transfer protocol for filter- > mirror/redir

RE: [PATCH V5 1/3] net/filter: Optimize transfer protocol for filter-mirror/redirector

2021-11-07 Thread Zhang, Chen
> -Original Message- > From: Jason Wang > Sent: Monday, November 8, 2021 10:42 AM > To: Zhang, Chen > Cc: Markus Armbruster ; qemu-dev de...@nongnu.org>; Li Zhijian > Subject: Re: [PATCH V5 1/3] net/filter: Optimize transfer protocol for filter- > mirror/redir

RE: [PATCH V5 1/3] net/filter: Optimize transfer protocol for filter-mirror/redirector

2021-11-08 Thread Zhang, Chen
> -Original Message- > From: Jason Wang > Sent: Tuesday, November 9, 2021 2:42 PM > To: Zhang, Chen > Cc: Markus Armbruster ; qemu-dev de...@nongnu.org>; Li Zhijian > Subject: Re: [PATCH V5 1/3] net/filter: Optimize transfer protocol for filter- > mirror/redir

RE: [PATCH V5 1/3] net/filter: Optimize transfer protocol for filter-mirror/redirector

2021-11-08 Thread Zhang, Chen
> -Original Message- > From: Jason Wang > Sent: Tuesday, November 9, 2021 3:26 PM > To: Zhang, Chen > Cc: Markus Armbruster ; qemu-dev de...@nongnu.org>; Li Zhijian > Subject: Re: [PATCH V5 1/3] net/filter: Optimize transfer protocol for filter- > mirror/redir

RE: [PATCH V5 1/3] net/filter: Optimize transfer protocol for filter-mirror/redirector

2021-11-08 Thread Zhang, Chen
> -Original Message- > From: Jason Wang > Sent: Tuesday, November 9, 2021 3:42 PM > To: Zhang, Chen > Cc: Markus Armbruster ; qemu-dev de...@nongnu.org>; Li Zhijian > Subject: Re: [PATCH V5 1/3] net/filter: Optimize transfer protocol for filter- > mirror/redir

RE: [PATCH V5 1/3] net/filter: Optimize transfer protocol for filter-mirror/redirector

2021-11-09 Thread Zhang, Chen
> > > > > > > > > > > > If we can do that, isn't it much more simpler to make > > > > > > vnet_hdr_support by default? > > > > > > > > > > Yes, For compatibility filters and COLO still work with the > > > > > original > > > > "vnet_hdr_support". > > > > > For new users, they can enable the new "aut

[PATCH] net/filter: Enable the vnet_hdr_support by default

2021-11-09 Thread Zhang Chen
This patch make filters and colo-compare module support vnet_hdr by default. And also support -device non-virtio-net(like e1000.). But it can't avoid user manual configuration error between different filters when enable/disable virtio-net-pci. Signed-off-by: Zhang Chen --- net/colo-comp

RE: [PATCH] net/filter: Enable the vnet_hdr_support by default

2021-11-09 Thread Zhang, Chen
> -Original Message- > From: Markus Armbruster > Sent: Wednesday, November 10, 2021 1:07 PM > To: Zhang, Chen > Cc: Jason Wang ; qemu-dev de...@nongnu.org>; Li Zhijian > Subject: Re: [PATCH] net/filter: Enable the vnet_hdr_support by default > > Zhan

RE: [PATCH] net/filter: Enable the vnet_hdr_support by default

2021-11-09 Thread Zhang, Chen
> -Original Message- > From: Markus Armbruster > Sent: Wednesday, November 10, 2021 2:21 PM > To: Zhang, Chen > Cc: Jason Wang ; qemu-dev de...@nongnu.org>; Li Zhijian > Subject: Re: [PATCH] net/filter: Enable the vnet_hdr_support by default >

[PATCH 2/2] migration/colo: More accurate update checkpoint time

2021-11-10 Thread Zhang Chen
Previous operation(like vm_start and replication_start_all) will consume extra time before update the timer, so reduce time in this patch. Signed-off-by: Zhang Chen --- migration/colo.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/migration/colo.c b/migration/colo.c

[PATCH 1/2] migration/colo: Optimize COLO start code path

2021-11-10 Thread Zhang Chen
There is no need to start COLO through MIGRATION_STATUS_ACTIVE. Signed-off-by: Zhang Chen --- migration/colo.c | 2 -- migration/migration.c | 18 +++--- 2 files changed, 11 insertions(+), 9 deletions(-) diff --git a/migration/colo.c b/migration/colo.c index 2415325262

RE: [PATCH V3] net/colo: check vnet_hdr_support flag when using virtio-net

2021-10-19 Thread Zhang, Chen
> -Original Message- > From: Jason Wang > Sent: Tuesday, October 19, 2021 3:39 PM > To: Zhang, Chen ; Eric Blake ; > Markus Armbruster > Cc: qemu-dev ; Li Zhijian > ; Lukas Straub ; Tao Xu > > Subject: Re: [PATCH V3] net/colo: check vnet_hdr_support f

RE: [PATCH V3] net/colo: check vnet_hdr_support flag when using virtio-net

2021-10-19 Thread Zhang, Chen
> -Original Message- > From: Jason Wang > Sent: Wednesday, October 20, 2021 11:13 AM > To: Zhang, Chen > Cc: Eric Blake ; Markus Armbruster > ; qemu-dev ; Li Zhijian > ; Lukas Straub > Subject: Re: [PATCH V3] net/colo: check vnet_hdr_support flag when using

RE: [PATCH V3] net/colo: check vnet_hdr_support flag when using virtio-net

2021-10-20 Thread Zhang, Chen
> -Original Message- > From: Jason Wang > Sent: Thursday, October 21, 2021 11:02 AM > To: Zhang, Chen > Cc: Eric Blake ; Markus Armbruster > ; qemu-dev ; Li Zhijian > ; Lukas Straub > Subject: Re: [PATCH V3] net/colo: check vnet_hdr_support flag when using

[PATCH V4 3/3] net/colo-compare.c: Remove vnet_hdr and check in payload from colo-compare

2021-10-26 Thread Zhang Chen
Enable vnet_hdr in payload by default. Make it easier to find module communication configuration errors. Signed-off-by: Zhang Chen --- net/colo-compare.c | 41 ++--- qemu-options.hx| 5 ++--- 2 files changed, 16 insertions(+), 30 deletions(-) diff --git

[PATCH V4 1/3] net/filter: Remove vnet_hdr from filter-mirror and filter-redirector

2021-10-26 Thread Zhang Chen
be 0. Signed-off-by: Zhang Chen --- net/filter-mirror.c | 88 ++--- qemu-options.hx | 14 2 files changed, 25 insertions(+), 77 deletions(-) diff --git a/net/filter-mirror.c b/net/filter-mirror.c index f20240cc9f..4f0e26cc92 100644 --- a/net/f

[PATCH V4 0/3] net/filter: Optimize filters vnet_hdr support

2021-10-26 Thread Zhang Chen
lters and colo-compare's "vnet_hdr_support" flag. v3: Fix some typos. Rebased for Qemu 6.2. v2: Detect virtio-net driver and apply vnet_hdr_support automatically. (Jason) Zhang Chen (3): net/filter: Remove vnet_hdr from filter-mirror and filter-redirector

[PATCH V4 2/3] net/filter: Remove vnet_hdr from filter-rewriter

2021-10-26 Thread Zhang Chen
Make the vnet header a necessary part of filter transfer protocol. So we need remove the module switch here. Signed-off-by: Zhang Chen --- net/filter-rewriter.c | 26 +- qemu-options.hx | 6 +++--- 2 files changed, 4 insertions(+), 28 deletions(-) diff --git a

RE: [PATCH V4 1/3] net/filter: Remove vnet_hdr from filter-mirror and filter-redirector

2021-10-26 Thread Zhang, Chen
> -Original Message- > From: Jason Wang > Sent: Wednesday, October 27, 2021 12:46 PM > To: Zhang, Chen > Cc: qemu-dev ; Markus Armbruster > ; Li Zhijian > Subject: Re: [PATCH V4 1/3] net/filter: Remove vnet_hdr from filter-mirror > and filter-redirector >

RE: [PATCH V4 1/3] net/filter: Remove vnet_hdr from filter-mirror and filter-redirector

2021-10-26 Thread Zhang, Chen
> -Original Message- > From: Jason Wang > Sent: Wednesday, October 27, 2021 2:24 PM > To: Zhang, Chen > Cc: qemu-dev ; Markus Armbruster > ; Li Zhijian > Subject: Re: [PATCH V4 1/3] net/filter: Remove vnet_hdr from filter-mirror > and filter-redirector >

RE: [PATCH V4 1/3] net/filter: Remove vnet_hdr from filter-mirror and filter-redirector

2021-10-26 Thread Zhang, Chen
> -Original Message- > From: Jason Wang > Sent: Wednesday, October 27, 2021 2:45 PM > To: Zhang, Chen > Cc: qemu-dev ; Markus Armbruster > ; Li Zhijian > Subject: Re: [PATCH V4 1/3] net/filter: Remove vnet_hdr from filter-mirror > and filter-redirector >

[PATCH V5 0/3] net/filter: Optimize filters vnet_hdr support

2021-10-28 Thread Zhang Chen
e filters and colo-compare's "vnet_hdr_support" flag. v3: Fix some typos. Rebased for Qemu 6.2. v2: Detect virtio-net driver and apply vnet_hdr_support automatically. (Jason) Zhang Chen (3): net/filter: Optimize transfer protocol for filter-mirror/redirecto

[PATCH V5 1/3] net/filter: Optimize transfer protocol for filter-mirror/redirector

2021-10-28 Thread Zhang Chen
Make the vnet header a necessary part of filter transfer protocol. It make other modules(like another filter-redirector,colo-compare...) know how to parse net packet correctly. If local device is not the virtio-net-pci, vnet_hdr_len will be 0. Signed-off-by: Zhang Chen --- net/filter-mirror.c

[PATCH V5 2/3] net/filter: Optimize transfer protocol for filter-rewriter

2021-10-28 Thread Zhang Chen
Make the vnet header a necessary part of filter transfer protocol. Signed-off-by: Zhang Chen --- net/filter-rewriter.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/net/filter-rewriter.c b/net/filter-rewriter.c index cb3a96cde1..70fa71583a 100644 --- a/net/filter

[PATCH V5 3/3] net/colo-compare.c: Optimize transfer protocol for colo-compare

2021-10-28 Thread Zhang Chen
Enable vnet_hdr in payload by default. Make it easier to find module communication configuration errors. Signed-off-by: Zhang Chen --- net/colo-compare.c | 24 +--- 1 file changed, 17 insertions(+), 7 deletions(-) diff --git a/net/colo-compare.c b/net/colo-compare.c index

RE: [PATCH V5 1/3] net/filter: Optimize transfer protocol for filter-mirror/redirector

2021-10-29 Thread Zhang, Chen
> -Original Message- > From: Jason Wang > Sent: Friday, October 29, 2021 11:11 AM > To: Zhang, Chen > Cc: qemu-dev ; Markus Armbruster > ; Li Zhijian > Subject: Re: [PATCH V5 1/3] net/filter: Optimize transfer protocol for filter- > mirror/redirector >

[PATCH] ui/cocoa: capture screencast with AVAssetWriter

2022-01-10 Thread Zhang Chen
To record screencast, AVAssetWriter APIs were called for each cocoa_update call. Commands for start/stop recording were added to View menu. AVFoundation, CoreMedia and CoreVideo were added as linking dependencies. Signed-off-by: Zhang Chen --- meson.build| 6 +++ ui/cocoa.m | 132

RE: [PATCH V2 1/4] softmmu/runstate.c: add RunStateTransition support form COLO to PRELAUNCH

2022-05-06 Thread Zhang, Chen
> -Original Message- > From: Zhang, Chen > Sent: Wednesday, April 27, 2022 5:26 PM > To: Jason Wang ; Paolo Bonzini > > Cc: Li Zhijian ; qemu-dev de...@nongnu.org>; Like Xu > Subject: RE: [PATCH V2 1/4] softmmu/runstate.c: add RunStateTransition > sup

RE: [PATCH V4 RESEND] net/colo.c: Fix the pointer issue reported by Coverity.

2022-08-17 Thread Zhang, Chen
Ping Jason and Peter, any comments for this patch? Thanks Chen > -Original Message- > From: Zhang, Chen > Sent: Tuesday, August 9, 2022 4:49 PM > To: Jason Wang ; Peter Maydell > ; Li Zhijian ; qemu-dev > > Cc: Zhang, Chen > Subject: [PATCH V4 RESEND] net

RE: [PATCH V4 RESEND] net/colo.c: Fix the pointer issue reported by Coverity.

2022-08-18 Thread Zhang, Chen
> -Original Message- > From: Jason Wang > Sent: Thursday, August 18, 2022 4:04 PM > To: Zhang, Chen > Cc: Peter Maydell ; Li Zhijian > ; qemu-dev > Subject: Re: [PATCH V4 RESEND] net/colo.c: Fix the pointer issue reported by > Coverity. > > On Wed, Aug 1

[PATCH V5] net/colo.c: Fix the pointer issue reported by Coverity.

2022-08-22 Thread Zhang Chen
e any misconfiguration here, the vnet_hdr_len is wrong for parse the packet, the data+offset will point to wrong place. Signed-off-by: Zhang Chen --- net/colo.c | 25 - net/colo.h | 1 + net/trace-events | 2 +- 3 files changed, 18 insertions(+), 10 dele

RE: [PATCH V5] net/colo.c: Fix the pointer issue reported by Coverity.

2022-08-22 Thread Zhang, Chen
> -Original Message- > From: Jason Wang > Sent: Tuesday, August 23, 2022 10:03 AM > To: Zhang, Chen > Cc: Peter Maydell ; Li Zhijian > ; qemu-dev > Subject: Re: [PATCH V5] net/colo.c: Fix the pointer issue reported by > Coverity. > > On Mon, Aug 22, 202

RE: [PATCH v7 01/13] multifd: Document the locking of MultiFD{Send/Recv}Params

2022-06-08 Thread Zhang, Chen
> -Original Message- > From: Qemu-devel bounces+chen.zhang=intel@nongnu.org> On Behalf Of Juan Quintela > Sent: Tuesday, May 31, 2022 6:43 PM > To: qemu-devel@nongnu.org > Cc: Marcel Apfelbaum ; Philippe Mathieu- > Daudé ; Yanan Wang ; Dr. > David Alan Gilbert ; Juan Quintela > ; Ed

RE: [PATCH v7 05/13] multifd: Count the number of bytes sent correctly

2022-06-08 Thread Zhang, Chen
> -Original Message- > From: Qemu-devel bounces+chen.zhang=intel@nongnu.org> On Behalf Of Juan Quintela > Sent: Tuesday, May 31, 2022 6:43 PM > To: qemu-devel@nongnu.org > Cc: Marcel Apfelbaum ; Philippe Mathieu- > Daudé ; Yanan Wang ; Dr. > David Alan Gilbert ; Juan Quintela > ; Ed

[RFC PATCH 02/12] meson: Add ubpf build config and misc

2022-06-17 Thread Zhang Chen
Make meson to build iovisor/ubpf code in Qemu. Signed-off-by: Zhang Chen --- meson.build | 47 + meson_options.txt | 3 ++ scripts/coverity-scan/COMPONENTS.md | 3 ++ scripts/meson-buildoptions.sh | 5 +++ 4 files

[RFC PATCH 01/12] configure: Add iovisor/ubpf project as a submodule for QEMU

2022-06-17 Thread Zhang Chen
Make iovisor/ubpf project be a git submodule for QEMU. It will auto clone ubpf project when configure QEMU. Signed-off-by: Zhang Chen --- .gitmodules | 3 +++ configure | 20 ubpf| 1 + 3 files changed, 24 insertions(+) create mode 16 ubpf diff --git a

[RFC PATCH 03/12] ebpf/uBPF: Introduce userspace ebpf data structure

2022-06-17 Thread Zhang Chen
Add ebpf/ubpf.h for the UbpfState. Signed-off-by: Zhang Chen --- ebpf/ubpf.h | 37 + 1 file changed, 37 insertions(+) create mode 100644 ebpf/ubpf.h diff --git a/ebpf/ubpf.h b/ebpf/ubpf.h new file mode 100644 index 00..2562fff503 --- /dev/null +++ b

[RFC PATCH 09/12] softmmu/vl.c: Add filter-ubpf for netdev as other netfilters

2022-06-17 Thread Zhang Chen
Signed-off-by: Zhang Chen --- softmmu/vl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/softmmu/vl.c b/softmmu/vl.c index 4c1e94b00e..d924fb1c71 100644 --- a/softmmu/vl.c +++ b/softmmu/vl.c @@ -1822,7 +1822,8 @@ static bool object_create_early(const char *type

[RFC PATCH 00/12] Introduce QEMU userspace ebpf support

2022-06-17 Thread Zhang Chen
nt from kernel ebpf needs strict inspection, but yes, it still need basic check). Any comments are welcome. Thanks Chen Zhang Chen (12): configure: Add iovisor/ubpf project as a submodule for QEMU meson: Add ubpf build config and misc ebpf/uBPF: Introduce userspace ebpf data structure ebpf

[RFC PATCH 04/12] ebpf/uBPF: Introduce ubpf initialize functions

2022-06-17 Thread Zhang Chen
Introduce ubpf.c/ubpf-stub.c with basic read and init_jit functions. Add ubpf related .c files to meson.build. Signed-off-by: Zhang Chen --- ebpf/meson.build | 1 + ebpf/ubpf-stub.c | 24 +++ ebpf/ubpf.c | 101 +++ ebpf/ubpf.h

[RFC PATCH 06/12] ebpf/uBPF: Add qemu_ubpf_run_once excute real ebpf program

2022-06-17 Thread Zhang Chen
Before running this function, we need to ensure that the userspace ebpf program has been loaded correctly. Signed-off-by: Zhang Chen --- ebpf/ubpf-stub.c | 6 ++ ebpf/ubpf.c | 16 ebpf/ubpf.h | 2 ++ 3 files changed, 24 insertions(+) diff --git a/ebpf/ubpf

[RFC PATCH 10/12] net/filter-ubpf.c: run the ubpf program to handle network packet

2022-06-17 Thread Zhang Chen
Run the loaded userspace ebpf program with the packet. Signed-off-by: Zhang Chen --- net/filter-ubpf.c | 40 ++-- 1 file changed, 38 insertions(+), 2 deletions(-) diff --git a/net/filter-ubpf.c b/net/filter-ubpf.c index c63a021759..554cc24d8f 100644 --- a

[RFC PATCH 05/12] ebpf/uBPF: Add qemu_prepare_ubpf to load ebpf binary

2022-06-17 Thread Zhang Chen
The qemu_prepare_ubpf() can load user defined userspace ebpf binary file to Qemu userspace ebpf VM but not run it. The ebpf program will triggered in the hook point. Signed-off-by: Zhang Chen --- ebpf/ubpf-stub.c | 5 +++ ebpf/ubpf.c | 100

[RFC PATCH 08/12] qapi: Add FilterUbpfProperties and qemu-options

2022-06-17 Thread Zhang Chen
Add filter-ubpf related QOM and qemu-options. Signed-off-by: Zhang Chen --- qapi/qom.json | 18 ++ qemu-options.hx | 6 ++ 2 files changed, 24 insertions(+) diff --git a/qapi/qom.json b/qapi/qom.json index 6a653c6636..820a5218e8 100644 --- a/qapi/qom.json +++ b/qapi

[RFC PATCH 07/12] net/filter: Introduce filter-ubpf module

2022-06-17 Thread Zhang Chen
The filter-ubpf module able to load user defined ebpf program to handle network packet based on filter framework. Signed-off-by: Zhang Chen --- net/filter-ubpf.c | 149 ++ net/meson.build | 1 + 2 files changed, 150 insertions(+) create mode

[RFC PATCH 11/12] docs/devel: Add userspace-ebpf.rst

2022-06-17 Thread Zhang Chen
Introduce userspace ebpf basic knowledge. Signed-off-by: Zhang Chen --- docs/devel/userspace-ebpf.rst | 106 ++ 1 file changed, 106 insertions(+) create mode 100644 docs/devel/userspace-ebpf.rst diff --git a/docs/devel/userspace-ebpf.rst b/docs/devel/userspace

[RFC PATCH 12/12] test/qtest: Add ubpf basic test case

2022-06-17 Thread Zhang Chen
test will load pre-compiled ebpf binary and run it in QEMU. Signed-off-by: Zhang Chen --- tests/qtest/demo_ubpf.o | Bin 0 -> 544 bytes tests/qtest/integer_5.mem | Bin 0 -> 4 bytes tests/qtest/meson.build | 3 +- tests/qtest/ubpf-test.c | 64 ++

RE: [RFC PATCH 01/12] configure: Add iovisor/ubpf project as a submodule for QEMU

2022-06-19 Thread Zhang, Chen
> -Original Message- > From: Daniel P. Berrangé > Sent: Friday, June 17, 2022 4:05 PM > To: Zhang, Chen > Cc: Jason Wang ; qemu-dev de...@nongnu.org>; Paolo Bonzini ; Eduardo > Habkost ; Eric Blake ; Markus > Armbruster ; Peter Maydell > ; Thomas Hut

RE: [RFC PATCH 01/12] configure: Add iovisor/ubpf project as a submodule for QEMU

2022-06-20 Thread Zhang, Chen
> -Original Message- > From: Thomas Huth > Sent: Monday, June 20, 2022 4:47 PM > To: Daniel P. Berrangé ; Zhang, Chen > > Cc: Jason Wang ; qemu-dev de...@nongnu.org>; Paolo Bonzini ; Eduardo > Habkost ; Eric Blake ; Markus > Armbruster ; Peter Maydel

RE: [RFC PATCH 12/12] test/qtest: Add ubpf basic test case

2022-06-20 Thread Zhang, Chen
> -Original Message- > From: Thomas Huth > Sent: Friday, June 17, 2022 5:34 PM > To: Zhang, Chen ; Jason Wang > ; qemu-dev ; Paolo > Bonzini ; Daniel P. Berrangé > ; Eduardo Habkost ; Eric > Blake ; Markus Armbruster > Cc: Peter Maydell ; Laurent Vivier >

RE: [RFC PATCH 08/12] qapi: Add FilterUbpfProperties and qemu-options

2022-06-20 Thread Zhang, Chen
> -Original Message- > From: Markus Armbruster > Sent: Monday, June 20, 2022 3:45 PM > To: Zhang, Chen > Cc: Jason Wang ; qemu-dev de...@nongnu.org>; Paolo Bonzini ; Daniel > P.Berrangé ; Eduardo Habkost > ; Eric Blake ; Peter Maydell > ; Thomas Hut

RE: [RFC PATCH 01/12] configure: Add iovisor/ubpf project as a submodule for QEMU

2022-06-20 Thread Zhang, Chen
> -Original Message- > From: Daniel P. Berrangé > Sent: Monday, June 20, 2022 6:01 PM > To: Zhang, Chen > Cc: Thomas Huth ; Jason Wang > ; qemu-dev ; Paolo > Bonzini ; Eduardo Habkost ; > Eric Blake ; Markus Armbruster > ; Peter Maydell ; Laurent > Vivier

RE: [RFC PATCH 01/12] configure: Add iovisor/ubpf project as a submodule for QEMU

2022-06-20 Thread Zhang, Chen
> -Original Message- > From: Thomas Huth > Sent: Monday, June 20, 2022 5:44 PM > To: Zhang, Chen ; Daniel P. Berrangé > > Cc: Jason Wang ; qemu-dev de...@nongnu.org>; Paolo Bonzini ; Eduardo > Habkost ; Eric Blake ; Markus > Armbruster ; Peter Maydel

RE: [PATCH] hw/net: Fix Coverity Issue for npcm-gmac

2024-06-19 Thread Zhang, Chen
this function comments the Steps 1/2/3... But I can't find the page 384 of datasheet, please add more details about the datasheet(versions of datasheet, URL). Reviewed-by: Zhang Chen Thanks Chen > Signed-off-by: Nabih Estefan > --- > hw/net/npcm_gmac.c | 1 - > 1 file cha

RE: [PATCH] Fix calculation of minimum in colo_compare_tcp

2024-09-09 Thread Zhang, Chen
> -Original Message- > From: Stefan Weil > Sent: Tuesday, September 10, 2024 4:43 AM > To: Zhang, Chen ; Li Zhijian ; > Jason Wang > Cc: qemu-devel@nongnu.org; Stefan Weil > Subject: [PATCH] Fix calculation of minimum in colo_compare_tcp > > GitHub's

[PATCH 4/4] net/colo.c: fix segmentation fault when packet is not parsed correctly

2022-03-09 Thread Zhang Chen
u Signed-off-by: Zhang Chen --- net/colo.c | 9 - net/trace-events | 1 + 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/net/colo.c b/net/colo.c index 694f3c93ef..6b0ff562ad 100644 --- a/net/colo.c +++ b/net/colo.c @@ -46,7 +46,14 @@ int parse_packet_early(Packet *pkt)

[PATCH 0/4] COLO net and runstate bugfix/optimization

2022-03-09 Thread Zhang Chen
This series fix some COLO related issues in internal stress testing. Zhang Chen (4): softmmu/runstate.c: add RunStateTransition support form COLO to PRELAUNCH net/colo: Fix a "double free" crash to clear the conn_list net/colo.c: No need to track conn_list for filter-rewr

[PATCH 3/4] net/colo.c: No need to track conn_list for filter-rewriter

2022-03-09 Thread Zhang Chen
Filter-rewriter no need to track connection in conn_list. This patch fix the glib g_queue_is_empty assertion when COLO guest keep a lot of network connection. Signed-off-by: Zhang Chen --- net/colo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/colo.c b/net/colo.c

<    1   2   3   4   5   6   7   8   9   10   >