>From b119164ba6715f53594facfc4d1022c198852e9d Mon Sep 17 00:00:00 2001
From: Yi Wang
Date: Mon, 12 Jan 2015 00:05:40 +0800
Subject: [PATCH] savevm: create snapshot failed when id_str already exits
Create snapshot failed in this case:
1) vm has two or more qcow2 disks;
2) the first disk
;
2015-02-25 17:41 GMT+08:00 Stefan Hajnoczi :
> On Mon, Jan 12, 2015 at 01:12:41AM +0800, Yi Wang wrote:
>> From b119164ba6715f53594facfc4d1022c198852e9d Mon Sep 17 00:00:00 2001
>> From: Yi Wang
>> Date: Mon, 12 Jan 2015 00:05:40 +0800
>> Subject: [PATCH] savevm: cre
ng snapshot on '%s'\n",
2015-03-06 1:40 GMT+08:00 Stefan Hajnoczi :
> On Thu, Mar 05, 2015 at 09:05:52PM +0800, Yi Wang wrote:
>> Thanks for your reply and Happy Lantern Festival!
>> I am afraid you misunderstood what I mean, maybe I didn't express
>>
ot list:
ID TAG VM SIZE DATE VM CLOCK
1 s2 0 2015-03-05 10:29:21 00:00:00.000
# virsh snapshot-create-as win7 s1
error: operation failed: Failed to take snapshot: Error while creating
snapshot on 'drive-virtio-disk1'
2015-03-06 23:50 GMT+08:00 Stefan Hajnoczi :
> On Fri, Mar 06, 2015 at
How about this?
>From 913cf2cd04167b7f6b892ac1ab405a617d886b97 Mon Sep 17 00:00:00 2001
From: Yi Wang
Date: Thu, 12 Mar 2015 22:54:42 +0800
Subject: [PATCH] savevm: create snapshot failed when id_str already exists
The command "virsh create" will fail in such condition: vm has t
would be happy to work on a patch to fix this. Please tell me how this
designs if this is not a bug.
Thanks a lot.
--
Best Regards
Yi Wang
From: Liu Xiangyu
During vhost_user_start, if openvswitch.service restart, cause the final
features
not expected. Because qemu not save the ack_features promptly.
Signed-off-by: Liu Xiangyu
Signed-off-by: Yi Wang
---
net/vhost-user.c | 4
1 file changed, 4 insertions(+)
diff --git a
uest and maybe
pending I/O during this flush. Just likes in bdrv_close fuction,
bdrv_drain(bs) followed by bdrv_flush(bs), we should add bdrv_drain fuction
to handle pending I/O after mirror_flush.
Signed-off-by: Long YunJian
Signed-off-by: Yi Wang
---
block/mirror.c | 2 ++
1 file changed, 2 insert
Add [vcpu] index support for hmp command "info lapic", which is
useful when debugging ipi and so on. Current behavior is not
changed when the parameter isn't specified.
Signed-off-by: Yi Wang
Signed-off-by: Yun Liu
---
hmp-commands-info.hx | 6 +++---
target/i386/monitor.c
This series add support querying local apic through apic-id for 'info
lapic'.
As cpu_index will not be used afterwards, so extend 'info registers'
firstly to get apic-id through monitor commands.
Yi Wang (2):
hmp: dump ids including socket-id, core-id and so on for 'inf
This patch add output of CPUs' socket-id, core-id, thread-id and
apic-id for 'info registers', which can be used for querying other
hmp commands.
Signed-off-by: Yi Wang
Signed-off-by: Yun Liu
---
include/qom/cpu.h| 12
monitor.c| 1 +
qom/cpu.c
Add [apic-id] support for hmp command "info lapic", which is
useful when debugging ipi and so on. Current behavior is not
changed when the parameter isn't specified.
Signed-off-by: Yi Wang
Signed-off-by: Yun Liu
---
hmp-commands-info.hx | 6 +++---
target/i386
This patch add output of CPUs' socket-id, core-id, thread-id and
apic-id for 'info registers', which can be used for querying other
hmp commands.
Signed-off-by: Yi Wang
Signed-off-by: Yun Liu
---
target/i386/helper.c | 8
1 file changed, 8 insertions(+)
diff --gi
arch_id() to obtain CPU [Eduardo]
Yi Wang (2):
hmp: dump ids including socket-id, core-id and so on for 'info registers'
hmp: allow apic-id for "info lapic"
hmp-commands-info.hx | 7 ---
include/qom/cpu.h | 10 ++
qom/cpu.c | 11 ---
Add [apic-id] support for hmp command "info lapic", which is
useful when debugging ipi and so on. Current behavior is not
changed when the parameter isn't specified.
Signed-off-by: Yi Wang
Signed-off-by: Yun Liu
Signed-off-by: Eduardo Habkost
---
hmp-commands-info.hx | 7 +
From: Liao Pingfang
Remove superfluous breaks, as there is a "return" before them.
Signed-off-by: Liao Pingfang
---
tcg/riscv/tcg-target.inc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/tcg/riscv/tcg-target.inc.c b/tcg/riscv/tcg-target.inc.c
index 2bc0ba7..3c11ab8 100644
--- a/tcg/ri
From: Liao Pingfang
Remove the superfluous break, as there is a "return" before it.
Signed-off-by: Liao Pingfang
---
fsdev/virtfs-proxy-helper.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fsdev/virtfs-proxy-helper.c b/fsdev/virtfs-proxy-helper.c
index de061a8..e68acc1 100644
--- a/fsde
From: Liao Pingfang
Remove the superfluous break, as there is a "return" before.
Signed-off-by: Liao Pingfang
---
ui/vnc-enc-tight.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/ui/vnc-enc-tight.c b/ui/vnc-enc-tight.c
index 1e08518..cebd358 100644
--- a/ui/vnc-enc-tight.c
+++ b/ui/vnc-en
From: Liao Pingfang
Remove superfluous breaks, as there is a "return" before them.
Signed-off-by: Liao Pingfang
---
target/cris/translate.c | 7 +++
target/cris/translate_v10.inc.c | 2 --
2 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/target/cris/translate.c b/targ
From: Liao Pingfang
Remove superfluous breaks, as there is a "return" before them.
Signed-off-by: Liao Pingfang
---
migration/migration.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/migration/migration.c b/migration/migration.c
index 92e44e0..2fd5fbb 100644
--- a/migration/migration.c
From: Liao Pingfang
Remove superfluous break.
Signed-off-by: Liao Pingfang
---
target/arm/kvm64.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/target/arm/kvm64.c b/target/arm/kvm64.c
index 1169237..ef1e960 100644
--- a/target/arm/kvm64.c
+++ b/target/arm/kvm64.c
@@ -330,7 +330,6 @@ int k
From: Liao Pingfang
Remove superfluous breaks, as there is a "return" before them.
Signed-off-by: Liao Pingfang
---
block/vmdk.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/block/vmdk.c b/block/vmdk.c
index 28cec50..8f222e3 100644
--- a/block/vmdk.c
+++ b/block/vmdk.c
@@ -1053,14 +10
From: Liao Pingfang
Remove superfluous breaks, as there is a "return" before them.
Signed-off-by: Liao Pingfang
---
scsi/utils.c | 4
1 file changed, 4 deletions(-)
diff --git a/scsi/utils.c b/scsi/utils.c
index c50e81f..b37c283 100644
--- a/scsi/utils.c
+++ b/scsi/utils.c
@@ -32,17 +32,
From: Liao Pingfang
Remove superfluous breaks, as there is a "return" before them.
Signed-off-by: Liao Pingfang
---
target/sh4/translate.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/target/sh4/translate.c b/target/sh4/translate.c
index 6192d83..60c863d 100644
--- a/target/sh4/transl
From: Liao Pingfang
Remove superfluous breaks, as there is a "return" before them.
Signed-off-by: Liao Pingfang
---
target/ppc/misc_helper.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/target/ppc/misc_helper.c b/target/ppc/misc_helper.c
index 55b68d1..e43a3b4 100644
--- a/target/pp
From: Liao Pingfang
Remove superfluous breaks, as there is a "return" before them.
Signed-off-by: Liao Pingfang
---
hw/block/pflash_cfi01.c | 1 -
hw/display/cirrus_vga.c | 1 -
hw/display/qxl-logger.c | 2 --
hw/gpio/max7310.c | 3 ---
hw/i386/intel_iommu.c |
From: Liao Pingfang
Remove superfluous breaks, as there is a "return" before them.
Signed-off-by: Liao Pingfang
---
target/openrisc/sys_helper.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/target/openrisc/sys_helper.c b/target/openrisc/sys_helper.c
index d9fe6c5..d9691d0 100644
--- a/
From: Liao Pingfang
Remove superfluous break.
Signed-off-by: Liao Pingfang
Signed-off-by: Yi Wang
Reviewed-by: Philippe Mathieu-Daudé
---
target/arm/kvm64.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/target/arm/kvm64.c b/target/arm/kvm64.c
index 1169237..ef1e960 100644
--- a/target
From: Liao Pingfang
Remove superfluous breaks, as there is a "return" before them.
Signed-off-by: Liao Pingfang
Signed-off-by: Yi Wang
Reviewed-by: Philippe Mathieu-Daudé
---
tcg/riscv/tcg-target.inc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/tcg/riscv/tcg-target.i
From: Liao Pingfang
Remove the superfluous break, as there is a "return" before it.
Signed-off-by: Liao Pingfang
Signed-off-by: Yi Wang
Reviewed-by: Philippe Mathieu-Daudé
---
fsdev/virtfs-proxy-helper.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fsdev/virtfs-proxy-helper
From: Liao Pingfang
Remove superfluous breaks, as there is a "return" before them.
Signed-off-by: Liao Pingfang
Signed-off-by: Yi Wang
Reviewed-by: Philippe Mathieu-Daudé
---
scsi/utils.c | 4
1 file changed, 4 deletions(-)
diff --git a/scsi/utils.c b/scsi/utils.c
ind
From: Liao Pingfang
Remove superfluous breaks, as there is a "return" before them.
Signed-off-by: Liao Pingfang
Signed-off-by: Yi Wang
Reviewed-by: Philippe Mathieu-Daudé
---
target/ppc/misc_helper.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/target/ppc/misc_helper.
From: Liao Pingfang
Remove superfluous breaks, as there is a "return" before them.
Signed-off-by: Liao Pingfang
Signed-off-by: Yi Wang
Reviewed-by: Philippe Mathieu-Daudé
---
migration/migration.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/migration/migration.c b
From: Liao Pingfang
Remove superfluous breaks, as there is a "return" before them.
Signed-off-by: Liao Pingfang
Signed-off-by: Yi Wang
Reviewed-by: Philippe Mathieu-Daudé
---
block/vmdk.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/block/vmdk.c b/block/vmdk.c
ind
From: Liao Pingfang
Remove superfluous breaks, as there is a "return" before them.
Signed-off-by: Liao Pingfang
Signed-off-by: Yi Wang
Reviewed-by: Philippe Mathieu-Daudé
---
hw/block/pflash_cfi01.c | 1 -
hw/display/cirrus_vga.c | 1 -
hw/display/qxl-logger.c | 2 -
From: Liao Pingfang
Remove superfluous breaks, as there is a "return" before them.
Signed-off-by: Liao Pingfang
Signed-off-by: Yi Wang
Reviewed-by: Philippe Mathieu-Daudé
---
target/sh4/translate.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/target/sh4/translate.c b/
From: Liao Pingfang
Remove the superfluous break, as there is a "return" before.
Signed-off-by: Liao Pingfang a
Signed-off-by: Yi Wang
Reviewed-by: Philippe Mathieu-Daudé
---
ui/vnc-enc-tight.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/ui/vnc-enc-tight.c b/ui/vnc-enc-tig
From: Liao Pingfang
Remove superfluous breaks, as there is a "return" before them.
Signed-off-by: Liao Pingfang
Signed-off-by: Yi Wang
Reviewed-by: Philippe Mathieu-Daudé
---
target/cris/translate.c | 7 +++
target/cris/translate_v10.inc.c | 2 --
2 files changed, 3
From: Liao Pingfang
Remove superfluous breaks, as there is a "return" before them.
Signed-off-by: Liao Pingfang
Signed-off-by: Yi Wang
Reviewed-by: Philippe Mathieu-Daudé
---
target/openrisc/sys_helper.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/target/openrisc/sys_
lock-nodes"
}' |grep threshold
"write_threshold": -9223372036854775805,
Fixes: e2462113b200 "block: add event when disk usage exceeds threshold"
Signed-off-by: Ren Lei
Signed-off-by: Yi Wang
---
qapi/block-core.json | 2 +-
1 file changed, 1 insertion
From: Cheng Lin
In a case, we have an not enabled VQ (virtio-net) which desc is NULL
and get a last_avail_idx is not 0 from dpdk.
As a result, it is successed to create a snapshot, but failed to revert it.
Because in virtio_load(), there is an inconsistent check for VQ.
(call virtio_load() in re
From: Liao Pingfang
We need install qemu-[qmp/ga]-ref.* files into the subdirectory of qemu docs:
interop.
If we visit the following address and click the link to qemu-qmp-ref.html:
https://www.qemu.org/docs/master/interop/bitmaps.html#basic-qmp-usage
It will report following error:
"
Not Foun
has the same problem.
Signed-off-by: Yechao Wang
Signed-off-by: Yi Wang
---
qga/commands.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/qga/commands.c b/qga/commands.c
index d3fec80..58d4da9 100644
--- a/qga/commands.c
+++ b/qga/commands.c
@@ -214,17 +214,21
From: Wang Yechao
In some case, $GuestExecInfo.out.length maybe zero and the memory
is leaked in qmp_guest_exec_status(). Call g_free() on the fileds
directly to fix memory leak (NULL is ignored).
$GuestExecInfo.err.data has the same problem.
Signed-off-by: Yechao Wang
Signed-off-by: Yi Wang
Since the ram bitmap and the unsent bitmap are split by RAMBlock
in commit 6b6712e, it's better to update the comments about them.
Signed-off-by: Yi Wang
---
migration/ram.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index 1c
45 matches
Mail list logo
