Re: [Qemu-devel] [PATCH 1/8] Travis: print acceptance tests logs in case of job failure

2019-06-10 Thread Wainer dos Santos Moschetta
andy. Unfortunately you cannot archive the log files in Travis, otherwise that would be a nice option. Reviewed-by: Wainer dos Santos Moschetta @@ -226,6 +226,8 @@ matrix: - env: - CONFIG="--python=/usr/bin/python3 --target-list=x86_64-softmmu,mips-softmmu,mips64el-softmm

Re: [Qemu-devel] [PATCH 2/8] tests/requirements.txt: pin paramiko version requirement

2019-06-10 Thread Wainer dos Santos Moschetta
ion. It's also easily obtainable on systems such as Fedora 30. Signed-off-by: Cleber Rosa --- tests/requirements.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Wainer dos Santos Moschetta diff --git a/tests/requirements.txt b/tests/requirements.txt index 3ae0e29ad

Re: [Qemu-devel] [PATCH 3/8] Acceptance tests: drop left over usage of ":avocado: enable"

2019-06-10 Thread Wainer dos Santos Moschetta
1 file changed, 3 deletions(-) I was about to send a patch to remove it as well. :) Reviewed-by: Wainer dos Santos Moschetta diff --git a/tests/acceptance/migration.py b/tests/acceptance/migration.py index 6115cf6c24..a44c1ae58f 100644 --- a/tests/acceptance/migration.py +++ b/tests/acceptan

Re: [Qemu-devel] [PATCH 4/8] Boot Linux Console Test: add a test for ppc64 + pseries

2019-06-10 Thread Wainer dos Santos Moschetta
line: %s' % kernel_command_line +self.wait_for_console_pattern(console_pattern) I'm refactoring the acceptance tests which boot a Linux Kernel so that they can share common functions. My latest implementation [1] was re-based on this patch, and it would help manage my contrib

Re: [Qemu-devel] [PATCH 5/8] VNC Acceptance test: use UNIX domain sockets to avoid port collisions

2019-06-10 Thread Wainer dos Santos Moschetta
On 06/07/2019 12:22 PM, Cleber Rosa wrote: While running in parallel, the VNC tests that use a TCP port easily collide. There's a number of possibilities to reduce the probability of collisions, but none that completely prevents it from happening. So, to avoid those collisions, and given that

Re: [Qemu-devel] [PATCH 6/8] VNC Acceptance test: simplify test names

2019-06-10 Thread Wainer dos Santos Moschetta
tions(-) Reviewed-by: Wainer dos Santos Moschetta diff --git a/tests/acceptance/vnc.py b/tests/acceptance/vnc.py index 675fd507ed..d32ae46685 100644 --- a/tests/acceptance/vnc.py +++ b/tests/acceptance/vnc.py @@ -45,7 +45,7 @@ class VncUnixSocket(Test): self.socket_dir = tempfile.mk

Re: [Qemu-devel] [PATCH 7/8] VNC Acceptance test: check protocol version

2019-06-10 Thread Wainer dos Santos Moschetta
ssertTrue(self.vm.qmp('query-vnc')['return']['enabled']) I will advocate for the use QEMUMachine.command() instead of qmp(). The former do some checks on the qmp response and raises a more gently exception if something went wrong. This patch looks good t

Re: [Qemu-devel] [PULL 8/8] travis: Make check-acceptance job more verbose

2019-06-10 Thread Wainer dos Santos Moschetta
Hi Eduardo, On 06/07/2019 06:15 PM, Eduardo Habkost wrote: It will help us debug issues when tests fail. Signed-off-by: Eduardo Habkost --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 75e017a5cf..82c74673e1 100644 --- a/.tr

Re: [Qemu-devel] [PATCH v5 0/5] Add "boot_linux" acceptance test

2019-03-14 Thread Wainer dos Santos Moschetta
nged, 68 insertions(+), 3 deletions(-) create mode 100644 tests/acceptance/boot_linux.py The make check-acceptance now finished with success in my system, that does not have qemu-img installed at system-wide (fixed by patches 03 and 04). Also the code looks good to me. So: Reviewed-by: Wainer dos Santos Moschetta

Re: [PATCH] tests/acceptance: Add boot tests for sh4 and mips64 QEMU advent calendar images

2020-02-13 Thread Wainer dos Santos Moschetta
- tests/acceptance/boot_linux_console.py | 23 +-- 2 files changed, 22 insertions(+), 3 deletions(-) This change looks good. Reviewed-by: Wainer dos Santos Moschetta diff --git a/.travis.yml b/.travis.yml index 5887055951..71a0097878 100644 --- a/.travis.yml +++ b/.travis.yml @@ -31

Re: [PATCH] tests/acceptance/ppc_prep_40p: Do not run NetBSD test by default

2020-02-13 Thread Wainer dos Santos Moschetta
environment variable. Reported-by: Alex Bennée Signed-off-by: Philippe Mathieu-Daudé --- tests/acceptance/ppc_prep_40p.py | 1 + 1 file changed, 1 insertion(+) LGTM. Reviewed-by: Wainer dos Santos Moschetta diff --git a/tests/acceptance/ppc_prep_40p.py b/tests/acceptance/ppc_prep_40p.py

Re: [PATCH] tests/acceptance/ppc_prep_40p: Use cdn.netbsd.org hostname

2020-02-13 Thread Wainer dos Santos Moschetta
. Reviewed-by: Wainer dos Santos Moschetta diff --git a/tests/acceptance/ppc_prep_40p.py b/tests/acceptance/ppc_prep_40p.py index efe06037ba..6729d96f5e 100644 --- a/tests/acceptance/ppc_prep_40p.py +++ b/tests/acceptance/ppc_prep_40p.py @@ -34,7 +34,7 @@ def test_factory_firmware_and_netbsd(self

Re: [PATCH v2] tests/acceptance/machine_sparc_leon3: Do not run HelenOS test by default

2020-02-13 Thread Wainer dos Santos Moschetta
: Wainer dos Santos Moschetta diff --git a/tests/acceptance/machine_sparc_leon3.py b/tests/acceptance/machine_sparc_leon3.py index f77e210ccb..27e4717a51 100644 --- a/tests/acceptance/machine_sparc_leon3.py +++ b/tests/acceptance/machine_sparc_leon3.py @@ -5,6 +5,9 @@ # This work is licensed

[RFC PATCH 3/6] travis.yml: Fix 'GCC check-acceptance' job on Ubuntu Bionic

2020-02-17 Thread Wainer dos Santos Moschetta
Ubuntu Bionic does not provide python3.5-venv and then the 'GCC check-acceptance' job was changed to use python3.6-venv. Signed-off-by: Wainer dos Santos Moschetta --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index

[RFC PATCH 5/6] travis.yml: Run '[ppc64] GCC check-tcg' job on Ubuntu Bionic

2020-02-17 Thread Wainer dos Santos Moschetta
Converted the '[ppc64] GCC check-tcg' job to run on Ubuntu 18.04 (Bionic). Signed-off-by: Wainer dos Santos Moschetta --- .travis.yml | 26 -- 1 file changed, 26 deletions(-) diff --git a/.travis.yml b/.travis.yml index 59b9eb20b7..c6465ae807 100644 --- a/.

[RFC PATCH 4/6] travis.yml: Fix 'Clang (main-softmmu)' job on Ubuntu Bionic

2020-02-17 Thread Wainer dos Santos Moschetta
ference to `__ubsan_handle_type_mismatch_v1' ``` In order to solve that problem it was needed to explicitly pass '--cxx=clang++' to the configure. Signed-off-by: Wainer dos Santos Moschetta --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travi

[RFC PATCH 6/6] travis.yml: Run '[aarch64] GCC check-tcg' job on Ubuntu Bionic

2020-02-17 Thread Wainer dos Santos Moschetta
Converted the '[aarch64] GCC check-tcg' job to run on Ubuntu 18.04 (Bionic). Signed-off-by: Wainer dos Santos Moschetta --- .travis.yml | 26 -- 1 file changed, 26 deletions(-) diff --git a/.travis.yml b/.travis.yml index c6465ae807..e0d2475899 100644 --- a/.

[RFC PATCH 0/6] Travis: Change default environment to Ubuntu Bionic

2020-02-17 Thread Wainer dos Santos Moschetta
unchpad.net/qemu/+bug/1838763 [3] https://travis-ci.org/wainersm/qemu/builds/651549376 [4] https://travis-ci.org/qemu/qemu/builds/651506018 Wainer dos Santos Moschetta (6): travis.yml: Bump default environment to Ubuntu Bionic travis.yml: Fix 'GCC9 with sanitizers' job on Ubuntu Bio

[RFC PATCH 2/6] travis.yml: Fix 'GCC9 with sanitizers' job on Ubuntu Bionic

2020-02-17 Thread Wainer dos Santos Moschetta
issue on Bionic Signed-off-by: Wainer dos Santos Moschetta --- .travis.yml | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/.travis.yml b/.travis.yml index e46c44bbee..232f84d196 100644 --- a/.travis.yml +++ b/.travis.yml @@ -336,7 +336,7 @@ matrix: u

[RFC PATCH 1/6] travis.yml: Bump default environment to Ubuntu Bionic

2020-02-17 Thread Wainer dos Santos Moschetta
obs explicitly use Xenial so they aren't converted on this patch. Signed-off-by: Wainer dos Santos Moschetta --- .travis.yml | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/.travis.yml b/.travis.yml index 5887055951..e46c44bbee 100644 --- a/.travis.yml

Re: [PATCH v2 1/6] tests/boot_linux_console: add microvm acceptance test

2020-02-19 Thread Wainer dos Santos Moschetta
Liam, Sorry for the long time to reply it... comments below. On 2/6/20 1:05 PM, Liam Merwick wrote: On 06/02/2020 14:09, Philippe Mathieu-Daudé wrote: Hi Liam, On 2/6/20 2:57 PM, Philippe Mathieu-Daudé wrote: On 2/5/20 3:56 PM, Liam Merwick wrote: Refactor test_x86_64_pc() to test_x86_64_ma

Re: [PATCH v2 2/6] tests/boot_linux_console: add BIOS acceptance test

2020-02-19 Thread Wainer dos Santos Moschetta
On 2/6/20 12:12 PM, Philippe Mathieu-Daudé wrote: On 2/5/20 3:56 PM, Liam Merwick wrote: Add a test to use qboot with the 'pc' machine class and SeaBIOS with the 'microvm' machine class (since microvm uses qboot by default) by adding the '-bios' option via self.vm.add_args() before calling do_

Re: [PATCH v9 1/3] Acceptance tests: introduce BUILD_DIR and SOURCE_DIR

2020-02-20 Thread Wainer dos Santos Moschetta
tions(+), 6 deletions(-) Reviewed-by: Wainer dos Santos Moschetta Also tested with QEMU built outside of source dir: Tested-by: Wainer dos Santos Moschetta diff --git a/tests/acceptance/avocado_qemu/__init__.py b/tests/acceptance/avocado_qemu/__init__.py index d4358eb431..59e7b4f763 100644

Re: [PATCH v9 2/3] Acceptance test: add "boot_linux" tests

2020-02-20 Thread Wainer dos Santos Moschetta
On 2/19/20 11:06 PM, Cleber Rosa wrote: This acceptance test, validates that a full blown Linux guest can successfully boot in QEMU. In this specific case, the guest chosen is Fedora version 31. * x86_64, pc-i440fx and pc-q35 machine types, with TCG and KVM as accelerators * aarch64

Re: [PATCH v1 2/4] Acceptance test: EXEC migration

2020-02-20 Thread Wainer dos Santos Moschetta
On 2/14/20 12:52 PM, Oksana Vohchana wrote: Improves EXEC migration to run whole test stage Signed-off-by: Oksana Vohchana --- tests/acceptance/migration.py | 2 ++ 1 file changed, 2 insertions(+) Indeed, with this changes the migration is triggered. Tested-by: Wainer dos Santos

Re: [PATCH v1 1/4] Acceptance test: add address as param

2020-02-20 Thread Wainer dos Santos Moschetta
by patches 03 and 04. - You could have described in the cover letter (or in the commit) your intention with this change. Reviewed-by: Wainer dos Santos Moschetta Thanks! - Wainer if port is None: self.cancel('Failed to find a free port') return port

[PATCH 2/2] .travis.yml: Add kernel build deps for acceptance tests

2019-12-06 Thread Wainer dos Santos Moschetta
The tests/acceptance/pvh.py test builds the Linux kernel at runtime so it needs dependencies installed in the container. Current used container image misses only libelf-dev, which is then added with this change. Signed-off-by: Wainer dos Santos Moschetta --- .travis.yml | 2 ++ 1 file changed

[PATCH 0/2] tests/acceptance: Add boot vmlinux test

2019-12-06 Thread Wainer dos Santos Moschetta
add a guard to skip it. [1] https://github.com/avocado-framework/avocado/pull/3389 Wainer dos Santos Moschetta (2): tests/acceptance: Add PVH boot test .travis.yml: Add kernel build deps for acceptance tests .travis.yml | 2 ++ tests/acceptance/pvh.py | 48

[PATCH 1/2] tests/acceptance: Add PVH boot test

2019-12-06 Thread Wainer dos Santos Moschetta
QEMU 4.0 onward is able to boot an uncompressed kernel image by using the x86/HVM direct boot ABI. It needs Linux >= 4.21 built with CONFIG_PVH=y. This introduces an acceptance test which checks an uncompressed Linux kernel image boots properly. Signed-off-by: Wainer dos Santos Mosche

[PATCH v2 4/4] python/qemu: accel: Add tcg_available() method

2019-12-06 Thread Wainer dos Santos Moschetta
This adds a method to check if the tcg accelerator is enabled in the QEMU binary. Signed-off-by: Wainer dos Santos Moschetta Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé --- python/qemu/accel.py | 8 1 file changed, 8 insertions(+) diff --git a/python/qemu/accel.py b

[PATCH v2 3/4] python/qemu: accel: Strengthen kvm_available() checks

2019-12-06 Thread Wainer dos Santos Moschetta
Currently kvm_available() checks for the presence of kvm module and, if target and host arches don't mismatch. This patch adds an 3rd checking: if QEMU binary was compiled with kvm support. Signed-off-by: Wainer dos Santos Moschetta Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-

[PATCH v2 0/4] python/qemu: New accel module and improvements

2019-12-06 Thread Wainer dos Santos Moschetta
ithub.com/wainersm/qemu - Branch: python_accel_v2 CI: - Travis (FAIL): https://travis-ci.org/wainersm/qemu/builds/621748861 Wainer dos Santos Moschetta (4): python/qemu: Move kvm_available() to its own module python/qemu: accel: Add list_accel() method python/qemu: accel: Strengthen kvm_avai

[PATCH v2 2/4] python/qemu: accel: Add list_accel() method

2019-12-06 Thread Wainer dos Santos Moschetta
Since commit cbe6d6365a48 the command `qemu -accel help` returns the list of accelerators enabled in the QEMU binary. This adds the list_accel() method which return that same list. Signed-off-by: Wainer dos Santos Moschetta Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé

[PATCH v2 1/4] python/qemu: Move kvm_available() to its own module

2019-12-06 Thread Wainer dos Santos Moschetta
This creates the 'accel' Python module to be the home for utilities that deal with accelerators. Also moved kvm_available() from __init__.py to this new module. Signed-off-by: Wainer dos Santos Moschetta Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé --- python/qemu/_

Re: [PATCH 1/2] tests/acceptance: Add PVH boot test

2019-12-09 Thread Wainer dos Santos Moschetta
On 12/6/19 2:54 PM, Cleber Rosa wrote: On Fri, Dec 06, 2019 at 09:00:11AM -0500, Wainer dos Santos Moschetta wrote: QEMU 4.0 onward is able to boot an uncompressed kernel image by using the x86/HVM direct boot ABI. It needs Linux >= 4.21 built with CONFIG_PVH=y. This introduces an accepta

Re: [PATCH 0/2] tests/acceptance: Use QEMUMachine on tests that expect failure

2019-12-09 Thread Wainer dos Santos Moschetta
Ping. Any brave soul to review it? :) - Wainer On 11/12/19 11:57 AM, Wainer dos Santos Moschetta wrote: The linux_initrd and empty_cpu_model tests assert that QEMU exit with failure on certain scenarios. Currently they are not able to use QEMUMachine object due to the QMP monitor connection

Re: [PATCH 1/2] python/qemu: Add set_qmp_monitor() to QEMUMachine

2019-12-11 Thread Wainer dos Santos Moschetta
On 12/10/19 3:17 AM, Cleber Rosa wrote: On Tue, Nov 12, 2019 at 08:58:00AM -0500, Wainer dos Santos Moschetta wrote: The QEMUMachine VM has a monitor setup on which an QMP connection is always attempted on _post_launch() (executed by launch()). In case the QEMU process immediatly exits then

Re: [PATCH v2 2/4] python/qemu: accel: Add list_accel() method

2019-12-11 Thread Wainer dos Santos Moschetta
On 12/9/19 10:52 PM, Cleber Rosa wrote: On Fri, Dec 06, 2019 at 04:34:31PM -0500, Wainer dos Santos Moschetta wrote: Since commit cbe6d6365a48 the command `qemu -accel help` returns the list of accelerators enabled in the QEMU binary. This adds the list_accel() method which return that same

[PATCH v2 0/2] tests/acceptance: Use QEMUMachine on tests that expect failure

2019-12-11 Thread Wainer dos Santos Moschetta
nnot be empty' message shows in the output. Git: - Tree: https://github.com/wainersm/qemu - Branch: tests_without_qmp_v2 CI: - Travis (PASS): https://travis-ci.org/wainersm/qemu/builds/623716505 References: [1] https://www.mail-archive.com/qemu-devel@nongnu.org/msg627498.html Wainer dos Sant

[PATCH v2 2/2] tests/acceptance: Makes linux_initrd and empty_cpu_model use QEMUMachine

2019-12-11 Thread Wainer dos Santos Moschetta
follow the same pattern to launch QEMU found on other acceptance tests. Signed-off-by: Wainer dos Santos Moschetta Reviewed-by: Cleber Rosa Tested-by: Cleber Rosa --- tests/acceptance/empty_cpu_model.py | 12 ++-- tests/acceptance/linux_initrd.py| 13 +++-- 2 files changed, 13

[PATCH v2 1/2] python/qemu: Add set_qmp_monitor() to QEMUMachine

2019-12-11 Thread Wainer dos Santos Moschetta
launch. Signed-off-by: Wainer dos Santos Moschetta Reviewed-by: Cleber Rosa --- python/qemu/machine.py | 66 +++--- 1 file changed, 43 insertions(+), 23 deletions(-) diff --git a/python/qemu/machine.py b/python/qemu/machine.py index a4631d6934..7d4d621a42

Re: [RFC PATCH] scripts/tap-driver: report "slow" tests (HACK)

2019-12-11 Thread Wainer dos Santos Moschetta
At least make check did not crash miserably, so: Tested-by: Wainer dos Santos Moschetta --- scripts/tap-driver.pl | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/scripts/tap-driver.pl b/scripts/tap-driver.pl index 6621a5cd671..0fe748d5de6 1007

[PATCH 1/1] tests/Makefile: Fix check-report.* targets shown in check-help

2019-12-11 Thread Wainer dos Santos Moschetta
The check-report.html and check-report.xml targets were replaced with check-report.tap in commit 9df43317b82 but the check-help text was not updated so it still lists check-report.html. Fixes: 9df43317b82 Signed-off-by: Wainer dos Santos Moschetta --- tests/Makefile.include | 4 +--- 1 file

[PATCH 0/1] tests/Makefile: Show check-report.tap in check-help

2019-12-11 Thread Wainer dos Santos Moschetta
Simple fix to commit 9df43317b82 that didn't adjust check-help. Wainer dos Santos Moschetta (1): tests/Makefile: Fix check-report.* targets shown in check-help tests/Makefile.include | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) -- 2.21.0

[PATCH v3 3/5] python/qemu: accel: Strengthen kvm_available() checks

2019-12-12 Thread Wainer dos Santos Moschetta
Currently kvm_available() checks for the presence of kvm module and, if target and host arches don't mismatch. This patch adds an 3rd checking: if QEMU binary was compiled with kvm support. Signed-off-by: Wainer dos Santos Moschetta Reviewed-by: Alex Bennée Reviewed-by: Cleber Rosa Review

[PATCH v3 4/5] python/qemu: accel: Add tcg_available() method

2019-12-12 Thread Wainer dos Santos Moschetta
This adds a method to check if the tcg accelerator is enabled in the QEMU binary. Signed-off-by: Wainer dos Santos Moschetta Reviewed-by: Alex Bennée Reviewed-by: Cleber Rosa Reviewed-by: Philippe Mathieu-Daudé Tested-by: Cleber Rosa --- python/qemu/accel.py | 8 1 file changed, 8

[PATCH v3 1/5] python/qemu: Move kvm_available() to its own module

2019-12-12 Thread Wainer dos Santos Moschetta
This creates the 'accel' Python module to be the home for utilities that deal with accelerators. Also moved kvm_available() from __init__.py to this new module. Signed-off-by: Wainer dos Santos Moschetta Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé --- python/qemu/_

[PATCH v3 5/5] python/qemu: Remove unneeded imports in __init__

2019-12-12 Thread Wainer dos Santos Moschetta
__init_.py import some sub-modules unnecessarily. So let's clean it up. Signed-off-by: Wainer dos Santos Moschetta Suggested-by: Cleber Rosa --- python/qemu/__init__.py | 6 -- 1 file changed, 6 deletions(-) diff --git a/python/qemu/__init__.py b/python/qemu/__init__.py index eff17

[PATCH v3 0/5] python/qemu: New accel module and improvements

2019-12-12 Thread Wainer dos Santos Moschetta
e] - logging added only when used on python/qemu/accel.py (patch 02) [alex.bennee] Git: - Tree: https://github.com/wainersm/qemu - Branch: python_accel_v3 CI: - Travis (FAIL): https://travis-ci.org/wainersm/qemu/builds/623800273 Failure is not related with this change Wainer dos Santo

[PATCH v3 2/5] python/qemu: accel: Add list_accel() method

2019-12-12 Thread Wainer dos Santos Moschetta
Since commit cbe6d6365a48 the command `qemu -accel help` returns the list of accelerators enabled in the QEMU binary. This adds the list_accel() method which return that same list. Signed-off-by: Wainer dos Santos Moschetta Reviewed-by: Alex Bennée Reviewed-by: Cleber Rosa Reviewed-by

Re: [PATCH v2 1/2] python/qemu: Add set_qmp_monitor() to QEMUMachine

2019-12-13 Thread Wainer dos Santos Moschetta
On 12/12/19 12:13 PM, Cleber Rosa wrote: On Wed, Dec 11, 2019 at 01:55:35PM -0500, Wainer dos Santos Moschetta wrote: The QEMUMachine VM has a monitor setup on which an QMP connection is always attempted on _post_launch() (executed by launch()). In case the QEMU process immediatly exits then

[PATCH v4 1/5] python/qemu: Move kvm_available() to its own module

2019-12-16 Thread Wainer dos Santos Moschetta
This creates the 'accel' Python module to be the home for utilities that deal with accelerators. Also moved kvm_available() from __init__.py to this new module. Signed-off-by: Wainer dos Santos Moschetta Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé --- python/qemu/_

[PATCH v4 3/5] python/qemu: accel: Strengthen kvm_available() checks

2019-12-16 Thread Wainer dos Santos Moschetta
Currently kvm_available() checks for the presence of kvm module and, if target and host arches don't mismatch. This patch adds an 3rd checking: if QEMU binary was compiled with kvm support. Signed-off-by: Wainer dos Santos Moschetta Reviewed-by: Alex Bennée Reviewed-by: Cleber Rosa Review

[PATCH v4 0/5] python/qemu: New accel module and improvements

2019-12-16 Thread Wainer dos Santos Moschetta
G): https://travis-ci.org/wainersm/qemu/builds/625827750 Wainer dos Santos Moschetta (5): python/qemu: Move kvm_available() to its own module python/qemu: accel: Add list_accel() method python/qemu: accel: Strengthen kvm_available() checks python/qemu: accel: Add tcg_available() method

[PATCH v4 2/5] python/qemu: accel: Add list_accel() method

2019-12-16 Thread Wainer dos Santos Moschetta
Since commit cbe6d6365a48 the command `qemu -accel help` returns the list of accelerators enabled in the QEMU binary. This adds the list_accel() method which return that same list. Signed-off-by: Wainer dos Santos Moschetta --- python/qemu/accel.py | 23 +++ 1 file changed

[PATCH v4 4/5] python/qemu: accel: Add tcg_available() method

2019-12-16 Thread Wainer dos Santos Moschetta
This adds a method to check if the tcg accelerator is enabled in the QEMU binary. Signed-off-by: Wainer dos Santos Moschetta Reviewed-by: Alex Bennée Reviewed-by: Cleber Rosa Reviewed-by: Philippe Mathieu-Daudé Tested-by: Cleber Rosa --- python/qemu/accel.py | 8 1 file changed, 8

[PATCH v4 5/5] python/qemu: Remove unneeded imports in __init__

2019-12-16 Thread Wainer dos Santos Moschetta
__init_.py import some sub-modules unnecessarily. So let's clean it up. Signed-off-by: Wainer dos Santos Moschetta Suggested-by: Cleber Rosa Reviewed-by: Cleber Rosa Tested-by: Cleber Rosa --- python/qemu/__init__.py | 6 -- 1 file changed, 6 deletions(-) diff --git a/python

Re: [PATCH v2 03/29] python/qemu: Add binutils::binary_get_version()

2020-02-03 Thread Wainer dos Santos Moschetta
On 1/29/20 7:23 PM, Philippe Mathieu-Daudé wrote: Add a helper to query the version of a QEMU binary. We simply send the 'query-version' command over a QMP socket. Introduce the PythonQemuCoreScripts class to test our new helper. Signed-off-by: Philippe Mathieu-Daudé --- python/qemu/binutil

Re: [PATCH 1/2] configure: Allow user to specify sphinx-build binary

2020-02-04 Thread Wainer dos Santos Moschetta
etter convention, but it makes more sense to me to stick with the convention we currently mostly have. (Perhaps we should even change --with-git= to --git= ?) configure | 10 +- Makefile | 2 +- 2 files changed, 10 insertions(+), 2 deletions(-) Reviewed-by: Wainer dos Santos Moschetta

Re: [PATCH 2/2] configure: Check that sphinx-build is using Python 3

2020-02-04 Thread Wainer dos Santos Moschetta
rather than let users stumble into corner cases we don't test and don't want to support even if they happen to work today. --- configure| 12 ++-- docs/conf.py | 10 ++ 2 files changed, 20 insertions(+), 2 deletions(-) Reviewed-by: Wainer dos Santos Moschetta

[PATCH v2 2/5] python/qemu: Delint the qmp module

2020-02-04 Thread Wainer dos Santos Moschetta
g) Signed-off-by: Wainer dos Santos Moschetta Reviewed-by: John Snow --- python/qemu/qmp.py | 51 +- 1 file changed, 41 insertions(+), 10 deletions(-) diff --git a/python/qemu/qmp.py b/python/qemu/qmp.py index 8c6c9847d0..f4e04a6683 100644 --- a/python/q

[PATCH v2 1/5] python/qemu: qmp: Replace socket.error with OSError

2020-02-04 Thread Wainer dos Santos Moschetta
The socket.error is deprecated from Python 3.3, instead it is made a link to OSError. This change replaces the occurences of socket.error with OSError. Signed-off-by: Wainer dos Santos Moschetta Reviewed-by: John Snow --- python/qemu/qmp.py | 16 1 file changed, 8 insertions

[PATCH v2 3/5] python/qemu: qmp: Make accept()'s timeout configurable

2020-02-04 Thread Wainer dos Santos Moschetta
Currently the timeout of QEMUMonitorProtocol.accept() is hard-coded to 15.0 seconds. This added the parameter `timeout` so the value can be configured by the user. Signed-off-by: Wainer dos Santos Moschetta Reviewed-by: Philippe Mathieu-Daudé --- python/qemu/qmp.py | 11 +-- 1 file

[PATCH v2 0/5] python/qemu: qmp: Fix, delint and improvements

2020-02-04 Thread Wainer dos Santos Moschetta
): https://travis-ci.org/wainersm/qemu/builds/645583812 Jobs failures aren't related with these changes Wainer dos Santos Moschetta (5): python/qemu: qmp: Replace socket.error with OSError python/qemu: Delint the qmp module python/qemu: qmp: Make accept()'s timeout configurable p

[PATCH v2 4/5] python/qemu: qmp: Make QEMUMonitorProtocol a context manager

2020-02-04 Thread Wainer dos Santos Moschetta
This implement the __enter__ and __exit__ functions on QEMUMonitorProtocol class so that it can be used on 'with' statement and the resources will be free up on block end: with QEMUMonitorProtocol(socket_path) as qmp: qmp.connect() qmp.command('query-status') Signe

[PATCH v2 5/5] python/qemu: qmp: Remove unnused attributes

2020-02-04 Thread Wainer dos Santos Moschetta
The `error` and `timeout` attributes in QEMUMonitorProtocol are not used, so this delete them. Signed-off-by: Wainer dos Santos Moschetta Reviewed-by: John Snow --- python/qemu/qmp.py | 4 1 file changed, 4 deletions(-) diff --git a/python/qemu/qmp.py b/python/qemu/qmp.py index

Re: [PATCH] tests/acceptance/migration: Add the 'migration' tag

2020-02-04 Thread Wainer dos Santos Moschetta
py | 3 +++ 1 file changed, 3 insertions(+) Reviewed-by: Wainer dos Santos Moschetta diff --git a/tests/acceptance/migration.py b/tests/acceptance/migration.py index 41b13b9e0d..b342cabe07 100644 --- a/tests/acceptance/migration.py +++ b/tests/acceptance/migration.py @@ -20,6 +20,9 @

Re: [PATCH 1/1] tests/acceptance: Count Raspberry Pi logos displayed on framebuffer

2020-02-04 Thread Wainer dos Santos Moschetta
On 2/3/20 2:08 PM, Philippe Mathieu-Daudé wrote: On 2/3/20 3:21 PM, Wainer dos Santos Moschetta wrote: On 1/31/20 9:24 PM, Philippe Mathieu-Daudé wrote: Add a test that verifies that each core properly displays the Raspberry Pi logo on the framebuffer device. We simply follow the OpenCV

Re: [PATCH v3 2/4] tests/acceptance: boot_linux_console: Add boot Linux with kvm tests

2020-02-04 Thread Wainer dos Santos Moschetta
On 1/24/20 1:45 PM, Philippe Mathieu-Daudé wrote: On 1/22/20 2:27 AM, Wainer dos Santos Moschetta wrote: Added boot Linux test cases that launch QEMU with kvm enabled. Likewise it was added tests for tcg. Signed-off-by: Wainer dos Santos Moschetta ---   tests/acceptance

Re: [PATCH v3 1/4] tests/acceptance: avocado_qemu: Introduce the 'accel' test parameter

2020-02-04 Thread Wainer dos Santos Moschetta
On 1/30/20 8:51 PM, Philippe Mathieu-Daudé wrote: On 1/27/20 8:28 PM, Wainer dos Santos Moschetta wrote: On 1/24/20 7:36 AM, Philippe Mathieu-Daudé wrote: On 1/22/20 2:27 AM, Wainer dos Santos Moschetta wrote: The test case may need to boot the VM with an accelerator that isn't act

[PATCH v4 4/8] python/qemu: accel: Fix kvm_available() on ppc64le

2020-02-05 Thread Wainer dos Santos Moschetta
0d7 Signed-off-by: Wainer dos Santos Moschetta --- python/qemu/accel.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/python/qemu/accel.py b/python/qemu/accel.py index 0b38ddf0ab..36ae85791e 100644 --- a/python/qemu/accel.py +++ b/python/qemu/accel.py @@ -24,7 +24,8 @@

[PATCH v4 8/8] travis.yml: Enable acceptance KVM tests

2020-02-05 Thread Wainer dos Santos Moschetta
to /dev/kvm. python3.5-venv is not packaged on Bionic. So it was replaced with python3.6-venv. Signed-off-by: Wainer dos Santos Moschetta --- .travis.yml | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 1ae645e9fc..76fc828887 100644 --- a

[PATCH v4 5/8] test/acceptance: boot_linux_console: Add boot Linux/ppc64le with KVM

2020-02-05 Thread Wainer dos Santos Moschetta
Likewise this splitted the boot Linux for ppc64le test in a version for KVM and another for TCG. The kvm test case is designed to run on POWER8 or greater, otherwise it is skipped. The SMT should be off on POWER8, that is also checked. Signed-off-by: Wainer dos Santos Moschetta --- tests

[PATCH v4 7/8] tests/acceptance: avocado_qemu: Refactor the handler of 'machine' parameter

2020-02-05 Thread Wainer dos Santos Moschetta
The Test._param_to_vm_args variable contain VM arguments that should be added at launch which were originated from test parameters. Use this variable to set -M from 'machine' parameter as well. Signed-off-by: Wainer dos Santos Moschetta Reviewed-by: Philippe Mathieu-Daudé --- tests/

[PATCH v4 1/8] tests/acceptance: avocado_qemu: Introduce the 'accel' test parameter

2020-02-05 Thread Wainer dos Santos Moschetta
nt. Signed-off-by: Wainer dos Santos Moschetta --- docs/devel/testing.rst| 16 tests/acceptance/avocado_qemu/__init__.py | 23 +++ 2 files changed, 39 insertions(+) diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst index ab5be0c

[PATCH v4 6/8] tests/acceptance: boot_linux_console: Add boot Linux/s390x with KVM

2020-02-05 Thread Wainer dos Santos Moschetta
Yet another splitting of boot the Linux tests between KVM and TCG. This time for s390x. Signed-off-by: Wainer dos Santos Moschetta --- tests/acceptance/boot_linux_console.py | 22 +- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/tests/acceptance

[PATCH v4 2/8] tests/acceptance: boot_linux_console: Add boot Linux/x86 with KVM

2020-02-05 Thread Wainer dos Santos Moschetta
Added boot Linux on x86_64 test case that launch QEMU with KVM enabled. Likewise it was added one test for TCG. Signed-off-by: Wainer dos Santos Moschetta --- tests/acceptance/boot_linux_console.py | 22 +- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/tests

[PATCH v4 0/8] Acceptance tests: boot Linux with KVM test

2020-02-05 Thread Wainer dos Santos Moschetta
st-v4 CI: - Travis (FAIL): https://travis-ci.org/wainersm/qemu/builds/646154220 Failed jobs are not related with this series changes. Wainer dos Santos Moschetta (8): tests/acceptance: avocado_qemu: Introduce the 'accel' test parameter tests/acceptance: boot_linux_console: Add

[PATCH v4 3/8] tests/acceptance: boot_linux_console: Add boot Linux/aarch64 with KVM

2020-02-05 Thread Wainer dos Santos Moschetta
pass the GIC version. The reason for that is an Avocado limitation, which is unable to parse correctly a tag containing ',' (this char being a tag delimiter). Keep the 'machine:virt' tag is still useful since it can be used on tests filtering. Signed-off-by: Wainer dos

Re: [RFC PATCH 2/2] GitLab CI: crude mapping of PMM's scripts to jobs

2020-02-06 Thread Wainer dos Santos Moschetta
On 2/6/20 11:03 AM, Philippe Mathieu-Daudé wrote: On 2/3/20 4:23 AM, Cleber Rosa wrote: This is a crude and straightforward mapping of Peter's "remake-merge-builds" and "pull-buildtest" scripts. Some characteristics were removed for simplicity sake (but eventually will), including:   * number

Re: [PATCH v2 27/29] tests/acceptance/migration: Default to -nodefaults

2020-02-07 Thread Wainer dos Santos Moschetta
tance tests the majority is going to fail with --without-default-devices. So could we do better on this problem? Although I would prefer a solution that cover all the tests, nothing is wrong with this change: Reviewed-by: Wainer dos Santos Moschetta Signed-off-by: Philippe Mathieu-

Re: [PATCH v2 28/29] tests/acceptance/version: Default to -nodefaults

2020-02-07 Thread Wainer dos Santos Moschetta
Daudé --- tests/acceptance/version.py | 1 + 1 file changed, 1 insertion(+) My comments in [1] also applies for this change. So: Reviewed-by: Wainer dos Santos Moschetta [1] https://www.mail-archive.com/qemu-devel@nongnu.org/msg675104.html diff --git a/tests/acceptance/version.py b/

Re: [PATCH] tests/acceptance/virtio_check_params: Disable test

2020-02-07 Thread Wainer dos Santos Moschetta
On 2/6/20 3:17 PM, Philippe Mathieu-Daudé wrote: This test fails on various CI: What CI(s) you mean? Afaik the acceptance tests are executed only on Travis - Using QEMU 4.0: tests/acceptance/x86_cpu_model_versions.py:X86CPUModelAliases.test_none_alias: ERROR: 'alias-of' (0.45 s)

[PATCH 1/1] travis.yml: Fix Travis YAML configuration warnings

2020-02-07 Thread Wainer dos Santos Moschetta
ue (3.5)' - 'on jobs.include.python: unexpected sequence, using the first value (3.6)' Signed-off-by: Wainer dos Santos Moschetta --- .travis.yml | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/.travis.yml b/.travis.yml index 6c0ec6cf69..b1228e9175 10064

[PATCH 0/1] Travis: Fix YAML warnings

2020-02-07 Thread Wainer dos Santos Moschetta
-ci.org/wainersm/qemu/builds/647461515/config [3] https://config.travis-ci.com/explore Wainer dos Santos Moschetta (1): travis.yml: Fix Travis YAML configuration warnings .travis.yml | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) -- 2.24.1

Re: [PATCH] MAINTAINERS: Add Philippe, Alex and Wainer to the Gitlab-CI section

2020-02-10 Thread Wainer dos Santos Moschetta
S | 3 +++ 1 file changed, 3 insertions(+) Reviewed-by: Wainer dos Santos Moschetta diff --git a/MAINTAINERS b/MAINTAINERS index e72b5e5f69..64ef7a1906 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2743,6 +2743,9 @@ W: https://cirrus-ci.com/github/qemu/qemu GitLab Continuous Integration

Re: [PATCH v2] gitlab-ci: Move EDK2 YAML config to .gitlab-ci.d directory

2020-02-11 Thread Wainer dos Santos Moschetta
directory. Move the YAML file, update its references. Suggested-by: Wainer dos Santos Moschetta Reviewed-by: Laszlo Ersek Acked-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé --- Supersedes: <20200211065022.11134-1-phi...@redhat.com> v2: Reworded subject/description (Thomas) --- .git

Re: [PATCH 01/15] tests/avocado: add RISC-V opensbi boot test

2022-12-27 Thread Wainer dos Santos Moschetta
;virt' 32 bit machines are able to run the default RISCV64_BIOS_BIN | RISCV32_BIOS_BIN firmware with minimal options. Cc: Cleber Rosa Cc: Philippe Mathieu-Daudé Cc: Wainer dos Santos Moschetta Cc: Beraldo Leal Signed-off-by: Daniel Henrique Barboza --- tests/avocado/riscv_opensbi.py | 65

Re: [Qemu-devel] [PATCH] Acceptance test: add coverage tests for -smp option

2018-12-03 Thread Wainer dos Santos Moschetta
On 11/12/2018 02:31 PM, Eduardo Habkost wrote: On Fri, Nov 09, 2018 at 02:58:00PM -0500, Wainer dos Santos Moschetta wrote: This adds tests for SMP option, by passing -smp with various combinations of cpus, cores, threads, and sockets values it checks that invalid topologies are not accepted

Re: [Qemu-devel] [PATCH] apic: Make APIC ID limit error message clearer

2018-12-03 Thread Wainer dos Santos Moschetta
On 11/26/2018 08:56 PM, Eduardo Habkost wrote: Remove the "apic initialization failed" prefix (it conveys no useful information), replace "invalid" with "too large", and add an error hint with two possible solutions for the problem. Before: $ qemu-system-x86_64 -machine q35 -smp 256 qem

[Qemu-devel] [PATCH] target/i386: Fixes to the check missing features routine

2018-12-07 Thread Wainer dos Santos Moschetta
"spec-ctrl", "ssbd", "3dnowprefetch", "xsavec", "xgetbv1", "mpx", "mpx", "avx512f",

[Qemu-devel] [PATCH v2] target/i386: Fixes to the check missing features routine

2018-12-11 Thread Wainer dos Santos Moschetta
"spec-ctrl", "ssbd", "3dnowprefetch", "xsavec", "xgetbv1", "mpx", "mpx", "avx512f",

Re: [Qemu-devel] [PATCH] target/i386: Fixes to the check missing features routine

2018-12-11 Thread Wainer dos Santos Moschetta
On 12/10/2018 02:46 PM, Eduardo Habkost wrote: On Fri, Dec 07, 2018 at 05:14:17PM -0500, Wainer dos Santos Moschetta wrote: The x86_cpu_class_check_missing_features() returns a list of unavailable features compared to the host CPU. Currently it may return empty strings for unamed features as

Re: [Qemu-devel] [PATCH v2] target/i386: Fixes to the check missing features routine

2018-12-11 Thread Wainer dos Santos Moschetta
On 12/11/2018 03:15 PM, Eric Blake wrote: On 12/11/18 10:28 AM, Wainer dos Santos Moschetta wrote: The x86_cpu_class_check_missing_features() returns a list of unavailable features compared to the host CPU. Currently it may return empty strings for unnamed features as well as duplicated names

Re: [Qemu-devel] [PATCH] x86: host-phys-bits-limit option

2018-12-12 Thread Wainer dos Santos Moschetta
On 12/11/2018 05:25 PM, Eduardo Habkost wrote: Some downstream distributions of QEMU set host-phys-bits=on by default. This worked very well for most use cases, because phys-bits really didn't have huge consequences. The only difference was on the CPUID data seen by guests, and on the handling

Re: [Qemu-devel] [PATCH RFC] qemu-io: Prefer stderr for error messages

2018-12-13 Thread Wainer dos Santos Moschetta
(uint64_t)BDRV_REQUEST_MAX_BYTES, argv[optind]); return -EINVAL; } if (bflag || cflag) { if (!QEMU_IS_ALIGNED(offset, BDRV_SECTOR_SIZE)) { -printf("%" PRId64 " is not a sector-aligned value for 'offset'\n", -

[Qemu-devel] [PATCH 0/1] checkpatch: checker for comment block

2018-12-13 Thread Wainer dos Santos Moschetta
27;foo bar') is reported. 3. block doesn't end on its own line. Example: /* * blah blah * and blah */ References: [1] https://www.mail-archive.com/qemu-devel@nongnu.org/msg580091.html ps: last time I wrote Perl code was about 13 years ago. That remember me of good times. :) Waine

[Qemu-devel] [PATCH 1/1] checkpatch: check for malformed comment block.

2018-12-13 Thread Wainer dos Santos Moschetta
x27;t end on its own line. Signed-off-by: Wainer dos Santos Moschetta --- scripts/checkpatch.pl | 32 1 file changed, 32 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 60f6f89a27..5abb579ed7 100755 --- a/scripts/checkpatch.pl +++ b/s

Re: [Qemu-devel] [RFC/PoC PATCH 0/3] support initrd size up to 4G

2018-11-08 Thread Wainer dos Santos Moschetta
Under review, the following patch adds acceptance tests for the initrd option: https://www.mail-archive.com/qemu-devel@nongnu.org/msg567776.html The test should be updated in case this series get merged. Maybe the best would be to include those tests along with this series actually. - Wainer

[Qemu-devel] [PATCH v2] Acceptance tests: add Linux initrd checking test

2018-11-09 Thread Wainer dos Santos Moschetta
4_t This change adds a regression test for that fix. It starts QEMU with a 2GiB dummy initrd, and check it evaluates the file size correctly and prints accurate message. Signed-off-by: Wainer dos Santos Moschetta Reviewed-by: Caio Carrara Reviewed-by: Cleber Rosa Reviewed-by: Eduardo Habk

  1   2   3   4   5   6   >